- 01 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b90d728f7c61..cc62aca3ecea Created with: gclient setdep -r src-internal@cc62aca3ecea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047731 Tbr: jbudorick@google.com Change-Id: I6dbb3fdd5ece8e029309b46b63c9629391a10d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737574}
-
Xianzhu Wang authored
The usages are all finding a scrollable layer by scroll element id, when we already know if it's scrollable, so we can just use LayerByElementId(). Change-Id: Ie45c984d6b046fa50712d3a325ac2d12cfcf79f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026370 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737573}
-
Manu Cornet authored
This is a step in the direction of better compartmentalizing each shelf component and better coordinate animations. It also aims at making the shelf layout manager not so huge. Change-Id: I7369e00f87bda1fac0956e119d60f34d9716a651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033567 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737572}
-
Tom Anderson authored
Rather than using complex singleton/state/locking, just use a static variable and let the compiler ensure it's only initialized once. Bug: None R=thestig Change-Id: I95b169d8eeaea297296b65983d6d4c116b88159e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031540 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#737571}
-
Chong Gu authored
Include AEMU by default in fuchsia package runner scripts for x64 hosts. Download AEMU package automatically for mac and linux hosts. Bug: 1000907 Change-Id: Ia0ef798a72ba517616331d8a2dcc9b003b180546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026424Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#737570}
-
David Black authored
This CL attempts to make minimal changes required to: - Remove standalone Assistant UI classes from code base - Clean up remnants of standalone UI from AssistantUiController. Note that additional clean up work will be done after: - Removing no longer needed visibility states (e.g. hidden) - Removing no longer needed UI modes (e.g. main, mini, and web) - Removing no longer needed caption bar class Bug: b:148080975 Change-Id: I9ac1ac5caa9399dfd8b5463a0238221d4b8e9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032416 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737569}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I2f079277bbb8cff79126d7f1f8722fb9caa161d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737568}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ib2225bba8193a7ad7ee0fcbf5b0af7a0d5790174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034064Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737567}
-
Kai Ninomiya authored
Partial revert of https://crrev.com/c/2028649. TBR: cwallez@chromium.org Change-Id: Ib063064394c973f5feca87e7de5d343c1e77f6df Bug: chromium:985142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033940Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737566}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a451858403a2..dc397e0a03e0 git log a451858403a2..dc397e0a03e0 --date=short --first-parent --format='%ad %ae %s' 2020-02-01 tsepez@chromium.org Remove CPDFSDK_Widget::GetAlternateName() 2020-02-01 tsepez@chromium.org Remove GetPDFUnssuportInto(). Created with: gclient setdep -r src/third_party/pdfium@dc397e0a03e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia952267417bc4a14c70ba4fcb955f88315de2944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033951Reviewed-by:
-
Nate Fischer authored
Move Monochrome WebView DevTools launcher icon component check to public Monochrome instead of the shared chrome_public_apk_tmpl that is shared with downstream. This way we can use downstream webview icons in downstream monochrome instead of using upstream WebView icons all the time. This pulls in the icon resource unconditionally, since the resource has been shrunk. There are other accidentally added format changes that made by running `git cl format`. Bug: 1026060, 1047530 Test: Build downstream and upstream with webview_devui_show_icon=true and observe dev ui icon Test: du out/Emulator/apks/Monochrome.apk out/Emulator/apks/MonochromePublic.apk Binary-Size: increase in monochrome is offset by prior decreases in standalone/trichrome Change-Id: I6733fb901a0874ee2724f05bc621de07401fe73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032573 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737564}
-
Xianzhu Wang authored
Blink uses wtf_size_t instead of size_t for indices in WTF containers. Follow the same convention in renderer/platform/graphics code. This saves memory (as wtf_size_t is 32bit), and avoids unnecessary conversion between the types within blink. Change-Id: Iff41401d1adf9522612a84ef54a53afc4749f80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032037Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36d6ae8fe7eb..b90d728f7c61 Created with: gclient setdep -r src-internal@b90d728f7c61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1046904 Tbr: jbudorick@google.com Change-Id: Ib858c9c244f1c36db6a3e3aa79614a980bf91446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033950Reviewed-by:
-
Mohsen Izadi authored
Currently, there is a single settings flag controlling CC latency recovery both on main thread and impl thread. This CL breaks that into two separate flags that can be controlled independently. Bug: 993895 Change-Id: I2caae6f5f2cd25332d8a164e082b313152e5e0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869749Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#737561}
-
Xianzhu Wang authored
cc::Layer's scroll offset should just for layer tree mode as the input of cc::PropertyTreeBuilder. In layer list mode, blink generates all paint properties, and cc should use the paint properties instead of the layer properties. (TBR for a trivial change under compositor/ui/layer.cc due to rename of cc::Layer::paint_offset) TBR=wangxianzhu@chromium.org Change-Id: I5865e4a98f0c4c6957ed117b9de189fd7bd84a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020554 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Darin Fisher authored
This change teases apart the code that runs in a renderer that observes link tags from the code that runs in a renderer used to perform no-state prefetching. That translates to moving the PrefetchFinished signal from PrerenderDispatcher to PrerenderHelper. This change also goes one step further and, recognizing that PrerenderHelper is a RenderFrameObserver, ditches the PrefetchFinished method on WebPrerenderingSupport in favor of just observing DidFinishDocumentLoad (aka DOMContentLoaded). The timing of the two signals is approximately the same and for what the no-state prefetching code requires, this seems sufficient. URLLoaderThrottleProvider is simplified by moving most of the logic associated with creating the PrerenderURLLoaderThrottle moved into PrerenderHelper, further consolidating logic around the throttles (again used only by the renderer process being used to drive the no-state prefetch). There's a slight change to the calculation of the start time for the parse time histogram. It should not be material, and if anything, this should be a less errorprone way of calculating it. Having it align to the creation of the PrerenderHelper means that we aren't reliant on prefetch happening in a newly created process to have a properly computed start time. Hopefully this change does not goof up any metrics. This CL sets the stage for onion-souping the renderer code used to observe link tags, kick-off prefetches and observe their activity. We should be able to eliminate WebPrerenderingSupport and WebPrerender, for example. Change-Id: Ia337c74484d8ff9fd8e1fdb57f0a3e282a03b8df Bug: 967834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032424 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#737559}
-
David Black authored
First step in the deprecation of standalone Assistant UI. app_list_features::IsAssistantLauncherUIEnabled will be removed in a follow up CL after usages are deleted. Usages will be addressed in a sequence of CLs to ensure there is no regression due to refactoring. Bug: b:148080975 Change-Id: Ic5f3a1e03e62c13c20950519d241db72c00863c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026386Reviewed-by:
-
John Budorick authored
gn treats executables as build-time dependencies by default; run-time dependencies of executables are not propagated unless the executable target is explicitly included in data_deps. This was causing issues for android's native executable tests that had data_deps of their own, as those data_deps weren't being propagated from the internal executable target up to the top-level wrapper target. This CL fixes that. Bug: 1041670 Change-Id: I1e8340c473ff1d655364336e705955c376886896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033984 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4073a3e9ecf..555e26ba9311 git log d4073a3e9ecf..555e26ba9311 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 primiano@google.com Merge "Client Library: temporarily re-link full library in Android" Created with: gclient setdep -r src/third_party/perfetto@555e26ba9311 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1011764b507e5463f3a6619c189a8251d474e8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033947Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1047811 Change-Id: I0fd7bbc18752122ba1bc415fc41f98298a92da7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033911 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737555}
-
Eric Orth authored
Route a DnsSession* back through HostResolverManager on config updates, and then reuse the cache invalidation mechanism to also update the per-context cached data in ResolveContext, particularly the current session. As part of reusing the cache invalidation mechanism, HostCache ownership moved from ContextHostResolver to ResolveContext. Seems reasonable because it is per-context data. HostResolverManager still accesses the cache separately from ResolveContext, but we could have it just use it out of the passed ResolveContext in the future. Bunch of related code churn in HostResolverManagerTests, but it's all pretty trivial. Bug: 1022059 Change-Id: I69f55895b1dc8d03c783002fda4e7ff031fde807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004953 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737554}
-
Chong Gu authored
Remove retry attempt limit, instead keep retrying to connect to device for a minute. Fuchsia bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=45090 Change-Id: I0c424fa4d63ffa457c50487261ad37ab97092d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033909 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
-
Jinsuk Kim authored
We evaluate gesture navigation enabled status every time Chrome app is resumed in order to deal with the system gesture navigation mode change while the app was in background. When testing, the parent view (CompositorViewHolder) is always in attached state when the activity is resumed, but it can happen that it is in detached state as reported in the bug. This caused an exception, since WindowInsets will be null in that state. This CL skips the check if the state is queried while the view is detached from its window. The only scenario that could potentially be affected is when user switched the system gesture navigation on the settings and resume the app later. But experiment shows that this re-creates ChromeActivity and attaches the views before resuming, and the mode change rarely happens in the field. So the change is not likely to be risky. Bug: 1045942 Change-Id: I7ac11796737b1f355786c65f309182b107c39f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029547Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42a51f6af195..906bfde9b6e2 git log 42a51f6af195..906bfde9b6e2 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sokcevic@google.com Use logger where unit test has coverage Created with: gclient setdep -r src/third_party/depot_tools@906bfde9b6e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2a73a1c83c82a484c40f9a285677d27676abaec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033946Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4513cdde4912..1b80c357926b git log 4513cdde4912..1b80c357926b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1b80c357926b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I94d792c0fd5deae0b56c80f6269162ee6770964d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033945Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4dc1eb42a4de..1736c47b74c1 git log 4dc1eb42a4de..1736c47b74c1 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tobine@google.com Vulkan: Remove transient cmd buffer workaround 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 8317b28e672a..bd4b3a888fca (27 commits) Created with: gclient setdep -r src/third_party/angle@1736c47b74c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I286636257d1be25a3c69bf26365d4680577cfd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033944Reviewed-by:
-
Shimi Zhang authored
We want to have a more general SchemeHostPortMatcher to allow a callsite doesn't need to rely on ProxyBypassRules' specific logics. The user should either use SchemeHostPortMatcher or create their own rules based on SchemeHostPortMatcherRule. Bug: 1030092 Change-Id: I095deb103cb4c3cbecc6e3c454423c805f1977c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030051 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7b8eb884cfd6..a451858403a2 git log 7b8eb884cfd6..a451858403a2 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 thestig@chromium.org Remove some CPDF_ImageLoader::Start() parameters. 2020-01-31 tsepez@chromium.org Remove CFFL_FormFiller::WndtoPWL() and FFLtoWnd() 2020-01-31 dhoss@chromium.org Add test case for dysfunctional FPDFTextObj_SetTextRenderMode() Created with: gclient setdep -r src/third_party/pdfium@a451858403a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifae40f85d36abadc7d886f7125a0ffb2132efc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033602Reviewed-by:
-
Peter Kasting authored
This is called a few places now and will add a few more in future CLs. Bug: none Change-Id: I83f17f4b981781a649c00aa2cf23f63994093d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026414 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#737546}
-
Avery Musbach authored
Test: manual Change-Id: I06df2ec89e48c9bd620ee1698a2dd4549e6ca45a Fixed: 1046517, 1047758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032235 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#737545}
-
Tibor Goldschwendt authored
Bug: 1042534 Change-Id: I7fd3603d7ee547ef2f70aec3576572f4e7f23f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028303 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737544}
-
Alexander Hendrich authored
This reverts commit 139c1efd. Reason for revert: https://crbug.com/1047721 Original change's description: > Run policy-presubmit when presubmit is changed > > When policy templates are changed, syntax_check_policy_template_json.py is run as part of the presubmit checks. It should also be run when changes to the file itself were made. > > Bug: 1045930 > Change-Id: Ic8870bd748d80d87b99b93889640cf2ebbbf0b27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022794 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Anina Koehler <aninak@google.com> > Cr-Commit-Position: refs/heads/master@{#737240} TBR=hendrich@chromium.org,aninak@google.com Change-Id: I9b1e9c6fc799516a5a7944706032ad5fc9cffd6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045930, 1047721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031110Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#737543}
-
Nick Diego Yamane authored
WindowEventFilterLinux currently calculates event's screen location (in pixels) using window bounds' origin + event's root_location(), while the correct would be to use Event::location() instead. It currently works because (for some reason) MouseEvent ctor that takes an XEvent as input, which is used atm in Aura/X11 to instantiate such events, sets root_location to the same value as location [1]. This is causing issues in window drag handling after migrating PlatformEvent to ui::Event (CL under review at crrev.com/c/2022280). Such change involves switching to x11_event_translation.{h,cc} to build ui::Events out of XEvents, which was originally based on X11 event source impl used in ozone/x11 (formerly used only for "CrOS on Linux") [2] which correctly sets MouseEvent's root_location [3] using ui::EventSystemLocationFromXEvent function, which is required, for example, to be able to retrieve event's screen point in X11WholeScreeMoveLoop [4]. [1] https://source.chromium.org/chromium/chromium/src/+/master:ui/events/event.cc;l=417-418;drc=948073da23 [2] https://source.chromium.org/chromium/chromium/src/+/d436c8e6a1:ui/events/platform/x11/x11_event_source_default.cc;l=91-94 [3] https://source.chromium.org/chromium/chromium/src/+/master:ui/events/x/x11_event_translation.cc;l=53-56;drc=bb682b7a02 [4] https://crrev.com/c/2022280/15/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#64 Bug: 965991 Change-Id: I2ad3fbde354ff66885253ccaca0e74391d4a11db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032307Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#737542}
-
Natalie Chouinard authored
The ImageView id in modern_list_item_view was changed from "icon_view" to "start_icon" (https://crrev.com/c/2024495) causing an NPE when the "Download file" dialog's dropdown is clicked. Bug: 1047883 Change-Id: I656562af3af4ada9e602c176c5d10abc035c9b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033929 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737541}
-
Dale Curtis authored
This is the same as the original patch, but restores the logic in WMPI::CurrentTime() which clamps to duration upon ended. PS#1 is the original change and all subsequent patch sets are the fixed. Even though we have an explicit ended signal, a lot of content doesn't have an accurate duration -- with some formats (e.g., VBR MP3, OGG) it can't be known without a complete play-through from beginning to end. The HTML5 spec says that upon ended, current time must equal duration. Due to the aforementioned issue, if we rely exclusively on current time, we can be a few milliseconds off of the duration. [ORIGINAL DESCRIPTION BELOW] We've long used now > dur as an implicit signal, but with poorly muxed media this can be unreliable. Since EndedPlayback() is used for a few important signals, we should ensure it's always right. As such, switch to using the explicit signal known by the WebMediaPlayer. This has been the source of a lot of flakiness over the years and we've been thinking about doing this since 2014. The only tricky part is in handling seeks to the end of file correctly; our pipeline previously required that play be called before we would trigger a real pipeline ended event. Instead we relied on HTMLME just declaring the playback ended at now >= dur. Now we will "render" end of stream even if playback hasn't started if we have nothing to play. TBR=rtoy,jrummell,mlamouri,guidou Bug: 409280, 1035472 Test: Updated unittests, all existing tests pass. Change-Id: I46dab0049ab8145c8d647a3d8c5365a45ba84c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033643Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b0c794156ba..36d6ae8fe7eb Created with: gclient setdep -r src-internal@36d6ae8fe7eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022108 Tbr: jbudorick@google.com Change-Id: Ic1c0b2ee515963304bddcf513191f1ad85c111c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033601Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 440da23e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1609fa65bef8cce4e600c21611af0adce18b1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033483Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737538}
-
Changwan Ryu authored
Currently, Chrome uses application context when it creates ContentView because it needs to reparent the view across different activities. Since it is not using activity context, and it seems quite challenging to refactor the codebase to do so, we are landing this as a short term workaround. The workaround consists of the following: 1) Pass WindowAndroid into IMMWI, and try to get activity context, only for Chrome. 2) Call setLocalFocus(true, true) only for showing keyboard. (jinsukkim@'s idea) 3) Wait for input connection to be established (yukawa@'s idea) The rest are just plumbing work. Manually tested the following on physical device and emulator: 1) activate IMEs between omnibox and content 2) activate and deactivate IMEs by touching inside and outside input box 3) move ChromePublic between displays and activate IMEs Also, manually tested that this works on WebView. Bug: 1021403 Change-Id: Ia952f76e2fb1afef073825435ab4569bcded6762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994393 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#737537}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2a397db501d..1ab87e04c957 git log c2a397db501d..1ab87e04c957 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 chrche@microsoft.com Fixed localization presubmit command line too long error Created with: gclient setdep -r src/third_party/devtools-frontend/src@1ab87e04c957 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib748032d28af476f9b71b991625b9314e8febbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033600Reviewed-by:
-
Ovidio de Jesús Ruiz-Henríquez authored
This reverts commit 0744e76c. Reason for revert: Suspect CL in causing compile errors on ios-device-xcode-clang and ios-simulator-xcode-clang builders. https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/121716 https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-xcode-clang/98510 Original change's description: > [base] Use dummy class to avoid superfluous initialization in Optional > > The initialization of "char empty_" union-member in Optional is > redundant and causes the compiler to generate extra code to ensure > zero-initialization. Using an empty Dummy class for the union member is > more optimal, since it guarantees that no code for its initialization is > generated. > > Explicitly touching this char member in the constructor also causes a > problem for conservative GC. Compiler is free to split shared and not > shared parts of the union in separate memory locations on stack (or keep > them in different registers). If a conservative GC is triggered at this > moment, stack scanning may not find the correct object (this is exactly > what happened in the bug 1044331). > > This can be tested in a minimized example: https://godbolt.org/z/t5q5ry. > > Bug: 1046776 > > Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737494} TBR=gab@chromium.org,fdoray@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I6a1f3a20d2c19716f51a45a4a1bb0bcafb7a558a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033439Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737535}
-
