- 23 Apr, 2020 40 commits
-
-
Peng Huang authored
The crash is because GLSurfaceEglReadback::SwapBuffers() uses glReadPixels() to read back pixels from framebuffer to a buffer. It assumes the current GL_PIXEL_PACK_BUFFER_BINDING is 0, so glReadPixels() will store pixels in the buffer passed in instead of buffer binded at GL_PIXEL_PACK_BUFFER. However the GL_PIXEL_PACK_BUFFER_BINDING is not 0 sometimes. Fix the problem by binding 0 to GL_PIXEL_PACK_BUFFER before glReadPixels(), and restore it after glTreadPixels(). This change also sets 0 to GL_READ_FRAMEBUFFER_BINDING to make sure reading from the right surface. Bug: 1073882 Change-Id: Ic4bf35fb02baccb87664b7488af06d77d5197446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163080 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762161}
-
Nigel Tao authored
Bug: 1070409 Change-Id: Id90483ff3ca77d241b72b1905fa564e1955ddb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160829 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#762160}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I35cd32c999401ebe4e4632c75ee001c42db126bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762159}
-
Tomasz Wiszkowski authored
This CL makes new Suggestion metadata - headers - available to Java, enabling subsequent work on Omnibox Suggestions List. No processing of any kind takes place here. Suggestion headers should be processed unconditionally as the feature will be enabled server-side. Bug: 1073671 Change-Id: I2e03e7cae1ca9ab54bf80798f2146ce499035ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161319 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#762158}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72f991f760ac..11b341547a92 git log 72f991f760ac..11b341547a92 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 fletcherw@chromium.org cpplint: move a build/include check to subcategory 2020-04-23 tikuta@chromium.org git_cl: add --parallel for yapf 2020-04-23 tikuta@chromium.org yapf: support --parallel flag 2020-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@11b341547a92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1073191,chromium:1073708 Tbr: agable@chromium.org Change-Id: I473ad40f4d3e2466f8d9c8c623fc9e1018e13dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163771Reviewed-by:
-
Navid Zolghadr authored
Bug: 1047176 Change-Id: Ic44fee80db7b74a5062cef1c9b8ff14565dd1dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159541Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762156}
-
Navid Zolghadr authored
Bug: 1047176 Change-Id: I958edb07c881aa604ecb474f4aa735b69002c445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163649Reviewed-by:
-
Nico Weber authored
As far as I can tell, it hasn't been used usefully in investigations in years, and StackTrace members can cause problems on Android (https://crbug.com/1056216 -- admittedly due to bugs elsewhere, so removing this is papering over symptoms in a way. But if this is unused, we should remove it for that reason anyways). Bug: 1056216 Change-Id: I32e4f468a9f8dd5cb6ff4ffb2938f25c86af7530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163261Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#762154}
-
James Cook authored
For now, always create a new window. Each running lacros browser window already gets a temporary "running dialog" shelf icon which can be used to minimize or close the lacros instance. Bug: 1072472 Test: manual, flip LacrosSideBySide flag, click shelf icon Change-Id: I006f2e6c2a180092d3f3603d4141a9fd69b29864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163778Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762153}
-
Jian Li authored
This reverts commit 69678443. Reason for revert: Caused several test crashes/failures as in https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/101971 Original change's description: > Sample the loader lock when taking stack samples. > > Bug: 1065879 > > Change-Id: I05ca50043d8efbcdc3ae6d4767fb289162d85198 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127911 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762064} TBR=gab@chromium.org,robliao@chromium.org,oysteine@chromium.org,joenotcharles@chromium.org Change-Id: I89904651a49e1582759e958c05a99c587fd4e40d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163873Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#762152}
-
Hiroki Nakagawa authored
This CL removes an outdated comment about off-the-main-thread shared worker script fetch that is already enabled by default. Bug: 924041 Change-Id: I6b1bc606be04be2e80b9ef52370b3d58ce794b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162394 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762151}
-
Xing Liu authored
This is not needed. The only data needed by image cache is the URL. Bug: 1058534 Change-Id: I7eecc924923efdf842f3475f82406d449187ca84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163158 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762150}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bbb839e1e684..e1767ded36b9 git log bbb839e1e684..e1767ded36b9 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 jalyn@microsoft.com Fix watch expression hover issue Created with: gclient setdep -r src/third_party/devtools-frontend/src@e1767ded36b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071769 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I39c5a9b4fea4b46f732018c8ef88b1f39711b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163769Reviewed-by:
-
John Lee authored
This CL replaces uses of --settings-list-frame-padding with the existing .list-frame class and removes the align-items property on the class as it has no effect on block elements. Bug: 973674 Change-Id: I69eef3deaa016e0183c6c3d359e29f94e5b0875a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161931 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#762148}
-
Greg Thompson authored
Call FlushViewOfFile before unmapping the output file to initiate committing dirty pages to disk. This, combined with the existing call to FlushFileBuffers, helps ensure that the data is available to another process. BUG=933975,1069116 R=brucedawson@chromium.org Change-Id: Ied41e0f4067ea8b9e7b0d5c9fc679d2ab2974714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162739 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#762147}
-
Pavel Yatsuk authored
This CL moves files, updates imports, moves JNI handling for the two files into different build target. Among other things this CL changes the target where java enum from infobar_android.h gets generated. BUG=1056346 R=mdjones@chromium.org Change-Id: I78d96a61a9e6eafbff563213420fd7dad1dcf994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111473 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#762146}
-
Nate Fischer authored
No change to logic. This enables WebViewWakeMetricsService by default, per go/finch-best-practices. This switch will be removed in a future CL. Bug: 1003204 Test: CQ Change-Id: I7ff2554fd24839a32a986ec0ef3eb5ae45a9f6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161615 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#762145}
-
Ben Pastene authored
The latest build is expiring its single 'sizes' test: https://ci.chromium.org/p/chrome/builders/ci/mac-chrome/3489 Likely cause most of the bots in the test pool on chrome-swarming are moving to 10.15. This updates it to target 10.15. Bug: None Change-Id: I68435fc7d4c0a6f152af37edb1663802a34fbabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163730Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#762144}
-
Shengfa Lin authored
When specify log-path, minidump path will be empty if specifying file in current dir such as --log-path=file.log. In this case, we don't have to pass in the minidump path option to driver as that is mainly used on bot and it will be specified on bot. Bug: 3437 Change-Id: Iacc53af30330bc2615499aa2667adb61fd460a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163422Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#762143}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed6e82796bde..f8865057e865 git log ed6e82796bde..f8865057e865 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 brianosman@google.com Make SkDevice preserve SkCanvas' 4x4 matrix 2020-04-23 herb@google.com correct only spill once 2020-04-23 brianosman@google.com Clean up Sample3D math a bit, fix a bug with world-space 2020-04-23 bsalomon@google.com Increase shader/pipeline timeouts in Metal backend 2020-04-23 scroggo@google.com Reland "Make SkBitmap/SkPixmap::erase* do so in sRGB" Created with: gclient setdep -r src/third_party/skia@f8865057e865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Iebfed16bfca50b4f1a4c7d01e0f6cbf56f8a85e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163765Reviewed-by:
-
David Bokan authored
These have grown large enough that it makes sense to split them out from navigation browser tests into their own separate file. This CL is a straightforward move with not changes to the tests themselves. Bug: None Change-Id: Iba4759b4e8f5797d5a693775684312c8997bac12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160325Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762141}
-
Regan Hsu authored
Bug: 1070712 Change-Id: I3469bf8625f584015631626d8bc0f9666a6a1829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163647 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762140}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dacaac7b0f29..4f5d3771dd9f git log dacaac7b0f29..4f5d3771dd9f --date=short --first-parent --format='%ad %ae %s' 2020-04-23 thestig@chromium.org Make more CBC_SymbolInfo improvements. 2020-04-23 tsepez@chromium.org Fix FormCalc NPV() function and enable test. 2020-04-23 thestig@chromium.org Simplify CBC_SymbolInfo initialization. Created with: gclient setdep -r src/third_party/pdfium@4f5d3771dd9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I099c6e2164b44e6d5a92fc6382eace8c350161d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163709Reviewed-by:
-
Nate Chapin authored
Now that LocalDOMWindow is an ExecutionContext, there is no reason to have separate client interfaces. Also, remove ExecutionContextClient::GetDocument() in favor of ExecutionContextClient::DomWindow(), since that's what it represents in the non-worker/worklet case. Bug: 1029822 Change-Id: Ia3cceeaaa56f6ab5a2dc4494a40000a3df0e0db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142099 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#762138}
-
Yuly Novikov authored
Similarly to SwiftShader, use fake GPU Vendor and Device IDs when running on top of SwANGLE to prevent blacklisting. This allows running WebGL tests on top of SwANGLE on GPU-less GCEs. Bug: 1064477 Change-Id: I0748d46e36e4749c05f1a52ff557173160089b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159796 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#762137}
-
Nick Harper authored
Change-Id: I40f1287b5760a6b8759d42eaa21bbae9015bbafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161690 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762136}
-
Matt Menard authored
Allows affiliated user activity to be managed based on login, logout, locking, unlocking, and suspending sessions for affiliated and primary users. Bug: 1058453 Change-Id: If21f269c98220835cc89b0d1c4db40cf213d6db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153324 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#762135}
-
Kai Ninomiya authored
Fixing the first bug triggers the second bug. Second bug: - WebGPUCommandBufferStub owns, and destroys in order: - MemoryTracker - parent class CommandBufferStub, which owns: - WebGPUDecoderImpl, which owns: - DawnDeviceAndWireServer, which owns: - SharedImageRepresentations, whose destructors call through a raw pointer to SharedImageRepresentationFactory's MemoryTypeTracker (this is okay) which calls through a raw pointer to WebGPUCommandBufferStub's MemoryTracker (not okay). - SharedImageRepresentationFactory, which owns: - MemoryTypeTracker, which holds a raw pointer to WebGPUCommandBufferStub's MemoryTracker (which can already be freed, as happens above). This fix destroys the WebGPUDecoderImpl explicitly, before destroying the MemoryTracker. Bug: 852089 Change-Id: Id22126764be3f98db02bbc6b40e8de0f606fd2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163150Reviewed-by:Peng Huang <penghuang@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762134}
-
Shakti Sahu authored
This CL provides implements the query tile chip spec. The generic ChipView class was augmented to support additional attributes such as useRoundedIcon and optional endIcon concepts. Bug: 1073793 Change-Id: I222ee46df0ab0a5d283cb0843278f7510854eb2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155494 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#762133}
-
Mohsen Izadi authored
Update EventLatencyScrollForPresentedFrameReported in CompositorFrameReportingControllerTest to test for TotalLatencyToSwapEnd metric. Bug: 1057193 Change-Id: I3cea912810138e6ec3ab6bdc10d3a4afb3016dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137674Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762132}
-
Becca Hughes authored
Add field trial testing conf since we plan to launch this through finch. BUG=1024351 Change-Id: I7912c1733f453fd43222f7fd2908d4120aaa3476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140196 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762131}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ba47db02daff..6e44504c513e git log ba47db02daff..6e44504c513e --date=short --first-parent --format='%ad %ae %s' 2020-04-23 digit@google.com Vulkan: Add vk_icdInitializeConnectToServiceCallback() Created with: gclient setdep -r src/third_party/swiftshader@6e44504c513e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5c49e35c1bd9c257163be52082a62caf46303f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163706Reviewed-by:
-
sczs authored
On M83 the BVC will be contained by the TabGrid rather than being presented. This requires some updating to the Messages presentation logic, which is done via this CL. - BVC now informs the InfobarContainer that it will disappear, when this happens no Infobar should be presented, until BVC "appears" again. - Fixes a bug where presenting a Banner while BVC is being dismissed would cause the Banner to remain on screen since now its presenting ViewController is not being dismissed. shouldDismissBanner was added to the InfobarBannerContainer protocol so a banner can ask its container if it should dismiss itself after being presented. - On InfobarCoordinator we shouldn't always rely on the baseVC (BVC) presenting Banners, that's why when dismissing a banner we check its presentingVC instead of BVC presentedVC, this approach would've been safer even when BVC wasn't contained. Bug: 1062245 Change-Id: I1d0641cd6e047a72eea9bec79997da4885d2953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160808Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#762129}
-
Andrew Grieve authored
Attempting to roll appcompat support library, and it looks like the next version breaks applyOverrideConfiguration(). Specifically, AppCompatActivity.attachBaseContext() is now calling getResources(), which triggers an assert in applyOverrideConfiguration() since it cannot be called after a call to getResources(). I believe createConfigurationContext() should be functionally equivalent to applyOverrideConfiguration(). Bug: 1064727 Change-Id: I2cd1f4c348b7b8e3815ae33bc8708f79308d40b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157676 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
David Bertoni authored
Per comments on the bug, this has been fixed and disabled tests should be re-enabled. Bug: 177163 Change-Id: Id9928781f25d659079571c762ac684b97cbece04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158019Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762127}
-
Robert Ogden authored
Adds a run loop to wait for the socket to be passed to the connection listener when it is expected. Bug: 1073761 Change-Id: Ie2efe7b8b7b61b4cf9df091ba4d773be6da060c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163424 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#762126}
-
Stephen McGruer authored
The idlharness tests routinely timeout on MSAN/ASAN due to how slow those bots are. Given that IDL tests are just examining the existence of web APIs, they are unlikely to turn up crashes in the browser (they don't even call the APIs under test), so we have decided to unilaterally disable them on MSAN/ASAN to reduce the pain for Chromium sheriffs. Bug: 856601 Change-Id: I96c36a4e3dcda9437ac776620bfc5c9cc48f52a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151087 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#762125}
-
Sushanth Rajasankar authored
Similar to the pattern established by https://chromium-review.googlesource.com/c/chromium/src/+/1713304 this change adds support for loopers for DrawImageRectOp. Care is taken to keep image_provider->GetRasterContent outside the loop since the raster content should be reused across loops. Bug: 1065694 Change-Id: Ia716a0566565fe357d6c6a272659225328a781ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159125Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sushanth Rajasankar <Sushraja@microsoft.com> Cr-Commit-Position: refs/heads/master@{#762124}
-
Becca Hughes authored
This will hopefully fix the crashes for good: 1) Adds a "cancelled" state that blocks any DB transactions 2) Replaces Raze with delete and makes sure it happens on DB thead 3) Make the DB exclusive BUG=1024351 Change-Id: I5da655ebfe54b6dfe7f5e536786625d5d942925a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155838 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#762123}
-
Mohsen Izadi authored
This CL adds the possibility to inject a base::TickClock* into CompositorFrameReporter, so its timing can be mocked by tests. CompositorFrameReportingController and CompositorFrameReporterTest are also updated to make use of this. Bug: 1054009,1057193 Change-Id: I38ab3ebb92b06f5c31e1dbdc514cab29b9791cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160408 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
-
