Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 01 Nov, 2017 3 commits
    • James Cook's avatar
      cros: Fix ash ScreenshotDelegate ownership and creation · 5e9d3403
      James Cook authored 
      Many ash_unittests fail under --mus and --mash because the
TestScreenshotDelegate is not created. This happens because of some
legacy AcceleratorControllerDelegate code that dates back ~18 months
to when we couldn't use aura::Window* in mash code. That isn't a
problem anymore.

* Move ownership of ScreenshotDelegate to ScreenshotController
* Create the delegate in ShellDelegate, similar to how we do other
  ash delegates
* Move screenshot accelerator code back into AcceleratorController
* Re-enable tests under mus and mash via filter files

Screenshots don't work yet under --mus and --mash due to lack of
graphics readback support and lack of a mojo interface, but we now
exercise more of the UI and accelerator handling code.

Bug: 557397, 632111
Test: ash_unittests (--mus, --mash), manually take screenshots
Change-Id: I7dd1946ddc30bddb407c9dbf6095caf8efb4fd1f
Reviewed-on: https://chromium-review.googlesource.com/744295Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarVladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513018}
      5e9d3403
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ 90dabec62..4dbdc677a (23 commits) · 17a37fce
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/90dabec62f9b..4dbdc677affd

$ git log 90dabec62..4dbdc677a --date=short --no-merges --format='%ad %ae %s'
2017-10-31 csmartdalton Fix undefined behavior in normalize_t_s
2017-10-31 csmartdalton Allow GrAppliedClip to have >1 clip coverage FP
2017-10-25 mtklein Some lowp refactoring
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ b8ee9dd35..c1f14fbea (1 commit)
2017-10-31 brianosman Use color filter to undo GBR (actually BRG)
2017-10-31 mtklein Revert "Fix int overflow issues with clip and path bounds."
2017-10-31 caryclark cataloger
2017-10-31 bsalomon Devirtualized token management in GrDeferredUploadTarget.
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b605ee34..b8ee9dd35 (1 commit)
2017-10-31 kjlubick Add Pixel 2 XL to waterfall
2017-10-25 mtklein clean up SK_LEGACY_LOWP_STAGES
2017-10-31 bsalomon Make deferred upload handling and draw recording be virtual interfaces implemented by GrOpFlushState.
2017-10-31 scroggo Simplify SkColorSpace::MakeICC
2017-10-31 bungeman Remove SK_IGNORE_SUBPIXEL_HINTING_FIX.
2017-10-31 fmalita Don't store legacy colors in gradient shaders
2017-10-31 mtklein Revert "gbr- has been brg- this whole time..."
2017-10-31 robertphillips Add a GM to test out odd matrix draws (take 2)
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 2c5c41f9b..1b605ee34 (1 commit)
2017-10-31 mtklein gbr- has been brg- this whole time...
2017-10-31 jvanverth Fix int overflow issues with clip and path bounds.
2017-10-31 robertphillips Revert "Add a GM to test out odd matrix draws"
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ d922775b6..2c5c41f9b (1 commit)
2017-10-31 mtklein update valgrind suppressions for revised keepalive thread

Created with:
  roll-dep src/third_party/skia
BUG=743617,779346


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I6c60d600f1b6ac2555e482e37465f2220492326a
Reviewed-on: https://chromium-review.googlesource.com/747886Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513017}
      17a37fce
    • Ted Choc's avatar
      Add additional logging in SearchActivityTest to diagnose flakes. · 9cba33b1
      Ted Choc authored 
      This removes the similar Activity launching logic in SearchActivityTest
and replaces it with the same functionality in ActivityUtils.  In
addition, it adds additional logs in ActivityUtils on failure to
attempt to help figure out what the state of the system is.

BUG=778239

Change-Id: Ic2aac185958044a8ba733213ac8daf5a4c8aa618
Reviewed-on: https://chromium-review.googlesource.com/738843
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513016}
      9cba33b1
  3. 31 Oct, 2017 37 commits