GitLab

Reason for revert:
Make WebKit Linux (dbg) to crash while running:
virtual/gpu/fast/canvas/canvas-style-intact-after-text.html

Original issue's description:
> Skia roll 60cc7d3:088f4b8
>
> https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=djsollen@google.com
>
> Committed: https://chromium.googlesource.com/chromium/src/+/06f45538f0dbff916938fc4a949875991c02c06a

TBR=djsollen@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/523603002

Cr-Commit-Position: refs/heads/master@{#292619}

Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)"

This reverts commit e8e38740 and fixes
the flakiness of the tests.

The fix is in patch set #2: when the icon is deleted before the bubble, it
clears the icon pointer in the bubble.

Ran five times on the bots without causing failures.

BUG=328847
TBR=vabr@chromium.org,shess@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/505123002

Cr-Commit-Position: refs/heads/master@{#292618}

Once the user tries starting the video, the video should not be 'ended'.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/517963002

Cr-Commit-Position: refs/heads/master@{#292617}

BUG=398856
TEST=existing browser_tests

Review URL: https://codereview.chromium.org/494093002

Cr-Commit-Position: refs/heads/master@{#292616}

https://chromium.googlesource.com/chromium/blink/+log/4c64aba5ca8a0edb090a6be235efad2ba65c9c89..8c8a7ba64b27fe8063e2211ecffcab1742d19a37
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/518013002

Cr-Commit-Position: refs/heads/master@{#292615}

Cr-Commit-Position: refs/heads/master@{#292614}

Since PrefService provides a consistent and convenient way to check if a user
value has ever been saved for a preference, there is no need for
NETWORK_PREDICTION_UNSET in enum chrome_browser_net::NetworkPredictionOptions.
The default value is NETWORK_PREDICTION_WIFI_ONLY, this is reported by
PrefService if there is no user setting, policy, etc.

Note that since MigrateNetworkPredictionUserPrefs was introduced in
https://codereview.chromium.org/421653006/diff/160002/chrome/browser/net/prediction_options.cc,
there is no need to check the old preference NetworkPredictionEnabled in
CanPrefetchAndPrerender* or CanPreresolveAndPreconnect*.

Also note that Chromium at no point did save NETWORK_PREDICTION_UNSET to disk,
it only used to be provided as a default option.  This guarantees that this CL
does not introduce functional change.

TODO:
 * Remove network_prediction_enabled from profile_io_data.
 * Remove PrerenderCondition classes.

As this CL will also fix UI bug https://crbug.com/404794, I prefer to land it
first, and deal with the other two clean-up items on a separate CL.

BUG=406583

Review URL: https://codereview.chromium.org/516443002

Cr-Commit-Position: refs/heads/master@{#292613}

BUG=388893
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/518043002

Cr-Commit-Position: refs/heads/master@{#292612}

We are getting renderer crashes, disable until someone can investigate.

BUG=392224,408496

Review URL: https://codereview.chromium.org/516883002

Cr-Commit-Position: refs/heads/master@{#292611}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/518703003

Cr-Commit-Position: refs/heads/master@{#292610}

- Move file_manager/js/media/media_controls.{css,js}
   -> video_player/js
- Move file_manager/js/media/mouse_inactivity_watcher.js
   -> file_manager/js (parent directory)
- Move file_manager/images/media/*
   -> video_player/images/media/
- Move file_manager/images/media/error.png
   -> gallery/images/media/error.png

BUG=405838
TEST=compile pasees
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/504073002

Cr-Commit-Position: refs/heads/master@{#292609}

The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.

BUG=391250
TEST=ninja -C out/Release chrome

Review URL: https://codereview.chromium.org/367113004

Cr-Commit-Position: refs/heads/master@{#292608}

BUG=400728
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/520543003

Cr-Commit-Position: refs/heads/master@{#292607}

Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (patchset #2 of https://codereview.chromium.org/511163002/)

Reason for revert:
It seems to be breaking GPU Mac Builder (Blink):
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19306/steps/compile/logs/stdio

Original issue's description:
> Net-related fixups for scoped_refptr conversion operator cleanup.
>
> BUG=110610
> TBR=pkasting@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/aa3dd9e5a2d3215f9c756ddcbb11268569cbe473

TBR=mmenke@chromium.org,rsleevi@chromium.org,pkasting@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=110610

Review URL: https://codereview.chromium.org/517873003

Cr-Commit-Position: refs/heads/master@{#292606}

Review URL: https://codereview.chromium.org/521573003

Cr-Commit-Position: refs/heads/master@{#292605}

BUG=408804

Review URL: https://codereview.chromium.org/522463003

Cr-Commit-Position: refs/heads/master@{#292604}

https://chromium.googlesource.com/chromium/blink/+log/ee13016d417011b60039bfe6f93cec2b081cf8d0..4c64aba5ca8a0edb090a6be235efad2ba65c9c89
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/519683002

Cr-Commit-Position: refs/heads/master@{#292603}

This CL wires up cryptohomed's GetKeyDataEx() as
HomedirMethods::GetKeyDataEx() in Chrome. The method will be used to
retrieve metadata such as the hashing algorithm and salt used for a
key.

BUG=367847
TEST=New homedir_methods_unittest.cc

Review URL: https://codereview.chromium.org/506943002

Cr-Commit-Position: refs/heads/master@{#292602}

BUG=328847

Review URL: https://codereview.chromium.org/513193002

Cr-Commit-Position: refs/heads/master@{#292601}

BUG=110610
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/511163002

Cr-Commit-Position: refs/heads/master@{#292600}

Move AppWindow, AppWindowRegistry and AppsClient from apps/ to extensions/browser/app_window
Change the namespace from apps to extensions.
Fix GYP and DEPS.

BUG=403726
TBR=sky@chromium.org for include and namespace changes

Review URL: https://codereview.chromium.org/494033002

Cr-Commit-Position: refs/heads/master@{#292599}

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/)

Reason for revert:
This is breaking the following Blink test:
inspector/layers/layer-canvas-log.html

Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out.  Performance and
> correctness problems are both possible.  Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over.  This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/522623002

Cr-Commit-Position: refs/heads/master@{#292598}

Put tests next to the code being tested.

Move tests to components/ without actually removing dependencies with temporary DEPS rules added.
This results in these tests still built as parts of unit_tests, not components_unittests.

Fix TemplateURLServiceTestUtil to simplify the code and reduce chrome dependencies:
- Create KeywordWebDataService instead of depending on WebDataServiceFactory.
- Remove TemplateURLService::SetKeywordSearchTermsForURL() and TestingTemplateURLService.  Instead, TestingTemplateURLServiceClient is responsible to implement SetKeywordSearchTermsForURL().
- Remove content::TestBrowserThreadBundle from test util.  Tests are responsible to set up one.  This enables TemplateURLServiceTestSyncTest to use multiple test util instances.

BUG=387985
TEST=unit_tests

Review URL: https://codereview.chromium.org/513133002

Cr-Commit-Position: refs/heads/master@{#292597}

ImageService is an abstract superclass that will have subclasses
for each mobile platform. This class stores a salient image for
a bookmark which is removed when the bookmark node is deleted.

BUG=None

Review URL: https://codereview.chromium.org/513793002

Cr-Commit-Position: refs/heads/master@{#292596}

BUG=110610

Review URL: https://codereview.chromium.org/513323002

Cr-Commit-Position: refs/heads/master@{#292595}

https://chromium.googlesource.com/chromium/blink/+log/5662a645ae76658b93bd944009407fb9d5911e3b..ee13016d417011b60039bfe6f93cec2b081cf8d0
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/523563002

Cr-Commit-Position: refs/heads/master@{#292594}

- Make sure that the DirectoryContent.dispose() is called when necessary.
- Defer dispose() temporarily when we need to replace directory contents.

BUG=408893
TEST=watched the cache size manually, and ran browser_tests

Review URL: https://codereview.chromium.org/520553002

Cr-Commit-Position: refs/heads/master@{#292593}

We don't need to call it before using GL context anymore.

BUG=404121

Review URL: https://codereview.chromium.org/470973002

Cr-Commit-Position: refs/heads/master@{#292592}

ContentsView should not be responsible for apps-grid-specific logic.

To this end, moved scroll and gesture event handling from ContentsView
to AppsGridView, removing the special cases for NAMED_PAGE_APPS. Also
moved some of the prerender logic from ContentsView to AppsGridView.

BUG=377381

Review URL: https://codereview.chromium.org/497413003

Cr-Commit-Position: refs/heads/master@{#292591}

The URL now contains a protocol (b/17204752) so we don't need this anymore.

BUG=404671

Review URL: https://codereview.chromium.org/509173005

Cr-Commit-Position: refs/heads/master@{#292590}

Midnight determination by scaling value of internal base::Time representation doesn't take in account time zones, it counts as UTC, but other time logic in local time.
There is failure of test ChromeNetworkDailyDataSavingMetricsTest.PartialDayTimeChange if system time zone will overcome test time to another day (like our +4 for example).
This fix make it work fine and in same way for win and others operating systems.

R=bolian@chromium.org

BUG=

Review URL: https://codereview.chromium.org/479793002

Cr-Commit-Position: refs/heads/master@{#292589}

This add an utility class to parse .data file. It will be used to run
the validation tests in java.

R=ppi@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/508033004

Cr-Commit-Position: refs/heads/master@{#292588}

https://chromium.googlesource.com/chromium/blink/+log/a0ba700b74d535334d0ba359bfc266cafba26104..5662a645ae76658b93bd944009407fb9d5911e3b
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/519633002

Cr-Commit-Position: refs/heads/master@{#292587}

BUG=110610

Review URL: https://codereview.chromium.org/515283002

Cr-Commit-Position: refs/heads/master@{#292586}

The test fails on some Win and Linux bots, more info on the bug.

BUG=408917
NOTREECHECKS=true
NOTRY=true
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/517953002

Cr-Commit-Position: refs/heads/master@{#292585}

Don't set lastError if chrome.dial.discoverNow() can't start; we always attempt discovery and success/failure is indicated through the callback.

Add browser test for chrome.dial.discoverNow() success.

BUG=376588

Review URL: https://codereview.chromium.org/511943004

Cr-Commit-Position: refs/heads/master@{#292584}

Cr-Commit-Position: refs/heads/master@{#292583}

https://chromium.googlesource.com/chromium/blink/+log/0b1c83564fc6d6e5518f711306b85553a01e19b9..a0ba700b74d535334d0ba359bfc266cafba26104
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/523553002

Cr-Commit-Position: refs/heads/master@{#292582}

https://skia.googlesource.com/skia/+log/088f4b8eb31b2af26e66dcbaae062f40b3955059..d684422f1711cbb4106a260d75ee09101065c092

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/519623002

Cr-Commit-Position: refs/heads/master@{#292581}

BUG=408520
TEST=manually tested

Review URL: https://codereview.chromium.org/514163002

Cr-Commit-Position: refs/heads/master@{#292580}