- 26 Sep, 2019 40 commits
-
-
Jesse McKenna authored
This reverts commit 17178955. Reason for revert: The CL this one was dependent on caused crashes and had to be reverted: crrev.com/c/1828234 Original change's description: > Disable stack sampling profiler under App Verifier > > The StackSamplingProfiler has been observed to cause crashes when > running under Application Verifier, a Windows utility used to detect > subtle programming errors. Samples collected by the > StackSamplingProfiler while Application Verifier is running are unlikely > to hold any value, as Application Verifier slows down execution > significantly. > > Because StackSamplingProfiler and Application Verifier are not > compatible, this change detects whether Application Verifier is running, > and does not start up StackSamplingProfiler if so. > > This is not expected to impact data collection, as Application Verifier > is used only by a few developers. > > Bug: 1004989 > Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735 > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700356} TBR=thestig@chromium.org,wittman@chromium.org,brucedawson@chromium.org,jessemckenna@google.com Change-Id: I1c55ab21a28ceef6c3d49f83cdb5c7689ec2402f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827187Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#700491}
-
danakj authored
Instead give the emulator a ScreenInfo and two sizes, which are the only parts of VisualProperties it uses, and have it store them instead of a whole VisualProperties. R=avi@chromium.org Bug: 1006052 Change-Id: Iecb2c1031dc3b438235175a716a01a531fafc5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825857 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700490}
-
Evan Stade authored
FirstRunDelayedExtensionUpdater used NOTIFICATION_PROFILE_CREATED to tell the first created profile's ExtensionSystem to run an update as soon as it was ready. Instead, set a (static) flag in ExtensionUpdater to do the same for the first ExtensionUpdater that is brought up. Bug: 268984 Change-Id: I82e113c45a5f77954c4674460e2b0582d78dfcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798887Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chrome://settings/androidAppsJeevan Shikaram authored
This CL restores the Android Apps route that was removed in crrev.com/c/1815957. This allows for the Split Settings flag to be turned off if required and have a working Android Apps section in browser settings. Bug: 1004583 Change-Id: I6d94a20ec7ba67c9206a94cd48ab04ddd4eb6ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824305Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#700488}
-
Jon Mann authored
This reverts commit 8bb925a2. Reason for revert: The "Add Wi-Fi" and "Add VPN" icons in ChromeOS network settings were showing up as solid gray boxes. Original change's description: > WebUI: cr-icon-button, make ripples opaque for WebUIA11yEnhancements > > In this CL: > - changed cr-icon-button to use -webkit-mask-image instead of > background-image to make it easy to change the color of image icons > - added an attribute 'a11y-enhanced' to <html> for settings, > bookmarks, history, extensions, print preview and downloads when the > WebUIA11yEnhancements flag is enabled > - removed the style that hides 'subpage-arrow' and 'icon-external' > since it is not really used and causes issues with the > cr-icon-button (it sets the display to block instead of inline-flex) > - fixed cr-link-row where it was using that no longer available > 'iconClass' property > - moved the background image icon inside of cr-icon-button because > when it is used as a mask on the :host, the ripple would also be > masked > - when 'a11y-enhanced' attribute is set on <html>, make the > cr-icon-button ripple opaque and change the color of the icon to > the background color when a ripple is shown > > Bug: 1001742 > Change-Id: Ia6d7f7c951003e440e7bca1cccf81ab849d98732 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769586 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699047} TBR=avi@chromium.org,dpapad@chromium.org,aee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008547, 1001742 Change-Id: Ic94af2134bbf0bdc59202181b574da6fa3017f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827472 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#700487}
-
Lukasz Anforowicz authored
After r694827 (Set |request_initiator| to the website, not to the content script's origin), CORB can detect all same-origin requests directly, without resorting to a hacky comparison with the request_initiator_site_lock. This CL reverts parts of r620866 where this hack was introduced. Bug: 940068 Change-Id: I69f3e6b868436f2aaa78b594da25a3c5431ab7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823597 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#700486}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6d7d58c13e8..7da4e563b791 git log c6d7d58c13e8..7da4e563b791 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 mellem@webrtc.org Allow receive-only use of datagram transport for data channels. 2019-09-26 m.olbrich@pengutronix.de pipewire: handle deleting the capturer while a D-Bus call is in progress Created with: gclient setdep -r src/third_party/webrtc@7da4e563b791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I535522752608ab4487c3d136bf8e42cff5a03950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700485}
-
Chong Gu authored
Adding an aemu_target.py that supports running headless AEMU with swiftshader. Adds AEMU checkout to the build (with aemu_checkout set to True). Add support for AEMU in layout tests. R=marshallk@google.com Bug: 1000906 Change-Id: Ie4a9e7957c5a33822dd44e8892c0820307ea5b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789849Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#700484}
-
Peter Boström authored
This lets us make sure that the View (but not necessarily subclasses) outlive their properties. Without this change accessing View in the property destructor would be a use after free. Bug: None Change-Id: I8e783fbf46ed046bd2ac7e77ed2373c1da5758e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828217Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#700483}
-
Jimmy Gong authored
- Refactor the tests to be able to verify visible and filtered printers separately. - CupsPrinterEntryList's tests are now easier to follow with their actual vs expected printer list comparisons. Bug: 965721 Test: browsertests Change-Id: Iffdda03fa5e2f5b6ecb6aa309bf91657db27a807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820028 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#700482}
-
David Benjamin authored
In non-NaCl builds, we've since replaced that file with a call to BoringSSL's SHA-1, which we ship regardless. Bug: 47218 Change-Id: Ie61f21378fe00566a218f42a8a3ecd7832eb46f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827385 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700481}
-
Chris Harrelson authored
This reverts commit 202162c2. Patchset 2 has the fix - removing the sorting_context_id field which is unused. This was a mistake in the original CL. TBR=vmpstr@chromium.org Change-Id: Ie13872cb53de33538800b3ff1e7d281625e4e6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827184Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700480}
-
Christopher Grant authored
DFMs that include both Java and native code will probably use JNI. This change introduces a reusable mechanism to load the native library and register its JNI methods. Originally landed in: 7ca339e3 Reverted in: 1cb1d038 Key points: - There are 3 build variants supported: 1. Production builds with lld-generated partitions. 2. Component build (with feature code in a component). 3. Fallback release build (feature code in the main library) - For consistency, explicit JNI registration is done in both ChromeModern and Monochrome. - The Test Dummy module is moved over to use this new system. VR will join the fun in a follow-on change. - Currently, modules must supply an explicit JNI registration method. Common code will locate this method and call it, at the appropriate time, on behalf of the module. TBR=agrieve@chromium.org Bug: 870055 Change-Id: I322c8e80d88e3ac0335f8c2785b90da04ff09d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827249 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#700479}
-
Pavel Yatsuk authored
This CL adds implementation for TemplateUrlServiceAndroid::SetPlayAPISearchEngine. The function: - Checks if Play API search engine already exists. - Adds new search engine marking it with created_from_play_api flag. - Sets the search engine as DSE if enterprise policy allows. The logic for merging new search engine with existing prepopulated or autogenerated is still not implemented. BUG=1002271 R=pkasting@chromium.org,wylieb@chromium.org Change-Id: I3065df7218f90fb74cabbd338b37b8286d2450ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826001Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#700478}
-
Luke Sorenson authored
In order to have a better understanding why the component sometimes fails to install on devices in production, we want to propagate error codes to clients of the setAnalyticsComponent API. Bug: 1003037 Change-Id: Ie57417a81d7556dd51f9b2f7e8db96e8fc695516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797467 Commit-Queue: Luke Sorenson <lasoren@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#700477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e4174f483ee5..e656e9883179 git log e4174f483ee5..e656e9883179 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ehmaldonado@chromium.org gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3. Created with: gclient setdep -r src/third_party/depot_tools@e656e9883179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1008202 Change-Id: Ic1f06e76ff942a2fa1293a6999fe24dc8a0b2909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827829Reviewed-by:
-
Lei Zhang authored
Change-Id: If523c4b07a1f19a47ccdd3b241b7ff2db6c8cfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828079Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700475}
-
jonross authored
CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 has begun flaking on Linux with SkiaRenderer becoming enabled by default. This test has previously flaked on Windows. I'm disabling it until the root cause of the flaking can be fixed TBR=lukasza@chromium.org TEST=CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 Bug: 1008567 Change-Id: I3d18c0b8a2f2fddfe6e383175f53638c78cf985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828119Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#700474}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be4787124940..3375a8848278 git log be4787124940..3375a8848278 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 mtklein@google.com roll GN 2019-09-26 mtklein@google.com Revert "hsw::S32_alpha_D32_filter_DX" 2019-09-26 kjlubick@google.com [canvaskit] remove debugging code 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-26 egdaniel@google.com Fix vulkan caps checks for external formats. 2019-09-26 robertphillips@google.com Add mipmap support to SkPixmap flavor of createBackendTexture 2019-09-26 csmartdalton@google.com Revert "Remove the resolve rect and resolve types from GrRenderTarget" 2019-09-26 kjlubick@google.com [canvaskit] Create SkFontMgr from passed in data Created with: gclient setdep -r src/third_party/skia@3375a8848278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I691107a9b12666aa86e4c52728430af2ebcd7271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827828Reviewed-by:
-
Zhenyao Mo authored
BUG=1006960 TEST=crash reports R=sunnyps@chromium.org Change-Id: Ia86f3505589786191eaaa74f5adb47d9245979e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828077Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700472}
-
Alex Newcomer authored
A few changes: - Hotseat background should always exist in tablet mode. - Update some paddings/sizes so it shows in the correct place. - Remove the transparent background (it was interfering with the scrollable shelf gradient). Bug: 973482 Change-Id: I0bc1e30ecdd4fac83cfeae5a8775b0abe03b1a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815615 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#700471}
-
Jared Saul authored
Fixes an issue where declining/ignoring the local card migration promo bubble would only log strikes the first time for a given tab, but not for subsequent times on that same tab. Change-Id: If75c52a4315369820339fc8909b0881ca92adbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827510Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#700470}
-
Yuly Novikov authored
conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html on Pixel 2 passthrough CB. TBR=kbr Bug: 1008535 Change-Id: Ic790be8a83b1f66fe20798cfdc3a7a755f22288f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827466Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700469}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/62960ae89911..15152b52a721 git log 62960ae89911..15152b52a721 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 bsheedy@chromium.org Fix Android non-browser crash symbolization Created with: gclient setdep -r src/third_party/catapult@15152b52a721 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:949321 Change-Id: I4ed2fe476ca3934567148d71ed2a6b5145150d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827827Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4371bf3..4c650007 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie07b0ff7eb4dff5999948a57cc0828803657a4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700467}
-
James Cook authored
It's testing the os-settings-page element, so rename it to match. This is a prelude to trying to de-flake it, then adding more tests to it. TBR=hsuregan@chromium.org Bug: 967896 Change-Id: I240124bd18169bb7126241416ce7e1a5cce03361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828107Reviewed-by:
-
Peter Kasting authored
No functional change intended, ideally just more maintainable code. Bug: 1005568 Change-Id: I94bec353c48114e79546e38474d4f55edb04442f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812317 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3900.0-1568629889-benchmark-78.0.3902.0-r1 to 79-3903.0-1569234053-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: If5ef30749a2c573b33ba6f6173064b46580ac287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827831Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3865.63-1568626808-benchmark-78.0.3902.0-r1 to 79-3903.0-1569232734-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ie17ffbcda052c963b780e1916bf4907ea2fbc325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827548Reviewed-by:
-
Jeroen Dhollander authored
This reverts commit de88f517. Reason for revert: Breaks internal builder Original change's description: > Introduce AssistantServiceManager::State::STARTING state. > > Until now the |AssistantServiceManager::State| enum did not distinguish > between the state in which libassistant was started (but not ready yet) > and in which it is ready. > That distinction is needed to be able to add tests using libassistant, > as they have to wait until it is ready. > > So now there are 4 states: > - STOPPED: It has not started/it has been stopped (this is the same > as the old STOPPED state). > - STARTING: |AssistantServiceManager::Start| has been called and the > libassistant |AssistantManager::Start| call has not finished yet (this > is the same as the old STARTED state). > - STARTED: the libassistant |AssistantManager::Start| call has > finished, but libassistant has not signalled it is ready yet (this > is the same as the old RUNNING state). > - RUNNING: libassistant signalled it is ready (this state is new). > > As this CL also introduces the first unittests for > |AssistantServiceManagerImpl|, it also contains a bunch of fake/dummy > classes used for the unittests. > > This CL increases test coverage in //chromeos/services/assistant from 28% > to 41%. > > Change-Id: If38a6b70e22e6392537b6658e5f39eebf6dd9099 > BUG: b/141264108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810019 > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700410} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,jeroendh@google.com Change-Id: Ia0a876aa4ccd1043d54f10dc42a0930ade00fb6f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828221Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#700462}
-
Christopher Thompson authored
This will be used to control our UI treatments for sites using legacy TLS versions (TLS 1.0/1.1). Bug: 989607 Change-Id: I4bc9e21248a83bdd566bdaec31e6fa8a11b9bda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827775Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#700461}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3903.0-1568628088-benchmark-78.0.3902.0-r1 to 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I9d6e24dd8f330faf135b5be2e659af289e3e67bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827830Reviewed-by:
-
Gavin Mak authored
Bug: 1008539 Change-Id: I91f499029b9aebea6163cf62429d84d0ee550040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827549Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#700459}
-
Scott Violet authored
Ian was of the opinion the horizontal version should be the same as the vertical position. BUG=993813 Change-Id: I6238b5fdff67701335e778d2dca6fd5b40c0ea9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826871Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#700458}
-
Sanket Joshi authored
After this change, users of the color picker can submit their color selection via the enter key. They can also cancel their selection via the escape key. Additionally, to support tests for this scenario, a custom delay parameter is being added to waitUntilClosing. When a value is submitted in the color picker, a callback to set the input type color's value and close the popup is issued, with a 100ms delay. So, in order to validate behavior after the value change and popup closure, the callback delay needs to be at least 100ms. So the enter and escape keyboard input tests pass a 100ms custom delay to waitUntilClosing. The reason for using an optional custom delay parameter rather than just increasing the delay for all tests is to avoid breaking existing tests (specifically "datetimelocal-change-type-on-input-crash.html") that rely on a shorter delay. Bug: 1007426 Change-Id: I9596bd4cc5955f02124d6c820a7b60444a1e1fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822843Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#700457}
-
Willie Koomson authored
ConciergeHelperService starts Concierge, and provides methods for throttling VMs through Concierge. Test: Run unittests Bug: 997397 Change-Id: I76f6aba67d0f8f702789ff406a803c7c52db8bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809806Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#700456}
-
Dominic Mazzoni authored
Bug: 1006402 Change-Id: I2ad9f834dd69ce149528d749d7b9c4e7dfa9d988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826599 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#700455}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f57843cb20ee..0f4ac587a4ae git log f57843cb20ee..0f4ac587a4ae --date=short --no-merges --format='%ad %ae %s' 2019-09-26 iapres@microsoft.com New API to retrieve a character's loose bounds 2019-09-26 thestig@chromium.org Roll third_party/freetype/src/ 99f23d6ff..432efa25b (5 commits) 2019-09-26 thestig@chromium.org Move a function into the anonymous namespace in fpdf_transformpage.cpp. 2019-09-25 awscreen@chromium.org [lcms] Clusterfuzz - avoid integer overflow Created with: gclient setdep -r src/third_party/pdfium@0f4ac587a4ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:985604,chromium:997463 Change-Id: Ic35c3206caa8f7e27cd81ecdf05ef0f47bfac258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827494Reviewed-by:
-
Avery Musbach authored
As a starting point for test coverage of multi-display overview and split view, the most important existing test suites involving split view mode shall be endowed with a parameter that determines whether to enable the feature flag, to test that old split view functionality still works. Bug: 970013 Change-Id: I971382e68cac7e423442db401e078b85c85f1953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825730 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#700453}
-
Miyoung Shin authored
This change converts MediaControlsMenuHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Iefe4ce64adfd4b67d6a12b18a400cf503d97369f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824917 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#700452}
-
