GitLab

Impending changes to Mojo IPC will require that handles serialized
as shared memory handles are actually shared memory handles. DXGI
resources are not, but are being transported using
GpuMemoryBufferHandle's shared_memory field.

This introduces a Windows-only GpuMemoryBufferHandle field for a
generic HANDLE to be used for DXGI resources, as well as a corresponding
mojom field for the same purpose.

There should be no net effect on the behavior of the system wrt handle
lifetime or usage.


Bug: 826213
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5d510e0ebdb60d4872fc428a95ce681dd18369dc
Reviewed-on: https://chromium-review.googlesource.com/1011600Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551231}

Forces layout tests to run in a debug mode.

Bug: 818832
Change-Id: I860e41169ea759e32806ba4ab45ca4e0d72ba4cd
Reviewed-on: https://chromium-review.googlesource.com/1014634Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551230}

To help with debugging

R=xiaochengh@chromium.org,ikilpatrick@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie56254eef3aaa3d21e0f74d2323211197ecd127a
Reviewed-on: https://chromium-review.googlesource.com/1013616Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551229}

In a FileManagerBrowserTest...SetUpInProcessBrowserTestFixture happens
after SetUpCommandLine and before SetUpOnMainThread. Move it there, so
its code location in this file is in call-order.

Bug: 831074
Change-Id: I999a057c3163ebe13146a54c44d8ba3deb7e0d8c
Reviewed-on: https://chromium-review.googlesource.com/1013783Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551228}

headless_example fails to compile on fuchsia with
https://chromium-review.googlesource.com/c/chromium/src/+/985648/15 .
The problem is that headless_shell_lib implicitly depended on
//base but that dependency wasn't in the gn file. Added //base to
public_deps for headless_shell_lib to fix this problem.

Bug: 831384
Change-Id: Ib4664a33a3c649063434911e0a4ee074233c3319
Reviewed-on: https://chromium-review.googlesource.com/1011631Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551227}

- let consumers create streams directly with DevTooolsStreamFoo::Create()
    rather than through different methods of DevToolsIOContext;
- get rid of Close() methods, do all cleanup in destructors;
- eliminate RWStream, let its consumer use DevToolsStreamFile directly;

Bug: 831887
Change-Id: I1aa28f8dea4a4e00c0323cb4101dc8db274a9bd4
Reviewed-on: https://chromium-review.googlesource.com/1014303
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551226}

R=dschuyler@chromium.org

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84fa57c20af482de22ff31dd09c223b4f4331770
Reviewed-on: https://chromium-review.googlesource.com/1007443Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551225}

This consolidates some of the similar exit-Picture-in-Picture behavior
from both WebMediaPlayerImpl and PictureInPictureWindowController sides.

When exiting from WMPI, we need to run an additional callback to signal
that the window should be closed. From user gesture, the window tear
down has already been handled.

BUG: 823172
Change-Id: I4ee6e03a519a7564f7eb8b195f2dc7ddeacf4a88
Reviewed-on: https://chromium-review.googlesource.com/1012521
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551224}

Historically, RWHVCocoa has owned RWHVMac, because the lifetime of
RWHVCocoa is unpredictable, and we needed to keep the RWHVMac around to
dereference it (the alternative would be to sprinkle "is the RWHVMac
still around" statements throughout).

RWHVCocoa no longer directly references RWHVMac -- all of its
interactions now go through its RWHNSViewClient interface.

Flip this ownership, so that now
- RWHVMac owns a
- RWHVNSViewBridge which owns a
- RWHVCocoa

To solve the issue of RWHVCocoa potentially out-living everything, when
the RWHVMac is destroyed, change RWHVCocoa's RWHNSViewClient to be a
dummy client which just ignores all of the calls made to it.

Make RWHVMac delete itself when its Destroy method is called (just like
Aura).

Delete all of the checks that RWHVCocoa's client_ be non-null, and delete
all of the checks that RWHVMac's browser_compositor_ and ns_view_bridge_
be non-null. These pointers will now be valid for the lifetime of the
objects.

TBR=avi

Bug: 821651
Change-Id: I568be2a3e0ca7b7abd1a2a2a6f68e4ad37193b51
Reviewed-on: https://chromium-review.googlesource.com/1009482Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551223}

- Adds an empty 15px space directly below the Console
  prompt's editor.
- Updates "isScrolledToBottom" logic in Console to account
  for the new space. Without this update, typing on the
  prompt's last line will not "jump + stick to bottom"
  as expected.

With this CL, overlay scrollbars (e.g. on Mac), should
never cover the prompt's editor.

Bug: 725249
Change-Id: Ib0167f6919d5b9942e7f2dc4d8cf0c15fc9368df
Reviewed-on: https://chromium-review.googlesource.com/965020
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551222}

We do not want callers (TabManager) to have to implement any of the logic related to determining the thresholds, but simply consume them. These thresholds will be used to determine timeouts until discard for proactive tab discarding.

Bug: 775644
Change-Id: I09b3f54cf3acb44ac3724ef4a08ae57d4ce42255
Reviewed-on: https://chromium-review.googlesource.com/1012797Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551221}

This Cl potentially fixes a regression in CharTypedToRepaintLatency UMA
by restoring a shortcut for one line (non-wrapping) answers.

Change-Id: I93d264610f73dfab9db10c81c4ba198adab14c90
Reviewed-on: https://chromium-review.googlesource.com/1014412
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551220}

The old name did not make it obvious that the intermediates are not compared.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0b2a3f4e9e2baf5d72fe5ec62e4f7ac91684dbd6
Reviewed-on: https://chromium-review.googlesource.com/1009106Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551219}

Using wpt-import in Chromium 74c38a06.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15672

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/service-workers/cache-storage

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I86175193483f50501563602bb03d902a53b82b05
Reviewed-on: https://chromium-review.googlesource.com/1014521
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551218}

https://pdfium.googlesource.com/pdfium.git/+log/d5624a47bcaa..6b26e1ae6932

$ git log d5624a47b..6b26e1ae6 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 hnakashima Remove non-const CPDF_PageObjectHolder::GetPageObjectList().
2018-04-16 dsinclair Merge CFX_XMLElement and CFX_XMLAttributeNode
2018-04-16 tsepez Write out StringViewTemplate::Operator=().
2018-04-16 tsepez Revert "Return pdfium::span<wchar_t> from WideString::GetBuffer()."
2018-04-16 dsinclair Split GetNumbericSymbol into individual methods
2018-04-16 hnakashima Add test for saving after adding or removing page objects.
2018-04-16 thestig Fix some checks for FX_Realloc() failures.
2018-04-16 npm Simplify CFX_DIBitmap::TransferBitmap
2018-04-16 thestig Consolidate Black/Whitepoint parsing code CPDF_ColorSpace.
2018-04-16 dsinclair Remove CXML
2018-04-16 tsepez Put prototypes of PDF_NameEncode/Decode in fpdf_parser_utility.h
2018-04-16 thestig Consolidate BlackPoint parsing code in CPDF_ColorSpace.
2018-04-16 thestig Add Black/WhitePoint array constant in CPDF_ColorSpace.
2018-04-16 thestig More CPDF_Colorspace cleanup.
2018-04-16 hnakashima Update AUTHORS.
2018-04-16 dsinclair Convert CXFA_XMLLocale to CFX_XML
2018-04-16 dsinclair Add CXFA_XMLLocale unittests
2018-04-16 npm Check that CFX_DIBitmap::Create calls succeeds in fpdf_view
2018-04-16 dsinclair Move CXML to be XFA only
2018-04-16 tsepez Revert "Return pdfium::span<char> from ByteString::GetBuffer()."
2018-04-16 thestig Fix some nits in CPDF_ColorSpace.
2018-04-16 thestig Fix a comment in CPDF_PatternCS.
2018-04-16 dsinclair Remove CPWL_Edit rich text support
2018-04-16 dsinclair Use CFX_XML instead of CXML in CPDF_Metadata

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:832557,chromium:832978,chromium:832992,chromium:833062,chromium:833097


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0362765b3919b2f1aa5ba1f50774f5176083a4fd
Reviewed-on: https://chromium-review.googlesource.com/1014474Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551217}

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests

https://chromium-review.googlesource.com/c/chromium/tools/build/+/1013289 needs
to land before the tests actually do anything. Hopefully I'll be able to land
that sometime soon. This at least gets the configs set up.

Bug: 832374
Change-Id: I93665b1307c82e84e5a5d83d2092a792786573f6
Reviewed-on: https://chromium-review.googlesource.com/1014484
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551216}

Looks like the underlying ivar names changed.

Change-Id: I78755e0d5a77c19c1b972ff933f0e81b14dbdbe4
Reviewed-on: https://chromium-review.googlesource.com/1013299Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551215}

https://skia.googlesource.com/skia.git/+log/d234afdc2e56..b460320a96df

$ git log d234afdc2..b460320a9 --date=short --no-merges --format='%ad %ae %s'
2018-04-17 mtklein Revert "low-hanging bilerp_clamp_8888 wins"
2018-04-16 mtklein low-hanging bilerp_clamp_8888 wins
2018-04-16 csmartdalton Don't support GrCubicEffect if float != fp32
2018-04-13 bungeman Add pixel geometry and dft selection to viewer app.
2018-04-16 csmartdalton Revert "ccpr: Implement conics"
2018-04-16 csmartdalton ccpr: Implement conics
2018-04-16 reed show cubic error-vectors anchored on pt(s) of max deviation
2018-04-16 herb Rename SkGlyphCacheGlobals to SkStrikeCache
2018-04-16 csmartdalton Add glFlush workaround for instanced draws on Skylake

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I395db6cc49729a477dabf03482080c657e814833
Reviewed-on: https://chromium-review.googlesource.com/1014665Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551214}

Fix a crash on PrefetchBackgroundTask when DeviceConditions was null
what occurrs in some uncommon hardware.

Bug: 830063
Change-Id: I7a16179a72c085020fc64ba7792b3edc537d04a5
Reviewed-on: https://chromium-review.googlesource.com/1014421
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551213}

At this point it's only used in tests, to test itself.
Also remove Resource::usage, which isn't used for anything anymore.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3b75bba09565d52a126c0f27c344d94ed50fc4c6
Reviewed-on: https://chromium-review.googlesource.com/1014274Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551212}

In normal cases in the render process WebMediaPlayerImpl holds a
reference to the CDM such that the CDM should never be destructed before
the media pipeline. Howeven, when both the decoder and CDM are hosted
remotely (e.g. in the GPU process on Android), the destruction order
could be reversed due to IPC. In this case, we should just fail instead
of crash.

Note that this case is already handled in MojoAudioDecoderService,
MojoVideoDecoderService and MojoRendererService.

Bug: 833641
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7f07c07dea86033ebe57700e0ce8834ea94b06f3
Reviewed-on: https://chromium-review.googlesource.com/1013690Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551211}

Spec: https://webaudio.github.io/web-audio-api/#rendering-loop (Step 9.5)

The AudioWorkletNode with zero output must be pulled by the renderer.
The actual output will be ignored just like AnalyserNode.

Bug: 831245
Test: LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html
Change-Id: If9bd27d6c4bfeecdcd2dd4c8445459afd8593e85
Reviewed-on: https://chromium-review.googlesource.com/1014388Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551210}

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I982e24b7234617b111e7adfa3c0f83356722ec8d
Reviewed-on: https://chromium-review.googlesource.com/1013280Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551209}

BUG=773295
TEST=
  1. <out_chromeos>/chrome --user-data-dir=<profile> --new-wallpaper-picker
  2. settings -> select wallpaper
  3. selection is functional.

Change-Id: Ib24dca7b428225772984860193c49f4d46225a0a
Reviewed-on: https://chromium-review.googlesource.com/1014223Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#551208}

Revert "Add browser tests for autofilling the shipping address info and payment info on captured sites."

This reverts commit 34a6f41d.

Reason for revert: Broke the Mac and Windows build.

https://ci.chromium.org/buildbot/chromium/Mac/40485

chrome/test/base/interactive_test_utils_aura.cc:24:9: error: member access into incomplete type 'NSWindow'
  window->Hide();

https://ci.chromium.org/buildbot/chromium/Win%20x64/21368

chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc(133,9):  error: format specifies type 'char *' but the argument has type 'const wchar_t *' [-Werror,-Wformat]
        src_dir.AppendASCII("third_party/catapult/web_page_replay_go")

Original change's description:
> Add browser tests for autofilling the shipping address info and payment info on captured sites.
> 
> These tests are the first step in building a test framework for testing chrome autofill on complex, real-world sites pages. Since interacting with live sites are flaky and vulnerable to updates to the sites' features, this framework interacts with captured sites.
> 
> Sites are captured with the Web Page Replay (WPR) tool. Prior to running the test, the browser test will start WPR locally on the machine using a capture file. The test then navigates to the test site, interact with the site's checkout workflow, and verifies that autofill correctly completes the address and payment information.
> 
> Tests for 5 sites are included in this code change: Amazon, Zappos, Apple, Ebay and Walmart.
> 
> Change-Id: I4b28e645554a2912c632fcb462439cac7142cf9f
> Reviewed-on: https://chromium-review.googlesource.com/963800
> Commit-Queue: Yiming Zhou <uwyiming@google.com>
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551190}

TBR=anthonyvd@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,uwyiming@google.com

Change-Id: Ied983de9c011fb6e3099e68b03bc60641a31b056
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1014497Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551207}

Following bot results are included.
4822 4825

Inlucdes 2 rebaselines after manual review of failures.

6 lines were removed and 7 lines were deflaked by consecutive
results since 4761.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic196acdbab4a48ab44d3cd9c50750fc399a9fe57
Reviewed-on: https://chromium-review.googlesource.com/1013780
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551206}

This is exact same thing as https://chromium-review.googlesource.com/c/chromium/src/+/987919
but on explicit mass-erase rather than eviction.

Thanks to nedwilliamson@ (on gmail) for the report and testcase.

Bug: 831963
Change-Id: I96a46700c1f058f7feebe038bcf983dc40eb7102
Reviewed-on: https://chromium-review.googlesource.com/1014023
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551205}

* Sub-directories of PerformanceTests are renamed to snake_case

* Need to skip PRESUBMIT because third_party/blink/perf_tests/speedometer/resources/todomvc/learn.json
 is not a valid JSON.


NOPRESUBMIT=true

Bug: 829695
Change-Id: I6c7fb94792aedbea19bbee194bb9ceaf6df5ddfb
Reviewed-on: https://chromium-review.googlesource.com/1006740Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551204}

Over time, individual features were added before or after the calls that
set groups of features. This could lead to different behavior for
individual features. Therefore, this CL moves them back to their
original position and adds comments to hopefully deter such future
changes.

This CL does not attempt to modify overall order (issue 832393).

Bug: 830978
Change-Id: I83df46b733751a0e9f1272c214518a3bdc67b199
Reviewed-on: https://chromium-review.googlesource.com/1013212Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551203}

snapshot is not necessary to be there when compiling.
This change allows src for headless to be compiled before generating snapshot.

This dependency optimization improves build parallelism and build time of chrome on Z840 linux with goma -j1000 reduced from 6m14.035s to 4m45.244s when goma's backend cache cannot be used.

Change-Id: I90e302f4b9da8ec252020755636483006f332a80
Reviewed-on: https://chromium-review.googlesource.com/1013958Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551202}

This reverts commit bc5d4eab.

Reason for revert: This change breaks numerous tests on Android with NetworkService enabled.

BUG=833612

Original change's description:
> Fix content_shell with network service enabled not loading pages.
> 
> This regressed in my earlier cl r528763.
> 
> Change-Id: I06513d517eaa96373628772159f639388fdea1db
> Reviewed-on: https://chromium-review.googlesource.com/988220
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547221}

TBR=jcivelli@chromium.org,jam@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1d3a83c789b845ec88e92cd9f81b0fe39993d01b
Reviewed-on: https://chromium-review.googlesource.com/1012736Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551201}

Bug: 775534
Change-Id: Ie06e780366afede4b6f9cd89f69e40bc14044fab
Reviewed-on: https://chromium-review.googlesource.com/1014654Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551200}

This CL adds the entity images (if present) to the preload list.

Bug: None
Change-Id: I614efbc6201122f36a180b40861ba22f9e6ad4d3
Reviewed-on: https://chromium-review.googlesource.com/1012511
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551199}

The rounded omnibox drop-down cuts out a hole for the omnibox to show through
when it's open to avoid having to teleport the LocationBarView between Widgets.
r550927 adjusted the positioning and size of the drop-down, but regressed by
positioning the cutout incorrectly. This patch re-aligns it.

Bug: 833281
Change-Id: If95dad702b54fa44e6e8e6df4b959401510993df
Reviewed-on: https://chromium-review.googlesource.com/1013020Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551198}

https://chromium.googlesource.com/catapult.git/+log/5d0c16d725ca..69a36a622381

$ git log 5d0c16d72..69a36a622 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 nednguyen Update Chrome reference builds (Chrome 63 to 65)
2018-04-16 simonhatch Dashboard - Remove whitespace from index.yaml
2018-04-16 nednguyen Update update_chrome_reference_binaries to use 'win-clang' and 'win64-clang' in cloud storage directory

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828378


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia8d35f0ab940b07231ee7520ec2e56e700fe9a39
Reviewed-on: https://chromium-review.googlesource.com/1014625Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551197}

Bug: 814897
Change-Id: Ibed0c4e7708cfa1b7ba1756e3cfca78c9501a22b
Reviewed-on: https://chromium-review.googlesource.com/1008875
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551196}

Chrome will open a tab with chrome://reset-password if the user reuses
their protected enterprise password on other sites that are not allowed
by enterprise policy.
chrome://reset-password will only show if password protection related
enterprise policy settings are properly set. Otherwise, user will see
ERR_INVALID_URL.

The new icon in ui/webui/resources/cr_elements/icons.html is copied from
/chrome/browser/resources/settings/icons.html

Bug: 824501
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8d648f0484e0c569ddbed048114a90471e4eea25
Reviewed-on: https://chromium-review.googlesource.com/996565
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551195}

Using MessageLoopCurrent* was an incorrect move of the old code.
In this case the preferred type would be a MessageLoopCurrent (which
is a proxy for a MessageLoop*), but we can't define
ScopedNestableTaskAllower with a MessageLoopCurrent member because
MessageLoopCurrent isn't fully defined by the time the inner-class is
defined.

Instead use a MessageLoop* member like before and move the impl to .cc

Also deprecating the old constructor which required a pointless
indirection:
  base::MessageLoop* loop = base::MessageLoop::current();
  base::MessageLoop::ScopedNestableTaskAllower allow_nested(loop);
I will follow-up with a scripted cleanup to remove such usage.

R=kylechar@chromium.org, thestig@chromium.org

Bug: 825327
Change-Id: I28c68d6450cf7c1743908118ce4dc2b4e09a4e76
Reviewed-on: https://chromium-review.googlesource.com/1014267Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551194}

This moves JavaScriptSourceFrame into a plugin, and completes
the plugin initiative.

Bug: 778043
Change-Id: I5908cfe46650fd50524a08b2e402d8ac6ce77cc9
Reviewed-on: https://chromium-review.googlesource.com/889692
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551193}

This reverts commit 673e013b.

Reason for revert: http://crbug.com/833550

Original change's description:
> [Closure GN] Convert simple WebUI Closure Compilation to GN.
> 
> See go/closure-compile-gn for details.
> 
> This CL converts the Closure Compilation from GYP to GN for the following:
> - cryptotoken
> - download_internals
> - md_downloads
> - md_extensions
> - md_history
> - md_user_manager
> - offline_pages
> - signin
> - webapks
> - welcome
> 
> A local closure compile can be run by setting closure_compile = true in
> args.gn, and then running ninja -C out/Default webui_closure_compile.
> Individual projects can be compiled via, for example,
> ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile
> 
> Bug: 632206
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I401fc54ee6c5202bd27855ba28d886677e52210e
> Reviewed-on: https://chromium-review.googlesource.com/954772
> Commit-Queue: calamity <calamity@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550956}

TBR=calamity@chromium.org,dpapad@chromium.org

Change-Id: I298237aae447470ad5e75ec6781baa124e58e925
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 632206
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1012904Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551192}