- 07 Dec, 2019 40 commits
-
-
behdad authored
Instead of a fixed 2ms margin of error for frame_times. Now using a percentage (10%) of upper limit. So for a story with upper limit of 16ms margin will be 1.6ms and for a story with upper limit of 60 ms would be 6ms. TBR=crouleau@chromium.org,sadrul@chromium.org Bug: chromium:1031609 Change-Id: I67ceb4f84af5d07ce5606856afd868265060e6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956042Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#722750}
-
gogerald authored
Screenshots: https://drive.google.com/file/d/1CGan4-nzQYh3xGi6le-vp070Xn6EI2qG/view?usp=sharing Known issue to be fixed in the following CL: Bookmarks and history is opened in standard tab in incognito mode tab switcher when there is no incognito tab. Bug: 1021577 Change-Id: I330b413603cafd3dcda184b29f552084ad60be0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896865 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#722749}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/95443cff5aef..26cd122a8d10 git log 95443cff5aef..26cd122a8d10 --date=short --first-parent --format='%ad %ae %s' 2019-12-07 thestig@chromium.org Roll third_party/skia/ 7d34dc774..d50cc9587 (160 commits; 41 trivial rolls) 2019-12-07 thestig@chromium.org Roll third_party/skia/ 17096c763..7d34dc774 (1 commit) 2019-12-07 thestig@chromium.org Roll third_party/skia/ 61169e9c4..17096c763 (22 commits; 5 trivial rolls) 2019-12-07 thestig@chromium.org Roll buildtools/ 140e4d7c4..6b3e658d6 (1 commit) 2019-12-07 thestig@chromium.org Roll third_party/googletest/src/ f2fb48c3b..5395345ca (18 commits) 2019-12-07 thestig@chromium.org Roll third_party/skia/ 30bc527fd..61169e9c4 (23 commits; 9 trivial rolls) 2019-12-07 thestig@chromium.org Roll third_party/skia/ 34cea00bd..30bc527fd (1 commit) 2019-12-07 thestig@chromium.org Roll tools/code_coverage/ 4a898be73..c7a868bac (4 commits) 2019-12-07 tsepez@chromium.org Remove CPDF_Parser::GetObjectGenNum(). Created with: gclient setdep -r src/third_party/pdfium@26cd122a8d10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I651a0e9799d07ddfb97aef0ec816b2b5c9611641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722748}
-
David Tseng authored
Change-Id: Ic32327990546b0187946a65c18f9bea4c33ee45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949855 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#722747}
-
Sunny Sachanandani authored
TBR=zmo@chromium.org Bug: 1026588 Change-Id: If9d91b6c19ef213cf161399e7f1972d0d4520c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956527Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#722746}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7dd3d6c54164..63ae4fb0ca65 git log 7dd3d6c54164..63ae4fb0ca65 --date=short --first-parent --format='%ad %ae %s' 2019-12-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@63ae4fb0ca65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8002bc2287343385aa764be0dd761a975291b061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956396Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba2306ac62ab..3b636c526de3 Created with: gclient setdep -r src-internal@3b636c526de3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0271e899ccce240d7c14baec0913b641987c2c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956395Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722744}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92183a268319..36ab960e885d git log 92183a268319..36ab960e885d --date=short --first-parent --format='%ad %ae %s' 2019-12-07 xinyi.he@arm.com Vulkan: Resize the result vector in EGLChooseConfigTest end2end test Created with: gclient setdep -r src/third_party/angle@36ab960e885d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: If0fbd40df01d53edd26d3e6d72af6238c907c779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955920Reviewed-by:
-
Darwin Huang authored
Provides integration between the Clipboard and Feature Policy features, so that by default the Async Clipboard API will only be accessible from the top-level origin. Top-level origins may delegate this permission to allow cross-origin iframes to access the Async Clipboard API. Previously, the Clipboard API seems to have been accessible from any origin. Overall Clipboard API Behavior strategy is discussed at this spreadsheet: https://docs.google.com/spreadsheets/d/178S5nBJ7YZY7NLcrJ67qSs03i70VOkLkIA5EsBG8y2M/edit Bug: 1002794, 897289 Change-Id: I1940905ef039a88f30f3c17ba3c02d68df15a4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913466 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722742}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I6d1bd678aa35185347499278d65ef207437144f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956664Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722741}
-
Xianzhu Wang authored
All tests in renderer/core/page/scrolling/scrolling_coordinator_test.cc except for the UMA test testing ScrollingCoordinatorTest::UpdateAfterPaint are moved into renderer/core/page/scrolling/scrolling_test.cc. To avoid naming conflict, rename renderer/core/scroll/scrolling_test.cc to renderer/core/scroll/scroll_test.cc. Change-Id: Ic5ee1250e2396600eed33b4de724412cdd0fccef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952543 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722740}
-
Sunny Sachanandani authored
This test fails most of the time, but let's mark it RetryOnFailure first and check if that's enough to make the bot go green. TBR=zmo@chromium.org Bug: 1027534 Change-Id: I1402fbef8539210a1930e04f4327da35a2ea40d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956564Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/de3a9d11f377..7dd3d6c54164 git log de3a9d11f377..7dd3d6c54164 --date=short --first-parent --format='%ad %ae %s' 2019-12-07 mandy.chen@microsoft.com Enable visibleSecurityStateChanged handler by default Created with: gclient setdep -r src/third_party/devtools-frontend/src@7dd3d6c54164 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:946860 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I473c7262d43d46d16461b445d8e9acc1e1b009c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955918Reviewed-by:
-
Jeremie Boulic authored
On the storage management settings page, replace the label "Downloads" with "My files". Instead of displaying the size of the Downloads directory: - Compute the size of the user's personal files. - Add the size of Play files (Music, Pictures etc... excluding apps and system files). Test: Manually tested. Automated tests to be implemented in follow-up CL. Bug: 1013459 Change-Id: I5ef7e5aacd1162dd219b6a093e79971f39fa65cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866120Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#722737}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9777a8561d00..ba2306ac62ab Created with: gclient setdep -r src-internal@ba2306ac62ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1013386 Tbr: jbudorick@google.com Change-Id: Ib38c63aac0f5e72b3d34a52ca3b63925a8cb14d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956427Reviewed-by:
-
Alex Cooper authored
"Space" is a bit ambiguous, in order to remove some of this ambiguity, explicitly refer to "Native" or "Offset", when referring to transforms. Also renames OriginOffset to indicate what it is: OffsetFromNative. Fixed: 1031600 Change-Id: I5863ac8a8c2bd81abd65e4ef17356de2c8891389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956109 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#722735}
-
Haiyang Pan authored
This builder will be used to verify the android app bundles(aab) for perf waterfall and will be removed when the work is done. Bug: 986990 Change-Id: I57e3f27a6dc114584b7deafd386ab9344d23df93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956074 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#722734}
-
Benjamin Beaudry authored
https://crrev.com/c/1796047 by Nektarios updated AXNodePosition::MaxTextOffset(), making the override execute the exact same code as AXPosition::MaxTextOffset() already does by calling GetText(). The override is not necessary anymore. The override was first introduced by Kevin Babbitt in https://crrev.com/c/1730094. Bug: 1031271 Change-Id: If9c7338544cc4d966dd7d82e465b04b03c06a5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954548 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722733}
-
Brian Sheedy authored
This is a reland of 281bcaf4 Relanding since it appears there are additional failures that need debugging. Original change's description: > Disable sandbox in content_browsertests > > Adds the --no-sandbox flag to content_browsertests on > "Win10 Tets x64 (dbg)" in order to get information on the renderer > process crashes that are occurring on that configuration. > > TBR=kbr@chromium.org > > Bug: 1007013 > Change-Id: I16174081881712e55af248b6dbc33a62c53e2605 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952097 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721826} TBR=kbr@chromium.org Bug: 1007013 Change-Id: Ifb2fcc644a2f56172f8978180c686ee72f6cbb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956382Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722732}
-
Asanka Herath authored
HttpAuthHandlerNTLM is a mish-mash of Posix logic and common logic. This change teases apart these two and places the Posix logic into something that implements HttpAuthMechanism. After this change http_auth_handler_ntlm_portable.cc and http_auth_handler_ntlm_win will only be trivially different. A followup change will merge the NTLM and Negotiate handlers. Bug: 927182, 991265 Change-Id: Ibec36d98c729e1d428fe7e9884a849678750bdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938967 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#722731}
-
Julie Jeongeun Kim authored
This is a part of the effort to convert to new Mojo types. This CL updates ChannelProxy and SyncMessageFilter with PendingAssociatedReceiver instead of AssociatedInterfaceRequest. Bug: 955171 Change-Id: I6db2902ddc0cf42be819241ebf020a2b39a616bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950733Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#722730}
-
shrekshao authored
Fix in angle has been rolled in. https://chromium.googlesource.com/chromium/src.git/+/34d9b5182ad4ee54a6fd66e6247a56e61d313e05 TBR=kbr@chromium.org Bug: 1023747 Change-Id: I540be727d1e92978cb497fff12581a9a87f0618c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952169Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#722729}
-
chrome://componentsDemetrios Papadopoulos authored
Bug: None Change-Id: I2be50e62f0cd7d263b6878e7363f0aaca725389b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956010 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#722728}
-
Sunny Sachanandani authored
We want to launch GPU vsync and presentation feedback on Windows on all channels and do a separate experiment for low latency presentation. Therefore this CL removes the low latency presentation finch flag from the waterfall config so that it matches the server finch config which will also remove any experiment associated with that flag, and we don't get a presubmit warning for the server config. Also in the future when we experiment with this flag separately we don't want conflicts with the existing config either on the waterfall or on the server. Bug: 953970 Change-Id: I38d792298b41bc7877d09bb454bd28ab3894fb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954564 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#722727}
-
rbpotter authored
Bug: 1022212 Change-Id: I3075f7155e79f7783686c958c54cf4257867d5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954777Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#722726}
-
Xianzhu Wang authored
Bug: 809638, 922419 Change-Id: Id941247287731cd47214f5b362e9e89f1be27551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931796 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#722725}
-
Thomas Guilbert authored
Calling avformat_find_stream_info can change the number of streams in the AVFormatContext. This means that an index that we thought was pointing towards an audio stream can now be referring to a video stream after the call. This CL fixes the issue by finding a new audio stream after calling avformat_find_stream_info. Bug: 1025964 Change-Id: I81f661412dcb108865925a37cb254db89938d00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953395 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#722724}
-
Jesse Schettler authored
This reverts commit 075c43d9. Reason for revert: Relanding now that m80 has branched. Original change's description: > Revert "printing: Check all color modes in IsColorModelSelected()" > > This reverts commit 0ec01b13. > > Reason for revert: Causing browser to crash. > > Original change's description: > > printing: Check all color modes in IsColorModelSelected() > > > > Update IsColorModelSelected() to check for all color modes. > > > > Change-Id: I61b4922e1ddb6b9a3f906b9122b1ca4f29c8272e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901835 > > Reviewed-by: Sean Kau <skau@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718884} > > TBR=thestig@chromium.org,skau@chromium.org,jschettler@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id739f17f6a3e8c1bc232eb85d10c165b8a515a0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948501 > Reviewed-by: Jesse Schettler <jschettler@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721187} TBR=thestig@chromium.org,skau@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7efb83ecd339fe64ca8a8becb337cb939641c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956274Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#722723}
-
Aran Gilman authored
Change-Id: Id77f761b8638094c73b571bad1704a4d5dd96f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931543Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The flag has been no use after BGPT. Change-Id: I00e71065799516bc1388ba9fe00dd4217292ea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945949 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Jiawei Li authored
CastWebContents now provides a getter to access QueryableDataHost. If InitParams::provide_queryable_data_host is set false, the getter will return a nullptr (for non Cast application page). Merge-With: eureka-internal/342948 Bug: internal b/144316072 Test: CQ Change-Id: I44a2aefbed9fcdcf5481423d073ffc42a8ee358d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956252Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#722720}
-
Tomasz Wiszkowski authored
This change is needed to properly manage suggestions with no decoration icons. These suggestions will receive additional padding at the front of the view. Bug: 1021263 Change-Id: I78c3d8ef6ad95882a812d9a076c36fe9dd3d29e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955088Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#722719}
-
David Tseng authored
Change-Id: Iff73bb8018053690ec88a6152a5c0740ef462e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937131 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The line "ASSERT_EQ(1u, invalidations.size());" was mistakenly removed in https://chromium-review.googlesource.com/c/chromium/src/+/1955484/3/third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc#b98. Change the test to use EXPECT_THAT(..., ElementsAre()) for better readability of code and failure message. TBR=pdr@chromium.org Change-Id: If818878796390e86d5b30761be27b985c2593516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955486Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722717}
-
Natalie Chouinard authored
This is a purely mechanical rename done with Android Studio. This class is being renamed to adhere to the conventions described in go/clank-preferences-refactor. Bug: 1029146 Change-Id: Ic564eca70b2abfabab219ea7bafab9f2d9f8c7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947390 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I747d7593985639dda16b028a18978210eeb70288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955758Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722715}
-
Jack Lynch authored
This CL disables a test that will be broken by the UI.ListControl changes here [1] and fixed after that is merged here [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880309 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1690089 Bug: 963183 Change-Id: Ie74c350af90e55961d12c819fe9f37e1eb085584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881715Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#722714}
-
Azeem Arshad authored
This CL removes unnecessary tab stops from the bluetooth-page element. Secondary details that appear in the item viz. On/Off status are already added in the button's aria description. Tab stop for policy indicators were left as such since removing this makes this detail inaccessible to some users. Bug: 1025414 Change-Id: I40cc98b3871f7cc77a9252b05e39c669ebf12358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940813 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722713}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c166eb7c0f9a..18c6a78448dd git log c166eb7c0f9a..18c6a78448dd --date=short --first-parent --format='%ad %ae %s' 2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback. 2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix. 2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp Created with: gclient setdep -r src/third_party/swiftshader@18c6a78448dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5087ca9e05a100fef7583edf81fb99d04e90c49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956021Reviewed-by:
-
Clark DuVall authored
This can happen if the original network loader is not used for the redirect, and the loader is recreated instead of calling FollowRedirect(). Bug: 1029944 Change-Id: I51c76a8c2ba3db6b4ed523edf60bff3dd891440d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949403 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722711}
-
