- 25 Jun, 2020 40 commits
-
-
Jimmy Gong authored
- Fixes a bug where the file icon of a print management would shrink when the app's browser window gets smaller. Before: https://screenshot.googleplex.com/0qO99Th9238 After: https://screenshot.googleplex.com/dDjGUuMEU33 Bug: 1053704 Change-Id: Ifd985e3715c3a4b095e0d3adfc89a0b963c92884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265449 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782660}
-
Kyle Horimoto authored
Change-Id: Iadb1c5c6f6f5cbc710346e4b04e15b1be241d40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268459 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782659}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab90f3a64a2a..dca7f0682577 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098933 Tbr: cmumford@google.com,eirage@google.com Change-Id: I4174a10f0b64d92fc1c663b338e95a964f9d7057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782658}
-
Yulun Wu authored
Bug: 1033219 Change-Id: Iaf760307c32a67e3ef5da7308235a3c297c2d0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242832Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782657}
-
Sinan Sahin authored
Currently, top margin for the control container is calculated using top_controls_height - tab_strip_and_toolbar_height (dimen). On tablet CCTs, this may be negative since the tablet CCTs don't have a tab strip while the tab_strip_and_toolbar_height always includes the tab strip height on tablets. A better way is to use the real view heights instead of dimens. Bug: 1098716 Change-Id: I7428536b722df4489028115511a0c743665fd964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265176Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#782656}
-
Joshua Pawlicki authored
Bug: 1092936 Fixed: 1092936 Change-Id: If2aff003d64a945b05ba2154b9cac94e4622b542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240060 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782655}
-
Robert Ogden authored
If a subresource redirects to an origin that the user has cookies for, none of that subresource's redirect chain should be reported as successfully cached. Uses some recursion! Bug: 1082505 Change-Id: I2ff30e073d4a9051c7eeb81c6fd7d8912b23f61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264261Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782654}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39adce149810..e3296b6d4cb4 2020-06-25 danilchap@webrtc.org Ignore inactive chains when writing DependencyDescriptor rtp header extension. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iec35b8b58ddfcabf33d5d022f57dabf73d12793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782653}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593104261-feaf838502d2cebda7dce5b42f2db042fba267b5.profdata to chrome-win64-master-1593108049-347f75b6d1676a52301ec3ad36e2e55c1372542f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4a4e0848862ecfed32c2395adff9806dd5540ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268082Reviewed-by:
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: I1fa60f4f920e2cade3b2fd9249f85cf049c8564b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268085Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782651}
-
Anupam Snigdha authored
When the |RenderWidgetHostViewAura| or the focused window is getting destroyed, we shouldn't be accessing the frame tree and do non trivial work in |VirtualKeyboardControllerWin| to notify about the VK insets. This should only be done during window focus changes. Added a flag in |DetachFromInputMethod| that indicates whether the call is during a window destruction or focus loss to detect these cases explicitly in |VirtualKeyboardControllerWin| code. Bug: 1098700 Change-Id: Ifbece79ba10e229c1e1c1ce09c40913ccd7b1f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265363Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782650}
-
Tamer Tas authored
Google Docs loading story doesn't produce any metrics due to configuration errors. This CL re-uses the interactive event which is common across GSuite products. R=johnchen@chromium.org,ulan@chromium.org Bug: 1044682 Change-Id: I8979fec52b4365bf6b908485f11725bfba4f0477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266961 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782649}
-
Patrick Noland authored
Bug: 1099384 Change-Id: I90d009400e38446ed658c9dda112a9179601b0d9 Tbr: chcunningham@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268019Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782648}
-
Scott Violet authored
BUG=1091129 TEST=testOnScrollOffsetOrExtentChanged Change-Id: I6a840fe58be5d8a21c83d0d8b095f1e6aacae5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255020Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#782647}
-
Curt Clemens authored
Implement an HTTP client to make calls to the OnePlatform server defined here: https://source.corp.google.com/piper///depot/google3/google/internal/location/nearby/sharing/v1/service.proto Bug: b/154863110 Change-Id: I0a3b06d067e7f06a0fc933f2cf69aac4ca20036f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229299Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#782646}
-
Dana Fried authored
Both authors have contributed significantly to tabstrip logic. Previously dfried was an owner for TabStyle* only. Change-Id: I46cdd15011488643d19fa5da8e92161cd9fb975c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265247 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782645}
-
Raymond Toy authored
Summary: Approximately 30% speedup for a-rate test (Linux). Scalar TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 735 735 754 759 768 1358 763.74 30.72 DelayAutomation-a-rate 643 643 676 689 705 1113 693.11 33.32 SIMD TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 730 730 754 760 769 862 763.18 15.17 DelayAutomation-a-rate 394 394 460 474 487 1053 475.71 34.42 One test needs an adjustment to the threshold. The difference is caused by changing the type of read_position from double to float. It would be difficult to keep this a double and still see performance improvements. Bug: 1087071 Change-Id: I08a8f4203ae3795cba45a7f3e735357c7bac0c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247140 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782644}
-
Wei-Yin Chen (陳威尹) authored
Some files that are often touched by Start surface are located outside of the start_surface or tab_ui folders. Add some per-file owners to streamline code review. Bug: None Change-Id: Ie4973fff3616521d95fcb150e6e9511132484422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267506 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Eugene Zemtsov authored
1. Originally roughness was calculated as: RMSE(subwindows errors) / (window duration) I just realized that it means that roughness effectively gets time-normalized twice. First time in RMSE where the sum of squares is divided by the number of frames, and the second time in the final roughness formula when it is divided by the window duration. As of this CL, roughness = RMSE(subwindows errors) By removing this quirk I restored the desirable additivity of the metric. I.e. two intervals with the same cadence pattern put together have the same roughness as each of them individually. After this change metric also became more human friendly - It has a simple intuitive interpretation as average desynchronization between the real and ideal playback in milliseconds. - It can be displayed as an integer number between 0 and 100 (although it's possible for it to go all the way up to infinity, it's very unlikely to be seen in practice) - Hopefully, it is now easier too fathom why ideal 24fps playback has roughness around 6. 2. The smoothness window size is extended from half a second to a second. It reduces number of windows boundaries where cadence anomaly can have negative effect on 2 windows, thus have a disproportionately large effect on the roughness. We might increase the window size even further but then we'll have to to wait more than 100 seconds to reliably calculate 95th percentile of window roughness. Bug: 1042111 Change-Id: Ibfee393308be77eb3fb8c7defba4056efff07752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263477Reviewed-by:David Bokan <bokan@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#782642}
-
Vladimir Levin authored
This patch adds the possibility to add margin to target instead of root: - Rename root_margin_ to margin_ - Add MarginTarget, which can be either root or target - Ensure that percent margin always resolves against root Note that we cannot add both target and root margin since then we need to be able to determine if we're 'double counting' the margin in the case where there is no intermediate clippers. I think however, just adding the target margin is sufficient for dealing with intermediate scrollers. Since the percent resolves against the root, it is also equivalent to root margin when there is only one (root) clipper. R=chrishtr@chromium.org, szager@chromium.org Change-Id: I836d5645615f440b61d835ee83d416b559efe352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258454Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782641}
-
Rakib M. Hasan authored
GenerateTags is no longer called on the telemetry side. The telemetry CL that removes the use of this function is crrev.com/c/1769732. Bug: 992260 Change-Id: Ie511df5d4fd1c604d68f2732eb7b6a3718221e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261146 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782640}
-
My Nguyen authored
This reverts commit 3566950c. Reason for revert: Emoji Suggestion will be 1% experiment in stable for M85 Original change's description: > Enable emoji suggestion by default > > Bug: 1049826 > Change-Id: Ic76e6d7f0a69e9e07c704ebfc3debe91fb1ab3b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241398 > Reviewed-by: Jing Wang <jiwan@chromium.org> > Commit-Queue: My Nguyen <myy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777735} TBR=myy@chromium.org,jiwan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049826 Change-Id: Ie909e473022c67e0e0343b07bb8b9b308b842da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264187Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782639}
-
Patrick Noland authored
These tests are parameterized so we need a * for the suffix Bug: 1096612 Change-Id: Idd2c220617179e11fbdd5fe5ee33f98cac452c42 Tbr: szager@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267643 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
edchin authored
When new items are inserted and selected, the previous selection should be removed. Change-Id: Ide541c7636f9788ee77a62561a449d77815be3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267740 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#782637}
-
Miriam Zimmerman authored
Per chrome inclusive language efforts, this CL replaces uses of the term "whitelist" with more-descriptive alternatives. BUG=1099354 TEST=CQ Change-Id: Ib91e7e5dcc228281895dd4545795bf94903ad233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267641Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#782636}
-
Matthias Körber authored
Change-Id: I2ddb14c249c98565b94ff4129f15d5b6b37b55d1 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264439 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#782635}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Fix a couple nits in chrome/browser/media/webrtc along the way. Bug: 1009837 Change-Id: Ieb2bfcfb39717c40c26743c2e900339833d15afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265251Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782634}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/87c8b9163983..30f774ef87bc 2020-06-25 sokcevic@google.com Rename whitelist/blacklist to allowlist/blocklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098560,chromium:1098562 Tbr: agable@chromium.org Change-Id: If3ddd72906d1be36a14da48bed08c98a01bbe865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267921Reviewed-by:
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/2261098 I made it so that the WebContents an utterance came from must be visible in order for it to be spoken. I'm worried this is going to break extensions, where the WebContents is most likely not visible. This patch gives the old behavior, unless SetStopSpeakingWhenHidden(true) has been called. BUG=1025626 TEST=will add tests later Change-Id: I855f8a9f039e38443150d43caea9a7eece8523bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267445 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#782632}
-
Xing Liu authored
The "later" downloads will be put to "Scheduled for later" section in download home UI. We use GenericViewHolder. The menu has a "change" item. The click event is currently not hooked to anything yet. TBR=holte@chromium.org Bug: 1078454 Change-Id: Ibc736a6c40878ea21b9ca5c656506e600a40f262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256741 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782631}
-
Garrett Beaty authored
Change-Id: I6a2e3b5f9a22119c9f430786c61c2a77c7a96b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261187Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#782630}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7abfef2d1558de6febb0efabd03ce08f06c56b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267848Reviewed-by:
-
Brian Geffon authored
This feature is now LAUNCHED in finch with an expiration of M86. Bug: 993569 Change-Id: I23a01f8e13ff90f47da2ceb753010b2a8a971f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267744 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#782628}
-
Ella Ge authored
Diable on mac due to flaky. TBR=johnidel@chromium.org No-try: true Bug: 1099410 Change-Id: I90585c2e10040624fa3ae1abbcb535285c258061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268218Reviewed-by:
-
Yi Gu authored
The metrics are still valuable until at least M88. Bug: 1088656 Change-Id: Id506d97f6a988d2d2db2eb639b169cb20a0b84f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264492Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782626}
-
Sahel Sharify authored
Bug: 1026667 Change-Id: Ib3eb35958c1307661243977f70a4102f63c3a744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268017Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782625}
-
Patrick Noland authored
Bug: 1099365 Change-Id: Icd983164e5382c3e593c2c53b2bd84074dfd4e72 Tbr: guidou@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267507Reviewed-by:
-
Garrett Beaty authored
This allows the generate_buildbot_json presubmit check to determine whether or not it should validate that builders exist without having to parse or scrape starlark source files. Bug: 1056428 Change-Id: I9540512275d9c8235e92870670d60a2809b1fcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268118 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ R=gab@chromium.org Bug: 1097092 Change-Id: I5651453cbc18845735cedf4aa019e6103f718db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261954 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#782622}
-
Matt Wolenetz authored
Reduces confusion between a couple top-level mp4 box log messages: 1) BoxReader::IsValidTopLevelBox() issues a MEDIA_LOG if an unrecognized top-level box is found in the path that returns false, and typically results in parse error. Since I could find no caller which allows this to proceed without parse error, I changed this from a DEBUG to an ERROR to give web apps more visibility into the root cause via MediaError.message. (Caveat, until bug 1099034 is fixed, the more generic "stream parsing failed" error replaces the more specific, new parse error added in this change.) 2) Mp4StreamParser::ParseBox() issued a similarly-worded DVLOG if there is a top-level box that *is* valid, but is skipped over. This change removes the confusing word "unrecognized" from this DVLOG, since the box is recognized as valid, but is just not parsed in detail. TEST=(For #1) Updated BoxReaderTest.WrongFourCCTest BUG=1096273,1099034 Change-Id: I5525119177343465a8046aaa6dec3f7993a4caec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264510 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782621}
-
