- 10 Mar, 2020 1 commit
-
-
Ryan Hansberry authored
Migrate metrics recording from bluetooth_private_api.cc and tray_bluetooth_helper_legacy.cc to bluetooth_utils.cc. Now that all metrics recording is unified under bluetooth_utils, subsequent CLs to flesh out these metrics in question will be easier to understand. Bug: 953149 Change-Id: Icf70d1e439b003f80f1250e4547c8275b77f201f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090295 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#748416}
-
- 09 Mar, 2020 39 commits
-
-
S. Ganesh authored
This reverts commit b99538b3. Reason for revert: The original CL 2092939 was not the cause of the flaky failures, so reverting the revert. Original change's description: > Revert "Better registry cleanup in InstallServiceWorkItemTest." > > This reverts commit b256ed1f. > > Reason for revert: I'm hoping reverting this and your other patch will fix the flake. Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 > > Original change's description: > > Better registry cleanup in InstallServiceWorkItemTest. > > > > mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are > > failing with the following error: > > > > AssertionError: In state 'chrome_user_installed_not_inuse', Registry key > > HKEY_LOCAL_MACHINE\Software\Chromium exists. > > > > This is most likely due to the change I made in change 2086353 to delete > > a value instead of the key. > > > > Now the test will delete the key if the test is the one that created the > > key in the first place. > > > > Bug: 1059314 > > Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939 > > Commit-Queue: Greg Thompson <grt@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Auto-Submit: S. Ganesh <ganesh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748062} > > TBR=ganesh@chromium.org,grt@chromium.org > > Change-Id: I875c730322f5bc4cc9fdfa8b5497e26f2b8b81da > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1059314 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095201 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748256} TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org Change-Id: Ia53b0dae159068f44137e0e8d597d3dd9c2f0428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095766Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748415}
-
S. Ganesh authored
This reverts commit 9e13a828. Reason for revert: The original CL 2086353 was not the cause of the flaky failures, so reverting the revert. Original change's description: > Revert "Fix InstallServiceWorkItemTest deletes Chrome key under ClientState." > > This reverts commit ea173bd3. > > Reason for revert: Still seeing failure of mini_installertests. Hoping this will fix the flake. Bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 > > Original change's description: > > Fix InstallServiceWorkItemTest deletes Chrome key under ClientState. > > > > Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will > > create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96} > > if it does not exist and then delete it. If the test is run on a > > development machine, it will corrupt the stable Chrome install. > > > > Bug: 1057233 > > Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353 > > Auto-Submit: S. Ganesh <ganesh@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Commit-Queue: Greg Thompson <grt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#746738} > > TBR=ganesh@chromium.org,grt@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1057233 > Change-Id: I57c3d50264dcf433a123e2802f04a70af8742935 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094466 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748270} TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org Change-Id: I561963764eae05901f083b9c235cce165e623b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095956Reviewed-by:
-
Brian Cui authored
This CL disables tests that will be broken by the Infobar Improvements CL [1]. These tests will be fixed and re-enabled by [2], after [1] is merged and DEPS is auto-rolled to pick up the commit. The tests have been broken due to a one-character method rename in [1] for ScriptFormatterEditorAction to make the .toggleFormatScriptSource() method public (formerly private). [2] simply fixes the tests by updating the method call names. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981175 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2091228 Bug: 1981175 Change-Id: I5357c43c7a8256fe28bd0f370d09ba473b5eca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092424Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748413}
-
Kenichi Ishibashi authored
If caching a service worker script is successfully finished, |size_bytes| should be always >= 0. Using CHECK() because we shouldn't store any invalid data into persistent storage. Bug: 946719 Change-Id: I5b397733fecb0eba49ea12e439efcfc8dcfd279b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094835Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748412}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.31-1583148634-benchmark-82.0.4077.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia5fde0cddffd5ed65bb8d2626179b8de4537685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748411}
-
Peter Kasting authored
I believe these were not caught earlier because we previously called MaterialDesignController::Initialize() in every test, which reset the controller state to non-touch mode after the TestAPI scoper had set it to whatever we were trying to check. The most problematic of these is AvatarDisplayOnTeleportedWindow, which is what the bug here is formally about. However, the other tests disabled here should also be checked: perhaps the test can be rewritten in a way that makes sense with the WebUI tabstrip. This also makes a couple other changes for robustness that should have little practical effect: changing an EXPECT to an ASSERT (since if we fail to leave immersive mode when we expect, the test has already timed out, and we might as well abort), and changing a click on the leftmost pixel of a button to a click on the center. Bug: 1059514 Change-Id: I7973e043e462b649cca9b4f25214149dcd6bc41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095855 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#748410}
-
Rakesh Soma authored
Change-Id: I691e445c50acbfd5aa6e5e7ca66395bbc022272f Bug: 1058467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056611 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748409}
-
Josh Nohle authored
The device registry is logged when the v2 device manager is started and after each successful v2 DeviceSync. This will greatly help with v2 DeviceSync debugging. Manually tested to verify formatting. Change-Id: Idfc5892b7d89e619784d8496ba0ead435f1950a2 Bug: 951969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079683Reviewed-by:
-
Ben Joyce authored
BUILD.gn changes not included to reduce files changed. Bug: 1052460 Change-Id: I95a5d6827d5cad9db9d04bf9c811a232a1aa895a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090626 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748407}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.31-1583145468-benchmark-82.0.4079.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6231c7fc57a128954055b8e27e3dcc33de96e6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095662Reviewed-by:
-
Scott Violet authored
This reverts commit 28cff5e2. Reason for revert: I believe this is causing failures on the mac 64 bot (official) bot: https://ci.chromium.org/p/chrome/builders/ci/mac64-trunk/37658 . I suspect the dependencies are wrong ("schema_org_properties" looks like it should depend upon base). Original change's description: > Add validator for schema org entities and types in doc metadata mojo. > > * Add a validator that removes properties that are not the right type. > * Add double, time, and timedelta types in the document metadata mojo > structure. > * Use the new mojo types in document metadata extractor. > > Downstream clank will not be able to read fields parsed into the new > type, but will just skip over them. We should consider updating support > there. > http://cs/clank/java/src/com/google/android/apps/chrome/icing/AppIndexingReporterInternal.java?l=133 > > Bug: 1044250 > Change-Id: Icfd7f0db74abf7bd1261b30dc416c94a7a23b4c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062907 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#748357} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I4e428fb0a5caa37f48a65f67e36db6abb3e9a74f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095670Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748405}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583147204-benchmark-82.0.4077.0-r1 to 82-4044.31-1583749230-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2336ca58802815a5b793f6857449f0e0e98645c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095837Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bcc6fa4..34d7ff92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54607e5c3225d478b682ef354c3c985fbaea57e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748403}
-
Mason Freed authored
Bug: 1012108 Change-Id: Ic9a38aaae92ea1592a244283304608b429cf7bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092933 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748402}
-
Mohsen Izadi authored
Current diagram is a bit outdated and incomplete. The updated diagram: https://drive.google.com/file/d/1HHvLtZYou2-wjEmuwb2DmfVdO_t9PCPd/view Bug: 1055051 Change-Id: Id551cfd79372222af82b0e36a6aae598db24d269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069850 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748401}
-
Cliff Smolinsky authored
GDI patching (inconsistently) results in delayload crashes due to the sandbox restrictions applied to various processes. In an effort to catch all processes which need the patching, we applied it to all utility processes. However, this has proven to be too inclusive, as many of those processes have sandboxes which prevent this code from working properly. This change detects the sandbox type and only executes the patching if the sandbox type is ppapi, PrintCompositor, or PdfConversion. Bug: 1028670 Change-Id: I651f50d073a94bf3a7c1cfa9f01aa21761c68132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083384Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748400}
-
Tao Bai authored
Bug: 1059071 Change-Id: I6020bb00f73b402fb9a2ea95c11ed656d4aa9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092122Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748399}
-
Hazem Ashmawy authored
Use "Via-WebView-DevTools" label alongside "User-Submitted" label to explicitly track bugs filed using WebView DevTools. Fixed: 1057167 Test: Try open a crash report via the UI and see the labels fields in monorail Change-Id: Ib5efe130e7b08e444317c2f0774f3ed76e01ec98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095307 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#748398}
-
Justin Cohen authored
This feature was dropped in lieu of the KeepRenderProcessAlive flag. TEST=Does not regress any of the WKWebView hidden test cases. Bug: 943569, 930123 Change-Id: Ia6ab0e83e808477d6dbc7498607036ac05a31899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094468Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748397}
-
Manu Cornet authored
Bug: 1009638 Change-Id: I2f0671524fb3d0be94a5c2123b3273f738ffefb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093222Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#748396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6190ec8363a0..85edfc8c8341 git log 6190ec8363a0..85edfc8c8341 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 jalyn@microsoft.com Fix 'Add custom device' focus regression 2020-03-09 petermarshall@chromium.org [styles] Make radio button focus ring circular 2020-03-09 jalyn@microsoft.com Update module.schema.json and add missing action titles 2020-03-09 tvanderlippe@chromium.org Sort generated property values on keys 2020-03-09 jacktfranklin@chromium.org Move `self.mod` into `NumberUtilities` Created with: gclient setdep -r src/third_party/devtools-frontend/src@85edfc8c8341 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039620,chromium:1050549,chromium:1052248,chromium:174309,chromium:920154 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3382d4e1642b465e7f49a301c5486445c8f9c7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095424Reviewed-by:
-
sauski authored
Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. Bug: 1032584 Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Auto-Submit: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748394}
-
Matthew Mourgos authored
Bug: 976949 Change-Id: Ie67e521cef4db401ae31a546862bb06912801abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088638Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#748393}
-
Jimmy Gong authored
- Future CL's will remove the app from the app drawer and launch the SWA from the printer settings page. - Currently using a temporary icon, will replace once UI mocks are available. - SWA is hidden behind a flag. Bug: 1053704 Change-Id: I576f119df3ceea52fac54da8e1ed035fdc2d3a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078783 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#748392}
-
jonross authored
The maps_pixel_test makes use of Skia Gold Triage links, but not only as an artifact. Not actual baselines. For those unfamiliar this can be confusing, as the lack of positive image in Skia, is juxtaposed with there only being a json of expectations in code search. To clarify this I'm adding some docs to the maps_integration_test.py to have a note that the actual pixel failures will be reported in the logs, and that the Skia Gold Triage is a supplimentary artifact. TEST=maps_pixel_test Change-Id: I1c802ba2d4d021890333cbe9c857e54824a0476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095207 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748391}
-
Kevin McNee authored
This reverts commit d3cc8c2a. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9949? ../../content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/LinkerTests.java:16: error: cannot find symbol public class LinkerTests implements Linker.TestRunner { ^ symbol: class TestRunner location: class Linker Original change's description: > base/android: Remove linker tests support. > > The linker tests don't run on bots (and likely not locally either) and > do not support the latest library loading patterns. This is the first > step to remove them, as they add non-trivial complexity in the codebase. > > Bug: 1059707 > Change-Id: Ia14693419792f57dc4f65b2fc7f999e833aec42e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095059 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748365} TBR=pasko@chromium.org,yfriedman@chromium.org,lizeb@chromium.org Change-Id: Ib45bd99a42903407e92dfb4a386b31ec0e7f7ee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095777Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748390}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I50a93d7bdafea8034f8ace100e25d9d98e385a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093480 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748389}
-
Dominik Inführ authored
Add accounting for global handles in memory dumps. Add UKM/UMA metrics for them as well to help uncover regressions and get some statistics. Privacy review doc: https://goo.gl/X5eYHh New metric: Memory.Experimental.Renderer2.V8.Main.GlobalHandles Change-Id: I5fba506fe9ce7f8b676f676f10f52f81f7a62639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084594Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748388}
-
Cliff Smolinsky authored
In order to support updates to InitializePDF() to better scope the GDI patching to only processes which need it, this change creates a new sandbox type for PDF conversion which can be easily detected at runtime. Bug: 1028670 Change-Id: I5cd7cb252d638eb376127d2926e75bdd590ccb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087855Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Antonio Gomes authored
EnablePreferredSizeMode() was enabled for the old cocoa (non-views) based mac UI. This code is no longer needed after [1]. What is more, with recent conversion of ViewMsg_EnablePreferredSizeChangedMode to mojo [2], we actually fixed the fact that EnablePreferredSizeMode() was being called to provisional RenderView instances, and the mode was not being effectively transferred when the RenderView instanced transitioned to committed state. Prior to [2], then, the mode was simply not working. However, now that we made calls to EnablePreferredSizeMode() effective on Mac for provisional (and committed) RenderViews, a performance drop was observed on loading.desktop benchmark - see [2]. [1] https://chromium.googlesource.com/chromium/src/+/1515d1b6e029d3071b15ae2e89991de62db890e3 [2] https://crrev.com/c/2068699 [3] https://chromeperf.appspot.com/group_report?bug_id=1058975 This CL fixes the perf regression by removing calling EnablePreferredSizeMode() on Mac for provisional RenderViews. As a follow up WebContentsView::RenderViewCreated() declaration and overrides can be removed altogether. BUG=1058975, 1051155 R=dtapuska@chromium.org Change-Id: I14be481949b7e11b6eeba8fe9ac383729ec994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092096Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#748386}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8259fd8a9e265207846842369e28e7e06b870637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095499Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748385}
-
Ben Joyce authored
Now that Recyclerview has migrated to Androidx, can remove gridlayout. Bug: 1052460 Change-Id: I844e8cd1480b8eb648d0a9104266103e0051c1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094543 Commit-Queue: benjamin joyce <bjoyce@google.com> Auto-Submit: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748384}
-
Annie Liu authored
In blink we use -1 to represent infinite iterations for historical reasons. Rather, we should use std::numeric_limits<double>::infinity() to be more specification-complaint. CL based on crrev.com/c/1373409. Bug: 913662 Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Annie Liu <t-hunliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748383}
-
Markus Handell authored
WebmMuxer feeds signed timestamps into a mkvmuxer method taking only unsigned timestamps. This turned into problems muxing data for the case the MediaRecorder was immediately paused on startup, and WebmMuxer would try to feed negative timestamps to mkvmuxer. The change makes sure we do not insert negative timestamps. Bug: 1045381, 1057810 Change-Id: I3ea00bb3f4d372e9f6ad4eeba484b0cb8a9582fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095071Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#748382}
-
Robbie McElrath authored
This CL reduces the minimum amount of time between seed downloads from 24 to 12 hours. This should reduce the time taken for variations seeds to be distributed on WebView. 12 hours was chosen as a compromise between our need for quick seed distribution and resource usage on device. We may revisit this number based on the results of this change. Test: Manually verified with logs that 12h is used for timestamp check. Bug: 979075 Change-Id: I5b183f9970662468be1b214cf7d8cb6d4665041d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086263Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#748381}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1901591 made the test useless by changing the initialization order it was meant to test. That change is no longer necessary as scheme registration happens at JNI_Onload, so it can be reverted. Bug: 783819 Change-Id: I7543eee8e42c13cf2b675d97e29ef3cd14669e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095558Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#748380}
-
Ryan Hansberry authored
Change-Id: I25d3bcf5cb68bc6c5a61f8a9fcb946924deef84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092711Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#748379}
-
Scott Violet authored
This reverts commit 1dd4504b. Reason for revert: this test is still flaky. It failed twice in a row here: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44908 and https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44907 . I am also able to reproduce the flake locally. Original change's description: > Regression test for null pointer deref. > > Bug: 1050801 > Change-Id: I67a09733abcc07e83031e05541b945ccdd56eece > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073158 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746908} TBR=pkasting@chromium.org,msramek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1050801 Change-Id: Ic1e632a5e00a97e4d297217619194a0c3631d6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095404Reviewed-by:
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I049a1e16fcd8ad7e3e85343cc01ba028f201c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095197 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748377}
-
