- 24 Jan, 2020 40 commits
-
-
John Budorick authored
Mistakenly updated the system image package instance ID rather than the avd package instance ID in crrev.com/c/2003563. Bug: 922145 Change-Id: Id7535607acc4e73415b5f39a1ba08262c92897ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017822 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734988}
-
yilkal authored
WebTimeNavigationObserver is used to notify its event listeners when a navigation finishes. Bug: 1034551 Change-Id: Ic233f11bbf17b6c0c6eccda9b9f52c8ded3feea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004994Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734987}
-
Koji Ishii authored
Following bot results are included. 1101 1105 1108 1111 1112 1114 1115 1116 1118 1119 1120 52 lines were removed and 12 lines were deflaked by consecutive results since 1094. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ia243b17fbe6214e126ceaf5c47f94e4d4835975a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016682Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734986}
-
Marian Fechete authored
This CL merges client memory into user data; removing parts of the client memory and parts of the former user data. In a previous CL, user data ownership was moved to the controller to allow it to be retained across multiple collect user data actions. With this CL, client memory is removed/merged into user data so that all the user values retained on the client will eventually be kept in a single place. Also in this change, selected_profile, billing_address and shipping_address are no longer separate/individual fields on the user data, rather they are stored in the autofill profiles map. Note that the action delegate can now provide the user data instead of the client memory. This is plumbed through from the controller via the script tracker. Bug: b/148132177 Change-Id: Ife130d7537680fd214459bc2d80610cd8c3dfea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014450 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#734985}
-
Jan Wilken Dörrie authored
Similarly to r733548 this change migrates the remaining base::PostTaskAndReplyWithResult APIs to use base::OnceCallback and updates their call sites. TBR=danakj@chromium.org Bug: 714018 Change-Id: I50d1038be0efc180313e43556848984ce0a42720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016624 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734984}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d87e67684558..fa06dd0b6210 git log d87e67684558..fa06dd0b6210 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 cwallez@chromium.org Fix Vulkan Swiftshader build on macOS Created with: gclient setdep -r src/third_party/dawn@fa06dd0b6210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1c6cca7a1f55424e81a508c642a4d61e3096f3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734983}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2a36ca29e3d..05eb37fad076 git log e2a36ca29e3d..05eb37fad076 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.shortcutRegistry 2020-01-24 tvanderlippe@chromium.org Migrate web_audio/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate persistence/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate timeline_model/ to import cross-module 2020-01-24 aerotwist@chromium.org [Global] Update refs to Persistence.persistence 2020-01-24 aerotwist@chromium.org [Global] Update refs to SDK.domDebuggerManager 2020-01-24 tvanderlippe@chromium.org Migrate settings/ to import cross-module 2020-01-24 aerotwist@chromium.org [Global] Update refs to SDK.isolateManager & SDK.domModelUndoStack 2020-01-24 tvanderlippe@chromium.org Migrate javascript_metadata/ to import cross-module 2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.context 2020-01-24 almuthanna@chromium.org Improve CharacterIdMap max capacity test 2020-01-24 mathias@chromium.org [e2e] Simplify collectAllElementsFromPage helper 2020-01-24 tvanderlippe@chromium.org Migrate search/ to import cross-module 2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.actionRegistry Created with: gclient setdep -r src/third_party/devtools-frontend/src@05eb37fad076 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632,chromium:1045385 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf903fdd6ead922950215988b1b89f81e9b6757e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019077Reviewed-by:
-
Martin Šrámek authored
*/EncryptedMediaTest.Playback_VideoOnly_MP4_AV1_10bit/* */EncryptedMediaTest.Playback_VideoOnly_WebM_Fullsample/* */EncryptedMediaTest.ConfigChangeVideo_EncryptedToClear/* TBR: tmathmeyer@chromium.org Bug: 1045393, 1045382, 1045376 Change-Id: Id1e866fa48d372d1fd88413d2fee8d159bad6fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019107Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#734981}
-
Sean Gilhuly authored
In the event that Vulkan or Metal are available and in use but GL is blocked, remove it from the list of fallback options. The first fallback will go to Swiftshader. Bug: 1005383 Change-Id: I4e1f471374072a74f82d55e08e0e84c98c6f7b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016345 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734980}
-
Yusuke Sato authored
BUG=None TEST=try, no real code change Change-Id: Ib552103883e98a83e7748a47c5a755f34b34b708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018003Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#734979}
-
Himanshu Jaju authored
Logs if parsing the ice candidate message was successful. Bug: 1021984 Change-Id: I5c7adaed6e3fef5e7e5417f8edd6d11381e6f95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014942Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#734978}
-
Yann Dago authored
Bug: 958893 Change-Id: I65e220fd47755686ef3a2a58468de2a640473c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013361 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: Id68870da5b0d31aeccffaedfbc2aead625bcefba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017466Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734976}
-
Nicolas Ouellet-Payeur authored
IE doesn't seem to unencode single-quote characters (') in the query-string of a URL. With this patch, Chrome unencodes single-quotes before sending it off to IE. Bug: 1030184 Change-Id: I0c5e21b5789dfe357272ea87ca33f3c486fec7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019762 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734975}
-
Josh Karlin authored
This is a second attempt to fix a unittest race. The main thread gets a callback to update its total cache size that is posted after the cache entry is created. Wait for that to be run before checking the cache size. I was able to reproduce the issue this time and can confirm that this fixes it. Bug: 1042441 Change-Id: Ic3f0f5a05415ba391be2887a3597c9645faac661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015738Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734974}
-
James Cook authored
This reverts commit 1454ded8. Reason for revert: There are timing differences in the behavior of AccessTokenFetcher and PrimaryAccountAccessTokenFetcher. We need to change the behavior of PAATF in another CL, then we can use the new version here with the unconsented primary account. Original change's description: > chromeos: Migrate TokenHandleFetcher to unconsented primary account > > SplitSettingsSync will allow the user to opt-out of browser sync. > However, IdentityManager::GetPrimaryAccount() assumes the user has > consented to sync. Switch to using the "unconsented" primary account, > which exists whether or not the user has consented to sync. > > This code doesn't add a DCHECK that the unconsented primary account > exists because there are managed guest session tests that don't > have a primary account but still exercise this code path. > > and on device > > Test: existing login browser tests, manual tests of login on linux > Bug: 1042400 > Change-Id: I14ee7bcc18c294dee31c26fcc9bed537836516b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015589 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734647} TBR=jamescook@chromium.org,xiyuan@chromium.org Change-Id: I42942890e077e1a4d613816b084f900bac7299c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019409Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#734973}
-
Kyle Milka authored
Add a test file for the ShareSheetCoordinator with a few basic tests. Bug: 1009124 Change-Id: I65494bdefade392d46d645d41ee3bd1555b99b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993758 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734972}
-
Scott Violet authored
This code may be triggered from the main thread. BUG=none TEST=none Change-Id: I72943d34eab9271cc2d94cbc3e1f064361b6c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018064Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734971}
-
Michael Forney authored
SIGSYS fields were added to siginfo_t on glibc in version 2.17, which is quite old now. Additionally, musl libc uses a different name (__si_fields) for its internal struct members. To fix this, use the libc-defined members if they are available, otherwise fall back to _sifields, as is done currently. Change-Id: I6a542a1817df7e31309a1043b899328a50834f7d Bug: 1045069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015735Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#734970}
-
Mia Glaese authored
StartSurfaceToolbarCoordinator is not created for tablets. Added a null check. Bug: 1044902 Change-Id: Ibca30bff92cabae9fc14db204c2a871ac93e04b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016966Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#734969}
-
Stephane Zermatten authored
Before this change, when an interrupt that ran inside of a PromptAction failed, the PromptAction would ignore the callback with a INTERRUPT_FAILED status and never return. The client would get stuck. With this change, PromptAction properly forwards errors and stop actions from interrupts. Bug: b/146311363 Change-Id: I7d2133746ecd6e6ee4c45796b1d106cecc46b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014938Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#734968}
-
Ali Juma authored
This moves UnsafeResource from components/security_interstitials/content to components/security_interstitials/core, and moves the methods in UnsafeResource that depend on content/ into unsafe_resource_util.{h, cc}. This makes it possible to use UnsafeResource on iOS. SafeBrowsingUrlCheckerImpl uses UnsafeResource, so this CL is a step towards refactoring SafeBrowsingUrlChekerImpl to make it usable on iOS. TBR=boliu,carlosil,jkarlin Change-Id: Ie981a39f1f42dd3a08162759c70582c0e15256c0 Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015344Reviewed-by:Ali Juma <ajuma@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#734967}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: Ieae5c6ac2742659716e71514c178ea9a9d02c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017462Reviewed-by:
-
Sebastien Marchand authored
proactive tab discarding has been removed, there's no more "CanDiscard" column on the discards page. Bug: 1044782 Change-Id: Iecd8c33c2fabc935b580951b1c6d383546ff0394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017926 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#734965}
-
Emily Stark authored
We are converting Android WebView Safe Browsing interstitials to committed interstitials, so that interstitials work more like other error pages. In WebView, existing error pages don't need to run JS, but interstitials do. This CL forces images and scripts to be enabled for error pages so that interstitials work properly (e.g., clicking on buttons works) even if the app has disabled JS for web content. Images and script are force-enabled by allowlisting the underlying error page URL in AwContentSettingsClient, similar to how content settings are allowlisted for error pages in ContentSettingsAgentImpl for Chrome (https://cs.chromium.org/chromium/src/chrome/renderer/content_settings_agent_impl.cc?type=cs&sq=package:chromium&g=0&l=616). I have not added tests in this CL because this will already be covered by existing Safe Browsing WebView tests once they are switched over to use committed interstitials (https://chromium-review.googlesource.com/c/chromium/src/+/1909276/). This CL can be manually tested by visiting a link on https://testsafebrowsing.appspot.com in an app that has Javascript disabled for WebView and clicking the "Details" link and observing that the interstitial UI changes. Bug: 1018809 Change-Id: I46f71738a2af3ff7361922ef0cde1522bcfb6e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017987Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Sidney San Martín authored
TBR=asvitkine Change-Id: I068e575c8ed7b49a3ce009545a4e6c7790a15340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019702Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734963}
-
Miguel Casas authored
USE_CHROMEOS_MEDIA_ACCELERATION should be used with BUILDFLAG() and not with defined(). This CL corrects that. Change-Id: Ib8807a7b282799eecc37bf32ed78519307b230ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018154 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#734962}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15d104be0c75..4ccfb08a648f git log 15d104be0c75..4ccfb08a648f --date=short --first-parent --format='%ad %ae %s' 2020-01-24 mmortensen@google.com Use goma env variable for goma-created temp log dir. 2020-01-24 vapier@chromium.org cbuildbot: drop blamelist code 2020-01-23 bpastene@chromium.org cros_chrome_sdk: Don't set a default val for target readelf. Created with: gclient setdep -r src/third_party/chromite@4ccfb08a648f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I185e588008561da36fe0c566146291af4a31ffea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019074Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/89730072b81077cc3e3a973963015b2494d36b1a..1cc95ac07c17d61bea601832bbdc1f8d13d313db Bug: none Change-Id: I4adf059483b2ec474303f9c9ba1d7857102bb7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017935 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#734960}
-
Francois Doray authored
This reverts commit e5eb732c. Reason for revert: https://crbug.com/1045466 Original change's description: > Roll src/third_party/webrtc 760fd5249488..9bac68c0cc44 (1 commits) > > https://webrtc.googlesource.com/src.git/+log/760fd5249488..9bac68c0cc44 > > git log 760fd5249488..9bac68c0cc44 --date=short --first-parent --format='%ad %ae %s' > 2020-01-23 kron@webrtc.org Reland "Reland "Distinguish between send and receive codecs"" > > Created with: > gclient setdep -r src/third_party/webrtc@9bac68c0cc44 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/webrtc-chromium-autoroll > Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:1029737 > Tbr: webrtc-chromium-sheriffs-robots@google.com > Change-Id: Ia45c015c7d76de3c5fb72044f26a6c1457d9c74d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018041 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#734895} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I255b09e0446b71e7146f09d0250b5962e6cd9f25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1029737, chromium:1045466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019407Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#734959}
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: Id42888f911937e2eaf9241fd89c9257f042a48c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016650Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#734958}
-
Sylvain Defresne authored
[ios] Fix uses of ios::ChromeBrowserState in /ios/chrome/browser/ui/browser_view/browser_view_controller.h The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I93ed83ef713fb87dcf730a8a40c28a7df9428c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017523Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734957}
-
Corentin Wallez authored
The issue when using multiple shared images was that a `ScopedAccess` was destroyed after it's `SharedImageRepresentation`. The code was similar to the following: struct Pair { unique_ptr<Representation> representation; unique_ptr<Access> access; }; base::flat_map<Key, Pair> map; map.erase(some_iterator); In the Pair destructor C++ guarantees that `access` is destroyed before `representation` but `erase` can move one element over another, causing the move-assignment operator to be called. In this case the defaulted move-assignment would first move `representation` then `access`. Causing incorrect member destruction order for the move-to object. Thanks to senorblanco@ and amaiorano@ for figuring out this wasn't a compiler bug by jumping in the flat_map internals! Bug: chromium:1038210 Change-Id: Ida90804a9840d1acba96a37c7cad17cf6bcc46ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014927Reviewed-by:Geoff Lang <geofflang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#734956}
-
Julian Pastarmov authored
This implementation still lacks the serial number and lock screen status extraction but provides the rest of the information similar to the other platforms' implementations. BUG=1037702 TEST=unit_tests Change-Id: I459eeafe02b495962c5d9f2a6e5eddc7ba90b974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012956 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734955}
-
Nikita Podguzov authored
Bug: 1043711 Change-Id: I0e5bd6986c9c1a26d80c7605cdff1192d37b39f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014901 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#734954}
-
nancy authored
This is the follow up for CL:2010449. The order of the AppContextMenu's functions is reordered to align with the definition. BUG=1038487 Change-Id: I2a979a32fe1b9ac2a18d1fda26097312027f7037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016684Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#734953}
-
Sharon Yang authored
We have now discovered fidl::Equals, so instances of individually checking each field in fidl objects can be replaced with fidl::Equals. An additional test cleanup in frame_impl_unittests. Test: CQ Bug: 1039849 Change-Id: Ifcb4e2fb87000fed558ef50aa786c77ea04b5ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995742 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#734952}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2691925b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Id7d3143604673d4fe9b7c565a12d13f6a8010c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019502Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734951}
-
Nicolás Peña Moreno authored
Change-Id: I5716c032afe345989397e655370c3b294a251f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018172Reviewed-by:
Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734950}
-
Akihiro Ota authored
Phase 1 of ChromeVox custom annotations project. This change adds a new file to the ChromeVox codebase called node_identifier.js. This file contains objects and methods used to uniquely identify AutomationNodes. Several basic tests have also been implemented in node_identifier_test.js. This file is being added to support ChromeVox custom annotations. For more details on that project, please see the following design document: https: //docs.google.com/document/d/1K6Sg0wLOjUdz7ycJqxPnFWNvie7yaJ3enlss10cXKqM/edit Change-Id: Id5c60ec9257bef0738366d045100915e26d19e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992594 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734949}
-
