GitLab

BUG=111900
TEST=Invoke 'Clear Browsing Data' from the wrench menu, should bring up the correct dialog.
Review URL: https://chromiumcodereview.appspot.com/9309018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120006 0039d316-1c4b-4281-b951-d872f2087c98

Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.

This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.

The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message. 

If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.  

Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.

This also addresses some GTK omnibox browsertest flakiness; see bug 112041.

Contributed by aaron.randolph@gmail.com

BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.

Review URL: http://codereview.chromium.org/6731036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120005 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis

Review URL: http://codereview.chromium.org/9315018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120004 0039d316-1c4b-4281-b951-d872f2087c98

To be removed when r119687 reaches official builds.

BUG=None
TEST=None

TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9233037

TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120003 0039d316-1c4b-4281-b951-d872f2087c98

xib changes: Cleared the "Key Equiv" field from the Change button.

BUG=112204
TEST=


Review URL: http://codereview.chromium.org/9307017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120002 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Delete some 0 byte files that are still lying around as a result of a CQ bug. (no code review because the CL is "empty")

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120000 0039d316-1c4b-4281-b951-d872f2087c98

On Mac, the search field's cancel button appeared to be missing. This was caused by applying
a transformX() to header elements to allow them to side-scroll properly. This CL changes to
use margin-left instead. The behavior is the same, but now the cancel button appears properly.
I will be filing a WebKit but since this is probably a core issue with the search control.

BUG=112046
TEST=Verify that search field displays a cancel button when not empty.
Review URL: https://chromiumcodereview.appspot.com/9318009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119999 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca

Review URL: https://chromiumcodereview.appspot.com/9318008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9318004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119997 0039d316-1c4b-4281-b951-d872f2087c98

In accelerated compositing mode we can't start rendering until the
native window (HWND/gtk widget) are created on Windows and GTK without
aura. For most render_widgets the code today is racy, but for
window.open() and similar creation paths this is a race that we pretty
much always lose. This defers the first DoDeferredUpdate on a render_widget
until its host_window_ is available.

Also defers querying for GL_CHROMIUM_supports_swapbuffers_callback
extension until the first draw, since the context isn't ready until the
host window is available.

BUG=106815
TEST=start with --force-compositing-mode and --show-fps-counter, load up
a page that uses window.open() to open a popup, and confirm that the
popup is in compositing mode


Review URL: http://codereview.chromium.org/9225050

TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25708
TEST=None

R=dtu@chromium.org


Review URL: http://codereview.chromium.org/9314006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9314004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119994 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99858
TEST=KeyboardOverlayDialog should show up on aura build.


Review URL: http://codereview.chromium.org/9250029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119992 0039d316-1c4b-4281-b951-d872f2087c98

The change just fixes a gyp style nit in a non-default code path.

BUG=96629
TBR=thakis

Review URL: http://codereview.chromium.org/9309014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104551
TEST=compile


Review URL: http://codereview.chromium.org/9160012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119990 0039d316-1c4b-4281-b951-d872f2087c98

* Reset the state of a GestureSequence after a tap/double-tap gesture.
* Do not send scroll-update gestures when both delta-x/delta-y are zero.

BUG=none
TEST=aura_unittests:GestureRecognizerTest.GestureTapFollowedByScroll

Review URL: https://chromiumcodereview.appspot.com/9318010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112153
TEST=no


Review URL: http://codereview.chromium.org/9315008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119988 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/9307006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119987 0039d316-1c4b-4281-b951-d872f2087c98

Revert 119976 - Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows.

http://crbug.com/112131
TEST=see unittests
Review URL: https://chromiumcodereview.appspot.com/9315015

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9315017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119986 0039d316-1c4b-4281-b951-d872f2087c98

Does the following:
- Removes race between autoplay and explicit .play().
- Removes race between seeked and .play().
- Adds logging for several other failure type events.
- Moves the events.join() code into Python so better errors can be
  reported.
- Instead of opening a new tab for each video in the matrix, reuses the
  same tab for each playback.  Ensures abort and emptied events fire on
  src switch.

Reusing the same tab was necessary to prevent the video from hanging on
the Linux bot, as a nice bonus it shaves seconds off the runtime.

BUG=111603
TEST=Ran on Linux bot.

Review URL: https://chromiumcodereview.appspot.com/9233046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119985 0039d316-1c4b-4281-b951-d872f2087c98

Move common file path related methods between chrome & content to file_util. I reduced the 4 methods into 3 by only having one GetUniquePathNumber which takes an optional suffix.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9316004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119984 0039d316-1c4b-4281-b951-d872f2087c98

This change causes asyncore.loop() to internally use poll() instead of
select(), which may prevent the "bad file descriptor" exception from being
thrown on the Chrome Endure tests.

Also enhanced an assertion error message in perf_endure.py to give more
context if the assertion is violated.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9309019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119983 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell

BUG=112200
TEST=TSAN bots

Review URL: https://chromiumcodereview.appspot.com/9317015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119982 0039d316-1c4b-4281-b951-d872f2087c98

This will get more runs on the ExtensionUnpacker tests to get
more directories.

BUG=108724
TBR=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9315016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots


Review URL: http://codereview.chromium.org/9019002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119980 0039d316-1c4b-4281-b951-d872f2087c98

This is to conserve video memory for hidden tabs that are not expected to be needed in the near term.
Review URL: https://chromiumcodereview.appspot.com/9303009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109663, 95586
TEST=None

Review URL: http://codereview.chromium.org/9114056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119978 0039d316-1c4b-4281-b951-d872f2087c98

In accelerated compositing mode we can't start rendering until the
native window (HWND/gtk widget) are created on Windows and GTK without
aura. For most render_widgets the code today is racy, but for
window.open() and similar creation paths this is a race that we pretty
much always lose. This defers the first DoDeferredUpdate on a render_widget
until its host_window_ is available.

Also defers querying for GL_CHROMIUM_supports_swapbuffers_callback
extension until the first draw, since the context isn't ready until the
host window is available.

BUG=106815
TEST=start with --force-compositing-mode and --show-fps-counter, load up
a page that uses window.open() to open a popup, and confirm that the
popup is in compositing mode


Review URL: http://codereview.chromium.org/9225050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119977 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows.

http://crbug.com/112131
TEST=see unittests
Review URL: https://chromiumcodereview.appspot.com/9315015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51716
TEST=valgrind mac bots

Review URL: https://chromiumcodereview.appspot.com/9314011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119975 0039d316-1c4b-4281-b951-d872f2087c98

Since most calls to WaitUntil use lambdas, you commonly see a lot of:
DEBUG    WaitUntil(<function <lambda> at 0x79b984c4>) still waiting. Expecting None. Last returned False.
With this change it is instead:
DEBUG    WaitUntil(pyauto.py:281 self.WaitUntil(lambda: _AreOrigPidsDead(orig_pids))) still waiting. Expecting True. Last returned False.

Also reduce the frequency to once every 5 seconds.


BUG=None.
TEST=Run any PyAuto test that uses WaitUntil().

Review URL: http://codereview.chromium.org/9104022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109875
TEST=PipelineIntegrationTest.*


Review URL: http://codereview.chromium.org/9309004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119973 0039d316-1c4b-4281-b951-d872f2087c98

Removing some of the prematurely-forked sync settings code, to make it easier to perform
refactoring of the sync APIs.

BUG=111859
TEST=Make sure sync signin and settings still work.


Review URL: http://codereview.chromium.org/9104028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119972 0039d316-1c4b-4281-b951-d872f2087c98

Everytime a user clicks on the Feedback menu item or presses ctrl+alt+i on ChromeOS, record the exact time of that happening and send it in the feedback report the user submits.


R=zelidrag@chromium.org,adlr@chromium.org
BUG=chromium-os:25678
TEST=Tested with sending several reports invoked both by the shortcut and the menu item.


Review URL: http://codereview.chromium.org/9104030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119971 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glider

BUG=105580
TEST=

Review URL: https://chromiumcodereview.appspot.com/9315014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/9225051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:102139
TEST=


Review URL: http://codereview.chromium.org/9312001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119968 0039d316-1c4b-4281-b951-d872f2087c98

Remove unnecessary |text16| temporary and change
the code to not to compute the width of each word
twice.

BUG=none
TEST=Text in about dialog should look the same as before.

Review URL: http://codereview.chromium.org/9232055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119967 0039d316-1c4b-4281-b951-d872f2087c98

CID=102975
TBR=ahendrickson@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/9303013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119966 0039d316-1c4b-4281-b951-d872f2087c98