GitLab

Add WebGeolocationClient getter on RenderFrameImpl in preparation for getting it from WebFrameClient.

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/256693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/256763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366750

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile
TBR=zturner

Review URL: https://codereview.chromium.org/258823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266221 0039d316-1c4b-4281-b951-d872f2087c98

Can't use DISABLED_ macro for TEST_P so just commented out for now.

BUG=366750
TEST=compile
TBR=acolwell
NOTRY=true

Review URL: https://codereview.chromium.org/250953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266220 0039d316-1c4b-4281-b951-d872f2087c98

can't be fixed up into valid URLs.

BUG=357172
TEST=Typing "google.com/%00" (no quotes) into a debug build omnibox should not cause a DCHECK
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/226283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266217 0039d316-1c4b-4281-b951-d872f2087c98

So that we don't have to bug Mojo owners everytime for any Pepper
interface change.

TEST=None
BUG=None
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/253613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266215 0039d316-1c4b-4281-b951-d872f2087c98

(And make it the default in mojom_bindings_generator.gypi, so people who
have other/older system-installed versions of ply or jinja2 don't get
broken.)

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/258733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367199
TBR=dewittj

Review URL: https://codereview.chromium.org/250813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266211 0039d316-1c4b-4281-b951-d872f2087c98

login_OwnershipNotRetaken failures due to this CL.

BUG=358728,367005

> Remove files in /var/lib/whitelist before attempting login with telemetry.
> 
> BUG=358728
> TEST=Manual
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/246353004

TBR=achuith@chromium.org

Review URL: https://codereview.chromium.org/256833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266209 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266206 0039d316-1c4b-4281-b951-d872f2087c98

The current binaries are blocking a WebRTC roll, and breaking the canary builder.

BUG=367059

Review URL: https://codereview.chromium.org/252633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/252693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/258693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266201 0039d316-1c4b-4281-b951-d872f2087c98

The latter may fail because permissions.

BUG=313751
TBR=glider@chromium.org
NOTRY=true
TEST=msan

Review URL: https://codereview.chromium.org/253493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266200 0039d316-1c4b-4281-b951-d872f2087c98

Mostly naming changes. Also, improve verbosity flag handling.

BUG=313751
R=glider@chromium.org
NOTRY=true
TEST=msan

Review URL: https://codereview.chromium.org/255923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266199 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves most of the GCMProfileService functionality to a new
GCMService class that does not depend on Profile. GCMProfileService
becomes a subclass of GCMService that adds Profile-specific lifetime
management and control over the service via user preferences.

The CL is a prerequisite for Chrome OS device policy pushing, which will
need to instantiate a Tango connection using device-wide GAIA credentials
not tied to any user or Profile.

The CL also fixes a few subtle bugs, such as GCMProfileService::IOWorker
being shut down on the wrong thread and unit tests looking at the wrong
GCMProfileService when trying to verify correct behavior.

BUG=362083
TEST=Updated unit tests
R=atwilson@chromium.org, dcheng@chromium.org, jianli@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/225403021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266197 0039d316-1c4b-4281-b951-d872f2087c98

Also, use this to blacklist a function which is crashing due to an MSan bug.
Also, fix a small issue in DESTDIR builds which I discovered while testing this.

BUG=313751
R=glider@chromium.org
NOTRY=true
TEST=msan

Review URL: https://codereview.chromium.org/253613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266194 0039d316-1c4b-4281-b951-d872f2087c98

Also make RawChannels destroyable without DCHECK failures if OnInit()
fails.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/251483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266193 0039d316-1c4b-4281-b951-d872f2087c98

R=rpaquay@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/246393010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266192 0039d316-1c4b-4281-b951-d872f2087c98

Revert 266019 - "Add detail to 'invalid JSON' message in PRESUBMIT.py."

This presubmit check is invalid - it fails on existing .json files in the tree that contain comments. (Other JSON-reading tools strip out these comments.) Any changes to these .json files are incorrectly rejected by this check.

BUG=366395
TBR=iannucci@chromium.org,tnagel@chromium.org

Review URL: https://codereview.chromium.org/252713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266191 0039d316-1c4b-4281-b951-d872f2087c98

Specifically ability to delete nodes, create views and attach them.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266159

Review URL: https://codereview.chromium.org/250633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266190 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266188 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266185 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff ulan@chromium.org in case of problems.

R=ulan@chromium.org
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/258773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266184 0039d316-1c4b-4281-b951-d872f2087c98

> Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes.
> 
> This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member.
> 
> BUG=243341
> 
> Review URL: https://codereview.chromium.org/247283007

TBR=stepco@chromium.org

Review URL: https://codereview.chromium.org/257763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266179 0039d316-1c4b-4281-b951-d872f2087c98

On LoginDatabase using platforms, a password entry found by a PSL match gets the signon realm and the origin overwritten to match the query password form. This way, when the credential is saved, it is saved for the new site.

On Gnome, the overwriting did not happen. This CL introduces this to match the LoginDatabase behaviour.

Also, on Gnome, PSL matching was used not only to get logins, but also to check for existing logins when adding and updating passwords. The latter two use cases should require exact matching (that's also what happens in LoginDatabase). This CL fixes that, and only keeps PSL matching for GetLogins.

BUG=364745
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/245563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266177 0039d316-1c4b-4281-b951-d872f2087c98

Only relevant for the --enable-experimental-app-list-position flag.

AppListView now has a mode where it automatically keeps the bubble
centered on the screen's primary display, rather than a fixed position.

BUG=363928
TEST=Run with --enable-experimental-app-list-position. Open the app
list, press Ctrl+Shift+F3 to rotate. App list should remain centered.

Review URL: https://codereview.chromium.org/237533015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/234473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266175 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the code in DiscardableMemoryManager that was
hard-coded to use heap allocations with code that handle
instances that implement the
DiscardableMemoryManagerAllocation interface instead.

This allows us to use the manager class not only for
emulated discardable memory but any other type that
might need some level of userspace control. This also
removes the circular dependency between
DiscardableMemoryManager and DiscardableMemory classes.

BUG=327516
TEST=base_unittests --gtest_filter=DiscardableMemory*

Review URL: https://codereview.chromium.org/204733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266174 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=354046
TEST=unit_tests

Review URL: https://codereview.chromium.org/250443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266173 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266170 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/257423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266169 0039d316-1c4b-4281-b951-d872f2087c98

Gin Java Bridge requires some customization in JS values serialization:

 - 'undefined' values must be encoded, not skipped;

 - 'non-finite' doubles must be supported;

 - ArrayBuffers and ArrayBufferViews must be encoded differently.

BUG=355644
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/248903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266168 0039d316-1c4b-4281-b951-d872f2087c98

Mostly manual refactoring of ServiceWorkerRequestHandler into a base class and two derived classes, one for use when processing requests from a controllee document, and the other for use with request from a service worker context.

BUG=364247

Review URL: https://codereview.chromium.org/255413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266166 0039d316-1c4b-4281-b951-d872f2087c98

In ResourceScheduler::GetNumDelayableRequestsInFlight,
total_delayable_count has no relation to active_request_host,
so we do not need to compute it for each request.

The patch can boost BrowsingBench workload >5% performance.

BUG=347454

Review URL: https://codereview.chromium.org/180843016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266165 0039d316-1c4b-4281-b951-d872f2087c98

For example, to create an alarm event for SmokeDetector

function SmokeDetector() {
    this.defineEvents(['alarm']);
 };
base.augment(SmokeDetector, base.Events);

To fire an event
SmokeDetector.prototype.onCarbonMonoxideDetected = function () {
  var param = {} // optional parameters
  this.raiseEvent('alarm', param);
}

To listen to an event
var smokeDetector = new SmokeDetector();
smokeDetector.addEventListener('alarm',listenerObj.someCallback,listenerObj);

The code lives in (base.js), a module that contains JavaScript utility components and methods for the web app.

Review URL: https://codereview.chromium.org/245923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266164 0039d316-1c4b-4281-b951-d872f2087c98

RenderViewTest::LoadHTML assumed that issuing a load
of a data url, posting a task to quit the message loop
and then pumping the message loop until it quits was
sufficient to end up with a fully parsed page.

That very soon won't be true once we send data: urls
to the threaded parser, as the parser thread posts
back to the main thread and may post tasks after the
quit message.
https://codereview.chromium.org/210253003/

Instead I've added a FrameLoadWaiter class which
implements RenderViewObserver to listen for the
load event for the frame and only post the quit
task once the load event had come in.

BUG=308321

Review URL: https://codereview.chromium.org/257723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266163 0039d316-1c4b-4281-b951-d872f2087c98

Compilation error:

c:\b\build\slave\cr-win-rel-x64\build\src\mojo\services\view_manager\view_manager_connection.cc(199) : error C2723: 'mojo::services::view_manager::ViewManagerConnection::DeleteView' : 'override' specifier illegal on function definition

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17746/steps/compile/logs/stdio


> Adds more to viewmanager
> 
> Specifically ability to delete nodes, create views and attach them.
> 
> BUG=365012
> TEST=covered by tests
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/250633003

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/250733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365868
TEST=visual and unit test

Review URL: https://codereview.chromium.org/249723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266161 0039d316-1c4b-4281-b951-d872f2087c98