- 13 Sep, 2017 33 commits
 - 
- 
Erik Chen authored
Bug: Change-Id: Idd4d452d03c8c5c20628c35d788fb322ba99df39 Reviewed-on: https://chromium-review.googlesource.com/661945Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501495}
 - 
Andrew Moylan authored
Content shell and Android webview don't make network geolocation requests. Previously these embedders had dummy (no-op) implementations of AccessTokenStore. This CL removes the dummy implementations and instead uses the existing UseNetworkLocationProviders flag in GeolocationDelegate as a gate. This is part of the removal of all AccessTokenStores. Overall design: https://docs.google.com/document/d/1A-ZYMadJkwdQad_pC3MbpuCVNOOnRP_UZjGnXl-FOqE Details of reasoning why this is safe: Content shell: AccessTokenStore was being created but LoadAccessTokens was not being called on it (after crrev.com/c/641175). Android webview: AccessTokenStore was being created and LoadAccessTokens was being called on it, but to no consequence due to an "#if defined(OS_ANDROID)" block at location_arbitrator.cc:174. Bug: 748921 Change-Id: I10ed3668ee015f855acf604e445643617bbe7713 Reviewed-on: https://chromium-review.googlesource.com/658010 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501494}
 - 
Steven Bennetts authored
This adds support to networkingPrivate for selecting a Cellular mobile network. BUG=717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2cc89aaceae25e73d177cfdcb44e58912a5bbc2d Reviewed-on: https://chromium-review.googlesource.com/646571 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501493}
 - 
Erik Luo authored
Prior to this CL, some input fields did not have the 'x' button to clear text from the field. Namely, HeapSnapshotView's 'Class filter' and DatabaseTableView's 'Visible columns' will now behave consistently with the others. Screenshot: http://imgur.com/a/AJecJ Bug: none Change-Id: Ia1be529c0d2d851cbf63e01f4c69841f85ff75b0 Reviewed-on: https://chromium-review.googlesource.com/662398Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#501492}
 - 
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ec37390b..36e9ca06 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I4e3b8048adf4e123a37c0939e132c707be1b29e0 Reviewed-on: https://chromium-review.googlesource.com/663301Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501491}
 - 
Sergey Ulanov authored
Previously the classes for Unix domain sockets were compiled on all POSIX platforms, except NaCl, but the tests were disabled on iOS and filtered on Fuchsia. This change disabled compilation of these classes and unittests on all platforms on which they are not supported (iOS, Fuchsia and NaCl). Bug: 731302 Change-Id: I1da281845fd282d0f791cc4a324ef3d233f8a598 Reviewed-on: https://chromium-review.googlesource.com/664157 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501490}
 - 
Piotr Swigon authored
This is a revert of crrev.com/c/654118, as the decision has been made to hide the status bar icon on pre-O Android. This is because on pre-O users don't have the ability to selectivly silence notification channels, so making the notification least intrusive is important. Bug: 471623 Change-Id: If2efcdf680bba405fdf7c180119d6d6f331c38ab Reviewed-on: https://chromium-review.googlesource.com/663105Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501489}
 - 
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specification. Before this CL, Iterable's value types cannot be annotated. After this CL, however, Iterable's value types can be annotated types. In order to check if ASTs are dumped correctly, I also added pattern match based tests. Bug: 714866 Change-Id: I4e5cb09f36b6b7c04b7a0d3a32cff085691bcdc6 Reviewed-on: https://chromium-review.googlesource.com/662979Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501488}
 - 
Sammie Quon authored
Move splitview window selector unittests to their own test class. Bug: None Test: ash_unittests Change-Id: I8153c916a05ef9ab6011105ca670dfc0e73ee257 Reviewed-on: https://chromium-review.googlesource.com/661327Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#501487}
 - 
Kyle Horimoto authored
This code was unnecessary, since the CryptAuth component is the one that needs to listen for these tokens. Additionally, the listener in this class was set up improperly, which made it possible to get "stuck" without a token. Bug: 763506, 672263 Change-Id: I3e02f10aa201b129591028a8606b6fb4eefbaf11 Reviewed-on: https://chromium-review.googlesource.com/663978 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501486}
 - 
Victor Costan authored
Bug: 763650, 763848 Change-Id: Ideb5ab7ed300718458fe2665bf8af099bc56d272 Reviewed-on: https://chromium-review.googlesource.com/658838Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#501485}
 - 
Yoland Yan authored
Bug: 640116 Change-Id: I74053b1b4bcb37553a72305ece82703453354586 Reviewed-on: https://chromium-review.googlesource.com/636171 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#501484}
 - 
Matt Wolenetz authored
Previously, FrameProcessorTest had a boolean test parameter indicating whether or not to test using sequence append mode. This change adds a second dimension to the test parameter, which parameterizes the tests further by which version of the buffering API is being tested. The test ctor forces on/off the media::kMseBufferByPts feature accordingly. It no longer uses test ctor initializer to construct the FrameProcessor, since that must happen after adjusting enable/disable of the kMseBufferByPts feature later in the ctor. This change also captures the sequence mode boolean test parameter as a protected member, including related test cleanup to use that member instead of a local boolean or local GetParam() check. Three previous TEST_F (that did not need an append mode variation) are now TEST_P using the new FrameProcessorTestParams instantiations to keep this change simpler. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9210900a29382bded23e3701b39af733864fceb2 Reviewed-on: https://chromium-review.googlesource.com/663765Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501483}
 - 
Jaebaek Seo authored
This is a reland of 030794ca with deviceScaleFactor obtained from global device to avoid MSAN problem. Original change's description: > Scale heights of BrowserControls in compositor by DSF > > Bug: 737777 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I711e05e8747850041f2c799d3b482da34e7e520d > Reviewed-on: https://chromium-review.googlesource.com/645906 > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500841} Bug: 737777 Change-Id: I6a27221ce5baac8573e0f074895a657eaf21183f Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/662500Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501482}
 - 
Doug Turner authored
Bug: 703369 Change-Id: Ifab324cf226c59881214be0d2d7c5c22ba1d0066 Reviewed-on: https://chromium-review.googlesource.com/659257 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#501481}
 - 
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: I119a6edf80a0de750d0b7ee61e3b748321dd20dc Reviewed-on: https://chromium-review.googlesource.com/618301 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501480}
 - 
ericwilligers authored
CSS Grid Layout shipped to stable in Chrome 57. The runtime flag is no longer needed. BUG=79180 Change-Id: Ia57d36d660d79d33fd9bc50eabb80f7f21d413fe Reviewed-on: https://chromium-review.googlesource.com/659638Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#501479}
 - 
tzik authored
This is to fix a potential unit test failure on VideoTrackRecorderTest.ReleasesFrame. The test spins a RunLoop until the VideoFrame instance is gone. And it needs to spin until OnFrameEncodeCompleted invocation to pass the test. Note: the test does not fail if EncodeOnEncodingTaskRunner is scheduled using base::Bind, as its implementation keeps an reference until the resulting base::Callback is gone. After it migrates to base::BindOnce, the bound VideoFrame reference will be passed by move, and the given VideoFrame reference can be the last reference. Change-Id: I0d28e29cd2e1d19fb7b9d2df617c71c04738c511 Reviewed-on: https://chromium-review.googlesource.com/646346Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#501478}
 - 
Matt Wolenetz authored
Parameterizes all ChunkDemuxerTests by which version of the buffering API is being tested; the test ctor forces on/off the media::kMseBufferByPts feature accordingly. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I28118da3a57b8f0156d8b399314333b2195d6e6b Reviewed-on: https://chromium-review.googlesource.com/663785Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501477}
 - 
kapishnikov authored
Before SDCH was removed, CronetPrefsManager couldn’t be destroyed before CronetUrlRequestContextAdapter because the adapter owned SdchOwner that owned SdchOwnerPrefsStrorage that had a weak reference to JsonPrefStore. JsonPrefStore is owned by CronetPrefsManager. Thus, deleting CronetPrefsManager left SdchOwnerPrefsStrorage with a dangling reference to JsonPrefStore. At the same time, we couldn’t destroy CronetUrlRequestContextAdapter first, because transitively it owned HostCache, that was needed by HostCachePersistenceManager. HostCachePersistenceManager is owned by CronetPrefsManager. Thus, deleting CronetUrlRequestContextAdapter before destroying CronetPrefsManager left HostCachePersistenceManager with a dangling reference to HostCache. To break that loop, the HostCachePersistenceManager was destroyed in CronetPrefsManager::PrepareForShutdown() method before destroying the CronetUrlRequestContextAdapter instance. After removing SDCH, we can simply destroy CronetPrefsManager before destroying the context. Testing: Ran ASAN version of Cronet tests twice with WiFi on and off to check different paths inside NetworkQualityEstimator. BUG=758711 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia13e5bc6db5f03158798e261ba778c1ef403d47a Reviewed-on: https://chromium-review.googlesource.com/664257Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#501476}
 - 
tzik authored
Before this CL, the FROM_HERE macro directly called GetProgramCounter() and passed the value to the Location constructor. However, that costs a few bytes for each FROM_HERE invocation. This CL moves the program counter calculation into a static constructor of Location for smaller binary size. This reduces the stripped binary size on x86_64 Linux by 36864 bytes. Change-Id: Ic49550abb4bf1e4e29756c7fc876ddfd85b5d3b2 Reviewed-on: https://chromium-review.googlesource.com/662086 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501475}
 - 
Jinsuk Kim authored
In ViewAndroid tree, the top view for WebContents should be of normal layout that can adjust its size to the OnSizeChanged event, while the bottom one for RenderWidgetHostViewAndroid should be of type match-parent to keep its size always in sync with its parent. This CL takes care of that. BUG=622847 Change-Id: Ie928a68334fc8c7342643081d85cdb88da075bb4 Reviewed-on: https://chromium-review.googlesource.com/654397 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501474}
 - 
Robert Liao authored
BUG=764528 Change-Id: Ice17f0371c5bbacfe4a332cd7d274b76dba18a4c Reviewed-on: https://chromium-review.googlesource.com/663889Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501473}
 - 
Qiang Xu authored
Test=emulator tests and ash_unittests WindowManagerTest.UpdateCursorVisibilityOnKeyEvent Bug: 463005 Change-Id: Iab920ba04163e75069d8cdc93e4294d9435b276c Reviewed-on: https://chromium-review.googlesource.com/659101Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#501472}
 - 
Xianzhu Wang authored
Check for null BottomNonEmptySection even if TopNonEmptySection is not null because of crbug.com/764525. Bug: 764284 Change-Id: I4d45cbd3432722a8958ba647767d97b782c10512 Reviewed-on: https://chromium-review.googlesource.com/664303Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501471}
 - 
Yoland Yan authored
This CL converts misc instrumentation tests to JUnit4. For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: I8ea44992b48709550855459b9ff4f20bb3eec15a Reviewed-on: https://chromium-review.googlesource.com/627672 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501470}
 - 
Anthony Zhang authored
Ref CL: cl/168305759 Bug: 63094198 Test: manual Change-Id: I5fe57a038d8c3b93eee122ef72ed01285c7e3900 Reviewed-on: https://chromium-review.googlesource.com/663884Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Anthony Zhang <antz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501469}
 - 
Yafei Duan authored
Implementing CreateArchiveTask, which is a task for starting the archive creation but will not wait for the completion of the process, in order to support multiple archivers working in parallel. The creator of the task has to provide a CreateArchiveTaskCallback, which will be processing the arguments and decide whether the creation is successful, so that it can create AddPageTask for next steps. Also duplicating most of the tests related with archive creation from the OfflinePageModelImpl unit tests. Bug: 753595 Change-Id: I915daab56a260ccaa9c028c0ea95c2ff0646d461 Reviewed-on: https://chromium-review.googlesource.com/634084 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#501468}
 - 
Tommy C. Li authored
Addresses some nits, but primarily fixes the SearchSuggestionParser match classification logic. Previously the match_start was incorrectly calculated using the cleaned-up formatted URL instead of the original URL, which we need to correctly flag which components the matches are in. Bug: 761505 Change-Id: Ifae972c79e16387c8a9b8c49811a035c1fb017f1 Reviewed-on: https://chromium-review.googlesource.com/663848 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501467}
 - 
Jared Saul authored
Bug: 754774 Change-Id: I7faf88c6d8ce2f734fdb6c39793a72628b73fa06 Reviewed-on: https://chromium-review.googlesource.com/658484Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#501466}
 - 
Etienne Bergeron authored
The outputted size is not the size of each allocation, but the sum of every allocation for a given stackframe. R=erikchen@chromium.org Bug: 753514 Change-Id: I1840f89d06a63e5f30af66da080ef7ea91d1715a Reviewed-on: https://chromium-review.googlesource.com/664250Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501465}
 - 
Daniel Cheng authored
Change-Id: I537ef4d26f75e57bc5868912746141cb9cc14ff7 Reviewed-on: https://chromium-review.googlesource.com/663674Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501464}
 - 
Klaus Weidner authored
According to Qualcomm the unexpected blocking issue likely affects "all A4x (or newer) chips", though the specific effect only seems to be noticeable for WebVR on Daydream-ready devices which are currently limited to Adreno 530 and 540. BUG=750306,764526 R=kbr Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifb95ed9a59f58fb7b4a3c91e3745f5def6b51d21 Reviewed-on: https://chromium-review.googlesource.com/662903Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501463}
 
 - 
 - 12 Sep, 2017 7 commits
 - 
- 
Sean Topping authored
This reverts exposing the browser target unconditionally; the proper solution is to retrieve the secure browser target URL from /json/version server endpoint. Bug: internal b/65209777 Change-Id: I0b77c7bb39a06cc19fc6fac68f341aded8cdd154 Reviewed-on: https://chromium-review.googlesource.com/663892Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#501462}
 - 
Sergey Ulanov authored
These tests pass after https://crrev.com/501346 Bug: 731302 Change-Id: I4c6639e59f4270933aaf66a9a25ffac8beb3761f Reviewed-on: https://chromium-review.googlesource.com/662922 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501461}
 - 
Hongchan Choi authored
The test has been flaky and we could not reproduce the time-out locally. To suppress the warning/error, we should disable the test until we figure out the solution. Bug: 763550 Change-Id: Ia89f569e372d0ee94860f2a1c0ace7d44cd5eb6f Reviewed-on: https://chromium-review.googlesource.com/664302Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501460}
 - 
erikchen authored
Adding myself, brettw@ and ajwong@. Bug: Change-Id: I6192ff1b4eefdf400b640e6ea7c61f8c297726a2 Reviewed-on: https://chromium-review.googlesource.com/661380Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501459}
 - 
Luke Sorenson authored
Using an explicit error enum is preferrable to checking runtime.LastError. Bug: 762147 Change-Id: I764269b18da6578c07bb3c7eb6e0be79b2f6c798 Test: Deployed local Chrome and verified ServiceError enums occur at the correct times. Reviewed-on: https://chromium-review.googlesource.com/651209 Commit-Queue: Luke Sorenson <lasoren@google.com> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501458}
 - 
Kent Tamura authored
Add move() function. Split the command to two steps. - move_blink_source.py update It updates file contents. - move_blink_source.py move It moves files in third_party/WebKit/. This separation would prevent git from misdetecting file moves Bug: 578345 Change-Id: Ie53668a3f1d75db92737097795e7a89690a10cad Reviewed-on: https://chromium-review.googlesource.com/662078 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501457}
 - 
Matt Mueller authored
Now including a hack to handle certificate dates outside the range that base::Time::FromUTCExploded can handle on 32-bit linux. (Previously those dates would be imploded with NSPR, which always uses 64bit time values.) Bug: 671420 Change-Id: I3c633b6f2f434bbb356b83bbc99cf8c8b8a08ff8 Reviewed-on: https://chromium-review.googlesource.com/658326 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#501456}
 
 -