- 23 Nov, 2017 11 commits
-
-
Scott Graham authored
Bug: 788007 Change-Id: I86de75ca303b66227db170021bdfd7fb50a61811 Reviewed-on: https://chromium-review.googlesource.com/786175 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#518820}
-
Peter Kotwicz authored
This CL removes unnecessary writing and reading from saved instance state. The EXTRA_COMING_FROM_CHROME_ICON extra is in the launch intent and is available even when the activity is launched from Android Recents after Chrome is killed by the OS. BUG=None Change-Id: I8ff88999c79fa51365b039b02be454d77cf3f168 Reviewed-on: https://chromium-review.googlesource.com/784593Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#518819}
-
Miguel Casas authored
This CL solves a problem in Skylake and older bots with the video encode accelerator unittests: VaSupportedProfiles is now a singleton that is never destroyed, preventing it from calling VADisplayState's Deinitialize(), thus leaving a dangling ref to VADisplayState, preventing it from cleaning itself up. Note that this is not truly a problem per se, and many bots are happy. This CL addresses the problem by calling the said Deinitialize() at the end of the construction sequence, when we don't need to use VADisplay::Get() anymore. Bug: 786457 TEST= Compiled, copied/deployed chrome, VEA and VDA unittests in _both caroline and soraka_: - Chrome launches OK; chrome://gpu enumerates supported accelerated profiles OK, playback of video in crosvideo.appspot.com is done using GpuVideoDecoder (as seen in chrome://media-internals). Chose a VP8 dash. - Unittests run: /tmp/video_encode_accelerator_unittest --test_stream_data=".//bear_320x192_40frames.yuv:320:192:1:./bear_320x192_40frames.yuv.out:200000" This is the one failing on the bots, this CL corrects it. /tmp/video_decode_accelerator_unittest --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I488b0d959ac57063324965fbdd5f4e01b9940750 Reviewed-on: https://chromium-review.googlesource.com/786111Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#518818}
-
Kenneth Russell authored
There are now machines in the Chrome-GPU pool on which these jobs should be spawned. Correct the experimental NVIDIA Mac bot's configuration even though it isn't actually Swarmed yet. BUG=786170 TBR=dpranke@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b7950349b173c36a624a468d7ab77b2532a6167 Reviewed-on: https://chromium-review.googlesource.com/786437Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518817}
-
Nicholas Verne authored
ChildProcessHostMsg_HasGpuProcess and ChildProcessHostMsg_SetThreadPriority now live in RenderMessageFilter. Bug: 775817 Change-Id: Idf9dd6dbb8d65b304aaff68d0dc22901ced19968 Reviewed-on: https://chromium-review.googlesource.com/778203 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#518816}
-
Xi Han authored
When WebAPKs target sdk 26, notifications are broken due to there being no channel set for a WebAPK notification. This CL fixes this issue in the shell APK by creating a WebAPK's default channel "General" and rewriting the channel id to this channel when displaying a notification. Bug: 700228 Change-Id: I6cde7387e5eec090406fb6522c1efc85ca979d5b Reviewed-on: https://chromium-review.googlesource.com/776162 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#518815}
-
Xiaocheng Hu authored
Bug: 766448 Change-Id: I38169a93624b85c7efe033913e92f53791345d50 Reviewed-on: https://chromium-review.googlesource.com/786633Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#518814}
-
dpapad authored
Also add bottom padding for the entire page. Bug: 787229,787195 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70ec65807a43627db213f0cc698e756ce28dbdc0 Reviewed-on: https://chromium-review.googlesource.com/786146Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#518813}
-
Mike Baxley authored
This has been running on the flaky bots, after upgrading to more reliable test APIs. I spot checked 50+ runs, and saw no failures. Bug: 631078 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8353ec8ad23a761f82fc30f0dcbf24fa190a4c3f Reviewed-on: https://chromium-review.googlesource.com/782717Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#518812}
-
Florin Malita authored
Pass sk_sp<SkTypeface> around, instead of raw SkTypeface*, to make the typeface ownership less ambiguous. BUG=skia:5077 TBR= Change-Id: I3d98c3eba95469eb1392a3c9a8f84da6679e6d9a Reviewed-on: https://chromium-review.googlesource.com/786290Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#518811}
-
Alexey Kozyatinskiy authored
Debugger.getPossibleBreakpoints can returns breakable locations only in current function. We can pass functionLocation as start position and fallback to current position if functionLocation is not available (should never happens). R=dgozman@chromium.org Bug: chromium:778796 Change-Id: I40bc1a3a1a9c8465e952bb5cdcd97e0d7dc4d1be Reviewed-on: https://chromium-review.googlesource.com/786543Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518810}
-
- 22 Nov, 2017 29 commits
-
-
danakj authored
If GL image textures are supported, and we can find the image texture target for the desired format, then use TexStorage2DImageCHROMIUM to allocate the texture so that it may be used for scanout. From the original patch this fixes layout tests which were trying to use overlays but can't. Now this asks the RenderThreadImpl if Gpu memory buffers should be used at all before trying to use the map to determine targets. Also noticed that we are not resetting the composited_output_modified_ bool for damage in the gpu texture upload path, which means we'll submit more frames than we used to without purpose. So resetting that bool to false now on the gpu compositing path. R=ccameron TBR=piman@chromium.org Bug: 786140 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1ad318f45143f8587f5f99775afbe23a0a9eafc4 Reviewed-on: https://chromium-review.googlesource.com/783851 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518809}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/5a654f5ff30f..c7b0cf2a28f7 $ git log 5a654f5ff..c7b0cf2a2 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 jmadill D3D11: Remove "fast path" check in DrawElements. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I857c230fb873f32386d561fd6acf60a5545c294f Reviewed-on: https://chromium-review.googlesource.com/786321Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518808}
-
Tom Anderson authored
TBR=dpranke@chromium.org Change-Id: I3a6c2f49e4c1515daef133ed83c7304017b1c3f0 Reviewed-on: https://chromium-review.googlesource.com/786277Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#518807}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d9d9233cb65..00fc72856bb0 $ git log 7d9d9233c..00fc72856 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 myjang [presubmit] Rename to CheckChangedLUCIConfigs 2017-11-22 myjang [presubmit] Extend depot tools auth to use luci context Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I76d54141806eacf10f44842661a9c55326e469f2 Reviewed-on: https://chromium-review.googlesource.com/786512Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518806}
-
Steve Kobes authored
Compared to generic baselines (patchset 3), the RLS baselines reflect the presence of scrolling layers for top-level documents. For composited iframes, PaintLayerCompositor's scrolling layers are gone, replaced by: - CompositedLayerMapping's scrolling layers, if the iframe is user-scrollable - "Child Containment Layer", if no overflow or user scrolls are disabled See comments on attached bug regarding treatment of RTL overflow and the decision not to create scrolling layers when user scrolls are disabled. Bug: 784053 Change-Id: I100a2e0ecad5b2599522f0472c603d51d20c6252 Reviewed-on: https://chromium-review.googlesource.com/786310Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#518805}
-
Eugene But authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib3512e0aa97580b72e48ca3f29d7ed0212a5e9fe Reviewed-on: https://chromium-review.googlesource.com/786313 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#518804}
-
Christopher Grant authored
This change adds more of the tree necessary to show the omnibox and suggestions, but does not enable anything. Element sizes and positions are not yet correct. BUG=777542 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia0450e7218fb4c58a4ced0cbbfe86f9d94913a2c Reviewed-on: https://chromium-review.googlesource.com/786301Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#518803}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a27e55e1c8c0..a1c4205eff6c $ git log a27e55e1c..a1c4205ef --date=short --no-merges --format='%ad %ae %s' 2017-11-22 thestig Call FreeLibrary() in CGdiplusExt. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic8f782d15ab4e569bdbe90e00558f82a3a3dad0b Reviewed-on: https://chromium-review.googlesource.com/786514 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518802}
-
Lei Zhang authored
autofill, history, and invalidation sub-directories. TBR=nyquist@chromium.org Change-Id: I57da5afb90bc42904d3f5e629816d1962b1c4087 Reviewed-on: https://chromium-review.googlesource.com/776021Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#518801}
-
Nathan Bruer authored
To get better mime-types we now intercept response info for overrides at the response stage. R=pfeldman BUG=760316 Change-Id: I6f0367ef2789d210c51dc1c39130e4a72106b05b Reviewed-on: https://chromium-review.googlesource.com/780922 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#518800}
-
David Bokan authored
MotionEventSynthesizer currently doesn't set the index of the pointer being changed by ACTION_POINTER_DOWN or ACTION_POINTER_UP which means it's interpreted as being the 0th pointer. This is wrong since these actions happen for the 1st pointer. This was causing DCHECKs to fire when gpuBenchmarking.pinchBy is used. This patch correctly sets the pointer index in the action bitfield. Tests that would have caught this (and surfaced it in the first place) are included in these patches: crrev.com/c/783823 crrev.com/c/784213 Bug: 610021 Change-Id: I0bebffaf1db4076c66c5009f5bf6f2b6e06f6939 TBR: yfriedman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/786331Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518799}
-
Tibor Goldschwendt authored
Bug: 706150 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3d4fd8eed952d0a22667d39de4e3186e0cb4db27 Reviewed-on: https://chromium-review.googlesource.com/782407Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518798}
-
Philip Jägenstedt authored
We're not actually running these tests, so like external/wpt/resources/webidl2/test there's not much reason to import them, and the risk of confusion if we do. Unskip README.md as it's harmless or potentially useful, however. This will take effect at the next import. No-Try: true Change-Id: I92a693417736fa605feedd88d33d094ead3e515c Reviewed-on: https://chromium-review.googlesource.com/786032 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#518797}
-
danakj authored
TextureMailbox has a lot of fields which were not used. Just pass a Mailbox and SyncToken on CopyOutputRequest. The target is removed from OwnedMailbox and the assumption that it is GL_TEXTURE_2D is documented in the CopyOutputRequest header. R=dcheng@chromium.org, enne@chromium.org, miu@chromium.org TBR=sadrul Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2266b936c6d6b5810c893df3e6b66f7e880fdc7d Reviewed-on: https://chromium-review.googlesource.com/786339Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#518796}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3bc0f66e..b759ad89 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4037520e5f24e93b7eb1b7f103bf2fb79bfca370 Reviewed-on: https://chromium-review.googlesource.com/786346Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518795}
-
Dominic Mazzoni authored
We store accessible bounding boxes as relative coordinates, and normally each element takes its parent's border and padding into account when exposing its own top/left coordinate. This doesn't work for the root document node inside an iframe, because it can't know the owning iframe element's border and padding, so we need a special case for that. Bug: 740312 Change-Id: I4c7d7f435eff9c69afa889d666bd09a2dc5716ae Reviewed-on: https://chromium-review.googlesource.com/775024Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#518794}
-
Xiaocheng Hu authored
This is a reland of 12aa0c66 Original change's description: > Final preparation for adding DCHECK(CanUseInlineBox) in ComputeInlineBoxPosition() > > This patch further refactors ComputeInlineBoxPositionForAtomicInline(), > so that it is now straightforward to add DCHECK(CanUseInlineBox) into > the code to trach usage of legacy inline boxes. > > Bug: 771398 > Change-Id: I3a3e839ebbc489cd2fa251259fe94921bf25de15 > Reviewed-on: https://chromium-review.googlesource.com/780365 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518123} Tbr: yosin@chromium.org, yoichio@chromium.org, kojii@chromium.org Bug: 771398 Change-Id: I997d6718d4eb0d88f02e667215fc4299448040b3 Reviewed-on: https://chromium-review.googlesource.com/785971 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#518793}
-
Eugene Ostroukhov authored
Bug: 783439 Change-Id: Id6a3ed5bed787ef498f175a93b69ea39182055d6 TBR: mmenke (trivial change to devtools server) Reviewed-on: https://chromium-review.googlesource.com/777475 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
-
Robert Ma authored
And use a new dedicated issue for them. TBR=eroman@chromium.org Bug: 757698, 787971 Change-Id: If51835eb88cf12ba2a16fe655aa2b54d2df97f2e Reviewed-on: https://chromium-review.googlesource.com/786261Reviewed-by:
-
CJ DiMeglio authored
This CL fulfills two TODO's that required access to LayerTreeSettings in VideoFrameResourceProvider. Previously we were just using dummy values for prototyping, but this CL grabs the true values. Bug: 746182 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7d4c1b4c8acdb2f99785dac2d2b2c3198169e3c0 Reviewed-on: https://chromium-review.googlesource.com/784355Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
One of the tests changed by this CL was flaky (CertificateReportingServiceBrowserTest. DontSendOldReports). This is now fixed, so relanding the CL. Original CL: https://codereview.chromium.org/2862453002 When sending certificate reports, we suspect that some content filters, firewalls and captive portals delay the response indefinitely without sending back any response. Certificate uploads rely on a response to be received in order to decide whether to retry uploading the report, so this breaks those assumptions. This CL adds a histogram to understand how often this happens. In particular, a difference between submitted reports and the sum of failed and successful reports will indicate that some reports simply get lost. The histogram also provides insight about how often queued reports are dropped, which will help us fine tune the queue size and report time-to-live. A question that came up while discussing this histogram was whether it would be useful since UMA uploads can also be blocked in a similar way. The answer seems to be yes, as UMA retries metrics uploads with a different frequency, and it persists metrics uploads whereas cert reports are not persisted. Bug: 682933 Change-Id: I09616eaf04854157ddeff8d20d39e18afc705967 Reviewed-on: https://chromium-review.googlesource.com/782642 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#518789}
-
David Dorwin authored
The uppercase styling should be applied in code and not depend on the actual strings. Leave the "EXIT VR" string unchanged for now. Bug: 787654 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If265f4f6a6584f95bd0f6cdb39f26632875967a4 Reviewed-on: https://chromium-review.googlesource.com/780692Reviewed-by:
-
Bence Béky authored
Currently, AppendToHeaderBlock() joins values for duplicate header names with a \0 character, which is incorrect for cookies. What makes this especially bad is that HpackEncoder only splits a header value at \0 characters if the header name is not "cookie", so such incorrect header blocks are encoded with a \0 character on the wire, which is against the specification. In particular, if I fix HeaderCoalescer to signal an error on a \0 character in a header value, then SpdyNetworkTransactionTest.ResponseHeaders fails because of this. Instead, this CL makes AppendToHeaderBlock() defer to SpdyHeaderBlock's built-in header name joining mechanism, which does the right thing. Also update SpdyNetworkTransactionTest.ResponseHeaders to reflect this behavior, and clean it up a bit. Bug: 787581 Change-Id: I58f8b8b72992c06bb5b365347f1eae75da6dd97b Reviewed-on: https://chromium-review.googlesource.com/786335Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#518787}
-
Tom Anderson authored
Also, use 128x128 icons to fix bug 625711. BUG=625711,773489 R=thestig@chromium.org Change-Id: Ifbe99e82bf29a0838b9322db3c6a3d27bc2b5ed9 Reviewed-on: https://chromium-review.googlesource.com/786531 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
khmel authored
This prevents ARC allowed check result is changed during the user session. This case usually leads to crash that hard to detect. Bug: b/69629934 Test: Manually + unit tests Change-Id: I8e7424f84997721ffefcef01619d60220b39afa3 Reviewed-on: https://chromium-review.googlesource.com/784211 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#518785}
-
Renjie Liu authored
original owner: amoylan@chromium.org original cl: https://chromium-review.googlesource.com/c/chromium/src/+/754153 This CL is part of the implementation of public-IP-only geolocation as described in the design doc: https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs This part is an implementation of the mojom::Geolocation interface that is separate from the existing web-platform implementation of that interface (which lives in //device/geolocation currently). This implementation uses the PublicIpAddressLocationNotifier (upstream dependent CL) to provide IP-only geolocation. Tested: Basic unit tests added. Bug: 718694, 769158 Change-Id: I716b52d8ea21cb8ad4f94b128fddc0c0cef967a3 Reviewed-on: https://chromium-review.googlesource.com/770306 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#518784}
-
Eugene But authored
WKHTTPCookieStore crashes if used on a background thread. Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7c300eb26aca984f50e336b4b34fda2050a0bea5 Reviewed-on: https://chromium-review.googlesource.com/786542Reviewed-by:
-
Jamie Walch authored
Note that this is not something we want enabled on all platforms due to bug 492414 but I plan on pushing this to dogfood to unblock Rodete users currently affected by missing modifier keyup events. Bug: 787523 Change-Id: Ice97bd74eb293298d36fc52ef32fa37f2e272904 Reviewed-on: https://chromium-review.googlesource.com/786391 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#518782}
-
Lucas Furukawa Gadani authored
Bug: 787512 Change-Id: Ib04d450fbb6d6f8ba389e378df8c4d5d8b643965 Reviewed-on: https://chromium-review.googlesource.com/782140 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#518781}
-
