- 10 Aug, 2018 40 commits
-
-
Kevin McNee authored
The associated bug which required this extra tab is fixed. Bug: 147644 Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343 Reviewed-on: https://chromium-review.googlesource.com/1170986Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582240}
-
Sam Maier authored
Change-Id: I6e3603ad89eca72a3cdd481dfb1667105b6ef0ed Reviewed-on: https://chromium-review.googlesource.com/1169128Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582239}
-
Christopher Cameron authored
Move the interfaces FocusChangeListener and InputMethodDelegate from being implemented by BridgedNativeWidget to being implemented in BridgedNativeWidgetHostImpl. This has the effect of moving them from the app shim process to the browser process. This is in preparaton for removing access to TextInputClient from BridgedContentView (that operation is delicate). Add a temporary method on BridgedNativeWidget to set the TextInputClient for BridgedContentView from BridgedNativeWidgetHostImpl (where we now receive the OnDidChangeFocus notification). Bug: 859152 Change-Id: I1f5639448cc9f7b4b00058444ab64914b9193df3 Reviewed-on: https://chromium-review.googlesource.com/1170582Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#582238}
-
chrome://flagsJan Krcal authored
Bug: 853688 Change-Id: I4069581ed4eea46c04351593a595102783bac438 Reviewed-on: https://chromium-review.googlesource.com/1169479 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582237}
-
Charlie Andrews authored
It looks like this file has * listed as its owner, so it doesn't need any specific owner review. Bug: 859514 Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: I9afd700a6a36f00b5fb46847fbc5d01d08646db8 Reviewed-on: https://chromium-review.googlesource.com/1169437 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582236}
-
Evan Stade authored
Bug: none Change-Id: I3aadd1d6c94c27dd9bdf2648ea241412d5a71078 Reviewed-on: https://chromium-review.googlesource.com/1167954 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582235}
-
Becca Hughes authored
The sound setting is only applied at a WebContents level so we should make sure it is registered with TOP_LEVEL_ORIGIN_ONLY_SCOPE. BUG=865548 Change-Id: Ia0e02f2201665b14a59e8c38b8dcfcde8e99ed67 Reviewed-on: https://chromium-review.googlesource.com/1169522 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582234}
-
Etienne Pierre-doray authored
Creates Disassembler that recognises and parses ELF format. For now, it only supports Intel architeture. Support for Arm will be added in follow-up CLs. Change-Id: Ibdcf113b573f22844b6a1611c5ff6df46829b9b3 Reviewed-on: https://chromium-review.googlesource.com/1136841 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582233}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c97933fb82f8..f5f537337258 git log c97933fb82f8..f5f537337258 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 nisse@webrtc.org Delete unused member MediaSenderInfo::packets_cached. 2018-08-10 phoglund@webrtc.org Temporarily skip linux_internal on autoroller tryjobs. Created with: gclient setdep -r src/third_party/webrtc@f5f537337258 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I401e8192beca5bd0160859d037944014dcfad7bf Reviewed-on: https://chromium-review.googlesource.com/1169706Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582232}
-
Adam Langley authored
This change aligns Chromium with the current state of the spec[1]: the “appid” extension output will only be returned when the caller requested the appid extension, and it'll be true iff the AppID value was actually used when getting the assertion. [1] https://w3c.github.io/webauthn/#sctn-appid-extension BUG=853770 Change-Id: I6ac9470c71bfc0cc3b38f6e91c5e8f00b0586405 Reviewed-on: https://chromium-review.googlesource.com/1162823Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582231}
-
Toni Barzic authored
Update CrOSComponentManager to handle the case when an installed compatible component is found during component registration started by CrOSComponentManager::Load. Previously, CrOSComponentManager would start OnDemandUpdate whenever no compatible component path was registered when Load() was called - this did not account for cases where Load was called early on, before registration of installed components finished. This means that CrOSComponentManager could end up starting foreground on demand update even if a compatible version of component was already installed. This CL moves decision whether an update should be requested later on - after the component registration was done. Update will be run if it's forced, or if there is no compatible component version after component registration finishes (which should check for any installed components). Note - this also moves ComponentInstaller::Register callback after OnComponentReady is called, to ensure that any potential compatible component path is registered before CrOSComponentManager::StartInstall is called. (This is more in line with order OnComponentReady and the callback are invoked during Install request, and no other callers seem to depend on this ordering). BUG=872871 Change-Id: I33ff01b5d127d17cd9016b012fc400562c03d9c1 Reviewed-on: https://chromium-review.googlesource.com/1170172Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582230}
-
Sujie Zhu authored
Since we only offer local cards migration to signed-in and synced user, we have to get the syncStatus in the payments_section in order to check the migration requirements in the payments_section.js. We use the similar code from the people_page.js to add the syncStatus property from SyncBrowserProxy in the payments_section. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Change-Id: I9786fd491780a6daf71d19da94da4b048ad59ed2 Reviewed-on: https://chromium-review.googlesource.com/1168386Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582229}
-
Elly Fong-Jones authored
TBR=pkasting@chromium.org Bug: 872705 Change-Id: I72edb9f5b1d07baf898fe8aa97231df5d76424a4 Reviewed-on: https://chromium-review.googlesource.com/1171106Reviewed-by:
-
Fabio Tirelo authored
The current CVC placeholder string is translated to the full form in some languages and doesn't look well on the card unmask dialog (for example, it looks like "Crypto..." in French). This adds a restraint to the number of characters it should be translated to and add a "meaning" tag to ensure the translation is not shared with other properties. Bug: 873158 Change-Id: I1ffd5154ef94705efe86dae842fbf913b09b6a36 Reviewed-on: https://chromium-review.googlesource.com/1170586 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582227}
-
James Cook authored
The serialized AX node locations need to be adjusted by the display device scale factor. This is similar to how AXTreeSourceArc handles remote ARC++ apps. Bug: 851578 Test: added to views_mus_unittests Change-Id: Ibf17c76584e1ec54e5b214866a7cd1abbcc88f7f Reviewed-on: https://chromium-review.googlesource.com/1168120 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582226}
-
Anna Malova authored
Bug: 873098 Change-Id: Ifafc4edec8ddae8da621908f69fdf3a39e9e8f8a Reviewed-on: https://chromium-review.googlesource.com/1170698 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582225}
-
Alexander Hendrich authored
This CL adds detailed warning/errors messages from the ONC value validation to chrome://policy. Bug: 855057 Change-Id: I6d6bca90d074bc6b5c6be3b416fe25f216b5b7cb Reviewed-on: https://chromium-review.googlesource.com/1118555Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582224}
-
Lukasz Anforowicz authored
After this CL site-per-process is the default in all layers on desktop platforms, except: - Layout Tests which still run with no isolation by default (see https://crbug.com/856734#c5 for the explanation why) - //content embedders that don't want to use site-per-process: //chromecast - //content embedders that don't yet support site-per-process, but will need to migrate eventually: //headless Also note that even after this CL: - //content on Android still defaults to no isolation. This is compatible with not_site_per_process_* test steps because such steps are not run on Android bots... - //chrome layer ChromeContentBrowserClient controls usage of site-per-process in the Chrome browser and continues to be controlled by a field trial (note that Android is not covered by the field trial or by testing/variations/fieldtrial_testing_config.json). Bug: 856734 Change-Id: Iebd46e5502583f84a4b0a7c2ee8d8b0e081c6ff2 Reviewed-on: https://chromium-review.googlesource.com/1153981 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582223}
-
Morten Stenshorne authored
LayoutInline::LinesVisualOverflowBoundingBox() is expected to return coordinates with a logical block coordinate. So we need to flip for writing-mode vertical-rl. Discovered while investigating why wpt/css/css-position/position-sticky-writing-modes.html fails. It had some weird repaint issues (that I discovered when picking the test apart) that this CL fixes. That's not enough to fix the test, though. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9a8930cc6de01991592282491677327e3406acfb Reviewed-on: https://chromium-review.googlesource.com/1170835Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582222}
-
Alexander Hendrich authored
This CL replaces all occurrences of base::RunLoop().RunUntilIdle() in UserCloudPolicyStoreChromeOSTest with run_loop.Run() and an associated Quit() call from the expected callback. Bug: none Test: unit_tests Change-Id: I9f8ec70381c44bb034cc19e0622b3b7cb090539a Reviewed-on: https://chromium-review.googlesource.com/1160239 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Robert Ogden authored
This adds the basic triggering logic to the Previews Navigation Throttle (not including loadshedding or bypassing which will come in the next CL). Also creates a NavigationThrottleManager interface to decouple the Nav Throttle from the decider. The decider will keep all the state for the Nav Throttle since the throttle's lifetime is so short. Most of the triggering testing is done in browser tests for sake of clarity and complexity. Bug: 864651 Change-Id: I1d1772c25ddfa159051bd5b1064c53256ced39f3 Reviewed-on: https://chromium-review.googlesource.com/1152164 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582220}
-
Matthew Cary authored
This is enabled with --system-health-orderfile. Other than taking much longer to run the profiling, and producing a much more effective orderfile, the orderfile generator is run in the same way and produces the same output. Bug: 758566 Change-Id: I66c3aa28c9499179f86644ee8e64c9a6c63bad54 Reviewed-on: https://chromium-review.googlesource.com/1159066 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582219}
-
Mustafa Emre Acer authored
This CL expands the navigation suggestion feature by looking for potential suggestions in the engaged sites list using the site engagement service. The match is still done by computing ICU skeletons of the hostnames. The skeletons are calculated from the eTDL+1 portions of the navigated and engaged sites, so that a navigation to a subdomain of a site looking similar to an engaged site successfully triggers the UI. Design: https://docs.google.com/document/d/1gQCTenYuRnP77nMOo8RpS3SUxCiVewxQ9uQ3fuSefdY/edit?usp=sharing Bug: 847662 Change-Id: I708b8f2503b16da8241145afe2f4aa0d2c001b9c Reviewed-on: https://chromium-review.googlesource.com/1162919 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582218}
-
Miguel Casas-Sanchez authored
OffscreenCanvasResourceProvider is only used for accountancy of viz::{Transferable/Returned}Resource; moreover it's not only used for Offscreen canvases (but also for e.g. lowLatency ones). This CL folds the logic into its only client, CanvasResourceDispatcher. Also, the resource recycling inside OffscreenCRP is removed. This is (all) inspired by junov@'s crrev.com/c/1103011 and follows up on crrev.com/c/1167474. CQ-DEPEND=CL:1169829 Bug: 839970 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifed24992a6aded5c48f5e808cd61986906b64f7a Reviewed-on: https://chromium-review.googlesource.com/1167907 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582217}
-
rajendrant authored
Subsequent CLs will implement the feature. Bug: 846170 Change-Id: Idf8e6352d3c0573a0cf014cc89b2f63251e26607 Reviewed-on: https://chromium-review.googlesource.com/1157143 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Roger McFarlane authored
Bug: 734151 Change-Id: Ia2a04fd5acaae8cfa32bbec102a47d31e4294db1 Reviewed-on: https://chromium-review.googlesource.com/1169422Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582215}
-
A Olsen authored
Using type 'list' seems like a good idea if the policy is indeed a list. However, it is not a good idea if it is a list of objects, and so will need to be parsed as JSON - in that case, 'dict' is a better fit. Added some documentation explaining why. Bug: 872765 Change-Id: I5185f515d7bc82048bfb1eaab5d6d9ae61848eea Reviewed-on: https://chromium-review.googlesource.com/1169469Reviewed-by:
-
Tommy C. Li authored
This is a reland of eb0754126c4ea3ef3aa55b65e607fe8204b6e197 Original change's description: > Omnibox UI: Trivial refactor of redundant logic. > > Bug: NONE > Change-Id: I081af3892dc52f73d7d92aed9b417defa862f8be > Reviewed-on: https://chromium-review.googlesource.com/1168512 > Reviewed-by: Kevin Bailey <krb@chromium.org> TBR=krb@chromium.org Bug: NONE Change-Id: Ie94842ac68a918714e3ddd258ee61b885ec371b5 Reviewed-on: https://chromium-review.googlesource.com/1169930 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582213}
-
Nico Weber authored
Looks like my new bot is only found without this requirement: https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=cores%3A32&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc Bug: 869973,871764 Change-Id: I9f6f6e8bdfb0f62553266ad9eac4a12fcfdedd9f Reviewed-on: https://chromium-review.googlesource.com/1171023Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582212}
-
Kevin Marshall authored
This adds new CIPD package definitions and supporting GN targets for Chrome Fuchsia prebuilts, for inclusion into the Fuchsia build. Adds a Blink override to licenses.py SPECIAL_CASES. Bug: 869197, 729194 Change-Id: Ibe609cd96fef91358e37c2bc440dd10d5c4cac32 Reviewed-on: https://chromium-review.googlesource.com/1155831 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Weidong Guo authored
1. To add an icon shadow without affecting its bounds, create a new image view for the shadow and hide it behind the icon. In this case, dragged icon does not have shadow, UX is fine with this. 2. Add shadow for app title. 3. Change folder bubble color 4. Change app list background shield color. Demo: https://screenshot.googleplex.com/EWBDpOrpUTa Bug: 872012 Change-Id: I8e2f1ab5cb3bd6ac980ebee0b549e0a7c86f96d2 Reviewed-on: https://chromium-review.googlesource.com/1168583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582210}
-
Xi Cheng authored
This change removes the current execution profile _mojo_ representation in favor of directly writing the data in the protocol buffer format used for UMA upload. The reasons for using this format are: 1. it's the format that we ultimately need the data in; 2. it's the most memory-efficient representation available to us, because of the protocol buffer varint encoding; 3. the serialized protocol buffers are trivially compressible. We generate execution profiles in non-browser processes, so this means writing the protocol buffer representation in those processes and sending over mojo to the browser process, where the UMA upload takes place. We're making this change as part of a refactoring to expand the profiling scenarios supported by the UMA Sampling Profiler. A key aspect of this refactoring is reducing memory consumption of the execution profile representation. See http://crbug.com/850148 for examples of memory usage problems with this representation. Bug: 851163, 804942 Change-Id: Ied88d6fd932587707c1f5a4c79acd77d5911f6ee Reviewed-on: https://chromium-review.googlesource.com/1157547 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582209}
-
Alexander Hendrich authored
This CL adds policy value validation to policy validators. For now, we only collect value validation errors/warnings and report them back to the DM server. In the future, the policy value validation can also reject entire policy blobs, if the value validation fails for a single policy. Right now only the values of ONC policies are validated and can generate warnings and errors. Bug: 794848 Test: unit_tests / components_unittests Change-Id: If4569075f698afd49e951794e78d53c0de73eeb2 Reviewed-on: https://chromium-review.googlesource.com/1127164Reviewed-by:
-
Jan Krcal authored
This CL creates the framework for running autofill wallet integration tests on both implementations. Bug: 869526 Change-Id: Ifb44357fa8be5e2e49f099abb53b69c7be1b53d7 Reviewed-on: https://chromium-review.googlesource.com/1170836 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Kevin McNee authored
Currently, when we create a RenderWidgetHostViewAndroid, we attach its corresponding native view to the hierarchy. However, RWHVAs may be created for a speculative RenderFrameHost for a cross-site navigation, and would not replace the old RWHVA until the navigation commits. This gives us two RWHVAs in the hierarchy. In this state, input events are targeted to the speculative RWHVA. Moreover, if the cross-site navigation is canceled before it commits, then we stay in this state where input events are sent to the unused RWHVA, causing the page to be seemingly unresponsive to input. We now move new RWHVAs behind any existing ones in the view hierarchy. Bug: 867932 Change-Id: I845d99ecbde7f721f6fa4b6e1b0243abb89a97fc Reviewed-on: https://chromium-review.googlesource.com/1165482Reviewed-by:
-
Tessa Nijssen authored
When the text surrounding the current selection gets too long, only part of it is received by TextSuggestionsTouchBarController. The location of the received text within the total block of text is denoted by an offset. Previously, TextSuggestionsTouchBarController did not take this offset into account, causing crashes when the selection range was past the end of the received text. The offset is passed along with the text and selection range. The selection range within the received text is calculated using the offset and received selection range. The editing word range is stored both as the range within the received text and the range within the total text for checking when to ignore text selection updates. RenderWidgetHostView::GetOffsetForSurroundingText() was added to retrieve the offset on WebContents update. Browser tests were modified to account for the new offset parameter. A new browser test, TextSuggestionsTouchBarController.Offset, was added to test that the controller properly handles offsets. Bug: 717553 Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c Reviewed-on: https://chromium-review.googlesource.com/1169597 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582205}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9b6a3f926032..04c084dd3cf4 git log 9b6a3f926032..04c084dd3cf4 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 jmadill@chromium.org Extend MultiviewDrawValidationTest. Created with: gclient setdep -r src/third_party/angle@04c084dd3cf4 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iefd268bdcd058300ae57892d2bfe2058bd6998fc Reviewed-on: https://chromium-review.googlesource.com/1169704Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582204}
-
Antoine Labour authored
SharedImageInterface is a minimal interface to allocate and destroy mailbox resources. It is independent of GL, stateless, thread-safe and expresses direct ownership of the resources. SharedImageInterfaceProxy and SharedImageStub implement SharedImageInterface over IPC. Note: currently SharedImageInterfaceProxy sends an IPC for creating and destroying shared images, but this will be merged into the multi-flush IPC in a follow-up. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f0b86957fab34a1a93f0b2ada8590a048e81724 Reviewed-on: https://chromium-review.googlesource.com/1164168 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#582203}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce9fa204b82d..615ae9b6f35a git log ce9fa204b82d..615ae9b6f35a --date=short --no-merges --format='%ad %ae %s' 2018-08-10 amyqiu@google.com Add tool for visualizing metrics times Created with: gclient setdep -r src/third_party/catapult@615ae9b6f35a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4e00e0ef35c9e5c240f472fb11900156873aafd3 Reviewed-on: https://chromium-review.googlesource.com/1170942Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582202}
-
James Cook authored
This reverts commit 2e6f9474f58ddcd3f72f425d5af6a8dd77cab614. Reason for revert: Relanding now that gerrit outage is over. Original change's description: > Revert "Add shelf owners to //ash/public/cpp/OWNERS" > > This reverts commit e7591612da4c080af86c964d14b25c4061f5b51b. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > Original change's description: > > Add shelf owners to //ash/public/cpp/OWNERS > > > > Bug: none > > Change-Id: Ib1fbca291732828c5b7feeaf853ed84a41970999 > > Reviewed-on: https://chromium-review.googlesource.com/1168646 > > Commit-Queue: James Cook <jamescook@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > TBR=jamescook@chromium.org,msw@chromium.org > > Change-Id: I8b26db1fca95f8ff6b9b01c62911fb904570c50f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1169853 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=jamescook@chromium.org,msw@chromium.org,tandrii@chromium.org Change-Id: I9ea7352dd60261d0dd604854f8cc76686562f1d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1171063 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582201}
-
