GitLab

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/887970.

MSAN use-of-uninitialized-value should be fixed.

Change-Id: I392ad1a83a269b47ff0c8583f6c72e18a4a0e5b9
Reviewed-on: https://chromium-review.googlesource.com/891302
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532669}

Change-Id: I8e9916fdd83b22f998f666f34df56a3d2552094b
Reviewed-on: https://chromium-review.googlesource.com/891809
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532668}

This CL was uploaded by git cl split.

R=qinmin@chromium.org

Bug: 177475
Change-Id: Ia84c9f7e74db4c035d44db9df84c3113474d74b4
Reviewed-on: https://chromium-review.googlesource.com/891901Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532667}

Bug: 807045
Change-Id: I6c834af2f380719959fc5650693f73c87d7a8a36
TBR: skyostil
Reviewed-on: https://chromium-review.googlesource.com/891600Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532666}

Adds code to download the VR Keyboard APK alongside the other VR test
APKs, and modifies the Telemetry benchmarks to install it before a
test.

Bug: 807022
Change-Id: I3c7030bb9b8399e74d136dedc5e8b4e6630d90b1
Reviewed-on: https://chromium-review.googlesource.com/891576Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532665}

This CL was uploaded by git cl split.

R=msw@chromium.org

Bug: 177475
Change-Id: I3aa4567f8f5ffd0b25369015475545918ecf48cd
Reviewed-on: https://chromium-review.googlesource.com/891747Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532664}

Remove dezippering from the frequency and detune attributes. The values
are changed immediately instead of gradually changing from the old
value to the new.

Chromium Feature: https://www.chromestatus.com/features/5287995770929152
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ

Bug: 752987
Test: Oscillator/dezipper.html
Change-Id: I58df869ca99a24f6429c9cc50c1af2101dbdf03d
Reviewed-on: https://chromium-review.googlesource.com/609095
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532663}

I took peak memory usage stats for top3 largest binary link using the same args.gn with linux_chromium_rel_ng.
229MB chrome: 2.22 GB peak memory
260MB browser_tests: 2.56 GB peak memory
258MB unit_tests: 2.57 GB peak memory

So 3GB is sufficient.

This will help to speed up build like below.
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634117
ninja trace: https://chromium-build-stats.appspot.com/ninja_log/2018/01/29/slave645-c4/ninja_log.slave645-c4.chrome-bot.20180129-023145.30339.gz/trace.html
Some newlib_pnacl related binary prevent mksnapshot to be linked due to small link pool and many targets indirectly depends on mksnapshot.


Change-Id: I7c58aec10949c350bbce0a97704048caf44f5b96
Reviewed-on: https://chromium-review.googlesource.com/891043Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#532662}

This CL is a speculative fix for the observed flakiness of this
test on TSAN linux. It seems that the old method of waiting for the
scroll data to propagate back to the browser, namely using a
UpdateResizeParamsMessageFilter to wait for the frame rects to
change, is no longer sufficient to synchronize. It's also necessary to
wait for the child-frame to draw its compositor frame so that the
transform functions used in TouchSelectionControllerClientChildFrame's
DidScroll() method will work properly (they rely on the compositor
surfaces to reflect the scroll changes).

Bug: 805017
Change-Id: I69ec3f318af8adb224d7fb54be1d00ec3c6caae8
Reviewed-on: https://chromium-review.googlesource.com/889864
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532661}

According to the spec, https://www.w3.org/TR/css-scroll-snap-1/,
:target/scrollIntoView()/etc should take scroll-margin, into account.

This patch also unifies the logic of ScrollIntoView() in PaintLayerScrollableArea,
LocalFrameView and RootFrameViewport, so that the new_scroll_offset is calcultated
directly by ScrollAlignment::GetScrollOffsetToExpose()


Bug: 803606
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie790bc58f7dcc0a2744768ddca0d07b24bbf6681
Reviewed-on: https://chromium-review.googlesource.com/875008Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532660}

This warnings should always be fixed in new code.

Bug: 801256
Change-Id: I6089a070efc7a5dfa276417f6035b3109e5dc565
Reviewed-on: https://chromium-review.googlesource.com/891483Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532659}

VC++ PGO builds crash deep inside memmove, as called by
message_center::InnerBoundedLabel::GetSizeForWidthAndLines which calls
base::JoinString and then ultimately basic_string<>::append and memmove.
Inspection of the stack and the generated code shows that
base::JoinString is called correctly but that base::JoinString (or the
inlined JoinStringT and three other levels of inlining) fail to read
separator off the stack correctly - they read it from an address that is
four bytes too early. This leads to copying too many bytes from the
wrong address.

Fully disabling optimizations in VC++ builds for the affected function
seems like the right fix. If time permits then a reduction and VC++ bug
will be created. However if this is a PGO-only bug then...

Bug: 804884
Change-Id: I80fd8e693a35b26a386cd99a1b17c54bede95d5c
Reviewed-on: https://chromium-review.googlesource.com/891569Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532658}

Change-Id: Ibbc3203a8d6107879cfa16e9970e6d7d69f422c0
Reviewed-on: https://chromium-review.googlesource.com/889649
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532657}

TBR=jochen@chromium.org

Change-Id: Ib27f59fe20674f81a077895c69cff28f753bb705
Reviewed-on: https://chromium-review.googlesource.com/887461Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532656}

GetFactoryLocale returned set value.
verified GetFactoryLocale returned set value.

Bug: internal b/72610561
Test: Set ro.product.locale through factory partition, verified
Test: Set ro.product.locale.language/region through factory partition,
Test: Left properties unset, verified GetFactoryLocale returned "en-US".
Change-Id: Ia0e48dd77a2825e6eed09d1e04331b713afb32a3
Reviewed-on: https://chromium-review.googlesource.com/889935
Commit-Queue: Bryan Henry <bryanhenry@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532655}

Removes the "nosync" testing since this no longer applies to the new tab
capture impl (because it is necessarily triggered by OnBeginFrame's).
Also, added a call to BrowserTestBase::UseSoftwareCompositing() when the
non-GPU variants are run to ensure the GPU compositor is not being used.

TBR=xjz@chromium.org

Bug: 806400, 567848
Change-Id: I1d00a5f95ee6d3ac8caf0e5d1191c7bb03ca8064
Reviewed-on: https://chromium-review.googlesource.com/892049Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532654}

This CL:
- Removes ChildProcessLauncherHelper#mCreationParams
- Moves public static ChildProcessCreationParams accessors from
  ChildProcessLauncherHelper.java to ChildProcessCreationParams.java
- Changes type of
  ChildProcessLauncherHelper#sSandboxedChildConnectionAllocatorMap
  from
    Map<String, ChildConnectionAllocator>
  to
    ChildConnectionAllocator
  (The map is no longer needed because WebAPKs no longer have special
   ChildProcessCreationParams)
- As there is now just one sandboxed ChildConnectionAllocator we now no
  longer free the allocator when the last connection is freed. This matches
  what we do for
  ChildProcessLauncherHelper#sPrivilegedChildConnectionAllocator

Deleted tests:
- Tested creating multiple allocators
  - testAllocatorForPackage()
  - testCustomCreationParamDoesNotReuseWarmupConnection() introduced in
    https://codereview.chromium.org/2705133002
- Tested that ChildConnectionAllocator is freed when last sandboxed connection
  was freed
  - testSandboxedAllocatorFreed() introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/513587
  - testSandboxedAllocatorFreedWith2Connections() introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/588380

BUG=797999

Change-Id: I2147ae24d99a7e8b2d93bb7f5a4a2b5ae37172f8
Reviewed-on: https://chromium-review.googlesource.com/884621
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532653}

This CL adds a check to WasRecentlyAudible before adding a mute icon to
a tab to avoid always showing a mute icon when a tab is muted. This also
adds the fade animation to the (mute icon)->(no icon) transition. Since
adding the fade animation breaks a TabTest unit test (which worked under
the assumption that each of its transitions was instantaneous), this CL
also manually stops fade animations in that test.

Bug: 785406
Change-Id: I0d7fd732b605f634f9df59b736dd7f19c382a09e
Reviewed-on: https://chromium-review.googlesource.com/889178Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532652}

Disables more failing VR tests that were missed in the previous CL due
to crbug.com/804808.

Bug: 804808
Change-Id: I64692f52891ee333c807b2e12be08d096de625b7
Reviewed-on: https://chromium-review.googlesource.com/892079Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532651}

Previously composited clip-path are applied multiple times, and can be
applied in the wrong order. This CL makes it so that composited
clip-path is always and only painted in the mask layer.

BUG=792280,792311

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4544c1709e98ca70996655e2e4bbbdc8fc7bd78a
Reviewed-on: https://chromium-review.googlesource.com/858299
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532650}

Bail out early when a condition in the switch is fulfilled.
This does not change behaviour due to RemoveTaskObserver being no-op when
the task observer is not present in the list.

R=thakis@chromium.org

Bug: 177475
Change-Id: Ibc7772c79f8a8c8a1d63a997dabe1efda5d3a7bd
Reviewed-on: https://chromium-review.googlesource.com/891187Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532649}

This was done previously, but the virtual/mouseevent_fractional version
was missed. Also marking them flaky only on Win 7, as per the original
report.

TBR=alexclarke@chromium.org

Bug: 784909
Change-Id: Iaa7ad21c750acedf179a9da0dcf686c65bf7300f
Reviewed-on: https://chromium-review.googlesource.com/891979Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532648}

WebContents manages PopupZoomer (tap diambiguation) via WebContentsUserData.
To make the migration possible, split the class into |TapDisambiguator|
that is actually managed via WCUD, and |PopupZoomer| is now a pure UI part
implementing the popup view inheriting android.view.View.

Bug: 789000
Change-Id: Icf36cf3075c0d79f642b585f7a1f8fc7150e8025
Reviewed-on: https://chromium-review.googlesource.com/872132Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532647}

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id6548d65c07bfa7217c16b6ce31c6ecb534622d5
Reviewed-on: https://chromium-review.googlesource.com/890053Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532646}

There is a fuzzer for parsing of origin trial tokens. In bug 802377, we
discovered that fuzzer was generating tokens > 500KB in size. This was
apparently causing sporadic timeouts in the fuzzer.

The token generation and parsing logic can support valid tokens of such
large sizes. Realistically, there's no need for such large tokens. In the
token contents, the origin is only portion that is user-supplied. While
there is no specified limit on the size of URLs or domains, there do seem
to be practical limits.

This CL limits token payloads to 4KB in size. That allows for the origin
to be ~4KB in size, which is 2x some practical limits for URLs.

Bug: 802377
Change-Id: I80c31dcd6d0e02afe9cbc1c53479fea3b5821751
Reviewed-on: https://chromium-review.googlesource.com/886822
Commit-Queue: Jason Chase <chasej@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532645}

Bug: 805509
Change-Id: Iff8178c0bc707da7c33b38f940cf6ca3fa19f994
Reviewed-on: https://chromium-review.googlesource.com/887293
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532644}

- Log all blocked or allowed attempts.
- Export API to drain log, and to register for log notification.
- New tests.

BUG=769590
TEST=chrome_elf_unittests.exe, Whitelist*

Change-Id: I4f1ec911efbe3eada231aa36b0fadceb3756521e
Reviewed-on: https://chromium-review.googlesource.com/847894
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532643}

This reverts commit 009da37a.

Reason for revert:
The new test is flaky on iPhone 6s. Example failures:
https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28895
https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28892

Original change's description:
> More integration tests for autofill in //ios/web_view.
> 
> One test that verifies fetching, filling, and clearing.
> 
> Bug: 778764
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Icc484e63fc0787bdfcedca95a15528111e4d7dcb
> Reviewed-on: https://chromium-review.googlesource.com/841342
> Commit-Queue: John Wu <jzw@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532462}

TBR=eugenebut@chromium.org,jzw@chromium.org

Change-Id: I2b994d4b5592ca84f0c77f2621ae894f4d52a36b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778764
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/892118Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532642}

BUG=806899

Change-Id: I6a5f1156fca2e8aa0b3726f69e9a1f6d40c0357c
Reviewed-on: https://chromium-review.googlesource.com/891418Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532641}

See https://bugs.chromium.org/p/chromium/issues/detail?id=806440

This CL adds a null check to prevent a NullPointerException.

Bug: 806440
Change-Id: I7106de9d1a9bbdfa3dd0bdb3fbfd3315d611f8d2
Reviewed-on: https://chromium-review.googlesource.com/891810
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532640}

Currently ExternalNavigationDelegateImpl tries to LoadUrl async. However
at the time of the call the tab may be in the process of closing and
native may no longer be available causing a crash. This cl adds a
TabObserver to ExternalNavigationDelegateImpl and checks if the tab is
closed before trying to load the url.

Bug: 662877
Change-Id: I280f9ed1af11177b6efb84221f25a9786856f9a2
Reviewed-on: https://chromium-review.googlesource.com/889704Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532639}

The updated expectations were generated with the try-flag tool,
documented at http://bit.ly/flag-try-jobs.  The flag try job's test
results are at http://crrev.com/c/794897.

The spv175 tests are no longer skipped, as they seem to be passing.

Bug: 711468
Change-Id: Ie9e8addc75dbcc428d234039afb02956e731383b
Reviewed-on: https://chromium-review.googlesource.com/891645Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532638}

Receiving an invalid child window handle is most likely due to a race
between the gpu process destroying the child window and the browser
receving SetChildSurface. There's not a strong argument to crash the gpu
process in this case. This is high volume on stable and polluting other
crash data.

R=piman
BUG=782359

Change-Id: If463462b0a15778513236013a8d31c833840c3ab
Reviewed-on: https://chromium-review.googlesource.com/891566Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532637}

quality when it matches the typical quality of the network

Bug: 806949
Change-Id: I02c8db315200e7ab28f72a0627015be15d8cfc4e
Reviewed-on: https://chromium-review.googlesource.com/890859Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532636}

This CL was uploaded by git cl split.

R=lazyboy@chromium.org

Bug: 177475
Change-Id: I004e612b6ab4ad45c43eb618f93a682cadbdebd3
Reviewed-on: https://chromium-review.googlesource.com/891480Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532635}

BUG=805938

Change-Id: Idd9c8c1945ace56192c11bbc94eb657a17cd26ee
Reviewed-on: https://chromium-review.googlesource.com/887718
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532634}

Bug: 803922
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b3320bea9e37afbab78e0f0d686f0a873b0f5c9
Reviewed-on: https://chromium-review.googlesource.com/876447Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532633}

The information already exists in the AllocationContext, and the plumbing
already exists from supporting type_name for PartitionAlloc. This CL just hooks
up the two pieces. This CL also adds escaping for type_name.

Bug: 758739
Change-Id: Ie3c0e07730f7fba8dda6efa7be5c06b422cbf648
Reviewed-on: https://chromium-review.googlesource.com/889880
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532632}

This CL was uploaded by git cl split.

R=delphick@chromium.org

Bug: 177475
Change-Id: Ibe368c7c16b12efb290f1ebfd12bd9a5a1aa8bac
Reviewed-on: https://chromium-review.googlesource.com/891886
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532631}

This CL was uploaded by git cl split.

R=pkalinnikov@chromium.org

Bug: 177475
Change-Id: I476fc29fb162f6a3f147f9c8fb9b93801e7df84a
Reviewed-on: https://chromium-review.googlesource.com/891880Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532630}