- 23 Jan, 2020 40 commits
-
-
Alex Danilo authored
CL:1345378 changed display of images in quickview to use the decode() API to allow the image to be decoded while the containing content node was detached from the DOM tree in order to avoid visible artifacts during decoding time. The decode() API fails when large image decodes are attempted resulting in nothing being displayed, even when those large images can be viewed from a simple <img src=...> container. Removes the use of decode() and instead, creates an Image object responsible for loading the image and uses the onload handler to reattach the content node to the DOM. Adds an onerror handler that sends an event to the host container in the case of load and/or decode failures. Note, this is in effect creating 2 images - the first is the host node in the content, the second is a temporary 'Image' object that is used to trigger the load/decode and when it's loaded the URL to the object is set on the host image node. That way, the image is already loaded so minimizes flicker when the 'src' is set, and in the error case it doesn't set the 'src' at all. (We call this the Double Image Device:) Bug: 645021, 1043799 Change-Id: Id14e01068c29d7cd373563ba20d2e13d7a4bbfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012368Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734394}
-
Clemens Backes authored
The type check for "WasmModuleObject" was renamed from "IsWebAssemblyCompiledModule" to "IsWasmModuleObject" in https://crrev.com/c/2013109. This CL switches the only caller in chrome to the new API, so we can deprecate the old one. R=haraken@chromium.org Bug: v8:10021 Change-Id: Ibf4d59933ce91086eb3edd1769aae2e3da2a9368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016622Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734393}
-
Colin Blundell authored
We will shortly be componentizing CaptivePortalService out of //chrome. This class depends on the Content API and should only be used on //content-based platforms, whereas the existing //components/captive_portal is shared with iOS. This CL moves the existing component into a layered component structure in anticipation of imminently moving CaptivePortalService and friends into a //content subdirectory. There are no functional changes here; it is a strict code move. TBR=jochen@chromium.org Bug: 1030692 Change-Id: Id231098e56b5c3f28c921c0082918fdf669ebeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010982 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734392}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e6361d160f..313d98ee7b49 Created with: gclient setdep -r src-internal@313d98ee7b49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1c738d66209d0c9850f069c12284795e4bee32f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734391}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=erikchen@chromium.org Bug: 1042208 Change-Id: I9148cc5a2f2ecdfa4d081e27470660b22604f431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007640 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734390}
-
Olga Sharonova authored
This reverts commit b2a8b8b0. Reason for revert: Suspected root cause of All/TabletModeControllerTest.* failures on Linux ChromiumOS MSan Tests Example build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17429 Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890504197399106784/+/steps/ash_unittests/0/logs/Deterministic_failure:_All__x2f_TabletModeControllerTest.DisplayDisconnectionDuringOverview__x2f_0__status_CRASH_/0 First build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17428 Original change's description: > Fix the occasional black flash when fling an ARC window to home screen. > > Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804 > doesn't fix the issue entirely. Looking deeper in this issue, it's > actually caused by ClientControlledShellSurface::UpdateBackdrop() can be > called on a dragged window (whose backdrop has been disabled (kDisabled) > when drag starts) to re-enable the backdrop. > > This CL makes sure an ARC window with disabled backdrop mode won't be > modified. > > Bug: 1027269 > Change-Id: I4d138ddf17bbcee2ab07e1a5fb9785fc05b3fc0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734250} TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org,afakhry@chromium.org Change-Id: Iec4b80f5689c72ea9e73a8051b81f640a6e21fef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016643Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734389}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=groby@chromium.org Bug: 1042208 Change-Id: Ia8c1e13be0579db3e51825be0dffd9e94f8f40f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010822 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734388}
-
Eriko Kurimoto authored
This CL adds a web platform test for checking the behavior of |import.meta.url| in SharedWorker when the script type is set to module. Bug: 824646 Change-Id: Ifaa34e238fe0a432137c5e8213e81610249b7e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014355 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#734387}
-
Miyoung Shin authored
This CL is a follow-up CL of https://crrev.com/c/2010448 and adds the warning message for blink's mojom namespace rule in Blink. Bug: 1043557 Change-Id: I1839ab7cf235cbff0ef3d3c7321c40c2f0adc71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014217Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#734386}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fca88b650404..20d0f9299138 git log fca88b650404..20d0f9299138 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f2517d68..7afe38da (473 commits) Created with: gclient setdep -r src/third_party/skia@20d0f9299138 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I93dc3a9257099a2eee56cb62c7c3bdc5a131a653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734385}
-
Alexander Timin authored
Add explicit expectations whether an event should be dispatched to the document or to the window. R=yuzus@chromium.org BUG=1021536 Change-Id: I97256993d80892e0bb362342aa34221fb345f235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013244Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734384}
-
arthursonzogni authored
The browser process is requesting the renderer process to update its subresource loaders. This must not happen in a renderer that hasn't committed any navigations yet. The browser process is guarding itself against that by checking its attribute: |has_committed_any_navigation_| The problem is that |has_committed_any_navigation_| is not updated after a crash, which allow the browser to misbehave. Bug: 1023226 Change-Id: I68e23c9d4bd80f4679039fac168a9a9b29fac420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012951Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734383}
-
Takashi Sakamoto authored
Change-Id: Ia240c27b892d29530fc10d7457f7dae40016ba97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011624 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734382}
-
Olga Sharonova authored
This reverts commit f32982c9. Reason for revert: broke QuicTransportServerSessionTest.* on Linux CFI first broken build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16249 example of failure: [ RUN ] QuicTransportServerSessionTest.ClientIndicationTooLong ../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22: runtime error: control flow integrity check for type 'quic::QuicCryptoServerStream' failed during base-to-derived cast (vtable address 0x55bc7d313108) 0x55bc7d313108: note: vtable is of type 'quic::TlsServerHandshaker' bc 55 00 00 10 c4 a1 7c bc 55 00 00 60 c4 a1 7c bc 55 00 00 e0 a7 9b 7c bc 55 00 00 90 10 a0 7c ^ #0 0x55bc7ac90d4e in quic::test::(anonymous namespace)::QuicTransportServerSessionTest::QuicTransportServerSessionTest() ./../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22 #1 0x55bc7ac9d83d in quic::test::(anonymous namespace)::QuicTransportServerSessionTest_ClientIndicationTooLong_Test::QuicTransportServerSessionTest_ClientIndicationTooLong_Test() ./../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:205:1 #2 0x55bc7ac9d81a in testing::internal::TestFactoryImpl<quic::test::(anonymous namespace)::QuicTransportServerSessionTest_ClientIndicationTooLong_Test>::CreateTest() ./../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:470:44 #3 0x55bc7c49b176 in testing::Test* testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2555:10 #4 0x55bc7c489138 in testing::Test* testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test*>(testing::internal::TestFactoryBase*, testing::Test* (testing::internal::TestFactoryBase::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2610:12 #5 0x55bc7c488f06 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2797:22 #6 0x55bc7c4898b1 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2939:28 #7 0x55bc7c490a81 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5480:44 #8 0x55bc7c49cd46 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2555:10 #9 0x55bc7c490728 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) ./../../third_party/googletest/src/googletest/src/gtest.cc:2610:12 #10 0x55bc7c490664 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5067:10 #11 0x55bc7d023d80 in RUN_ALL_TESTS() ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2470:46 #12 0x55bc7d023684 in base::TestSuite::Run() ./../../base/test/test_suite.cc:457:16 #13 0x55bc7bbe67fa in int base::internal::FunctorTraits<int (base::TestSuite::*)(), void>::Invoke<int (base::TestSuite::*)(), NetTestSuite*>(int (base::TestSuite::*)(), NetTestSuite*&&) ./../../base/bind_internal.h:499:12 #14 0x55bc7bbe678e in int base::internal::InvokeHelper<false, int>::MakeItSo<int (base::TestSuite::*)(), NetTestSuite*>(int (base::TestSuite::*&&)(), NetTestSuite*&&) ./../../base/bind_internal.h:599:12 #15 0x55bc7bbe672d in int base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<NetTestSuite> >, int ()>::RunImpl<int (base::TestSuite::*)(), std::__1::tuple<base::internal::UnretainedWrapper<NetTestSuite> >, 0ul>(int (base::TestSuite::*&&)(), std::__1::tuple<base::internal::UnretainedWrapper<NetTestSuite> >&&, std::__1::integer_sequence<unsigned long, 0ul>) ./../../base/bind_internal.h:672:12 #16 0x55bc7bbe66dc in base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(), base::internal::UnretainedWrapper<NetTestSuite> >, int ()>::RunOnce(base::internal::BindStateBase*) (.cfi) ./../../base/bind_internal.h:641:12 #17 0x55bc7b0c8ae4 in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:98:12 #18 0x55bc7d029cfe in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:162:38 #19 0x55bc7d029b9b in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:232:10 #20 0x55bc7bbe63bc in main ./../../net/test/run_all_unittests.cc:55:10 #21 0x7fe0a7c4282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 #22 0x55bc79ff0ee9 in _start ??:0:0 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../net/third_party/quiche/src/quic/quic_transport/quic_transport_server_session_test.cc:77:22 in Original change's description: > Roll src/net/third_party/quiche/src/ dfabdfb68..f579b5e51 (5 commits) > > https://quiche.googlesource.com/quiche.git/+log/dfabdfb6884b..f579b5e51aaf > > $ git log dfabdfb68..f579b5e51 --date=short --no-merges --format='%ad %ae %s' > 2020-01-21 nharper Refactor TlsServerHandshaker to implement QuicCryptoServerStreamBase directly > 2020-01-21 fayang Disable gfe2_restart_flag_quic_default_on_ietf_loss_detection in QuicEndpointTest.Competition while investigating the issue. > 2020-01-21 wub gfe-relnote: (n/a) Change the return value of QuicUdpSocketApi::ReadMultiplePackets from number of good packets to number of total packets read. Code not used yet. > 2020-01-21 bnc Use quiche_export instead of http2_export. > 2020-01-21 ianswett gfe-relnote: Add a connection option(1ACK) to send only one immediate ACK in QUIC after reordering, instead of 4. Protected by gfe2_reloadable_flag_quic_one_immediate_ack > > Created with: > roll-dep src/net/third_party/quiche/src > > Change-Id: I6a3b22464f673884affc55883c090a8df1dead3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014053 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Auto-Submit: Bence Béky <bnc@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734145} TBR=rch@chromium.org,bnc@chromium.org Change-Id: Iae4d63a3ffd5f4aa6c3abb4aad9c59a9d9261a1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015242Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734381}
-
Victor-Gabriel Savu authored
Add TimeBetweenFreeDiskSpace metric to measure how often cleanup is performed. Used by crrev.com/c/1960285 BUG=chromium:1043041 TEST=manual Change-Id: I38bf6b78c4c3b0e808b943ea687f2090314346d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960146Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#734380}
-
Victor-Gabriel Savu authored
Add a metric to measure how much space is being cleared by the automatic disk cleanup. Used by crrev.com/c/2007128 BUG=chromium:1043037 TEST=manual Change-Id: I00e88ca84466fa5b3032957641b8b5512649c3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005991Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#734379}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/135f8fcba837..24627fa40a48 git log 135f8fcba837..24627fa40a48 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 syoussefi@chromium.org Row-major test: switch to compute Created with: gclient setdep -r src/third_party/angle@24627fa40a48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ia9dde9b289e322bbe9f799063bc363d0b5b096fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734378}
-
Roman Sorokin authored
Fixed: 1022774 Change-Id: I2ffc80512230316cc3b94b70e7e11f6b2db0390e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010950Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734377}
-
Yoshifumi Inoue authored
This patch introduces |NGFragmentItem::IsEmptyLineBox()| along with |LineBoxType()| for preparation of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: Ic1500c0c26f36042ccb5321e64065405faf823a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014358 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734376}
-
Maksim Sisov authored
So, I removed the x_pending_visual_id from the DWTHLinux and started to set the wm_role_name in order to identify status-icon window. That helps to remove X11 specific calls done in outside X11Window class and brings us closer to Ozone/X11. This is a prerequisite CL to split current implementation into two parts: client and platform. Bug: 1043089 Change-Id: I4de1a34cd38ca0fb760717dc1e9a3d3c8348a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007709Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#734375}
-
David Munro authored
Currently CONTAINER_START_FAILED is our largest bucket of Restarter failures, with close to double the failures of every other category combined. When OnCreateContainer fails emit CONTAINER_CREATE_FAILED (currently one of the smallest buckets) and create a new error for setup failing which anecdotally we've seen a lot of. Test: CQ Bug: None Change-Id: I19d9eceb49c121779c7051e70d25725a557a3d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015877 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734374}
-
Yoichi Osato authored
TBR=graphics-dev@chromium.org Bug: 1044841 Change-Id: I8b75e9a2939bdaf9f50e1f90d1fe56c64f9304ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015473Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d7da3cc922f..a0e6361d160f Created with: gclient setdep -r src-internal@a0e6361d160f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039943,chromium:1044743 Tbr: jbudorick@google.com Change-Id: I3c1d3f872993619a4f7a7caab0eef409596e591d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016462Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734372}
-
Yoichi Osato authored
This reverts commit 97dfeb90. Reason for revert: TabletModeControllerTest.VerticalHingeTest (CRASHED) on Linux ChromiumOS MSan Tests Fixed: 1044871 Original change's description: > Prepare shelf layout manager for shutdown earlier > > Starts shelf layout manager shutdown earlier at the beginning of shell > shutdown sequence (during OnShellDestroying call issued to shell > observers when the shell tear down starts). > > The main goal is to prevent shelf state updates that might happen during > shutdown. For example, tablet mode controller destruction, and overview > controller destruction might cause window stacking changes, that in > turn can cause shelf state updates - both of which happen before > Shell::CloseAllRootWindowChildWindows(), which is from where > ShelfLayoutManager::PrepareForShutdown is currently called (with some > indirection). > > NOTE: Calls to start shelf shutdown issued from > RootWindowController::CloseChildWindows() are kept around to handle root > window controller shutdowns that happen outside shell shutdown. > > BUG=1033343 > > Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734253} TBR=xiyuan@chromium.org,tbarzic@chromium.org Change-Id: I69855c62eedfc7698df237169fc1282868d2876b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015879Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734371}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b345995a827..68125d909621 git log 6b345995a827..68125d909621 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rmhasan@google.com [Typ] Add ability get string value of an Expectation instance 2020-01-23 dberris@chromium.org Find multiple points with E-Divisive Created with: gclient setdep -r src/third_party/catapult@68125d909621 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041688,chromium:986447 Tbr: nuskos@google.com Change-Id: I030004cb0ab80301705f879dd20e9c26d2bc2384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734370}
-
Kent Tamura authored
LayoutMenuList is going to be removed after enabling LayoutNG for form controls. This CL is a preparation for the removal. Bug: 1040828 Change-Id: Ia399a7fed5ac9b35e1f04fdb870a4ea139fbd66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000253Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734369}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I62e5ebb6237def06272f3890d42157831c98d287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014347 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#734368}
-
Julien Isorce authored
ERROR Unresolved dependencies. //media/gpu/vaapi:jpeg_decoder_unit_test(//build/toolchain/linux/unbundle:default) needs //media/gpu/test:local_gpu_memory_buffer_manager(//build/toolchain/linux/unbundle:default) //media/gpu/vaapi:webp_decoder_unit_test(//build/toolchain/linux/unbundle:default) needs //media/gpu/test:local_gpu_memory_buffer_manager(//build/toolchain/linux/unbundle:default) Also added a TODO(https://crbug.com/1043007) to remove the new is_chromeos guard around these tests. Indeed the file local_gpu_memory_buffer_manager.cc does not compile on Desktop Linux since https://chromium-review.googlesource.com/c/chromium/src/+/1970544 because this CL prevents to use minigbm on Desktop Linux. To handle the api differences between minigm and desktop system libgbm, a solution would be to use the existing wrapper in ui/gfx/linux/gbm_wrapper.cc. Bug: 1036647 Test: ninja -C out/Default capture_unittests vaapi_unittest Change-Id: I63d267bcc156916ddf85778c651e0b737d5e7cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006482Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#734367}
-
Simon Que authored
So that they can be used for ATS vs non-ATS comparison. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1040754 Change-Id: Ica5fb60f396393ffcd68f30456835b2f7f1fcb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015918 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#734366}
-
Ahmed Mehfooz authored
This change adds kIconSystemMenu, kIconSystemMenuToggled types to the ash color provider. These colors are utilized in the tray with dark mode being default. Bug: 960118 Change-Id: I4cf9da17454aa25619a172aca8b038569a0a7849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013723 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734365}
-
Eriko Kurimoto authored
The worker's name must be |''| in this test. According to the spec, the default value of WorkerOptions (which is the second argument of SharedWorker) is set as follows: dictionary WorkerOptions { WorkerType type = "classic"; RequestCredentials credentials = "same-origin"; DOMString name = ""; }; spec:https://html.spec.whatwg.org/multipage/workers.html#workeroptions Here, name property is set to an empty string. Therefore, the worker's name must be an empty string when the second argument is |undefined|. Bug: 907749 Change-Id: I5bc9c5afcf76beae1e3924661b2ea65fad5efe1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015911 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734364}
-
Makoto Shimazu authored
This CL is to add a new experiment ServiceWorkerTerminationOnNoControllee which is to terminate a service worker soon after all controllees are gone. The experiment introduces a small delay until the worker is actually stopped. If a new client results in being controlled by the service worker during the delay, the scheduled termination will be canceled. By default, this feature is disabled and the termination happens based on the existing 30-second idle timeout. Bug: 1043845 Change-Id: I132fc2da300ddef7aa6e111e0af2e587b72c8121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011589 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734363}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0537aa80..b5c6594d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1de0ceb0499fa4dbd7fc605c426fe1f120890d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016382Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734362}
-
Yoichi Osato authored
TBR=layout-dev@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 626703 Change-Id: Ifda3ec2fd9307c57a8f9c3e3a6192d76c294a032 Fixed: 1044858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015914Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734361}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f324fe10ca65..c514ab001bb0 git log f324fe10ca65..c514ab001bb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 capn@google.com Evaluate interpolants at pixel center when multisampling disabled 2020-01-23 capn@google.com Use pixel centers for non-multisampled rasterization Created with: gclient setdep -r src/third_party/swiftshader@c514ab001bb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3913539aa6de2a9c529763476c138953e6514df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734360}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::GetLayoutBlockFlow()| to return valid block flow for inline-block for painting selection correctly for inline-block. This patch fixed following web_tests: * paint/selection/text-selection-inline-block-rtl.html * paint/selection/text-selection-inline-block.html Bug: 982194 Change-Id: Ic9ac0969159c893499fcbdba31a032318c91b4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011630 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734359}
-
Simon Que authored
If a builder config explicitly sets goma_enable_ats to either True or False, use that value. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1040754 Change-Id: I4b0fca44f5bb526480c9f99caaba4d5e47231c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015917Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#734358}
-
Mitsuru Oshima authored
This is reland of crrev.com/c/1963234. See my comment for fix. Also added Added ArcNotificationContentViewTestCloseButtonInMessageCenterView to cover regression b/148028487 FPS on arm+hires is now ~60fps even with bg blur (w/o notifications) * Use layer clip during animation * Remove unnecessary background paint * Fine tune layer structures: Remove unnecessary texture layer, and use smaller layer, or change so that it require less repainting. Refactoring: * Consolidate the shield/blur/rounded code into TrayBubbleView. * Introduce layer type to buggle dialog delegate. Fix: * Looks like we were painting bg twice which made blur darker. It happens once in TrayBubbleView's layer. TBR=msw@chromium.org, tengs@hromiumorg Bug: 1033986, b/148028487 Test: no functional change. Added unittest for regresssion. Change-Id: I0d130d40f30cc3660a48a3c2b8979536fa24d85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015577 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#734357}
-
Kent Tamura authored
This CL merges duplicated code into LayoutBlock::EmptyLineBaseline(). This CL has no behavior changes. Bug: 1040828 Change-Id: Ibef264899797f5e443b2485a098d555fe93a949b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015870Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734356}
-
Kent Tamura authored
The function is effective only if the box has non-"visible" overflow property, and the container element doesn't have it. This CL has no behavior changes. Bug: 1040828 Change-Id: Idf00ff9b8e9f650ddac199437a52e3423edbc223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015907Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#734355}
-