- 08 May, 2018 40 commits
-
-
Ian Vollick authored
Previously, we'd plumbed the display rotation as an integral angle, but the only valid values were 0, 90, 180 and 270 degrees. We then converted to an enum. With this CL, we plumb the enum directly. Bug: 836948 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ia99aa7543188fb56f9595cea835b2dfee496f811 Reviewed-on: https://chromium-review.googlesource.com/1045910 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556685}
-
Yuly Novikov authored
We need to reduce the load on Vk N5X bots in order to be able to run dEQP Vk tests on them. Bug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I036c98e02e22c269399feed20225ecd6759cb413 Tbr: kbr@chromium.org No-try: true Reviewed-on: https://chromium-review.googlesource.com/1048210 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#556684}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ife9b0b37224aa2f59cc1b907f340388b05c7c477 Reviewed-on: https://chromium-review.googlesource.com/1033996Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556683}
-
Bence Béky authored
Send HTTP/2 PRIORITY frames when the priority of an HTTP or WebSocket request backed by an HTTP/2 stream changes. Bug: 166689, 500673 Change-Id: Icd1dd31ff9893215110e26d2f7100912e2a9e7a8 Reviewed-on: https://chromium-review.googlesource.com/1045988 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556682}
-
Darren Shen authored
This patch adds a new private API getting the composition bounds of the currently focused text field. This will be used by the inline handwriting feature, and may be used for full screen handwriting. Bug: 824604 Change-Id: I33e66684ffb6d551e5acf8d13057e047ce1311c8 Reviewed-on: https://chromium-review.googlesource.com/1043666 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#556681}
-
tzik authored
As std::random_shuffle is deprecated in C++14, and removed in C++17, its usage blocks the transition to C++17. This CL adds base::RandomShuffle as the replacement, updates all users, and adds a presubmit check to ban std::random_shuffle. Bug: 752720 Change-Id: I99a9dd267e56c04176cf3dc1f6bb7025cdb1deb6 Reviewed-on: https://chromium-review.googlesource.com/1023495Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#556680}
-
Alex Kalugin authored
_ProcessEntry function (which is called only on win) uses shlex.split to split command line arguments. shlex.split function operates in posix mode by default and stripps out all quotes, therefore arguments with spaces in them are split into separate arguments and misinterpreted later. For example -D"MY_DEFINE=\"MY VALUE\"" command line argument is converted in two arguments -DMY_DEFINE=\MY VALUE\. Change-Id: Ie0e92a903782c7f2578d2c99a61fc9c6f4bf57e3 Reviewed-on: https://chromium-review.googlesource.com/1046966Reviewed-by:
-
Fredrik Hubinette authored
This is the first step towards implemeing support for the "SDR brightness" slider in windows 10 RS4. It may also come in handy for implementing brightness-adjusted pseudo-HDR on android devices. Bug: 823547 Change-Id: If9dbdb1b0c56916d3422ba502c3322d9cfe9b385 Reviewed-on: https://chromium-review.googlesource.com/1048685Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#556678}
-
Tetsui Ohkubo authored
This reverts commit edd33a2c. Reason for revert: All ash focus rings are broken Original change's description: > Remove border outline when focused when tab key is used. > > Bug: b/74415372 > Test: Manually Tested > Change-Id: I4e3e5a5b48054b6a7c59e2a02b38b0d200885fee > Reviewed-on: https://chromium-review.googlesource.com/1009243 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Sara Kato <sarakato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554301} TBR=yoshiki@chromium.org,oshima@chromium.org,yawano@chromium.org,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=b/74415372,838850 Change-Id: Id2bafab905a039f634ebcf62a6ab0f919274564d Reviewed-on: https://chromium-review.googlesource.com/1049205 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#556677}
-
Koji Ishii authored
Following bot results are included. 5210 5211 5212 5213 5214 5215 5218 5223 5225 5234 5242 5250 3 lines were removed and 8 lines were deflaked by consecutive results since 5152. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I21b84e82e702b280263c307f74598596ec502f75 Reviewed-on: https://chromium-review.googlesource.com/1045952 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556676}
-
Kunihiko Sakamoto authored
This reverts commit 71098015. Reason for revert: ios build is still broken. https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59679 Original change's description: > Roll src/third_party/webrtc/ 823f9135f..d5ef6ff25 (15 commits) > > https://webrtc.googlesource.com/src.git/+log/823f9135f858..d5ef6ff258da > > $ git log 823f9135f..d5ef6ff25 --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > BUG=chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402 > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Ibaedd51469f75941f90aed9f4ba6bb686cd79f6c > Reviewed-on: https://chromium-review.googlesource.com/1048112 > Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556561} TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I2823387c7aadad799befbf88cc5b4503a379dd3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:None, chromium:840347, chromium:839860, chromium:838402 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1049345 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556675}
-
Xiaocheng Hu authored
InlineBoxTraversal is not supposed to alter the layout tree, so its member functions should return const pointers. Some member functions always return non-null values, so their return types are changed to const references to beffer clarity. This is also a preparation patch for crrev.com/c/1038058, splitting off some of its trivial changes to reduce the size of the big patch. Bug: 822575 Change-Id: I9c32814a88d42e9115be97425b0e0015c4d1779d Reviewed-on: https://chromium-review.googlesource.com/1048785Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#556674}
-
Alexey Kozyatinskiy authored
Network should not be intsrumented with JavaScript AsyncTask instrumentation since it does not trigger JS execution explicitly. R=pfeldman@chromium.org Bug: chromium:840502 Change-Id: I07a939b7f583b0330fa40afb0326a40e58918547 Reviewed-on: https://chromium-review.googlesource.com/1049107 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556673}
-
Ted Choc authored
This reverts commit 76b70285. Reason for revert: ava.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:210) at org.chromium.chrome.browser.TabsTest.runToolbarSideSwipeTestOnCurrentModel(TabsTest.java:1627) at org.chromium.chrome.browser.TabsTest.testToolbarSwipeOnlyTab(TabsTest.java:1477) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:114) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) Original change's description: > Attempt to deflake TabsTest#testToolbarSwipePrevTab* > > This patch updated the toolbar swipe tests to not depend on criteria > helpers and operate on about:blank pages rather than the ntp. Most > importantly, this fixes an issue where we assert tab selection before > waiting for the callback. > > Bug: 813584 > Change-Id: I1e743291add6398bc3eebc06c03c6c69cefc21f9 > Reviewed-on: https://chromium-review.googlesource.com/1044538 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556240} TBR=tedchoc@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813584 Change-Id: I5a6e7d7f585cae58772eb2474b08b45a2d71439c Reviewed-on: https://chromium-review.googlesource.com/1048646 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556672}
-
Emil A Eklund authored
In legacy layout multi-line image mask painting is handled by giving the entire width of the element to the painting code and then clipping it to ensure the left edge is omitted for all but the first line and the right edge is for all but the last. This is inefficient and different from how the logic to omit edges is implement for other border/image paint calls. This change adds include_logical_left_edge/include_logical_right_edge to the NinePieceImageGrid constructor and uses these new parameters to size the left and right edges respectively. Matching existing painting logic. Bug: 714962 Test: fast/borders/inline-mask-overlay-image.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4bcefcc91115a9601632d9e1a0bce70b591cd0a6 Reviewed-on: https://chromium-review.googlesource.com/1048844 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
rdar://35063950Eugene But authored
rdar://35063950 is not fixed and workaround is still needed. Bug: 840426 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I033a508aadc0dad25bc2b70b0db5527a5800e4c5 Reviewed-on: https://chromium-review.googlesource.com/1048566Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556670}
-
Jennifer Apacible authored
This change allows the user to interact with the window contents, most notably the media controls. This also disables dragging on the window, which is a lower priority to have compared to working media controls. Previously, we were unable to interact with Mac controls. Other platforms, such as Linux, required a double click to interact with them. Manually tested on Mac OSX and Linux. Enabling dragging will be done in a future patch. BUG: 839721 836389 Change-Id: Iddaa83d244c0b76760688d12e469afc9265d93a8 Reviewed-on: https://chromium-review.googlesource.com/1048394Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#556669}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 835626 Change-Id: I45957a882b6f3209cc06f6eb2f70d1e6d12f4012 Reviewed-on: https://chromium-review.googlesource.com/1049087Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556668}
-
Bence Béky authored
Remove global ScopedTaskEnvironment instance that lives across all of net_unittests. Add a local variable or test fixture member to whichever test would crash/fail without that. Change type from default to IO for whichever test would crash/fail without that. In some cases, like HttpServerPropertiesManagerTest, make member private and add protected accessors. In most other cases make member protected and access directly from tests. I was mostly doing this by occurrence, and I'm happy to change any test in either direction. I made scoped_task_environment_ the last member unless it was necessary to construct it before the constructor of some other members. I generally made it a private member, unless it is manipulated from a test and I was too lazy to write an accessor, or unless it needed to be created before other, non-private members, because I did not feel like the ugliness of multiple alternating private and protected sections is justified. I'm happy to change this is necessary. Bug: 791831 Change-Id: I578690820c07264372cff9dbd8bd9c944c243ba8 Reviewed-on: https://chromium-review.googlesource.com/1037405 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556667}
-
Luciano Pacheco authored
This fixes the issue where ChromeVox was reading "Zero width no break space" while File Manager or "Save as" dialog was loading. This unicode char was added by the following patch, but without a clear reason: https://chromium.googlesource.com/chromium/src/+/9485ad7b2a08306e23e9980d73a0eaa73da98610%5E%21/#F10 Bug: 835789 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7cc698071ab0c42df4f208e92a2c3cf0fb15cb0a Reviewed-on: https://chromium-review.googlesource.com/1034415Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#556666}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation of the PDF viewer from GYP to GN. A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. A more localized compile may look like: ninja -C out/Default chrome/browser/resources/pdf:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I267f1ba4b25758e1677b83f0304d6d8a5ef5df36 Reviewed-on: https://chromium-review.googlesource.com/1036711Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#556665}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia99636ca8e4a45849cb7cfed062ed4f3a88ba92e Reviewed-on: https://chromium-review.googlesource.com/1049325Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556664}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie2bacf47634aa70bacdee1564db1cd0961348ac6 Reviewed-on: https://chromium-review.googlesource.com/1049270 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556663}
-
mrefaat authored
Update ShouldAllowRequest in WebStatePolicyDecider to take a boolean from_main_frame. iTunes URL Handling Policydecider needs this information, also this will be useful in the future when we move applaunching code out of web_controller Bug: 838359 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia242e14bcf3ac9776cbca70c0bbec58944c5bd72 Reviewed-on: https://chromium-review.googlesource.com/1048397Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#556662}
-
Ryan Hamilton authored
Change-Id: Ic7cfabb1b6b7fbf03efd061058244d59ca4fa357 Reviewed-on: https://chromium-review.googlesource.com/1039770 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556661}
-
Fady Samuel authored
At this point we can always use RenderFrameMetadata on all platforms for resize / visual properties update throttling. RenderFrameMetadata is sent from the impl thread on the renderer instead of the main thread. With the IPC gone, a bunch of tests had to be updated and two RenderWidget unit tests no longer made sense and were deleted. Ultimately, this resulted in significant simplification in RenderWidget and tests. Change-Id: I647a068314309720071134749da2649e71df973f Bug: 410029, 122288, 672962 Reviewed-on: https://chromium-review.googlesource.com/1045913 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556660}
-
Jinsuk Kim authored
Added a test method in ImeAdapter to avoid exposing an impl-detail class ChromiumBaseInputConnection to embedder. Bug: 617324 Change-Id: Ie0f3a4e6db3b161deb00731a52767d9d10273bfb Reviewed-on: https://chromium-review.googlesource.com/1034424Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG= TBR=rdevlin.cronin@chromium.org,sky@chromium.org Change-Id: Iaf80768f4800ad18b6278c8339bd9f7d9df1dde5 Reviewed-on: https://chromium-review.googlesource.com/1047448 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The old PaintLayerFragment based fixed-position repeating method works for the existing printing/fixed-position*.html tests, but doesn't work for transformed fixed-position because we use FragmentData to find the proper paint offset in the case. Now generate FragmentData for repeating fixed-position in paged media. Bug: 839424 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2dee12ef502488a0a3683d2b3d81ecbca38e4b5b Reviewed-on: https://chromium-review.googlesource.com/1045560Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556657}
-
Sunny Sachanandani authored
Replace GLContext::SetSwapInterval with GLSurface::SetVSyncEnabled. The correct place for this is GLSurface because we want to set the correct state when recreating the surface on resize. This fixes --disable-gpu-vsync on D3D9 (--disable-d3d11). R=piman BUG=480361 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib441fda75a86f12c13827a38c37ada05fcf8cb47 Reviewed-on: https://chromium-review.googlesource.com/956898 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Charlie Harrison authored
Some of the new redirect-style interventions require a sticky permission bit. There is a plan to govern these interventions via the popup setting. This CL avoids tab-under blocking if the popup setting is set to ALLOW. Follow-up CLs make modifications to the UI to make this behavior understandable to users. See go/popup-redirect-unification-ui for mocks. Bug: 840351 Change-Id: I14f8a30cf8528a98d203cec89bf06d94fc64947e Reviewed-on: https://chromium-review.googlesource.com/1042106 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556655}
-
Peter Boström authored
Uses COLOR_TOOLBAR_VERTICAL_SEPARATOR instead of the toolbar button color. This matches the separators used in the bookmarks and download bars. Bug: chromium:822069 Change-Id: Iea05d91bebf432f90e58d09104118cb322b00e23 Reviewed-on: https://chromium-review.googlesource.com/1048842 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556654}
-
Owen Rodley authored
The compilation database for chromium is ~180MB of JSON. The current implementation of "run_tool.py --all" reads the whole database, pulls out only the filenames, and then has the tool rescan the compilation database for the flags. We can instead extract the flags as well, and pass them directly to the tool, to avoid the rescanning. A local run of translation_unit over the whole repository took 44m15s before this change, and 17m23s after. Change-Id: I373238980654a5586e32f5a516f0953a4eec03c3 Reviewed-on: https://chromium-review.googlesource.com/1039203 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
-
ziyangch authored
b/74129186 Change-Id: I3cb04fc2c642c8aa6418f60dafb3db6407db0887 Reviewed-on: https://chromium-review.googlesource.com/1044654Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556652}
-
Xu Xing authored
BUG=837155 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0ee28059ab44ace3fd066d500a57cbde252863d7 Reviewed-on: https://chromium-review.googlesource.com/1046371 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556651}
-
David Benjamin authored
Bug: 820198 Change-Id: I8e1992390ac2bbb6f7b2e5a4409cc739ddb5ad60 Reviewed-on: https://chromium-review.googlesource.com/955729Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. No-Presubmit: true No-Try: true Bug: 835626 Change-Id: I079d77a41435f188b2286460f0ee072f1ce6c87c Reviewed-on: https://chromium-review.googlesource.com/1049185 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Sergey Berezin authored
R=jbudorick@chromium.org Bug: 731546 Change-Id: Ib96999ee99a9bb8bfbca9a95b182d517c6ccad86 Reviewed-on: https://chromium-review.googlesource.com/1048908 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#556648}
-
Boris Vidolov authored
Check system Keystone version to offer recovery in the UI when system Keystone is broken. Refactored a bit KeystoneGlue implementation. Added unit tests. Bug: 658993 Change-Id: I16870fc37e1f71772848240f0ae397d6aa13b2e5 Reviewed-on: https://chromium-review.googlesource.com/1044527 Commit-Queue: Boris Vidolov <borisv@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556647}
-
Peter Boström authored
Replaces GG800 with GG700 as icon color in a couple of places: * Omnibox default chip (HTTP (i) icon for instance). * BubbleIconView inside omnibar (these used to be GG700 but regressed to GG800 in Touchable / Refresh recently). * Toolbar button icons. Bug: chromium:821996, chromium:834510 Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef Reviewed-on: https://chromium-review.googlesource.com/1040875 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#556646}
-
