GitLab

Created by adding the following to testing/buildbot/manage.py in
def process_file(..):

   if 'views_unittests' in seen and 'native_theme_unittests' not in seen:
     data = [d for d in gtest_tests if d['test'] == 'views_unittests'][0].copy()
     data['test'] = 'native_theme_unittests'
     gtest_tests.append(data)

Then running manage.py --write. It told me to put an entry in
gn_isolate_map.pyl as well.

BUG=398316

Review-Url: https://codereview.chromium.org/2560633004
Cr-Commit-Position: refs/heads/master@{#437807}

Review-Url: https://codereview.chromium.org/2560423002
Cr-Commit-Position: refs/heads/master@{#437806}

It's only one test now (zero on Android, so it breaks on Android FYI)
and will be merged into service_manager_unittests.

BUG=None
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2563253003
Cr-Commit-Position: refs/heads/master@{#437805}

We moved to checking need-for-repaint and invalidating based
on anchor node in http://crrev.com/2401363003 but we
incorrectly left null-checking based on non-anchor node.

BUG=663319

Review-Url: https://codereview.chromium.org/2565103002
Cr-Commit-Position: refs/heads/master@{#437804}

Because refX and refY are in the coordinate space of each marker instance,
they are included in markerTransformation() instead of being part of the
marker viewport. As a result, only a viewport size is maintained in
LayoutSVGResourceMarker. This patch makes this distinction a little
clearer by refactoring m_viewport to m_viewportSize, as well as adding
some comments.

No new tests; no change in behavior.

Review-Url: https://codereview.chromium.org/2567853002
Cr-Commit-Position: refs/heads/master@{#437803}

https://chromium.googlesource.com/chromium/src/+/c896e79e5ba34

BUG=548616
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2563323002 .
Cr-Commit-Position: refs/heads/master@{#437802}

ReadingListStoreDelegate has virtual methods, so it should have a virtual
destructor.

BUG=673169

Review-Url: https://codereview.chromium.org/2565213002
Cr-Commit-Position: refs/heads/master@{#437801}

ReadingListStore inherits from multiple classes, including from
ReadingListModelStorage that does not define a virtual destructor.

Since ReadingListModelImpl has a scoped_ptr to ReadingListModelStorage,
it calls the base destructor with a pointer that does not correspond
to memory returned by "new" (it points to somewhere inside the memory
block).

The issue can be fixed by defining a virtual destructor on the base
class ReadingListModelStorage (as all class with virtual method should
do). Also mark the class a non-copyable since copying would cause slicing.

BUG=673169

Review-Url: https://codereview.chromium.org/2563303002
Cr-Commit-Position: refs/heads/master@{#437800}

Revert of Enable RL by default (patchset #6 id:100001 of https://codereview.chromium.org/2562643003/ )

Reason for revert:
Speculative revert as I think this CL broke the downstream autoroller.

It is a bit hard to debug as the autoroller was unable to land some CL as the downstream tree was closed, but the last successful roll would have happened at 39e086ae [1], and the first failing roll is at a229e828 [2].

This CL is the only one having an impact on the iOS build, so I think it is causing the failures:

$ git log --oneline 39e086ae...a229e828
a229e828 Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot
d1693364 Update V8 to version 5.7.202.
7cfbed3d Enable RL by default
314c528d Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10 id:240001 of https://codereview.chromium.org/2559323007/ )

[1]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6861
[2]: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/trunk-autoroller/builds/6862

Original issue's description:
> Enable RL by default
>
> BUG=577659
>
> Review-Url: https://codereview.chromium.org/2562643003

TBR=noyau@chromium.org,mardini@chromium.org,olivierrobin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=577659
NOTRY=true

Review-Url: https://codereview.chromium.org/2564293002
Cr-Commit-Position: refs/heads/master@{#437799}

Computing the offset for a list marker after the rest of the objects on the line
it is on have been laid out means it will avoid floats it ought not to.

Instead, compute the offset when laying out the marker and cache it for use later.

BUG=548616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2553793003
Cr-Commit-Position: refs/heads/master@{#437798}

BUG=671181

Review-Url: https://codereview.chromium.org/2559223002
Cr-Commit-Position: refs/heads/master@{#437797}

BUG=672516

Review-Url: https://codereview.chromium.org/2567483003
Cr-Commit-Position: refs/heads/master@{#437796}

Without this check we'd crash when creating the watcher and
asking for the server file descriptor from a null server instance.

TBR=sky@chromium.org
BUG=
TEST=chrome --enable-wayland-server (without XDG_RUNTIME_DIR set)

Review-Url: https://codereview.chromium.org/2569633002
Cr-Commit-Position: refs/heads/master@{#437795}

FaceDetector.detect() in ToT returns a sequence<DetectedObject>,
but DetectedObject doesn't exist, and it should return DetectedFace
instead according to the Spec. Also, DetectedFace is not used at the
moment (FaceDetector  goes around this issue by returning DOMRects
directly).

This CL sorts that out by returning DetectedFaces directly.

BUG=673075

Review-Url: https://codereview.chromium.org/2564123003
Cr-Commit-Position: refs/heads/master@{#437794}

Always creating a GL context is currently preventing this client
from being used when GL is not available.

BUG=
TEST=wayland_motion_events (without GL)

Review-Url: https://codereview.chromium.org/2566863002
Cr-Commit-Position: refs/heads/master@{#437793}

Globals need to be destroyed before the wl_display.

BUG=
TEST=wayland_motion_events --use-drm
TBR=dcastagna@chromium.org

Review-Url: https://codereview.chromium.org/2568703002
Cr-Commit-Position: refs/heads/master@{#437792}

Use ios_packed_resources_target as a dependency of //ios/chrome/app
target to select the correct packed resource target.

BUG=653086

Review-Url: https://codereview.chromium.org/2558913005
Cr-Commit-Position: refs/heads/master@{#437791}

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org, pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Review-Url: https://codereview.chromium.org/2562733003
Cr-Commit-Position: refs/heads/master@{#437790}

This rolls //third_party/typ to v0.9.9 to pick up dglazkov's patch
to allow "foreign arguments" to typ. A foreign argument is one
that the typ arg parser ignores.

This roll includes:

  d77f1a5 bump version to 0.9.9
  69c6119 Merge pull request #7 from dglazkov/foreign-argument
  0a2f193 fix indentation
  c8845b2 Introduce the concept of a foreign argument.

R=dglazkov@chromium.org

Review-Url: https://codereview.chromium.org/2568683002
Cr-Commit-Position: refs/heads/master@{#437789}

http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473

Two changes are in the range:

1. Timezone update to 2016i
2. Bign Endian support for MIPS

BUG=473288
TBR=mark@chromium.org
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/4/2016, 4:00:00 PM"
> (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/3/2016, 3:00:00 PM"

Review-Url: https://codereview.chromium.org/2557743010
Cr-Commit-Position: refs/heads/master@{#437788}

BUG=641020

Review-Url: https://codereview.chromium.org/2557403005
Cr-Commit-Position: refs/heads/master@{#437787}

Cr-Commit-Position: refs/heads/master@{#437786}

This CL changes how the scope is computed if the scope is unspecified in the
Android Manifest.
We used to compute the default scope based on the "URL the WebAPK navigates to
when launched." Deep links can open a WebAPK at an arbirtrary URL.
This CL changes the computation to be based on the Web Manifest start URL.

This change enables cleaning up
ManifestUpgradeDetectorFetcher#onDataAvailable(). We can now create the fetched
WebApkInfo using the current WebAPK's WebApkInfo#uri().

BUG=639536

Review-Url: https://codereview.chromium.org/2548333006
Cr-Commit-Position: refs/heads/master@{#437785}

This is always defined on non-mobile platforms and it is not possible to
override in the build. Since //chrome is no longer build on iOS, most uses
can be easily keyed off of the Android defines. For files not compiled on
Android, the conditionals were removed altogether.

This change additionally coalesces some Android blocks in
chrome/browser/BUILD.gn and chrome/browser/ui/BUILD.gn

BUG=671706

Review-Url: https://codereview.chromium.org/2561013002
Cr-Commit-Position: refs/heads/master@{#437784}

This improves the synchronization by deferring the client side
wait until commit time.

BUG=
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2563263002
Cr-Commit-Position: refs/heads/master@{#437783}

Pending damage was ignored prior to this change. Full damage should
be used in lost context situations and client provided damage for
normal commit.

BUG=673134
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2565973002
Cr-Commit-Position: refs/heads/master@{#437782}

BUG=
TEST=wayland_motion_events

Review-Url: https://codereview.chromium.org/2569613002
Cr-Commit-Position: refs/heads/master@{#437781}

CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink.

CompositorFrameSink is no longer a friend class of exo::Surface.

Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient.

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493223002
Review-Url: https://codereview.chromium.org/2493223002
Cr-Commit-Position: refs/heads/master@{#437780}

BUG=none
R=sdefresne@chromium.org,rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2564023002
Cr-Commit-Position: refs/heads/master@{#437779}

It is a followup patch to https://codereview.chromium.org/2533793002/
In addition to renaming this CL fixes a typo in code where sensor
cache in erased.

BUG=606766

Review-Url: https://codereview.chromium.org/2560263002
Cr-Commit-Position: refs/heads/master@{#437778}

Dumps of check_example.exe

Current:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EDC: 55                 push        ebp
  00404EDD: 8B EC              mov         ebp,esp
  00404EDF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EE3: 75 07              jne         00404EEC
  00404EE5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EEC: 5D                 pop         ebp
  00404EED: C3                 ret
?DoCheck@@YAX_N@Z:
  00404EEE: 55                 push        ebp
  00404EEF: 8B EC              mov         ebp,esp
  00404EF1: 51                 push        ecx
  00404EF2: 83 65 FC 00        and         dword ptr [ebp-4],0
  00404EF6: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EFA: 75 07              jne         00404F03
  00404EFC: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404F03: 8B E5              mov         esp,ebp
  00404F05: 5D                 pop         ebp
  00404F06: C3                 ret
_main:
  00404F07: 55                 push        ebp
  00404F08: 8B EC              mov         ebp,esp
  00404F0A: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404F0E: 53                 push        ebx
  00404F0F: 0F 9F C3           setg        bl
  00404F12: 53                 push        ebx
  00404F13: E8 D6 FF FF FF     call        ?DoCheck@@YAX_N@Z
  00404F18: 53                 push        ebx
  00404F19: E8 BE FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404F1E: 59                 pop         ecx
  00404F1F: 59                 pop         ecx
  00404F20: 33 C0              xor         eax,eax
  00404F22: 5B                 pop         ebx
  00404F23: 5D                 pop         ebp
  00404F24: C3                 ret

After this CL:

?DoBlinkReleaseAssert@@YAX_N@Z:
  00404EAC: 55                 push        ebp
  00404EAD: 8B EC              mov         ebp,esp
  00404EAF: 80 7D 08 00        cmp         byte ptr [ebp+8],0
  00404EB3: 75 07              jne         00404EBC
  00404EB5: C6 05 00 00 00 00  mov         byte ptr ds:[0],0
            00
  00404EBC: 5D                 pop         ebp
  00404EBD: C3                 ret
_main:
  00404EBE: 55                 push        ebp
  00404EBF: 8B EC              mov         ebp,esp
  00404EC1: 83 7D 08 02        cmp         dword ptr [ebp+8],2
  00404EC5: 53                 push        ebx
  00404EC6: 0F 9F C3           setg        bl
  00404EC9: 53                 push        ebx
  00404ECA: E8 DD FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ECF: 53                 push        ebx
  00404ED0: E8 D7 FF FF FF     call        ?DoBlinkReleaseAssert@@YAX_N@Z
  00404ED5: 59                 pop         ecx
  00404ED6: 59                 pop         ecx
  00404ED7: 33 C0              xor         eax,eax
  00404ED9: 5B                 pop         ebx
  00404EDA: 5D                 pop         ebp
  00404EDB: C3                 ret

Amusingly, I was confused because I thought I was going crazy when
DoCheck wasn't showing up in the /disasm. But of course, it's because it
got COMDAT'd with the Blink one, as we want. :)

R=primiano@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2559323007
Review-Url: https://codereview.chromium.org/2559323007
Cr-Commit-Position: refs/heads/master@{#437777}

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Review-Url: https://codereview.chromium.org/2557213002
Cr-Commit-Position: refs/heads/master@{#437776}

BUG=629946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2563683003
Cr-Commit-Position: refs/heads/master@{#437775}

This adds an entry to about:flags so that users, and internal testers,
can opt into Chrome OS component updates before we roll them out to all
users.

This was originally landed in https://codereview.chromium.org/2544133002,
but reverted in https://codereview.chromium.org/2567773002
because one of the other flags did not work properly.

BUG=670421

Review-Url: https://codereview.chromium.org/2565043002
Cr-Commit-Position: refs/heads/master@{#437774}

BUG=673090

Review-Url: https://codereview.chromium.org/2566823002
Cr-Commit-Position: refs/heads/master@{#437773}

There were two bugs in readonly handling.

BUG=673074

Review-Url: https://codereview.chromium.org/2567633003
Cr-Commit-Position: refs/heads/master@{#437772}

BUG=643746, 604369
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555693005
Cr-Commit-Position: refs/heads/master@{#437771}

Using update-w3c-deps in Chromium a229e828.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7824

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2565143003
Cr-Commit-Position: refs/heads/master@{#437770}

Removes a number of branches from the calculations. Also now exporting
SafeUnsignedAbs as a public API.

NOTRY=true

Review-Url: https://codereview.chromium.org/2566733002
Cr-Commit-Position: refs/heads/master@{#437769}

Now we have format_blink_cpp_source_code filter, and continuous
new lines are merged.  So we don't need such hacks to avoid
duplicated empty lines.

BUG=None

Review-Url: https://codereview.chromium.org/2558383003
Cr-Commit-Position: refs/heads/master@{#437768}