- 14 Jan, 2020 40 commits
-
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ia7baa75e8c66f6d5ec255bc6a044640685c83db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977380Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#731693}
-
Natalie Chouinard authored
Extract ExpandablePreferenceGroup to Settings build target, along with owned resources. Move shared resources (expand more/less icon and transitions) to ui/android. Bug: 1035928 Change-Id: I54173013d78f731aceb5ae90a7b85d07c176d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992517 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731692}
-
Greg Thompson authored
This aligns Chrome's DM token storage with Google Update's. This CL also makes base::win::RegKey a movable type. BUG=970162 Change-Id: Id6270411d2417501746ad85f8061cd7d93841618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997184 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731691}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I1af30f759635ad05f311f9d43b8c5c75c8f2cbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998004 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#731690}
-
Rossana Monteriso authored
This CL: * adds a required reference to the alignment.css resource file, that provides alignment-related CSS classes used in several test cases. Adding this reference fixes the align-content-distribution tests. * changes the dimension of grids having 3 rows, .verticalLR and .stretchedGrid classes, and gives them a new value of 300px width and 400px height (by using the class .width300height400). This way each row width is now equal to 300px/3=100px, instead of the previous dimension of 400px/3=133,33...px. The 133,33...px dimension was, in fact, interpreted differently in different browsers, thus making some tests fail in WebKit and Firefox. * removes the -expected.txt files, related to align-content-distribution tests, that were generated when these tests were failing. Change-Id: I404dd188e8a2275042b4ace218c78a99e3248be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996303Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#731689}
-
Piotr Bialecki authored
Prior to calling into ChromeActivity's getFullScreenManager(), we should check whether the activity is not finishing or already destroyed to protect ourselves from IllegalStateException. Fixed: 1038736 Change-Id: Ic8f25f5e839535031d92055b424cd624db4b2704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985168 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#731688}
-
Olivier Li authored
Tracing config needed a comma for proper sepration in BENCHMARK_RENDERERS. Currently it does not and merges with the next category which breaks both. The file category should also be logged in BENCHMARK_NAVIGATION because we want to use it to get some insights into the use of ImportantFileWriter use from the Browser. Bug: 1039794 Change-Id: Ib2acf7eef6f2bacb1874d95e2bf427f54088b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001244Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#731687}
-
Fei Ling authored
To enter full screen mode, use keyboard shortcut instead of finding and clicking the full screen button. Change-Id: I762952ed04d73d9be6a45ea3757a6212b59cff14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992693Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Fei Ling <feiling@chromium.org> Cr-Commit-Position: refs/heads/master@{#731686}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I696313dd80fb0801d951ff6c6e0c50661f84a63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000599Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731685}
-
Filip Filmar authored
The tzdata is loaded only for OS_FUCHSIA, since Fuchsia is the only OS that needs this. Fuchsia needs tzdata loading because it supports multiple runners, and it is important that all of them use exactly the same tzdata version. If the tzdata files are not present, the execution proceeds, but the files are not loaded. In production, the runner will get time zone data from the config data directory which is made available to apps in specific Fuchsia products. Two unit tests are added: 1. A unit test that confirms tzdata loading affects the reported library revision. This test confirms that the loading mechanism works. 2. A unit test that checks whether the loaded timezone data revision matches what Fuchsia expects to see. This test will fail if loading fails so that the version in use is different from what Fuchsia expects. This allows Fuchsia engs to see how to fix the harmful version skew. This falilure should happen only if ICU libraries in Fuchsia and Chromium become backward-incompatible, which is unlikely but possible. R=dpranke@chromium.org, wez@chromium.org Bug: fuchsia:37487 Change-Id: I884777befbdb0ea9e324acc6c4359145c54d02aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949120 Commit-Queue: Filip Filmar <fmil@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#731684}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ericrk@chromium.org Bug: 1041419 Change-Id: I38a8a73da2d421506d7cbeab034ed83850d602f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998513 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#731683}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ifbee858c55b92caa7c1d2345f207d681973526f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998380 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731682}
-
Nico Weber authored
Reformat all gn files in /chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/library/BUILD.gn. `gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ib00515a92a2d56c559e23ae6d806cc38441eb380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994078 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ic155e6e0cac97155ca369d554b92ccc7b3af26f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998158 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: I7a872b33ae310a59fd9d0091c4afe63e1b00b690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997707 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: I8bf21a918bdac68dc24be4b374dd68b8b65bcf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998665 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This CL updates the Create() factory method to allow specifying the username and password for a mock infobar delegate. It also converts the password banner test to use the mock delegate. Bug: none Change-Id: Ied9dcec354e49c5bd523b9c417fa94a0d2cc5014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995632 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#731677}
-
Nathan Zabriskie authored
Pixel_WebGLCopyImage is passing again on tip of tree. Reenabling it. TBR=kbr@chromium.org Bug: 1037654 Change-Id: Ic24f74191fa063adb307363dd4c672ba98720ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999156Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#731676}
-
Devlin Cronin authored
Instead of deleting all the menu items within the menu and repopulating it each time it needs to be updated, dynamically refresh the items. This results in significantly less churn, but also means that we won't be moving around or removing menu items unless absolutely necessary. This fixes accessibility issues where the menu would update and the user would lose state and focus, as well as fixing re-entrancy issues with removing extensions. Bug: 984654, 1038821 Change-Id: Ic56bfa4f6b0c115565904891630ed024cd527877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986332 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#731675}
-
Mohammad Refaat authored
Use SessionRestorationAgent instead. Bug: 783777 Change-Id: Ic8edffbb58876fa29f18f8e9a580c1a4a21b7d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999748 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#731674}
-
Peter Kasting authored
Split from https://chromium-review.googlesource.com/c/chromium/src/+/1918828 and modified; as much as possible, this declares constants locally to individual tests, even if this means duplicating constants, when the tests don't rely on using the same constants as other code. Bug: 783819 Change-Id: I8519496dc3f1e1c39b51f069485559d7e9618aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999089Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#731673}
-
Michael Thiessen authored
QueryIntentActivities is slow, and we were redundantly calling it with the same intent we had already called it with. Change-Id: I24e47336c1d5207ea6a933bd9f5148752d3a78b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001386Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#731672}
-
Francois Doray authored
This is a reland of a79e01b5 In this reland, tests do not run in debug builds as the multiple navigations cause time outs. Original change's description: > Re-enable TabManagerTest.DiscardTabsWithMinimizedAndOccludedWindows. > > The crash stack on the bug is in non-TabManager code. Let's see if > the test passes when re-enabled. > > This CL also: > - Splits the test in 2 tests to avoid timing out (local tests show > that we can time out when having too many navigations in the same > test). > - On ChromeOS, allows discarding of the active tab in the last focused > browser window if that window is not visible. Previously, the active > tab in the last focused browser window was not discardable, even if > the window was not visible. > > Bug: 772839 > Change-Id: I18552a16361c8beb4d48409227b727a40cc40ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972570 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728572} TBR=chrisha@chromium.org Bug: 772839 Change-Id: I17e41e176028f76ff09cb9fac60b8ffe51b36132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001240Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#731671}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/711a2b75fb81..4bb7b1ddf3b1 git log 711a2b75fb81..4bb7b1ddf3b1 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 rharrison@google.com Convert spvc messages internal struct to be a vector (#952) Created with: gclient setdep -r src/third_party/shaderc/src@4bb7b1ddf3b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I743d19aeadc48757a4a94af66511087d56934fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731670}
-
Brandon Wylie authored
This is a reland of 24eca4b9 Original change's description: > Reparent the current Tab when the theme is changed > > * Creating a class which handles reparenting the current tab when the > theme is swapped. > * Hooking that class into ChromeActivity. > * Adding plumbing to a few ReparentingTask/TabReparentingParams to > facilitate the process. > > Bug: 944302 > Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726136} Bug: 944302 Change-Id: I8e8b0ebb67d16dafbef3c4bc0de37813302c8b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980962 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#731669}
-
David Roger authored
The new menu has been launched successfully, the old menu can be removed. Change-Id: I3730adb0fedc10d4f1d1e4e3293a2578fa4dbca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983215 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#731668}
-
Kartik Hegde authored
Add a new policy ('DeviceDisplayGraphicsStatus') to control whether the display and graphics statuses are reported to the device management server. This setting is checked in DeviceStatusCollector. BUG=chromium:1017893 TEST=Cherry pick https://crrev.com/c/1779132 and ensure that the display and graphics values match the values reported in chrome://gpu. Change-Id: I3e803112288dc028951f3d659ae72b5490d6008b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961132 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#731667}
-
Toni Barzic authored
This makes home launcher visibility change happen sooner when the last visible app window is hidden (to when the window starts hiding, instead of when the currently active window changes). The main benefit is that, during window minimization to shelf, the home visibility, and the new hotseat state is calculated before the target shelf item icon bounds for the minimizing window. In other words, the target hotseat bounds will be known when the window minimization animation is set up. Additionally, this makes ShouldHomeLauncherBeVisible check in shelf_layout_manager redundant (as target visibility returned by AppListControllerImpl should now cover the state where the last window was hidden, but the new active window has not yet been set). BUG=1030819 Change-Id: I405e1fda018c4b0681bcf9a1a74266a37cd634d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999443 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731666}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1041419 Change-Id: Ib122628e14f65d56479d29490d5f7c36c3193d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997907 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731665}
-
Moe Ahmadi authored
It feels snappier and more consistent with the omnibox behavior. Also potentially presents zero-prefix suggestions at an earlier opportunity. Bug: 1041183 Change-Id: Ief77c3447ea82ce6dd78dacb33f4483d3acc84c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001286Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#731664}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1041419 Change-Id: I1e8cfb997b358a1adeb39f2b4d6e5aaa5a1d8d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998173 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#731663}
-
Ian Swett authored
R=rch@chromium.org Change-Id: I7463aac76261de088584fa4503370498865d119f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001184 Commit-Queue: Ian Swett <ianswett@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#731662}
-
Demetrios Papadopoulos authored
This is in preparation of running auto conversion tools for c/b/r/settings. Bug: 1026426 Change-Id: I1a1fdbd1f97910c2611f54f8f0ccb87192b4ad52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001379 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#731661}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 1041419 Change-Id: I5ab11cc97e64ccf3b92cdca4dc7950d8509c0ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998704 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#731660}
-
Brian Salomon authored
This reverts commit 09e36ff4. Bug: 1041451 Change-Id: Ib164a508b7406fd25c64990995f725ca993b4f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999062 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#731659}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1041419 Change-Id: I7cf01fd713eecdf0509185d87258fbb1d8a04a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998296 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=xhwang@chromium.org Bug: 1041419 Change-Id: If1fb0f375831775260aec2754c49002018138428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994507 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#731657}
-
Olivier Li authored
This is the code half of https://crrev.com/c/1960467 that was reverted because of tests breakage. Comments will be uploaded in a separate CL. The tests have been fixed and this is conceptually reland. Bug: 661143 Change-Id: Ic61c6a77cf232330c575f1ac5621c1393b5db1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000798Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#731656}
-
Egor Pasko authored
The symbol_level was switched to 2 recently (crrev.com/729971). This works on general builders, but on the orderfile bot with less RAM onboard the LLD hits an OOM after swapping a lot. Attempt to mitigate this by switching symbol_level back to 1. This may be not enough because there were other changes making ThinLTO smarter. Those could consume a lot of RAM potentially as well. Bug: 1041096 Change-Id: I034939b7ca9b04990a2f2d3ac8205a085cb0b8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000819Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#731655}
-
Olivier Li authored
This is the comments half of https://crrev.com/c/1960467 that was reverted because of tests breakage. The actual flag flip is at https://crrev.com/c/2000798. The tests have been fixed and this is conceptually a reland. Bug: 661143 Change-Id: Ic009bd84a8b4fe09f60967b90ff1434931e4734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999228Reviewed-by:
-
