- 09 Aug, 2018 40 commits
-
-
Kevin Schoedel authored
Replaced Stub with parent implementation stubs to make it easier to add sounds; made the proxy explicit; renamed things for clarity. Follow-up CL will remove accessibility_sound_delegate.h. Bug: internal b/73383411 Test: manual Change-Id: I95d6619f373024f66aed6204ee667585c7db0f76 Reviewed-on: https://chromium-review.googlesource.com/1166029Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581931}
-
Jian Li authored
Currently it is reported as "Download Home". We now add the logic to separate it out, together with the case that clicking from progress bar. Bug: 869692 Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f Tbr: dgn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1157644 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581930}
-
Tom Anderson authored
This CL fixes some colors I noticed were off around the NTP. * Specify COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR in the GTK theme. Previously we were falling back to a value calculated in [1]. * Gets the download bar separator color from the ThemeProvider. Previously it was hardcoded to #D6D6D6. This changes it to use the toolbar separator color. This color should work well with the download bar because the background color of the download bar is already obtained from the toolbar color. [1] https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=b0784bef916569b6e4f06a6dce95b75a8a2cf10a&l=530 BUG=None Change-Id: Ib892b8ebb3355299020a4bc570cf37a3aee7a8c2 Reviewed-on: https://chromium-review.googlesource.com/1167979 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581929}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd5051fa529e..15a5a77db412 git log dd5051fa529e..15a5a77db412 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 tandrii@chromium.org Reland "Deploy git 2.18 to depot_tools on a bleeding edge." 2018-08-09 tandrii@chromium.org Revert "Deploy git 2.18 to depot_tools on a bleeding edge." 2018-08-08 tandrii@chromium.org Deploy git 2.18 to depot_tools on a bleeding edge. 2018-08-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@15a5a77db412 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851505,chromium:851505,chromium:851505 TBR=agable@chromium.org Change-Id: I925476691895d7caf2e8e3ada3144e0312302025 Reviewed-on: https://chromium-review.googlesource.com/1169114Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581928}
-
Tommy Steimel authored
This CL adds content:// to the list of schemes that the UrlBar should display completely. This fixes an issue with the media intent handler where only "content:" was shown as the url, which looked buggy. Bug: 872489 Change-Id: I4af4bf01df1b62738df2023ebb633b4674562b86 Reviewed-on: https://chromium-review.googlesource.com/1168383Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581927}
-
Kevin Strohbehn authored
Bug: 869638 Change-Id: Ifea913dd4df2c94487173e87eba2bd860802c6c9 Reviewed-on: https://chromium-review.googlesource.com/1168475 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581926}
-
Hector Carmona authored
Bug: 832938 Change-Id: Id53c3e80f9db1b160e252a23e33a448daf22514c Reviewed-on: https://chromium-review.googlesource.com/1160727Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Scott Violet authored
As the widget is shown only once the webcontents has loaded it is possible to close the popup before it's shown. Ignore activation changes until the popup is shown. BUG=867654 TEST=covered by tests in mash Change-Id: I74956b137a119f2b745a52698cb9dee6543b85e4 Reviewed-on: https://chromium-review.googlesource.com/1169525Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581924}
-
Becca Hughes authored
If the sound content setting has been set to ALLOW by the user then we should set the force allow autoplay flag. BUG=865548 Change-Id: I895ce4d1a0f99357f097ee23ee52fa5fa566cc69 Reviewed-on: https://chromium-review.googlesource.com/1159349 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Scott Violet authored
This test is creating an aura::Window and then embedding another client in it. When this happens it is expected that clients set the type before doing this. I'm sending this to make sure we don't block some work being done to mojo. I think the real fix is to remove EMBED_IN_OWNER (there is a bug filed on it). BUG=872071 TEST=test only change Change-Id: I6e0f6c5584ea9ec19b0e09fe944a83187a9f5ebf Reviewed-on: https://chromium-review.googlesource.com/1169695Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581922}
-
Scott Violet authored
These now pass because of adding kOverrideUseSoftwareGLForTests in AshTestSuite. BUG=838520, 725095 TEST=test only changes Change-Id: I070d5749486338e2fd72815b4dd75d13a391204f Reviewed-on: https://chromium-review.googlesource.com/1169535 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581921}
-
Evan Stade authored
Bug: 854704 Change-Id: I13acab5de5dc2565f12c02b2cb23b2d41d4331f8 Reviewed-on: https://chromium-review.googlesource.com/1167744Reviewed-by:
-
Lukasz Anforowicz authored
There has been a lot of work on adding OOPIF support to DevTools. I am guessing that some of that work has fixed the tests - they are passing when 20 times in a row on my local machine. Bug: 582176 Change-Id: I8ec94ff9cf8d19774c88eaf86fe4839d43a5d8b6 Reviewed-on: https://chromium-review.googlesource.com/1169948Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581919}
-
Joshua Peraza authored
CrashReportMimeWriter provides a method to call into native code to rewrite the minidumps as MIME messages. This CL also links that native code into webview and clank, but makes no functional changes. Bug: crashpad:30 Change-Id: Ief41d366614a833db3b643f46a0297c52fea495f Reviewed-on: https://chromium-review.googlesource.com/1115702 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581918}
-
Toni Barzic authored
Make sure every call to SendNewNoteRequest is followed by call to FlushTrayActionForTesting, which should flush mojo pipes. For most instances this was already the case, but it was missing in few places - these were followed up with ExpectObservedStatesMatch, which did fluch of its own (to ensure the mojo pipe is flushed in other direction), which flushed the new note request as well, or were expecting mojo call to have no effect. With CL:1145692, this does not seem to be enough anymore, as flush in ExpectObservedStatesMatch ends up handling only a single mojo message. While here, replace checks for empty observed state changed with calls to ExpectObservedStatesMatch. TEST=run tets with CL:1145692 applied BUG=872070 Change-Id: I58447ffe8315ddcd5917f0ce901ea5b2624b4e2a Reviewed-on: https://chromium-review.googlesource.com/1170026 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#581917}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e2e069052f7b8d593119e8e96f670e7f1a12073 Reviewed-on: https://chromium-review.googlesource.com/1169980 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581916}
-
Muyuan Li authored
Bug: b/112373646 Test: use "set timer for 3s" and listen. Change-Id: I642325f182f2e2895b6a7d0c76019dc064cd8552 Reviewed-on: https://chromium-review.googlesource.com/1168467Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581915}
-
Daniel Erat authored
When one or more users are signed in, make ash::PowerPrefs always use the primary (i.e. first) user's prefs to derive power management policy. Bug: 872504 Change-Id: Ibe7cf26d3089ee0a69b58bf61d613354e9c6379c Reviewed-on: https://chromium-review.googlesource.com/1168509Reviewed-by:
-
wutao authored
This cl adds a pref to turn off Launcher continue reading feature. Bug: 843839, 872481 Test: manual. Change-Id: I46553972af783ebc32cdb7fbab76ae207b9474ba Reviewed-on: https://chromium-review.googlesource.com/1168733Reviewed-by:
-
Lei Zhang authored
Change-Id: I89c98bdec12e657b7928b00082a5c6591596879e Reviewed-on: https://chromium-review.googlesource.com/1168595 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581912}
-
Daniel Nicoara authored
Enable universal planes when initializing the DRM device in the browser process. This ensures all planes are exposed via DRM. If DRM reports 0 planes (on legacy this can happen) do not report support for PLANE_CTM otherwise the display configuration will try to set hardware CTM. Bug: 869901 Test: Compiled Change-Id: I3fd09e3628e198219d8bb0b1400afd156cb4bcbe Reviewed-on: https://chromium-review.googlesource.com/1167892 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#581911}
-
Dirk Pranke authored
This reverts commit 1df37f0e33c9cfb2337be2895d6f3c434aebdf17. Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again. Original change's description: > Reland "Use CompletionOnceCallback in //content/browser/appcache." > > This reverts commit dfc0e36093e5c5818a613dc7782aa15f8c171694. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > Revert "Use CompletionOnceCallback in //content/browser/appcache." > > > > This reverts commit 6b2ace6e0bb70c5c5f6d35f84e62c84207059ac0. > > > > Reason for revert: Inadvertently submitted without CQ. New UI is confusing. > > > > Change-Id: Ie9b9ca30b5f456cb75ca1813041b6cba9904dd27 > > Reviewed-on: https://chromium-review.googlesource.com/1169442 > > Reviewed-by: Bence Béky <bnc@chromium.org> > > TBR=kinuko@chromium.org,bnc@chromium.org > > Change-Id: I32f091e1d523965cd85f18eb527ae71e3fdf18dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1169867 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=kinuko@chromium.org,bnc@chromium.org,tandrii@chromium.org Change-Id: If57f238de6a6d00a540ca2c241c290506becc863 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1169929Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581910}
-
Dirk Pranke authored
This reverts commit bbe0692bd9283569546670318df6e3d8e605be8c. Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again. Original change's description: > Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This reverts commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > > > This reverts commit 1bd58466. > > > > Reason for revert: The crashes are still happening, and we aren't > > closer to finding the cause. Changing focus to the > > onion-souping effort. > > > > Bug: 859464, 857464, 867850, 866827 > > > > Original change's description: > > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > > > Bug: 716490 > > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#563169} > > > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 716490 > > Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0 > > Reviewed-on: https://chromium-review.googlesource.com/1157446 > > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org > > Change-Id: Ia063033d68cd05bc46ca9259ed9f49e5ee06bab9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 859464, 857464, 867850, 866827, 716490 > Reviewed-on: https://chromium-review.googlesource.com/1169843 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,tandrii@chromium.org Change-Id: I3ff96a37dd11d2986651dbd8a7156178c20fb018 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859464, 857464, 867850, 866827, 716490 Reviewed-on: https://chromium-review.googlesource.com/1170005Reviewed-by:
-
Dirk Pranke authored
This reverts commit a86c92901aa9f21db709d7b40d1fcf0d472570d2. Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again. Original change's description: > Reland "WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file." > > This is a reland of c8299015 > to revert findit revert of the above in https://chromium.googlesource.com/chromium/src/+/224eb4663f904ffc0c1356fe5f1d83fc4afc2c90 > Why? Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. > Please, re-land it after all clear is given. > If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file. > > > > Extract all the low-level skia/gfx/color_util stuff as > > ResizeIconsAndGenerateMissing function. > > > > This is a cut-and-paste CL, no behavior changes. > > > > Notes: > > - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL: > > Merge IconInfo and BitmapAndSource - they are essentially the same. > > > > - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test > > was always broken (a bug in ValidateAllIconsWithURLsArePresent helper) > > https://codereview.chromium.org/1066623008/patch/80001/90005 > > > > Bug: 860581 > > Change-Id: I0d866ac323f8dfdb409b69b22fac796155b1da23 > > Reviewed-on: https://chromium-review.googlesource.com/1166751 > > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581827} > > Bug: 860581 > Change-Id: If155ed6aedda2c7256f3ab707d4d335eeab26b6f > Reviewed-on: https://chromium-review.googlesource.com/1169795 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=ortuno@chromium.org,loyso@chromium.org,tandrii@chromium.org,dominickn@chromium.org Change-Id: I8c9475f3ed6ddb87bc09c0b1f8317147134ecbb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860581 Reviewed-on: https://chromium-review.googlesource.com/1169928Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 72bd9335. Reason for revert: breaks test. Original change's description: > [iOS] Using UnifiedConsentService::SetUnifiedConsentGiven() in the settings > > This CL enables unified consent given when the user signs in to Chrome. > This CL also disabled and enables unified consent given when the user > toggles the corresponding switch on and off in the Sync and other services > settings screen. > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5384052f4abe117e7816733e45dc4091afe55708 > Reviewed-on: https://chromium-review.googlesource.com/1165151 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581873} TBR=msarda@chromium.org,jlebel@chromium.org,sczs@chromium.org,tangltom@chromium.org Change-Id: I057d4085ebfb55e08e7a06d7e0cc0fbdedfaf36c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1170003Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581907}
-
Cathy Li authored
Change-Id: I8086423200b43d771ad800c84ef8c1795ef18b56 Reviewed-on: https://chromium-review.googlesource.com/1168285 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581906}
-
Nico Weber authored
Reverts https://codereview.chromium.org/2519803003 , it shouldn't be needed with lld. (Running `ninja -t msvc` directly means ninja doesn't have to be in PATH, since then clause 1 of how CreateProcessA() finds binaries can take effect: 1. The directory from which the application loaded. Due to the delete, `ninja -t msvc` was run under `cmd /c`, which means we did require ninja in PATH only for official builds. This removes this exception. But we're also making sure ninja is in PATH for now until crbug.com/872740 is resolved, so this change is more a defense-in-depth thing.) Bug: 665773,828472,828466 Change-Id: Ic86b255df1544fcb4744ff4d2bf1f3f0b25119c3 Reviewed-on: https://chromium-review.googlesource.com/1169302Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581905}
-
Oriol Brufau authored
They are implemented behind the CSSLogical runtime flag. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ Spec: https://drafts.csswg.org/css-logical/#directional-keywords BUG=850004 TEST=external/wpt/css/css-logical/logical-values-float-clear.html TEST=external/wpt/css/css-logical/logical-values-resize.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ieede2703368a44f3ce9996e917857226795ebaea Reviewed-on: https://chromium-review.googlesource.com/1163667Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#581904}
-
Matthew Jones authored
This patch fixes an issue with the bottom toolbar when entering fullscreen while the keyboard is visible. To conserve space while the keyboard is showing, the bottom controls height is set to 0 and reset when the keyboard is hidden. This does not account for fullscreen mode, so when the keyboard is hidden it blindly tells the controls to become visible again. This patch adds logic to update the bottom toolbar when the controls height is restored and only conditionally shows the toolbar if another browser feature isn't blocking it. Bug: 872323 Change-Id: Ic3f33fcd7ae207415a5d36b56dba86ec216d3a51 Reviewed-on: https://chromium-review.googlesource.com/1167997Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581903}
-
Sammie Quon authored
Test: manual Bug: 871985 Change-Id: I3747ce934f186acd677252ce22d748f4fe853907 Reviewed-on: https://chromium-review.googlesource.com/1166326 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581902}
-
Justin Cohen authored
Bug: 872788 TBR: rohitrao Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I55e2ba91fe5cbd0ef170d7a34d7e5104b7de735a Reviewed-on: https://chromium-review.googlesource.com/1169318 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581901}
-
Ned Nguyen authored
This is a reland of 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9 Original change's description: > Add perf/core/bot_platforms.py file that contain metadata about all perf builders > > Bug:871746,863768 > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8 > Reviewed-on: https://chromium-review.googlesource.com/1169127 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> Bug: 871746, 863768 Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi TBR=perezju@chromium.org Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797 Reviewed-on: https://chromium-review.googlesource.com/1169882Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581900}
-
Boris Sazonov authored
This CL disables EnableAndStopTracingWithEmptyFile and DoubleStopTracing from TracingControllertest, as they are flaky on Android. Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23169 TBR=oysteine@chromium.org Bug: 872631 Change-Id: I55612d42712a9867fce271efdefc920139a6972d Reviewed-on: https://chromium-review.googlesource.com/1169209Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581899}
-
Justin DeWitt authored
Change-Id: I5cb3c934aece88cadbd909e5162093b5b49903c7 Reviewed-on: https://chromium-review.googlesource.com/1169623 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator for //chrome/common, and fixes all compile errors after that. After this CL, Mojo interfaces there service starts using base::OnceCallback instead of base::Callback on its return value handling. Bug: 714018 Change-Id: I70823c7a0ca0032fa3223e2a2926d37acc8f6523 Reviewed-on: https://chromium-review.googlesource.com/1152342Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
-
Jun Mukai authored
Some windows, including tab-dragging window, want to suppress the window animations. This property needs to be propagated to Ash to take an effect. BUG=867074 TEST=manually Change-Id: I80847702e26cd04981cac71b02114389312d83e1 Reviewed-on: https://chromium-review.googlesource.com/1166331Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581896}
-
manuk authored
Previously, the results popup shadow color was kGoogleGrey800 (#3C4043) for both incognito and normal windows. This shadow was difficult to detect on incognito's dark new tab page. This changes the shadow color for incognito windows to black (#000). This change only affects material refresh. The results popup uses BubbleBorder to draw its border, including its shadow. BubbleBorder can be provided a shadow elevation to determine the size of its shadow, or else it will provide a default shadow. Additionally, BubbleBorder shadows consider the material refresh flag. Elevated refresh shadows (e.g. refresh flag is on and elevation is 3 or 16) are delegated to ShadowValue::MakeRefreshShadowValues. Elevated non-refresh shadows (e.g. refresh flag is off or elevation is neither 3 nor 16) are delegated to ShadowValue::MakeMdShadowValues. Un-elevated shadows are constructed inline within BubbleBorder::GetShadowValues. Previously, ShadowValue::MakeRefreshShadowValues shadows were kGoogleGrey800, while ShadowValue::MakeMdShadowValues and BubbleBorder::GetShadowValues shadows were SK_ColorBLACK. This cl adds the ability to set custom shadow colors for all 3 shadow constructions. If no color is set, SK_ColorBLACK is used by default, this is consistent with all current usages of ShadowValue and BubbleBorder. Bug: 866054 Change-Id: I6d592f290daf41a6a083e7e6214c0a30dfdfb68f Reviewed-on: https://chromium-review.googlesource.com/1165794 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Bence Béky authored
Use CompletionOnceCallback instead of CompletionCallback, and CancelableCompletionOnceCallback instead of CancelableCompletionCallback in //content/browser/appcache. Bug: 807724 This exact CL has been reviewed and approved at https://crrev.com/c/1163933. However, due to a bug in Gerrit, I inadvertently submitted that CL skipping the CQ. See https://crbug.com/872722. That CL was reverted, and now I am relanding it properly in this CL, through CQ this time. Original reviewer is TBR'd. TBR=kinuko@chromium.org Change-Id: Ie1d8e275e754cc51457aca6537ad08b228cfaaac Reviewed-on: https://chromium-review.googlesource.com/1169307Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581894}
-
Tim Song authored
This makes the behaviour consistent with BLE advertisement on ChromeOS. Change-Id: I8405f5fafc6f29874abf7e988d6828d7d03828ad Reviewed-on: https://chromium-review.googlesource.com/1162689 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#581893}
-
Mark Pearson authored
and extend date of another omnibox histogram. Bug: 871485 Change-Id: Ied602a6df0748faa501112c2a0dfcd38dab49071 Reviewed-on: https://chromium-review.googlesource.com/1166192Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#581892}
-
