- 22 Jun, 2017 40 commits
-
-
Marijn Kruisselbrink authored
Rather than erasing the LevelDBWrapperImpl as soon as the last mojo connection to it is closed, keep around unused wrappers, and only delete them when new connections are opened, if too many wrappers are around. This more closely resembles the behavior of the old localstorage implementation, and should have a performance improvement in certain situations. It does come with a slight memory penalty, but not worse than the old implementation. Bug: 730475 Change-Id: I258dc4218f88167a19fc103cd581bf3e9567f901 Reviewed-on: https://chromium-review.googlesource.com/541815 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#481725}
-
Scott Graham authored
Links but 25/80 tests crash. Bug: 734791 Change-Id: I0e53a60c33ec016bb051b661eaa398d246b6d5eb Reviewed-on: https://chromium-review.googlesource.com/540288Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#481724}
-
Renjie Liu authored
I'm exposing a RecordLanguageDetection API in translate_client so different platforms can handle record language detection uniformly. Bug: 722679 Change-Id: I6df293b7d7d6ef81ffd5f46cb0885a28bf4bef19 Reviewed-on: https://chromium-review.googlesource.com/523882Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481723}
-
Darren Shen authored
This patch removes direct references to: - StyleRareNonInheritedData - StyleWillChangeData - StyleGridItemData - StyleFlexibleBoxData and replaces them with internal accessors. Bug: 710938 Change-Id: I757411ece02c28a3e3fb8bad0f29537594db4ebb Reviewed-on: https://chromium-review.googlesource.com/544635Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#481722}
-
Matt Falkenhagen authored
Help debugging for PlzNavigate regression. We want to see if SW-controlled loads make an outsized contribution to the PlzNavigate FowardBack regression. See bug, comment 64. Bug: 705318 Change-Id: I28136ee2a1e220a6d9584b168fe13308434cc55f Reviewed-on: https://chromium-review.googlesource.com/541257 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481721}
-
warx authored
Changes: (1) app list item view, which is used for all apps grid view, has the same tile layout (icon, title, and their paddings) requirement as start page recommended apps tile. (2) fix recommended apps tile title width issue: it has 80px width requirement, we just need to set left and right 8px insets for it. R=xiyuan@chromium.org CC=newcomer@chromium.org, weidongg@chromium.org BUG=735702 TEST=tested with and without --enable-features=EnableFullscreenAppList flag Review-Url: https://codereview.chromium.org/2945343003 Cr-Commit-Position: refs/heads/master@{#481720}
-
avi authored
BUG=689520 Review-Url: https://codereview.chromium.org/2953633002 Cr-Commit-Position: refs/heads/master@{#481719}
-
dgozman authored
BUG=734762 Review-Url: https://codereview.chromium.org/2952023003 Cr-Commit-Position: refs/heads/master@{#481718}
-
Darren Shen authored
Currently, column-rule related properties are being stored as a single BorderValue called ColumnRule. However, it is possible to split ColumnRule into its constituent fields and generate each of them individually. There should be no performance impact from this patch. Diff: https://gist.github.com/955fa418e240be79c0521d7d53e26ca7/revisions Bug: 628043 Change-Id: I31db806f2fc427eb996ba78ef56dce17e5bc83d5 Reviewed-on: https://chromium-review.googlesource.com/544479Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#481717}
-
varkha authored
Store kPreferredSize property in an aura::Window when Chrome browser frame is updated upon BrowserView::Layout(). Retrieve it in CustomFrameViewAsh::GetMinimumSize() to ensure that in Mus the browser window frame honors window size constraints. This only affects chrome browser frame when running with --mash. BUG=728455 TEST=BrowserNonClientFrameViewAshTest.FrameMinSizeIsUpdated CustomFrameViewAshTest.HonorsMinimumSizeProperty Review-Url: https://codereview.chromium.org/2914793005 Cr-Commit-Position: refs/heads/master@{#481716}
-
Luna Lu authored
Added two entries to separately count: http header and iframe allow attribute. Also fix bug for including type attribute in <enum> in enums.xml Change-Id: I065ba516445c065c1d11cafc55591299f5c01d64 Reviewed-on: https://chromium-review.googlesource.com/535995 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#481715}
-
Robert Hogan authored
"For the ellipsis value implementations must hide characters and atomic inline-level elements at the end edge of the line as necessary to fit the ellipsis, and place the ellipsis immediately adjacent to then end edge of the remaining inline content." - https://drafts.csswg.org/css-ui/#text-overflow Bug: 534798 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I39e39e17bcb8fbafd862822f9633faa8adb33d88 Reviewed-on: https://chromium-review.googlesource.com/539460 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#481714}
-
kristipark authored
Bug: 729772 Change-Id: I34b16707b790f65faba01bdcc44bbd98c911b93b Reviewed-on: https://chromium-review.googlesource.com/541981 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#481713}
-
Alok Priyadarshi authored
This reverts commit c461e58e. Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/ Original change's description: > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" > > Reason for revert: > WebKit Android (Nexus4) are still broken with four failing tests: > JsToCppTest.BackPointer > JsToCppTest.BitFlip > JsToCppTest.Ping > JsToCppTest.Echo > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 > Reviewed-on: https://chromium-review.googlesource.com/538520 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480282} TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org Bug: 699569 Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506 Reviewed-on: https://chromium-review.googlesource.com/540664 Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481712}
-
eroman authored
These existed to support ProxyConfigServiceLinux, which used to require a SingleThreadTaskRunner for FILE (but was recently removed). TBR=sky@chromium.org,mkwst@chromium.org BUG=689520 Review-Url: https://codereview.chromium.org/2946343003 Cr-Commit-Position: refs/heads/master@{#481711}
-
Tom Anderson authored
The eu-strip that ships with Ubuntu Trusty segfaults when stripping a chrome binary that statically links libc++. The issue was fixed upstream at some point because the crash does not occur on Ubuntu Xenial. This CL bundles a patched eu-strip for x86_64 (and removes the x86 one that used to be in Google Cloud Storage). The issue was due to a double-free in libelf.so. The patched version simply removes the offending call to free and statically links libelf into eu-strip. This probably results in a memory leak, but this is ok for now since the utility is a very short-lived process. BUG=593874 R=dpranke@chromium.org,thestig@chromium.org TBR=thakis@chromium.org Change-Id: I2085c4f6278cffbaeae972545280ebb437a8bdc0 Reviewed-on: https://chromium-review.googlesource.com/544798 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481710}
-
Shakti Sahu authored
Bug: Change-Id: Icc4c9740a70c95d8137692638438b1506eda4979 Reviewed-on: https://chromium-review.googlesource.com/542936 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#481709}
-
Nick Ward authored
This code is an unused duplicate of third_party/catapult/common/py_trace_event. The only code that used this copy of the py_trace_event library was removed here: https://codereview.chromium.org/1290113003 Bug: Change-Id: Iac39091c22f38cea92724b8adc77e03be2e0c1ea Reviewed-on: https://chromium-review.googlesource.com/543566Reviewed-by:
David Tu <dtu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Case <mikecase@chromium.org> Commit-Queue: Nick Ward <npward@google.com> Cr-Commit-Position: refs/heads/master@{#481708}
-
Charles Harrison authored
Bug: 689992 Change-Id: Idcc8123a17c44ff3bac30237a60d70532254d7f7 Reviewed-on: https://chromium-review.googlesource.com/541642Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481707}
-
Stephen Martinis authored
The bots are imbalanced, and a referenc build is expiring. This CL shuffles around some benchmarks. Specifically, the following benchmarks will probably shift: * v8.runtime_stats.top_25 * page_cycler_v2.basic_oopif TBR=nednguyen Bug: 736089 Change-Id: Icf50165a37a437f59492e61d5ee0aec0ab892542 Reviewed-on: https://chromium-review.googlesource.com/545157Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#481706}
-
Marijn Kruisselbrink authored
No implementation for BytesProvider so no data is actually being transported, but this does contain the bulk of the logic of converting BlobDataItems to mojo DataElement, combining byte elements, and optionally embedding data in the byte elements. Bug: 611935 Change-Id: Iccd789c03130c03549d1a00866af05d7c958434b Reviewed-on: https://chromium-review.googlesource.com/517254 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#481705}
-
Kenichi Ishibashi authored
It seems there was an intention of merging lexer/parser for PPAPI IDL and WebIDL but no one has been working on it recently. PPAPI has its own lexer/parser in ppapi/generators. Blink is the only user of tools/idl_parser in the code base with some custom extensions (See third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py). The grammar of WebIDL has been actively changing and maintaining both idl_parser.py and blink_idl_parser.py is troublesome. Let's remove PPAPI support from tools/idl_parser so that we can easily keep the parser up-to-date. BUG=617899 Change-Id: Ia4b8c7918245cce57c7a14326e5fc5c48ba42127 Reviewed-on: https://chromium-review.googlesource.com/544401Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#481704}
-
warx authored
BUG=none TBR=xdai@chromium.org TEST=chrome doesn't crash Review-Url: https://codereview.chromium.org/2954563002 Cr-Commit-Position: refs/heads/master@{#481703}
-
dgozman authored
BUG=734762 Review-Url: https://codereview.chromium.org/2950193003 Cr-Commit-Position: refs/heads/master@{#481702}
-
Andrew Moylan authored
This is just some typos and other small fixups I noticed while reading these docs. Only substantial thing is probably this rename which I think is appropriate but please confirm: s/InterfaceRegistry/BinderRegistry Change-Id: I2c9f712b87a45d9d1f66f5e8cc053fa4e9751e2e Reviewed-on: https://chromium-review.googlesource.com/544639Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481701}
-
Danyao Wang authored
NavigationManagerImpl::GetPreviousItemIndex is a wrapper around |CRWSessionController previousItemIndex|. This can actually be -1, so the return type should be int not size_t. This mistake was introduced in https://codereview.chromium.org/2944093002. Added a unit test to verify this edge case. Moved the method to public section to allow access in test. Bug: 734150 Change-Id: I3f70635ccb62ae205fcef6dc2d9b8813ed872a99 Reviewed-on: https://chromium-review.googlesource.com/544626 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#481700}
-
rbpotter authored
If the default Save As PDF directory (which is the same as the user's default downloads directory) does not exist, create it before opening the select file dialog. Otherwise, the select file dialog will open in the lowest level folder on the path that already exists. BUG=718527 Review-Url: https://codereview.chromium.org/2952043002 Cr-Commit-Position: refs/heads/master@{#481699}
-
avi authored
When early-exiting NavigationControllerImpl::NavigateToPendingEntry, the interstitial page may have been created but not yet attached itself to the WebContents. In that case, because asking the WebContents for the interstitial won't work, ask the interstitial pages if any of them are attached to the desired WebContents. Even before attaching to the WebContents, the interstitial pages know that. BUG=703655 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2953513002 Cr-Commit-Position: refs/heads/master@{#481698}
-
sque authored
BUG=715263 R=afakhry@chromium.org Review-Url: https://codereview.chromium.org/2948813002 Cr-Commit-Position: refs/heads/master@{#481697}
-
cjgrant authored
Refactoring to make the indicators easier and cleaner to manage: - Use a single parameterized class for all indicators. - Change how indicator textures are drawn, such that we only need to specify height, and the widths are computed. - In general, allow textured elements to override how their world size is computed (rather than forcing all to compute height based on width). - Dynamically position the indicators according to which are showing. BUG= Review-Url: https://codereview.chromium.org/2950173002 Cr-Commit-Position: refs/heads/master@{#481696}
-
Hidehiko Abe authored
BUG=None TEST=Built locally. Ran trybots. Change-Id: I97c13c15877ae48e03556a6ff1dfce7bc5e8f1d7 Reviewed-on: https://chromium-review.googlesource.com/544723Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#481695}
-
Matthew Jones authored
This reverts commit dc4f1d73. Reason for revert: testCloseNTP became flaky. Original change's description: > [Home] Implement new tab creation animation from tab switcher > > This change introduces the animation for creating a new tab from the > tab switcher. A previously unused code path through StackLayout has > been replaced by the logic for this animation. The primary additions > are as follows: > > - New tab slides up in 300ms. > - Existing tabs in stack move to top of screen. > - Landscape mode excludes this animation. > > BUG=731294 > > Change-Id: Iedb542f08eb75bbb50f33eee4bf5e113d4d05c56 > Reviewed-on: https://chromium-review.googlesource.com/541917 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481636} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: Iee7028fda3fc6d7dc4fbca614f9abcc4f906811d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731294 Reviewed-on: https://chromium-review.googlesource.com/545179Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#481694}
-
Bryan Henry authored
This already isn't necessary on Android TV builds based on where the flag is used, and we don't want this default for Android Things builds. BUG=internal b/62633642 TEST=Builds. Change-Id: Ie571a5d9ef3a7f8f08ac71346165d828c734e848 Reviewed-on: https://chromium-review.googlesource.com/541864Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Commit-Queue: Bryan Henry <bryanhenry@google.com> Cr-Commit-Position: refs/heads/master@{#481693}
-
erikchen authored
Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. To support machines running macOS versions < 10.12, but don't require building targets, this CL also: * Does not download the hermetic toolchain if the macOS version does not support the toolchain version. * Does not allow building targets with the default hermetic toolchain if the macOS version does not support the toolchain version. BUG=624049 Review-Url: https://codereview.chromium.org/2950933003 Cr-Original-Commit-Position: refs/heads/master@{#481225} Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e Review-Url: https://codereview.chromium.org/2950933003 Cr-Commit-Position: refs/heads/master@{#481692}
-
eroman authored
ProxyConfigServiceLinux. BUG=689520 TBR=jochen@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2944313003 Cr-Commit-Position: refs/heads/master@{#481691}
-
oshima authored
BUG=704929 TEST=covered by unit test Review-Url: https://codereview.chromium.org/2950083002 Cr-Commit-Position: refs/heads/master@{#481690}
-
David Benjamin authored
This reverts commit af16f316. Reason for revert: Speculative revert to see if it fixes crbug/735659. Original change's description: > Don't take a mutex around certificate verifications on Android. > > We use a worker pool to verify certificates, but then undo it all in > Android by locking around the entire operation. However, Android's > X509TrustManager implementations are already thread-safe. We do some > work on top which must be synchronized, mostly around reloading various > caches. > > Instead, lock only around acquiring the current instance of the caches. > When we need to invalidate, we drop the pointer. Any pending tasks > will continue using the old state (as they would have before this > change as they'd be holding the lock), but all verifications after the > invalidation will use a fresh set of state. > > A completely unscientific (I checked about:histograms after startup) > suggest that this speeds up the mean startup cert verification time > by about 40%. > > Bug: > Change-Id: I3cddb798f3dfd51a2f1d2e529127c39f521e93de > Reviewed-on: https://chromium-review.googlesource.com/531973 > Reviewed-by: Matt Mueller <mattm@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480472} TBR=davidben@chromium.org,mattm@chromium.org Bug: 735659 Change-Id: Ib84eb5b0a03d674565a075ad1003828904aebe24 Reviewed-on: https://chromium-review.googlesource.com/545057Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#481689}
-
Tien-Ren Chen authored
This is a reland of afc31e81 Fixed Windows x64 build failure. DLL export needs to be specified on individual explicit template instantiation: https://docs.microsoft.com/en-us/cpp/cpp/general-rules-and-limitations Original change's description: > [SPv2] Rework GeometryMapper transform computation > > When computing the conversion matrix between two spaces, there are two > types of conversion that are commonly used, but with slightly different > semantics: > > m1 = destination_to_screen ^ -1 * source_to_screen > m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen) > > The former computes the space conversion, which is useful for mapping > 3D points from one space to 3D points in another space. The latter > computes the "projection through screen", which is useful for mapping > 2D points from a plane to a backing that is expected to be drawn onto > the screen. > > To illustrate the difference, see the following example: > <div style="transform:rotateY(45deg)">A</div> > <div style="transform:rotateY(-45deg)">B</div> > > The space conversion from A to B is equal to rotateY(90deg), but the > projection between the two planes is identity. > > Prior to this CL, GeometryMapper implemented a mixed semantics. This is > okay because all existing code only make queries that are co-planar, in > which case, either version returns identical result. This is because we > only make intra-compositing-layer queries, and 3D transform makes a > compositing boundary. > > This CL changed the implementation to strictly return the "projection > through screen". The algorithm runs in amortized O(1) by caching the > matrix between a node and its nearest coplanar ancestor that has a > invertible projection. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93 > Reviewed-on: https://chromium-review.googlesource.com/534899 > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Reviewed-by: Chris harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481049} Change-Id: I067a0f40f2e41a9fc282c4014975f144417d7d3b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/543897 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481688}
-
tommycli authored
Enabled by feature flag only. Only trims out HTTPs, since we already trim HTTP, and other schemes do not seem appropriate to trim out. BUG=732582 TEST=unit and manual Review-Url: https://codereview.chromium.org/2940973002 Cr-Commit-Position: refs/heads/master@{#481687}
-
fsamuel authored
Revert of [Offline Pages] Cleans up DEPS in offline_pages (patchset #2 id:20001 of https://codereview.chromium.org/2950113002/ ) Reason for revert: This seems to have broken checkdeps Original issue's description: > [Offline Pages] Cleans up DEPS in offline_pages > > This moves DEPS into prefetch that were put on core. > > BUG=NONE > > Review-Url: https://codereview.chromium.org/2950113002 > Cr-Commit-Position: refs/heads/master@{#481555} > Committed: https://chromium.googlesource.com/chromium/src/+/4bd9a54564189647e023fce848681bfd82ca4d01 TBR=jochen@chromium.org,dimich@chromium.org,dewittj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Review-Url: https://codereview.chromium.org/2948923004 Cr-Commit-Position: refs/heads/master@{#481686}
-