GitLab

The purpose is to test CPU usage and vital WebRTC stats over a
longer, more taxing call. Also updates all pages since the GitHub
location has moved again.

BUG=436361

Review URL: https://codereview.chromium.org/962113003

Cr-Commit-Position: refs/heads/master@{#319623}

[Cronet] Make sure to only pass the application Context to InitApplicationContext to avoid DCHECK failures.

An application may have multiple Contexts but only one application Context.  InitApplicationContext DCHECKs if passed more than one Context, so make sure to always pass it only the application Context.
Also, clean up other uses of Contexts in Cronet to only use the application Context when necessary.  Unnecessarily using the application Context was hiding the bug this CL fixes.  I'm renaming variables to make it clear where an application context is needed versus where any Context is okay.  It's good practice to use the Context explicitly passed in as the wrapping it provides may add additional functionality on top of wrapped Contexts and the application Context.
Also, add a test that Cronet can be simultaneously instantiated upon a Context, a wrapped version of the Context and the application Context to verify Cronet doesn't DCHECK.

BUG=453845

Review URL: https://codereview.chromium.org/981013002

Cr-Commit-Position: refs/heads/master@{#319622}

This was causing a crash in Blink with some Chrome Android UI pages. These
pages would disable top controls by setting the height to 0 but when we
scroll the page we calculate the "shown ratio" by dividing by height. This
the divided-by-0 value made its way down to Blink.

BUG=460007

Review URL: https://codereview.chromium.org/982333003

Cr-Commit-Position: refs/heads/master@{#319621}

Revert of Add policy_templates target for GN. (patchset #3 id:40001 of https://codereview.chromium.org/957283003/)

Reason for revert:
Seems to have broken (at least) the Mac GN build:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg)

Original issue's description:
> Add policy_templates target for GN.
>
> BUG=462362
>
> Committed: https://crrev.com/f24e2a468f0fffe65f626ba5d7c4c0089a78a65e
> Cr-Commit-Position: refs/heads/master@{#319616}

TBR=pneubeck@chromium.org,bauerb@chromium.org,knn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462362

Review URL: https://codereview.chromium.org/994533003

Cr-Commit-Position: refs/heads/master@{#319620}

Swap sdefresne@ instead of blundell@ and droger@ as temporary OWNERS of
chrome/browser/favicon during the componentization of the feature.

BUG=359513

Review URL: https://codereview.chromium.org/985073002

Cr-Commit-Position: refs/heads/master@{#319619}

BUG=443095

Review URL: https://codereview.chromium.org/974463002

Cr-Commit-Position: refs/heads/master@{#319618}

As pointed out in https://codereview.chromium.org/906973007/diff/80001/chrome/browser/password_manager/password_store_x.cc#newcode157, instead of overriding Get*LoginsImpl in PasswordStoreX, it is enough to rely on the PasswordStoreDefault implementation of those methods to use PasswordStoreX::Fill*Logins.

The only current difference is that in addition to what Fill*Logins do, PasswordStoreX::Get*LoginsImpl also sorted the logins by origin, to match the order of the login database. There are two ways to fix this:
(1) Move the sorting from Get*LoginsImpl to Fill*Logins.
(2) Drop the sorting.

This CL chose (1). This means that now also PasswordSyncableService::ReadFromPasswordStore, which currently gets the logins unsorted, will perform the sorting. This call should be infrequent enough for this not to be noticeable.r

While (2) would also not break the insides of the password manager, it would degrade the UI (try to find a login in an unsorted list of them). For the reference, the CL which added the sorting was https://codereview.chromium.org/6953010.

BUG=324291

Review URL: https://codereview.chromium.org/986983002

Cr-Commit-Position: refs/heads/master@{#319617}

BUG=462362

Review URL: https://codereview.chromium.org/957283003

Cr-Commit-Position: refs/heads/master@{#319616}

We don't use one on windows either, and e.g. for running V8 compile
jobs, we need a higher stack size limit than we currently have. Instead
of guessing a value, let's just use the default.

BUG=464538
R=mark@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/992623002

Cr-Commit-Position: refs/heads/master@{#319615}

BUG=464837

Review URL: https://codereview.chromium.org/983283002

Cr-Commit-Position: refs/heads/master@{#319614}

BUG=451004,464993

Review URL: https://codereview.chromium.org/976313003

Cr-Commit-Position: refs/heads/master@{#319613}

Cr-Commit-Position: refs/heads/master@{#319612}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cedc36f..1b110d6

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/989193002

Cr-Commit-Position: refs/heads/master@{#319611}

WebRTC 8646:8649
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a2bd4b8..b4c07a0

TBR=

Review URL: https://codereview.chromium.org/994503002

Cr-Commit-Position: refs/heads/master@{#319610}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/27dc83a..9434cdf

TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/987013002

Cr-Commit-Position: refs/heads/master@{#319609}

The tests are tagged for rebaseline in Blink now, new results trickling
in.

BUG=458898
TBR=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/990103002

Cr-Commit-Position: refs/heads/master@{#319608}

Previously, the callback would be run when a new Profile object was instantiated, even when the profile already existed on disk. This would have the effect of reopening windows for closed profiles, when we just want to preload the profile on Mac.

BUG=463898

Review URL: https://codereview.chromium.org/961863006

Cr-Commit-Position: refs/heads/master@{#319607}

Looks like nobody is using this target according to
https://code.google.com/p/chromium/codesearch#chromium/src/build/all.gyp&q=chromium_builder_perf_av&sq=package:chromium&l=645

BUG=224072
TEST=trybots
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/984363002

Cr-Commit-Position: refs/heads/master@{#319606}

BUG=464890
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/980423003

Cr-Commit-Position: refs/heads/master@{#319605}

BUG=464030

Review URL: https://codereview.chromium.org/984073003

Cr-Commit-Position: refs/heads/master@{#319604}

 menuitem

The condition to check the status of "resume" was wrong. This patch fixes it by flipping the condition.

BUG=465193
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/991753002

Cr-Commit-Position: refs/heads/master@{#319603}

This is a clean up CL and should not change any behavior.

BUG=none
TEST=browsertest passes

Review URL: https://codereview.chromium.org/984593002

Cr-Commit-Position: refs/heads/master@{#319602}

NOTRY=true
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org
BUG=465187

Review URL: https://codereview.chromium.org/989183002

Cr-Commit-Position: refs/heads/master@{#319601}

Cr-Commit-Position: refs/heads/master@{#319600}

BUG=449754
R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/988243002

Cr-Commit-Position: refs/heads/master@{#319599}

BUG=458898
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/926403002

Cr-Commit-Position: refs/heads/master@{#319598}

This is dependent on https://codereview.chromium.org/965903003/

BUG=377250

Review URL: https://codereview.chromium.org/968663004

Cr-Commit-Position: refs/heads/master@{#319597}

BUG=413437

Review URL: https://codereview.chromium.org/990503002

Cr-Commit-Position: refs/heads/master@{#319596}

The NSView hosting composited UI was stealing hit tests used for
accessibility. This CL makes the compositor superview unhittable.

An integration test is added. Implement [AXPlatformNodeCocoa AXTitle]
which is needed anyway and gives the test something to check for.

BUG=462133

Review URL: https://codereview.chromium.org/976403004

Cr-Commit-Position: refs/heads/master@{#319595}

Cr-Commit-Position: refs/heads/master@{#319594}

BUG=463892

Review URL: https://codereview.chromium.org/985343002

Cr-Commit-Position: refs/heads/master@{#319593}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/82966b5..cedc36f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/989053002

Cr-Commit-Position: refs/heads/master@{#319592}

Tested with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn egl
$ gn check out-gn //gpu/gles2_conform_support/egl/*

BUG=None
TEST=see above
R=dpranke@chromium.org
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/988053002

Cr-Commit-Position: refs/heads/master@{#319591}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ceb9cf3c..1fbbd4ac

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/990013002

Cr-Commit-Position: refs/heads/master@{#319590}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/51bf7a79..ceb9cf3c

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/989853003

Cr-Commit-Position: refs/heads/master@{#319589}

To support Clients.matchAll(options)

* Add ServiceWorkerClientQueryOptions param to GetClients IPC msg (renderer -> browser)
* Add client_type field to ServiceWorkerClientInfo for DidGetClients IPC msg (browser -> renderer)

Spec links:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworker-client-query-options-dictionary
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-getall

1/2: https://codereview.chromium.org/958933004/ (blink)
2/2: THIS PATCH

BUG=455241,460415
TEST=to be added after we add actual impl

Review URL: https://codereview.chromium.org/970693003

Cr-Commit-Position: refs/heads/master@{#319588}

BUG=133097

Review URL: https://codereview.chromium.org/982643003

Cr-Commit-Position: refs/heads/master@{#319587}

WebRTC 8643:8646
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/d6bd5e2..a2bd4b8

This roll includes a fix for the build configuration issue we ran into on Mac debug.

TBR=

Review URL: https://codereview.chromium.org/990703002

Cr-Commit-Position: refs/heads/master@{#319586}

Cr-Commit-Position: refs/heads/master@{#319585}

No behavior change.

BUG=none

Review URL: https://codereview.chromium.org/985403002

Cr-Commit-Position: refs/heads/master@{#319584}