- 20 Feb, 2019 40 commits
-
-
Eli Ribble authored
Reland commit f4f6c5ff Revert was 172ccc05 The previous attempt at a reland changed FetchGitRevision which caused breakage when chrome/test/chromedriver/embed_version_in_cpp.py attempted to call this function. https://crrev.com/c/1459921 was recently merged which completely removed embed_version_in_cpp.py which should allow this change to re-land without modification from the previous attempt at a reland. Change-Id: I0dbd7436938ae27167a9381415277d95d0d8312f Bug: 917159 Reviewed-on: https://chromium-review.googlesource.com/c/1460454Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#633730}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e3080f52cbc..177cd13347a9 git log 9e3080f52cbc..177cd13347a9 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@177cd13347a9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b42a11dbc628c41347c592a1a471d3659680edf Reviewed-on: https://chromium-review.googlesource.com/c/1477401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633729}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this avoids is: third_party/blink/renderer/modules/filesystem/directory_reader.cc:140:21: error: declaration shadows a local variable [-Werror,-Wshadow] EntryHeapVector entries; ^ third_party/blink/renderer/modules/filesystem/directory_reader.cc:136:57: note: previous declaration is here void DirectoryReader::AddEntries(const EntryHeapVector& entries) { ^ third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc:248:37: error: declaration shadows a local variable [-Werror,-Wshadow] Vector<ScriptPromise> result; ^ third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc:238:32: note: previous declaration is here base::File::Error result, ^ Bug: 923510 Change-Id: Ib907382435b0d1417e9ca2f070bfb68ef591e123 Reviewed-on: https://chromium-review.googlesource.com/c/1478871 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#633728}
-
Nate Fischer authored
No change to logic. This proposes an OWNERS file for WebView's net-service-specific code, and makes Tim and I owners (since we're the primary engineers for the WebView-specific work). R=timvolodine@chromium.org, tobiasjs@chromium.org Bug: 841556 Test: N/A Change-Id: Id2b8ed4e9229b1ec18336821c2aa257183a3d122 Reviewed-on: https://chromium-review.googlesource.com/c/1478352Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#633727}
-
Mike West authored
Rather than sending a `Sec-CH-UA` header containing the full version number by default (e.g. "Chromium 99.0.1232.12"), send only the major version (e.g. "Chromium 99"). This does not effect the value of `UserAgent.version` obtained from `navigator.getUserAgent()`, but only the HTTP request header. Bug: 928669 Change-Id: I074e244a3918b0bdab4453c2f56dc737c506f732 Reviewed-on: https://chromium-review.googlesource.com/c/1475438Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#633726}
-
David Roger authored
This CL fixes an edge case where multilogin flow and merge session flow were behaving differently. The right behavior is the multilogin one. Bug: none Change-Id: Id815b6089dca48f51d712653801538b51212914e Reviewed-on: https://chromium-review.googlesource.com/c/1477605Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#633725}
-
Mohamed authored
This change removes the member is_external_protocol and changes the getter to get it directly from the GetContentClient. Change-Id: Iec3ac802bbf051e4f295b765bc4385114739d611 Bug: 916537 Reviewed-on: https://chromium-review.googlesource.com/c/1477697Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#633724}
-
edchin authored
This enables by default an experiment that uses the faster |-drawViewHierarchyInRect:| instead of |-renderInContext:|. TEST=Ensure that snapshots entering/exiting the tab grid look good. Test NTP, "No internet connection" page, and sad tab page. Bug: 636188 Change-Id: I8f482ce189a89a578ed79f4b6add7a303cbfb327 Reviewed-on: https://chromium-review.googlesource.com/c/1450973Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633723}
-
chrome://settingsLucas Tenório authored
This change adds a button that toggles the Contained Shell pref and signs out the current user. Since this is a rough transition, we are also adding a dialog that warns users that we need to sign them out. Bug: 922687 Change-Id: I88f161ee7bfd2e1f26c00840c6ac66c65d8eed64 Reviewed-on: https://chromium-review.googlesource.com/c/1471110 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#633722}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca145bec7f33..bc42944741bc git log ca145bec7f33..bc42944741bc --date=short --no-merges --format='%ad %ae %s' 2019-02-20 robertphillips@google.com Switch image filters over to GrRecordingContext Created with: gclient setdep -r src/third_party/skia@bc42944741bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I8dbdc887e2021c1ac41234860a781a8761eb6b25 Reviewed-on: https://chromium-review.googlesource.com/c/1477398Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e82643fb9c64..109b5fb5f5b2 git log e82643fb9c64..109b5fb5f5b2 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 mbonadei@webrtc.org Revert "Extend TransportSequenceNumber RTP header extension" 2019-02-20 kron@webrtc.org Extend TransportSequenceNumber RTP header extension 2019-02-20 eshr@google.com Clarify that pacing rate is based on raw target rate 2019-02-20 srte@webrtc.org Adds support for VP8 simulcast to scenario tests. 2019-02-20 eladalon@webrtc.org Create version 01 of Generic Frame Descriptor - with discardability flag 2019-02-20 titovartem@google.com Add a task queue into pc e2e fixture implementation Created with: gclient setdep -r src/third_party/webrtc@109b5fb5f5b2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide7ab8132754ea916d5dabb2235e042cca31dccd Reviewed-on: https://chromium-review.googlesource.com/c/1477396Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/274ad0c9456b..106dac4e61d8 Created with: gclient setdep -r src-internal@106dac4e61d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I15eb7451fcecc33311cfbded56a42686a86a2a66 Reviewed-on: https://chromium-review.googlesource.com/c/1477399Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633719}
-
Nick Diego Yamane authored
Wayland compositors let clients know about keyboard layout index currently set using the "group" parameter in wl_keyboard::modifiers event[1]. Currently it is used to update the libxkbcommon modifiers mask and generate the corresponding event flags value, but is not used later on when translating keysyms into UTF characters (when xkb_state_update_modifiers function is used again). That makes the keys to be converted using incorrect layout. To fix it, this CL does the following: 1. Rename GetModifierFlags -> UpdateModifiers; modifying it to be non-const and then be able to cache 'group' value (coming from wl_keyboard::modifiers event) into the new layout_index_ class variable; 2. In XkbLookup method, pass in the previously cached layout_index_ when calling xkb_state_update_modifiers function, making the characters to be correctly converted when xkb_state_key_get_utf32 is called. [1] https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_keyboard Bug: 921947 Change-Id: I5758da5b771bd46c6a43250439b63b0911f51fbb Reviewed-on: https://chromium-review.googlesource.com/c/1474041Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#633718}
-
Alexander Timin authored
Move TaskAnnotator out of base::debug namespace (as is also runs tasks, which can be useful not only for debug but also in some other cases). Move it to base/task/common to other task posting and running infrastructure. R=gab@chromium.org TBR=gab@chromium.org Change-Id: Ia464c7476f9d8342f417f364fb2a66a87899b02b Reviewed-on: https://chromium-review.googlesource.com/c/1477894 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#633717}
-
Maksim Sisov authored
$ git log --oneline ff1ecaf...4fe3038 4fe3038 Reland "minigbm: define GBM_BO_IMPORT_FD_MODIFIER" eea88fa minigbm:amdgpu: align stride to 256 067594b minigbm: msm: Add modifier for tiled buffer allocation 90f8bb0 minigbm: Fix some clang-format issues c65bd8c minigbm: msm: Add platform specific alignment for NV12 linear format 400e928 Revert "minigbm: define GBM_BO_IMPORT_FD_MODIFIER" bc667c3 minigbm: define GBM_BO_IMPORT_FD_MODIFIER ff66c80 amdgpu: use amdgpu_gem_wait_idle_ioctl to wait for GPU to finish. 74e4893 amdgpu: Don't use AMDGPU_GEM_CREATE_EXPLICIT_SYNC flag. d7630cd amdgpu: fix misplaced code block 39eb951 minigbm: i915: Do not use I915_MMAP_WC for camera buffers 11161ac minigbm: add MINIGBM define. ee98f4e minigbm: align width so that stride aligns to 256 617ee71 minigbm: minimal buffer allocation support using msm gem ioctls 71bc665 minigbm: don't advertise BGR24 as a render/texture target 86ddfdc minigbm: use drv_add_combination when adding a single combination 2fdb721 minigbm: delete unused functions and definitions 2b1d689 minigbm: run clang-format a72f442 minigbm: mediatek: always provide munmap() with a valid address 500928f minigbm: mediatek: wait for outstanding operations when invalidating b131c9d minigbm: msm: add supported formats 571a687 minigbm/i915.c: Android's HAL_PIXEL_FORMAT_BLOB is not tilable if BO_USE_PROTECTED d706a8c minigbm: move height adjustments to helper function 79155d7 minigbm: run clang-format a13dda7 minigbm: support NV12 in virtio_gpu af94db9 minigbm: adjust height of NV12 buffer in helper Bug: 933123 Change-Id: I174363f379407697ae0d571175ecc43d4cc51d3e Reviewed-on: https://chromium-review.googlesource.com/c/1477075 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoid is: third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:313:22: error: declaration shadows a local variable [-Werror,-Wshadow] for (const auto& request_response : responses_) { ^ third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc:277:22: note: previous declaration is here RequestResponse& request_response = Bug: 923510 Change-Id: I8f6b6cd11f80a254c2c926e934dacefaa6dfccf8 Reviewed-on: https://chromium-review.googlesource.com/c/1477285Reviewed-by:Ben Kelly <wanderview@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#633715}
-
Michael Lippautz authored
The root in AbortSignal was creating the following cycle with unified heap: Request -> AbortSignal -> AbortSignal (root) -> ExecutionContext -> Request Bug: 928781,843903 Change-Id: Iefad41f37fe3ccb3960a7c3d9e1b963730aab7ec Reviewed-on: https://chromium-review.googlesource.com/c/1477241Reviewed-by:
-
Sylvain Defresne authored
Update the implementation of AutofillAutomationTestCase to use JSONReader::Read instead of JSONReader::ReadDeprecated. Bug: 925165 Change-Id: I6048349675225b82f04274b209064d258ef02ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1477226 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#633713}
-
Christian Dullweber authored
This reverts commit 8c4d384b. Reason for revert: Probably caused flakiness: https://crbug.com/933788 Original change's description: > Tracing: Re-add the Coordinator::StartTracing callback > > This effectively reverts http://crrev.com/627423 and then implements > the callback in a different way. > > The issue is that there are cases (mostly tests) that use this pattern: > 1. Start tracing > 2. Wait for BeginTracing callback > 3. Send IPC to some other child process to add trace events. > > With the tracing service now running on-demand, this would be inherently > flaky. The CL which this is reverting changed the behavior to send > the callback when the browserprocess got tracing enabled, which covers most > cases, but not all of them. > > This CL (see diff between patchset 1 and last, for the actual changes) > re-implements the central callback by leveraging service_manager callbacks > to try and wait for running services to connect back and have tracing > enabled. > > TBRing owners for files that do not include any of the new changes, > only the revert. > > R=ssid@chromium.org > TBR=yusukes@chromium.org,nasko@chromium.org > BUG=843467,929802 > > Change-Id: Ifd8e6a927a2bc3e946dde22cc7c30678e294a8dd > Reviewed-on: https://chromium-review.googlesource.com/c/1474309 > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633659} TBR=yusukes@chromium.org,nasko@chromium.org,oysteine@chromium.org,ssid@chromium.org Change-Id: I67afcf62b0637cae17281f3433cf9f630ec385ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843467, 929802, 933788 Reviewed-on: https://chromium-review.googlesource.com/c/1477682Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#633712}
-
Nicolas authored
Bug: 927455 Change-Id: I2da2e729df4d55794c8342390a061c01b759e3e5 Reviewed-on: https://chromium-review.googlesource.com/c/1478004Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#633711}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5305896e52a1..1baa5dddb7dc git log 5305896e52a1..1baa5dddb7dc --date=short --no-merges --format='%ad %ae %s' 2019-02-20 lalitm@google.com Merge "traced: don't add timestamp to clock snapshot" 2019-02-20 lalitm@google.com Merge "trace_processor: implement an iterator API and make trace to text use it" Created with: gclient setdep -r src/third_party/perfetto@1baa5dddb7dc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I079fd01ea3fcef9845661128c49b923b99fb25b3 Reviewed-on: https://chromium-review.googlesource.com/c/1477400Reviewed-by:
-
Yuwei Huang authored
This is to include my fix on gRPC for build issue on Windows+Clang+32bit architecture setup. Bug: 915790 Change-Id: I69213ef4d11c103dcb7ac38e3964d3bbcc8a373b Reviewed-on: https://chromium-review.googlesource.com/c/1477926 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#633709}
-
Lei Zhang authored
BUG=925165 Change-Id: Id8b792e3ecf77168129c4b5994db108b7c26d24a Reviewed-on: https://chromium-review.googlesource.com/c/1476412 Auto-Submit: Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#633708}
-
Edwin Joe authored
Added extra trace events in category ui, views, renderer, and renderer_host to trace events in tab switches Bug: 921120,858944 Change-Id: Ia069a04088b80d45c6128a270f5c886cd2dbb9c0 Reviewed-on: https://chromium-review.googlesource.com/c/1446868Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#633707}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 714018 Change-Id: If0230073d1b8e9f1f54985af1214ec8d005be52e Reviewed-on: https://chromium-review.googlesource.com/c/1475648 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#633706}
-
Gauthier Ambard authored
This CL changes the height of the cells, making sure that they have 48pt when they only have one line of text, 58 when they have two lines. It also unifies the different font for the subtitles to Footnote. Bug: 922511 Change-Id: I669e6de5ae8e85fed9f8da1458dd48e986c57126 Reviewed-on: https://chromium-review.googlesource.com/c/1474755Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Bruno Santos authored
Bug: 927809 Change-Id: I8d0aa79c00699f95f7e79cd673a92f39529b7d04 Reviewed-on: https://chromium-review.googlesource.com/c/1474047Reviewed-by:
-
Kent Tamura authored
crrev.com/569501 removed NEVER_INLINE macro from Blink. crrev.com/585239 added it again as WTF_NOINLINE. This CL has no behavior changes. Change-Id: I31226e874101f7f51b66a85a4e9651ecc984ed6c Reviewed-on: https://chromium-review.googlesource.com/c/1478326 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#633703}
-
Elly Fong-Jones authored
This change removes: disable-new-korean-ime enable-emoji-handwriting-voice-on-ime-menu opt-in-ime-menu and removes their backing features. It adds some TODOs for shuchen@ for places where the exact cleanup to be done was not clear to me. Bug: None Change-Id: I915d4b220a5e2a34d0bd61fc0c26d6623166c16f Reviewed-on: https://chromium-review.googlesource.com/c/1476985 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#633702}
-
Nico Weber authored
- Require semicolon after DECLARE_WEAK_IDENTIFIER_MAP - Remove semicolons after DEFINE_WEAK_IDENTIFIER_MAP - Remove semicolons after DEFINE_WEB_NODE_TYPE_CASTS - Remove semicolon after 1 of 105 instances of DEFINE_NODE_FACTORY - Remove semicolon after 1 of 10 instances of DEFINE_ELEMENT_FACTORY_WITH_TAGNAME - Rename DECLARE_EAGER_FINALIZATION_OPERATOR_NEW to DEFINE_INLINE_EAGER_FINALIZATION_OPERATOR_NEW and remove semicolons after it (renaming because DECLARE_ macros for functions usually require a semicolon and DEFINE_ macros for functions are not followed by semicolons, so this makes things a bit more consistent with other macros). Bug: 926235 Change-Id: I8afeec02aa604d1315e740de161845850950c776 Reviewed-on: https://chromium-review.googlesource.com/c/1478495 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Tim Volodine authored
Rebaseline some interfaces and properties that are exposed in Chrome and are also expected/OK to be exposed in Android WebView. In particular the following interfaces/properties: BaseAudioContext - removed methods CSSStyleSheet - methods CanvasRenderingContext2D.getContextAttributes Clipboard DOMMatrixReadOnly.scaleNonUniform Document - getters/setters Element - getters/setters GamepadButton.touched HTMLElement - getters/setters HTMLIFrameElement - getters/setters HTMLLinkElement - getters/setters HTMLMediaElement - getters/setters IDBFactory.databases InputEvent IntersectionObserver IntersectionObserverEntry Lock LockManager MediaStreamTrack - getter/setter NavigationPreloadManager Navigator - getters OffscreenCanvas OffscreenCanvasRenderingContext2D PannerNode PerformanceObserver.supportedEntryTypes PointerEvent RTCDTMFSender RTCDTMFToneChangeEvent RTCDataChannel RTCDataChannelEvent RTCError RTCErrorEvent RTCIceCandidate - getters RTCPeerConnection RTCPeerConnectionIceEvent RTCRtpReceiver RTCRtpSender RTCRtpTransceiver RTCStatsReport RTCTrackEvent ReadableStream.toStringTag ReportingObserver ResizeObserver ResizeObserverEntry SVGElement - getters/setters SVGFEBlendElement - attributes ServiceWorkerContainer.startMessages ShadowRoot - getters/setters SourceBuffer.changeType StaticRange StereoPannerNode StylePropertyMap StylePropertyMapReadOnly TextDecoderStream TextEncoder.encodeInto TextEncoderStream URL.toJSON VisualViewport WebGL2RenderingContext WebGLQuery WebGLSampler WebGLSync WebGLTransformFeedback WebGLVertexArrayObject webkitRTCPeerConnection - getters/setters webkitSpeechGrammar webkitSpeechGrammarList webkitSpeechRecognition webkitSpeechRecognitionError webkitSpeechRecognitionEvent webkitURL.toJSON window.onselectionchange window.onselectionstart window.visualViewport BUG=867450 Change-Id: I953bcaa298b529f6320a010576eb8f24ff960d6a Reviewed-on: https://chromium-review.googlesource.com/c/1475446Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#633700}
-
Wez authored
Persistent storage is now isolated between components, with a deprecated option for global persistent storage which we'll continue to use for the test sandbox in the short-term. Bug: 931860 Change-Id: I584c00b7273b863fad071692a9963f39c1ac70db Reviewed-on: https://chromium-review.googlesource.com/c/1471354Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99ac5ffb. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I13245c2586352e3d85dce8b975f2dc15fb410950 Reviewed-on: https://chromium-review.googlesource.com/c/1477395Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633698}
-
Nico Weber authored
Bug: 926235 Change-Id: I63f4c71b020e9e1dea0cab3dd5d7a21b8db872a1 Reviewed-on: https://chromium-review.googlesource.com/c/1475198 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e7d41f09a48..5305896e52a1 git log 0e7d41f09a48..5305896e52a1 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 treehugger-gerrit@google.com Merge "Protect SharedRingbuffer against concurrent manipulation." Created with: gclient setdep -r src/third_party/perfetto@5305896e52a1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I36ca9996b6048348be90f4c4f20b8eeb20426f01 Reviewed-on: https://chromium-review.googlesource.com/c/1478467Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3499d3ee975e..f20f5b94939e git log 3499d3ee975e..f20f5b94939e --date=short --no-merges --format='%ad %ae %s' 2019-02-20 cwallez@chromium.org WebGPU error handling 5: Move CmdBufBuilder logic to CmdEncoder Created with: gclient setdep -r src/third_party/dawn@f20f5b94939e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3e67a731df13b67f16c4988e097f201224382402 Reviewed-on: https://chromium-review.googlesource.com/c/1478466Reviewed-by:
-
Rayan Kanso authored
This will delete all the logged events for the background service. The upstream CL this is based on adds the ability to clear user data across all registrations. This CL also exposes a `ShouldLogEvent` function for clients to know whether they should create an event proto or not. Bug: 927726 Change-Id: I68f5419251ee29ecc130d0df712da556109e2860 Reviewed-on: https://chromium-review.googlesource.com/c/1470703 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#633694}
-
Andreea Costinas authored
This CL enables sharing EAP TLS networks with device-wide server CA and client certificates. This means EAP TLS will be available at the sign-in screen. Bug: 904362 Test: browser_tests Change-Id: I549b94bfd95067891cdee85e649110e98c7fe0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1461037 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Shortcuts need to be centered. This is achieved by insetting the cells with a computed amount. This computation used to happen in -viewWillAppear:, but in some cases the containing table view cell is not yet properly sized. So postpone this insetting to -viewDidAppear: Bug: 931210 Change-Id: Ic66a273d5337a442ccb57fda30cf0d8c370052c3 Reviewed-on: https://chromium-review.googlesource.com/c/1475751 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633692}
-
Felipe Cerqueira authored
When trying to access a blocked webpage, the child user can press Ctrl+S and save the error page (the one with the "Ask your Parent" message). If the child chooses to save the page as HTML-only (.html), the downloaded source code is the one from the blocked page. The child can then open the page locally and see the blocked content. As a workaround, we are temporarily disabling the HTML-only download of the blocked page for supervised users. They can still save the page as MHTML, which works as expected. AFTER THIS CL Normal user (unaffected): https://screenshot.googleplex.com/kipKMUOKA6r Supervised user (normal page): https://screenshot.googleplex.com/r3hQ6E1edx3 Supervised user (blocked page): https://screenshot.googleplex.com/Jqba7rhiOf2 Bug: 928323 Change-Id: I7a82cfb9194a14070910716848228ddb1faeedff Reviewed-on: https://chromium-review.googlesource.com/c/1460876 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:Carlos IL <carlosil@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633691}
-
