Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Dec, 2016 23 commits
    • yzshen's avatar
      Mojo JS bindings: introduce concepts that are more similar to C++ bindings: · 5f3032e7
      yzshen authored 
      - InterfacePtrInfo
- InterfaceRequest
- InterfacePtr
- Binding

BUG=579646

Review-Url: https://codereview.chromium.org/2549683002
Cr-Commit-Position: refs/heads/master@{#436201}
      5f3032e7
    • bnc's avatar
      Use wire values in SpdySettingsIds. · 08e5b8e4
      bnc authored 
      - Use wire values in SpdySettingsIds,
- remove SPDY/3.1-only setting values from SpdySettingsIds,
- rename ParseSettingId() to ParseSettingsId(),
- merge IsValidSettingId() into ParseSettingsId(),
- remove SerializeSettingId(),
- factor out SettingsIdToString(); remove default case
  to make sure every enum value is handled.

These values are not persisted to disk (that was a SPDY/3.1 feature),
so the only downside to the value change is Chrome net-log incompatibility.

This lands server side change 140592266 by bnc.

BUG=622737, 488484

Review-Url: https://codereview.chromium.org/2544343003
Cr-Commit-Position: refs/heads/master@{#436200}
      08e5b8e4
    • mcasas's avatar
      ShapeDetection: adding Exposed=(Window,Worker) to idls · a7ef3116
      mcasas authored 
      Because they are missing as [1] mentions.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c10

BUG=665150

Review-Url: https://codereview.chromium.org/2546293002
Cr-Commit-Position: refs/heads/master@{#436199}
      a7ef3116
    • blink-w3c-test-autoroller's avatar
      Import wpt@5915964199b07226bf6d8fbb177a63b1f272907a · dfb4c717
      blink-w3c-test-autoroller authored 
      Using update-w3c-deps in Chromium 0740b0df.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7818

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2548193002
Cr-Commit-Position: refs/heads/master@{#436198}
      dfb4c717
    • nednguyen's avatar
      [tools/perf] Disable smoke testing of system_health.memory_mobile.load:news:cnn · 5cc57314
      nednguyen authored 
      BUG=671018
TBR=perezju@chromium.org

Review-Url: https://codereview.chromium.org/2548993002
Cr-Commit-Position: refs/heads/master@{#436197}
      5cc57314
    • ynovikov's avatar
      Revert of Updating the CLD3 commit hash in DEPS (patchset #1 id:1 of... · 8377083c
      ynovikov authored 
      Revert of Updating the CLD3 commit hash in DEPS (patchset #1 id:1 of https://codereview.chromium.org/2546943002/ )

Reason for revert:
I believe this breaks https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/398
	base::WeakPtr<base::win::ObjectWatcher>::get [0x1035E083+67]
	invalid_parameter [0x66D62011+161]
	std::_String_const_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x023398F3+211]
	std::_String_iterator<std::_String_val<std::_Simple_types<char> > >::operator* [0x0233994F+15]
	chrome_lang_id::FMLParser::NextItem [0x06832F16+726]
	chrome_lang_id::FMLParser::Initialize [0x06832B1F+111]
	chrome_lang_id::FMLParser::Parse [0x068330CF+31]
	chrome_lang_id::GenericFeatureExtractor::Parse [0x06835340+48]
	?Setup@?$EmbeddingFeatureExtractor@V?$FeatureExtractor@VSentence@chrome_lang_id@@$$V@chrome_lang_id@@VSentence@2@$$V@chrome_lang_id@@UAEXPAVTaskContext@2@@Z [0x0681AD70+128]
	chrome_lang_id::NNetLanguageIdentifier::Setup [0x0681AE8C+28]
	chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06815F2F+527]
	chrome_lang_id::NNetLanguageIdentifier::NNetLanguageIdentifier [0x06816009+25]
	translate::DeterminePageLanguage [0x06A3F017+1287]
	translate::DeterminePageLanguage [0x06A3EC50+320]
	translate::TranslateHelper::PageCaptured [0x06A3D13F+335]
	ChromeRenderFrameObserver::CapturePageText [0x06874729+489]
	ChromeRenderFrameObserver::DidMeaningfulLayout [0x06874CA9+73]
	content::RenderFrameImpl::DidMeaningfulLayout [0x12BA7F73+99]
	content::RenderWidget::didMeaningfulLayout [0x12C5FC09+169]
	blink::WebViewImpl::updateAllLifecyclePhases [0x1A84A852+690]
	blink::WebViewImpl::resizeViewWhileAnchored [0x1A844719+265]
	blink::WebViewImpl::resizeWithBrowserControls [0x1A844A8E+670]
	content::RenderViewImpl::ResizeWebWidget [0x12C39199+89]
	content::RenderWidget::Resize [0x12C5AB34+756]
	content::RenderWidget::OnResize [0x12C595F2+114]
	content::RenderViewImpl::OnResize [0x12C37F54+516]
	base::DispatchToMethodImpl<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &,0> [0x12C4B006+54]
	base::DispatchToMethod<content::RenderWidget *,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),std::tuple<content::ResizeParams> const &> [0x12C4A505+53]
	IPC::DispatchToMethod<content::RenderWidget,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &),void,std::tuple<content::ResizeParams> > [0x12C4AAD6+38]
	IPC::MessageT<ViewMsg_Resize_Meta,std::tuple<content::ResizeParams>,void>::Dispatch<content::RenderWidget,content::RenderWidget,void,void (__thiscall content::RenderWidget::*)(content::ResizeParams const &)> [0x12C47F5C+300]
	content::RenderWidget::OnMessageReceived [0x12C580F7+1975]
	content::RenderViewImpl::OnMessageReceived [0x12C36F81+6561]
	IPC::MessageRouter::RouteMessage [0x0D90088A+58]
	content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage [0x109E2FF6+22]
	IPC::MessageRouter::OnMessageReceived [0x0D9005DA+58]
	content::ChildThreadImpl::OnMessageReceived [0x109E228F+1439]
	IPC::ChannelProxy::Context::OnDispatchMessage [0x0D8AD953+115]
	base::internal::FunctorTraits<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),void>::Invoke<scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A6995+37]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall IPC::ChannelProxy::Context::*const &)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context> const &,IPC::Message const &> [0x0D8A7055+53]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::RunImpl<void (__thiscall IPC::ChannelProxy::Context::*cons [0x0D8A7453+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall IPC::ChannelProxy::Context::*)(IPC::Message const &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void __cdecl(void)>::Run [0x0D8AE364+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68]
	base::debug::TaskAnnotator::RunTask [0x1008AADF+367]
	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x191CE676+1094]
	blink::scheduler::TaskQueueManager::DoWork [0x191CCDA1+737]
	base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C28ED+61]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &> [0x191C2A43+83]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::sc [0x191C2B32+114]
	base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run [0x191CEFC4+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x1008A944+68]
	base::debug::TaskAnnotator::RunTask [0x1008AADF+367]
	base::MessageLoop::RunTask [0x10105444+660]
	base::MessageLoop::DeferOrRunPendingTask [0x1010323C+44]
	base::MessageLoop::DoWork [0x10103822+242]
	base::MessagePumpDefault::Run [0x1010B4FE+190]
	base::MessageLoop::RunHandler [0x1010513C+444]
	base::RunLoop::Run [0x101B7594+52]
	content::RendererMain [0x12C789FE+830]
	content::RunNamedProcessTypeMain [0x130B0007+135]
	content::ContentMainRunnerImpl::Run [0x130AFEC8+488]
	content::ContentMain [0x130ADDE4+100]
	ChromeMain [0x02315ED8+264]

Original issue's description:
> Updating the CLD3 commit hash in DEPS
>
> The main change are:
> - a retrained model with additional script-based features
> - replacing "vector" with "std::vector"
>
> Link to the page in GitHub showing the diff:
> https://github.com/google/cld3/commit/fa5974a4d3b5e7934fcb166ff26ed6bfce68b18a
>
> BUG=670742
>
> Committed: https://crrev.com/f31c5cafc3b085a1f08ed917e518dcc1b30e175f
> Cr-Commit-Position: refs/heads/master@{#436034}

TBR=groby@chromium.org,rouslan@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670742

Review-Url: https://codereview.chromium.org/2547833004
Cr-Commit-Position: refs/heads/master@{#436196}
      8377083c
    • aleksandar.stojiljkovic's avatar
      Revert "win: /utf-8 for all code" · 373af458
      aleksandar.stojiljkovic authored 
      This reverts commit a53f3c37.

Original CL: https://codereview.chromium.org/2543743002

Reason for revert: Compilation issue on master.tryserver.chromium.win:win_optional_gpu_tests_rel

Failing [1] task on the bot:

FAILED: obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj.rsp /c ../../third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp /Foobj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_libgles3_cc.pdb"
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): warning C4828: The file contains a character starting at offset 0x3714f that is illegal in the current source character set (codepage 65001).
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

[1]
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/5729/steps/compile%20%28without%20patch%29/logs/stdio

BUG=454858, 637203, 671021

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
NOTREECHECKS=true
TBR=scottmg@chromium.org, dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2550973002
Cr-Commit-Position: refs/heads/master@{#436195}
      373af458
    • tfarina's avatar
      net: move kRcodeMask into dns_response.cc · b0dfc121
      tfarina authored 
      It is used only there and it is not part of the public protocol.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org

Review-Url: https://codereview.chromium.org/2545163002
Cr-Commit-Position: refs/heads/master@{#436194}
      b0dfc121
    • jschuh's avatar
      Rename CheckNum to MakeCheckedNum · 4bc919cb
      jschuh authored 
      R=dcheng@chromium.org
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2545303002
Cr-Commit-Position: refs/heads/master@{#436193}
      4bc919cb
    • mstensho's avatar
      Complete layout even if a block needs relayout due to widows or column balancing. · 0740b0df
      mstensho authored 
      We cannot just abort in the middle of layoutBlockFlow() when we detect that we
need another layout pass (due to new column height or because we want an
earlier break to satisfy the widows requirement). We might miss our only
opportunity to detect size changes that way, and thus skip necessary layout and
repositioning of absolutely positioned descendants.

BUG=591637

Review-Url: https://codereview.chromium.org/2471623003
Cr-Commit-Position: refs/heads/master@{#436192}
      0740b0df
    • chromeos-commit-bot's avatar
      Automated Commit: Committing new LKGM version 9047.0.0 for chromeos. · 5bbd80fb
      chromeos-commit-bot authored 
      Cr-Commit-Position: refs/heads/master@{#436191}
      5bbd80fb
    • jschuh's avatar
      Add support for CheckedNumeric Max and Min constexpr functions · 711ac6a1
      jschuh authored 
      This also adds variadic helper functions CheckMax and CheckMin that
return the maximum or minimum (respectively) result of an arbitrary
number of arithmetic, CheckedNumeric, or StrictNumeric arguments.

Review-Url: https://codereview.chromium.org/2545253002
Cr-Commit-Position: refs/heads/master@{#436190}
      711ac6a1
    • scottmg's avatar
      win: /utf-8 for all code · a53f3c37
      scottmg authored 
      Previously enabled for chromium_code, can now be turned on everywhere.

BUG=454858,637203

Review-Url: https://codereview.chromium.org/2543743002
Cr-Commit-Position: refs/heads/master@{#436189}
      a53f3c37
    • ratsunny's avatar
      Remove obsolete keywords table migrating function · 62ef852f
      ratsunny authored 
      Since the function KeywordTable::MigrateKeywordsTableForVersion45
is not used in codebase, it's safe to remove it.

R=pkasting@chromium.org
BUG=665018

Review-Url: https://codereview.chromium.org/2542933002
Cr-Commit-Position: refs/heads/master@{#436188}
      62ef852f
    • glebl's avatar
      Floating legend should be added to the fieldset's anonymous block. · 0f77a4ef
      glebl authored 
      If fieldset's legend is floating it should be added to the existing fieldset\'s anonymous block instead of creating a nested one.
This is necessary because flexbox forces the floating legend to be non-floating and therefore if the legend needs to be floating it should be added to the fieldset's anonymous block.

BUG=661230, 670837
TEST=fast/forms/fieldset/fieldset-legend-float.html

Tested with real world websites:
https://jsbin.com/zutekilusi/1/edit?html,css,output
http://www.timico.co.uk/timico-ltd-application-form
http://codepen.io/michaelpumo/pen/VmZqrr
https://en.wikipedia.org/wiki/Special:ActiveUsers
https://jsfiddle.net/tdbthtra/

Review-Url: https://codereview.chromium.org/2550963002
Cr-Commit-Position: refs/heads/master@{#436187}
      0f77a4ef
    • kylechar's avatar
      Move DisplayChangeObserver + tests from ash to ui. · f2e4e41b
      kylechar authored 
      Move DCO + tests from ash to ui. All of the ash dependencies were
already removed, so it's mostly just changing the file location and
namespace.

BUG=667344

Review-Url: https://codereview.chromium.org/2524863003
Cr-Commit-Position: refs/heads/master@{#436186}
      f2e4e41b
    • chrome-cron's avatar
      Updating trunk VERSION from 2941.0 to 2942.0 · eaf47654
      chrome-cron authored 
      Cr-Commit-Position: refs/heads/master@{#436185}
      eaf47654
    • khorimoto's avatar
      Create Tether Chrome OS component and add a skeleton Initializer class. · 4c53995f
      khorimoto authored 
      Review-Url: https://codereview.chromium.org/2545923005
Cr-Commit-Position: refs/heads/master@{#436184}
      4c53995f
    • dglazkov's avatar
      Unbreak test-webkitpy. · 2cda52ae
      dglazkov authored 
      The wpt_github code imports libhttp2, which is not part of the
standard Python libraries (at least on Mac). Luckily, we have
a hermetic instance of it in depot_tools, so let's use that instead.

R=jeffcarp
BUG=

Review-Url: https://codereview.chromium.org/2548163002
Cr-Commit-Position: refs/heads/master@{#436183}
      2cda52ae
    • kbr's avatar
      Add suppressions for WebGL 2.0.1 tests failing on Linux AMD and Intel. · ab3ad5db
      kbr authored 
      BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550023002
Cr-Commit-Position: refs/heads/master@{#436182}
      ab3ad5db
    • zmo's avatar
      Roll WebGL 4b93f82..3e235f7 · 666b1238
      zmo authored 
      https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4b93f82..3e235f7

BUG=
TEST=bots
TBR=kbr@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2541163008
Cr-Commit-Position: refs/heads/master@{#436181}
      666b1238
    • kbr's avatar
      Remove now-incorrect assert in WebGLContextGroup. · f9370828
      kbr authored 
      BUG=537054, 666061
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2548153002
Cr-Commit-Position: refs/heads/master@{#436180}
      f9370828
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ ca719be61..627b0d972 (4 commits). · bdd3719e
      catapult-deps-roller authored 
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ca719be61d32..627b0d9726b5

$ git log ca719be61..627b0d972 --date=short --no-merges --format='%ad %ae %s'
2016-12-02 dtu Update Firefighter deployment scripts.
2016-12-02 aiolos Fix errors in chart_track and x_axis_track.
2016-12-02 eakuefner [Telemetry] Ensure that story display names are unique
2016-12-02 aiolos Revert of Make telemetry use the same chrome stable build as tracing/dashboard. (patchset #1 id:1 of https://codereview.chromium.org/2415683002/ )

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2546283002
Cr-Commit-Position: refs/heads/master@{#436179}
      bdd3719e
  3. 03 Dec, 2016 17 commits