- 21 Sep, 2018 40 commits
-
-
Tatiana Buldina authored
Enabling ChromeOptionsFunctionalTests.* tests due to fix defect 2572 (https://chromium-review.googlesource.com/c/chromium/deps/webdriver/+/1236222) Bug: chromedriver:2572 Change-Id: I7477da94180a37aa23c713805269cadb78b15a00 Reviewed-on: https://chromium-review.googlesource.com/1238443Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#593266}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/381f401bc444..39707b216ffe Created with: gclient setdep -r src-internal@39707b216ffe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I622d6e53017c0b3f70ce218c15af2bc34865b796 Reviewed-on: https://chromium-review.googlesource.com/1239053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593265}
-
Matthew Denton authored
Bug: 887783 Test: /proc/{network process pid}/status shows no capabilities Change-Id: I08c7d6665c520b361a1a48bcd2f1a5812dadce52 Reviewed-on: https://chromium-review.googlesource.com/1229363Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#593264}
-
Artur Khachatryan authored
Disabling testShouldCaptureScreenshotOfCurrentViewport was done by mistake when we run the test on local machine without "--chrome" flag. This test must be run with the flag "--chrome=<path_to_chrome_binaries>" Bug: chromedriver:2480 Change-Id: I21cc8c155a1eec1952eb3e50b2dcd27a8aa450cb Reviewed-on: https://chromium-review.googlesource.com/1238825Reviewed-by:
-
Frank Liberato authored
This reverts commit 6e1bb98a. Reason for revert: https://chromium-review.googlesource.com/1238859 reverted the original CL, tests pass again. Original change's description: > [Build Sheriff] Disable various tests pending fix. > > NOTRY=true > TBR=nohle@chromium.org, dtrainor@chromium.org > > Bug: 887953 > Change-Id: I3a3f3ea828c86873fdea72d75c50a83a83271408 > Reviewed-on: https://chromium-review.googlesource.com/1238377 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593189} TBR=liberato@chromium.org Change-Id: Idf5e5d75ed6087c52d6b70e0e51126ceec000a27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887953 Reviewed-on: https://chromium-review.googlesource.com/1239257Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593262}
-
Brian Osman authored
This was effectively testing the old behavior of makeColorSpace (that it always produces the same color type). We don't want that behavior, and we can't guarantee that color types will be preserved through encoding and decoding). Bug: skia:8382 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibabe3333545d72f9c697c57ee9b1b5ed3a2c4431 Reviewed-on: https://chromium-review.googlesource.com/1238779Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#593261}
-
Frank Liberato authored
This reverts commit 254369a5. Reason for revert: <INSERT REASONING HERE> Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593108} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610 Reviewed-on: https://chromium-review.googlesource.com/1239216Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/998ad81680e0..0464dbfe8e21 git log 998ad81680e0..0464dbfe8e21 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 dgarrett@google.com cidb: UpdateMetadata to include branch. Created with: gclient setdep -r src/third_party/chromite@0464dbfe8e21 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0bc2e9f45792ccb3f400e46d88fbf2dad6261b6d Reviewed-on: https://chromium-review.googlesource.com/1238937Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593259}
-
Lei Zhang authored
PDF contents have to be fit into the printable area before the PDF gets flattened for printing. Otherwise some PDFs will not print correctly. r554188 flipped the ordering, so this flips it back. BUG=873840 Change-Id: I68a05d0951caa31080b3b9bb424d458a899b92a7 Reviewed-on: https://chromium-review.googlesource.com/1237719Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593258}
-
Oystein Eftevaag authored
Some unnoticed debug sizing caused the host-side tracing buffer to be a bit larger than necessary. R=ssid@chromium.org Bug: 886685 Change-Id: I56f3ed15952d7f0d6382b6e939c5386169f672b8 Reviewed-on: https://chromium-review.googlesource.com/1236663Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#593257}
-
Andrey Kosyakov authored
Drive-by: remove references to NetLog. Bug: 877075 Change-Id: I9fa4df67d89793754f8502a4e756f86c84571129 Reviewed-on: https://chromium-review.googlesource.com/1232616Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#593256}
-
Xida Chen authored
This change enables PaintTouchActionRects by default. This is a new implementation of how the blink->cc logic works for the css touch-action feature. The big idea behind PaintTouchActionRects is to compute touch-action rects during paint, in paint order, as part of the background paint phase. With this change we expect better performance (primarily a drop in ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as well as observable bug fixes (e.g., https://crbug.com/826746). Bug: 836905, 881894 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa Reviewed-on: https://chromium-review.googlesource.com/1233114Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593255}
-
Philip Rogers authored
This change introduces cc::Layer::SetChildLayerList and uses it to avoid re-attaching all layers every frame when using layer lists. This is one step closer to sending a layer list to cc instead of a layer tree. The primary change is to remove the call to RemoveChildLayers in PaintArtifactCompositor::Update. Instead of attaching layers to the root layer incrementally, they are built up using LayerListBuilder and then set on the root layer in a single step. This approach revealed some dependencies that are no longer true. Because the host tracks layers that need to push, it is important that Layer's host is set prior to calling any Layer setters. Layer::SetElementId only worked in layer list mode because the Layer's host was not set; this has been fixed. Bug: 879650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I894297dff3c1cdebacb3485abc3bec1d855e9afc Reviewed-on: https://chromium-review.googlesource.com/1226264Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593254}
-
Dmitry Gozman authored
We don't use the public version anymore, so we now host NavigationState in InternalDocumentStateData instead of DocumentState. This also fixes a bug where we forgot to clone InternalDocumentStateData when cloning DocumentState. TBR=boliu@chromium.org,jochen@chromium.org Bug: none Change-Id: Ieeed9a73ed3791c7adcf831eb832c87b20a55bc5 Reviewed-on: https://chromium-review.googlesource.com/1236341 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#593253}
-
Dale Curtis authored
https://crrev.com/592977 disabled these tests for browser_tests which doesn't even run on Android... Instead they should have been disabled in content_browsertests. This also re-enables the tests elsewhere where they should already be passing due to the browser_tests coverage. BUG=778245 TEST=none TBR=xhwang Change-Id: Iabe79be96f8edb9d5aca3b2dd7e8ed3827c62999 Reviewed-on: https://chromium-review.googlesource.com/1238832Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593252}
-
Tarun Bansal authored
Network Quality Estimator (NQE) encapsulates int32_t as a base::Optional<int32_t> at some of the places. This happens on-the-fly. This is confusing, and may also be the cause of some of the crashes. Change-Id: I66142aa5047d9da577d60e17b3186c37b0c9a149 Bug: 887162 Reviewed-on: https://chromium-review.googlesource.com/1237730Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593251}
-
rbpotter authored
Fix the sizing of the print destinations list so that it is always set to the maximum of the available space and 3 destinations of height. This will ensure there is no double scrollbar unless the dialog is extremely short. Bug: 884741 Change-Id: Ieba1a4e634d667b2e6e5567cf6f80f5962bd0fde Reviewed-on: https://chromium-review.googlesource.com/1235120Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593250}
-
rbpotter authored
2 bugs in the scaling section: (1) Fix a pre-existing bug where the scaling input incorrectly displayed 0 and an error when fit to page was checked for a non-uniform page size PDF (2) Prevent cr-input from expanding to the full row to try to fix a bug with touch on Windows. Bug: 874226, 886854 Change-Id: I8cb8785129f125a17a2ea8715ec85af3b467cad8 Reviewed-on: https://chromium-review.googlesource.com/1237516 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Kyle Milka authored
The flag was enabled by default and no longer needed. Bug: 885301 Change-Id: I84ec4557a1ca4c2f1eb70213c7bc56cd67512611 Reviewed-on: https://chromium-review.googlesource.com/1236287 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593248}
-
Pavel Shmakov authored
Bug: 871738 Change-Id: Ibdc024e5dce12dc1ca9d8280d4144d3576522016 Reviewed-on: https://chromium-review.googlesource.com/1179895 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593247}
-
Tommy C. Li authored
This test breaks up OmniboxViewTest.PreserveDisplayTextOnFocusSearch, which was a browser test, into three smaller unit tests. OmniboxViewTest.PreserveDisplayTextOnFocusSearch is flaky, and the whole set of OmniboxViewTest.* browser tests have been flaky for at least a year. Bug: 751031 Change-Id: I6e7a8fc88f55fee706cdfc1ee0617ce4a27f5103 Reviewed-on: https://chromium-review.googlesource.com/1232525Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#593246}
-
Brian White authored
Bug: 882892 Change-Id: I91d2cf5b46b8ef3b790b5e00692a053686ba17d1 Reviewed-on: https://chromium-review.googlesource.com/1236460 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#593245}
-
Dale Curtis authored
This reverts commit 1eee7cc0. Reason for revert: These tests are not run on Android; I meant to change the ones in content/ Original change's description: > Disable FrameSizeChange tests on Android KitKat. They're flaky. > > BUG=778245 > TEST=none > TBR=xhwang > > Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a > Reviewed-on: https://chromium-review.googlesource.com/1237265 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592977} TBR=dalecurtis@chromium.org,xhwang@chromium.org Change-Id: I7df83977706f0e90affa616b5546e1066f76c429 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778245 Reviewed-on: https://chromium-review.googlesource.com/1239000Reviewed-by:
-
Mike Dougherty authored
With SlimNavigationManager enabled, a placeholder page is rendered at the start of the navigation stack. Prevent this placeholder page from being registered as a frame. Bug: 869884 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I09907135bf48720ef4b25fb7ddaa607db4f03a27 Reviewed-on: https://chromium-review.googlesource.com/1234268 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593243}
-
Alexei Filippov authored
Change-Id: I57c51a878d7d1112e4ed69db0a23008e346e670b Reviewed-on: https://chromium-review.googlesource.com/1237556Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#593242}
-
Esmael El-Moslimany authored
Also fixing focus issue with cr-policy-pref-indicator. Need to pass make a function that returns the iron-icon that is the focusable element and is within the shadow DOM. Bug: 878331 Change-Id: I4c04aae355e713a086e69df3dd480193005b72b3 Reviewed-on: https://chromium-review.googlesource.com/1195674 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
QuicLockImpl's methods had various lock annotations (e.g. EXCLUSIVE_LOCK_FUNCTION), but the class itself wasn't annotated as LOCKABLE. After a recent clang change this was causing compiler errors like the one reported in https://crbug.com/887610. This CL fixes this by adding LOCKABLE annotation to QuicLockImpl. I've searched for other files under //net/third_party/quic that include LOCK_FUNCTION substring but do not include LOCKABLE substring. It seems that quic_mutex_impl.h was the only one. Merge internal change 213866214 Bug: 887610 Change-Id: Iddedd166a97cfe1f77ea2c14a6e98a836bdb08d8 Reviewed-on: https://chromium-review.googlesource.com/1237716Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593240}
-
Samuel Huang authored
generate_milestone_report.py intendes to list all existing .ndjson files in the given --size-file-bucket gs://bucket/subdir link, and only generate missing .ndjson files. However, the command line used: gsutil ls -r gs://chrome-supersize/milestones/ is incorrect (-r means reverse). This tends to return an empty list, and the logic is ineffective, and everything gets generated. The correct command to list files recursively is: gsutil ls -R gs://chrome-supersize/milestones/* This CL fixes the problem. However, since we're used to regenerating everything, so we're making this the default behavior. This CL also adds '--skip-existing' switch to only generated missing .ndjson files. As unrelated clean-up, also add new line to end of milestones.json. Bug: 880671 Change-Id: I2a21b59c7d7f5b1b8765ea260030814bb8188139 Reviewed-on: https://chromium-review.googlesource.com/1238814Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593239}
-
Paul Miller authored
Multiple CachingPermutedEntropyProvider objects would all try to cache their values in the same pref store, overwriting each other's. BUG=866722 Change-Id: I42efd8b4eaf5f0dfec9e2b1be1fcac51e2b481ab Reviewed-on: https://chromium-review.googlesource.com/1236290Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#593238}
-
Etienne Pierre-doray authored
Original CL intention was: This CL uses ScopedBlockingCall to mark blocking calls in /components/bookmarks. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 874080 Change-Id: I8ca5da34968b9b94659c189b02e982f51399ab49 Reviewed-on: https://chromium-review.googlesource.com/1191799Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593237}
-
Ian Kilpatrick authored
As above, move similar tests into subdirectory, and apply minor documentation cleanups. Adds two new tests checking that setting an invalid (negative) available size, clamps it to zero. Bug: 726125 Change-Id: Id5bdfa25970a4e4bfe359377b88176043ab1f6c3 Reviewed-on: https://chromium-review.googlesource.com/1236266 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#593236}
-
Rayan Kanso authored
Strip out non-default download notification icons when in incognito mode for privacy reasons. Bug: 880359 Change-Id: I92a06923672e4f581389f56e17a2f9c0d05b8bc3 Reviewed-on: https://chromium-review.googlesource.com/1233753Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593235}
-
Rayan Kanso authored
With the recent changes in the Download Service, we should use the response headers and request url chain provided when the download is complete. Bug: 881314 Change-Id: I3291186c9b867130683b3b09ef9c1d226d0089f1 Reviewed-on: https://chromium-review.googlesource.com/1236274Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593234}
-
Dominic Mazzoni authored
http://crrev.com/c/1192062 made it so that we don't enable accessibility as often. The idea was to only enable accessibility if we get a call to IAccessible2, or to both get_accName and a response to our alert message on a honeypot window. However, this only worked if we constructed at least one BrowserAccessibilityManager. In cases where the external client never explored and discovered a BrowserAccessibilityManager, the IAccessible2UsageObserver wasn't registered yet. As a fix, move the IAccessible2UsageObserver code to part of BrowserAccessibilityStateImpl. Bug: 878072 Change-Id: Iadcbd032fa1d6f635bbb99c1e130d384efe0d9b1 Reviewed-on: https://chromium-review.googlesource.com/1234267Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593233}
-
Steven Bennetts authored
This reverts commit dad5078a. Reason for revert: crbug.com/887868 Original change's description: > Fix that cookies with long names can't be deleted > > This change fix settings css to access expand and delete icons. > As a Result, cookies with long names can be deleted. > > Bug: 871639 > Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42 > Reviewed-on: https://chromium-review.googlesource.com/1202362 > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592760} TBR=stevenjb@chromium.org,jinho.bang@samsung.com,jdragon.bae@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 871639 Change-Id: I3a2f8c3d75a91ddd54b406f2e4ca37e0f20db3cc Reviewed-on: https://chromium-review.googlesource.com/1238813Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593232}
-
Reilly Grant authored
This method was only used by the BrowsingDataCookieHelper unit tests, which this change converts to using the network::mojom::CookieManager interface. Bug: 721395 Change-Id: Ia4f5a54221d0ce902a42e8f910230ad0d732b7ee Reviewed-on: https://chromium-review.googlesource.com/1236289Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593231}
-
Wez authored
- Migrate //mash and //ui/views examples off QuitCurrent*Deprecated(). - Migrate //net mock off it as well. These are the final remaining call-sites that codesearch identifies as not-test-specific (even though the mock is a mock ;). Bug: 859095 Change-Id: I417f9c93aa6ef6eaae4cf22948e07750d176d83d Reviewed-on: https://chromium-review.googlesource.com/1226455 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Guohui Deng authored
MixerServiceConnection is a component that connects to MixerService via Socket. Bug: internal b/29571387 Test: build and run on an audio device and verify the assistant works fine. Change-Id: Iae323943909167fe247666ffd2c319efcf34c3ac Reviewed-on: https://chromium-review.googlesource.com/1231813Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593229}
-
Christopher Cameron authored
There exist the following to endpoints that need to be hooked up - NativeWidgetMac::InitWidget can use a views::BridgeFactoryHost - AppShimHost has a views::BridgeFactoryHost that can create Cocoa UI in the app shim process Hook these two up by - Adding a virtual method NativeWidgetMac::GetBridgeFactoryHost - Overriding this in the BrowserFrameMac sub-class - Calling into apps::ExtensionAppShimHandler to find the apps::AppShimHandler::Host for the browser window - Adding an apps::AppShimHandler::Host::GetBridgeFactoryHost method - Overriding this in AppShimHost to return its views::BridgeFactoryHost This involves adding the helper function apps::ExtensionAppShimHandler::FindHostForBrowser. Most similar functions are implemented as a static function that call GetInstance to effectively make the function non-static. Because this is confusing, change such instances to be non-static functions, and make public the GetInstance method as apps::ExtensionAppShimHandler::Get. Also do a little bit of cleanup in BridgedNativeWidgetHostImpl so that we don't crash immediately - Make GetBoundsOffsetForParent not dereference null and add a comment that its logic needs updating - Remove |has_received_window_geometry_| because the approach that it assumed will not work R=tapted TBR=avi (for chrome/ OWNERship) Bug: 859152 Change-Id: I9873e0c70b07468fefa90a574606cca1ed54a951 Reviewed-on: https://chromium-review.googlesource.com/1235221 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#593228}
-
Kenichi Ishibashi authored
We should call AppCacheStorage::CancelDelegateCallbacks() in DeliverNetworkResponse(). because otherwise we could call SendResponseInfo() without having a valid URLLoaderClient. No test since AppCacheURLLoaderJob has special casing for testing and it's difficult to work around it. Bug: 882538 Change-Id: I0c4661a08532d0891fc1696464b675eeb4ce6cde Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1237893 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593227}
-
