Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 22 Jul, 2017 13 commits
    • sohan's avatar
      cc: HUD handle context lost in Gpu raster. · 5f348030
      sohan authored 
      This returns the resource id in case the HUD canvas
is invalid, because of context loss while SkSurface
creation. The resource is subsequently evicted from
quad list.

BUG=736127
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

patch from issue 2961633002 at patchset 160001 (http://crrev.com/2961633002#ps160001)

Change-Id: I8d04dfed24ec9cd7e2b520d20988b7a70efcacc3
Reviewed-on: https://chromium-review.googlesource.com/571821Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
Reviewed-by: default avatarVladimir Levin <vmpstr@chromium.org>
Reviewed-by: default avatarSohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Cr-Commit-Position: refs/heads/master@{#488827}
      5f348030
    • skym's avatar
      [Sync] Maintain a global_id mapping to update UserEvents that references navigations. · a58a1f01
      skym authored 
      UserEvents are created and reference sessions data by global_id. It is
important that they travel over the wire in this format, as this is how
the sessions data is keyed into Footprints, and the sync server cannot
feasibly perform a persistent read before writing new UserEvents.
Because global_id is forced to be part of the wire interface and
specifics, it is also conveniently part of the interface to the
UserEventService.

However, while this global_id is seemingly sacred to sync, it comes
from simply the timestmap of the navigation entry. And if a page is
reloaded, this value can change. A problem arises when a UserEvent
references a navigation by a global_id that was updated and the old
value is never going to reach the sync server.

To fix we maintain two sets of mappings, one that allows us to map old
global_ids to new global_id, and one that allows us to efficiently look
up uncommitted UserEvents by global_id, so that if we get either a new
global_id or a new UserEvent we can quickly fix the global_id.

BUG=747621

Review-Url: https://codereview.chromium.org/2958303002
Cr-Commit-Position: refs/heads/master@{#488826}
      a58a1f01
    • Will Chen's avatar
      DevTools: extract console_counters module · 6fb7ab1a
      Will Chen authored 
      Follow-up from https://codereview.chromium.org/2975523002/

Bug: 667560
Change-Id: Ic562500db2fc352f7938306ba3408e18e57a55dc
Reviewed-on: https://chromium-review.googlesource.com/575444
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488825}
      6fb7ab1a
    • Dianna Hu's avatar
      Refactor HTTP/2 protocol constants. · 9f2dfb6d
      Dianna Hu authored 
      Compile-time constants returned by methods that are not constexpr,
not even static?  Wait, there's a better solution!  (These methods
are leftover from SPDY days when frame sizes were different for
different SPDY versions.)

This CL lands server change 162294268 by bnc.

BUG=488484

Change-Id: Idf6feb66ca5aac69faccb2ce9fe05c53327b819c
Reviewed-on: https://chromium-review.googlesource.com/581432
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: default avatarBence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488824}
      9f2dfb6d
    • Fady Samuel's avatar
      Broke the build. · 08b90b79
      Fady Samuel authored 
      Revert "viz: Make hit testing mojoms match README.md"

This reverts commit af391815.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> viz: Make hit testing mojoms match README.md
> 
> This CL moves hit_test code to match the directory structure in README.md.
> 
> Bug: 722935
> Change-Id: I1565e9de3ec9387e13651b4a89d623bbc4267773
> Reviewed-on: https://chromium-review.googlesource.com/581798
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488820}

TBR=rjkroege@chromium.org,fsamuel@chromium.org,tsepez@chromium.org

Change-Id: Id074cbea1cde58042e55cbc8ce24ac7c178afc10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 722935
Reviewed-on: https://chromium-review.googlesource.com/582528Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488823}
      08b90b79
    • Ian Vollick's avatar
      Revert "[vr] Restore opacity when transient elements are shown again." · 11bcfff5
      Ian Vollick authored 
      This reverts commit c1405389.

Reason for revert: trying a different approach.

Original change's description:
> [vr] Restore opacity when transient elements are shown again.
> 
> We'd previously set opacity to 0.0 when hiding elements in the
> transience manager which makes it tricky to see them when they come
> back. With this change, we inform the manager of the desired "opacity
> when visible" and it will restore elements to that opacity when
> shown again.
> 
> Bug: None
> Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5
> Reviewed-on: https://chromium-review.googlesource.com/582069
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488788}

TBR=vollick@chromium.org,cjgrant@chromium.org,ymalik@chromium.org

Change-Id: Ic3ec7b20a980b42c1048c0d074cff6136c3997c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/582527Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488822}
      11bcfff5
    • dpapad's avatar
      WebUI: Replace vulcanize with polymer-bundler. · 1e6a87f5
      dpapad authored 
      Summary of changes needed for the migration:
 - Excluded URLs behavior is different than Vulcanize, need to explicitly list
   all URLs to be excluded (unlike Vulcanize, transitive deps of an excluded
   URL are not implicitly excluded).
 - Excluded URLs need to match exactly, unlike Vulcanize where foo.html would
   match chrome://some-path/foo.html.
 - Input HTML files need to have
   <html><head>...</head><body>...</body></html> tags.
 - A single invocation of poylmer-bundler produces both "basic" and
   "lazy" modules (achieved by using the --shell flag), unlike Vulcanize
   which required two separate invocations.
 - Using new --manifest-out instead of previous --out-request-list flag to
   generate depfiles for Ninja.
 - Using --rewrite-urls-in-templates to preserve previous rewriting behavior.
 - polymer-bundler does not blow up when it can't find a file (unlike Vulcanize,
   so check output manifest for any reported "missing" dependencies).
 - Removed some Windows specific hacks that don't seem necessary anymore.

BUG=731881
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2936333002
Cr-Commit-Position: refs/heads/master@{#488821}
      1e6a87f5
    • Fady Samuel's avatar
      viz: Make hit testing mojoms match README.md · af391815
      Fady Samuel authored 
      This CL moves hit_test code to match the directory structure in README.md.

Bug: 722935
Change-Id: I1565e9de3ec9387e13651b4a89d623bbc4267773
Reviewed-on: https://chromium-review.googlesource.com/581798Reviewed-by: default avatarRobert Kroeger <rjkroege@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488820}
      af391815
    • Alok Priyadarshi's avatar
      Cleanup MultibufferDataSource constructor params. · b8f30548
      Alok Priyadarshi authored 
      Replaces GURL, CORSMode and UrlIndex parameters with UrlData.

Change-Id: I42e723381ad53c3a9d33289b3da585d5d825f587
Reviewed-on: https://chromium-review.googlesource.com/581610Reviewed-by: default avatarFredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488819}
      b8f30548
    • Quinten Yearsley's avatar
      Apply Chromium patches to local wpt and continue · 6971b156
      Quinten Yearsley authored 
      Previously, the importer would check for exportable Chromium commits and
abort if any existed. This CL would make it so that instead of aborting,
the importer would apply the patch to the local WPT before copying
files over.

This should make it so importer is no longer blocked on exporter in
general, but it should still be the case that exportable Chromium changes
aren't clobbered.

Bug: 734121
Change-Id: I5ca08df2f38a3afe2c98af1cfa8ef1f1ac44eceb
Reviewed-on: https://chromium-review.googlesource.com/580574
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: default avatarJeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488818}
      6971b156
    • Kyle Horimoto's avatar
      [CrOS Tether] Fix scan behavior of HostScanner. · 7830751b
      Kyle Horimoto authored 
      Previously, when a scan began, we would clear all existing scan results
from the cache, then add results back to the cache as the scan
progressed. This was janky because it would result in the UI removing
Tether networks and then adding them back shortly afterwards when scan
results came in.

This CL changes this functionality so that results are only removed
after a scan ends and the associated device is not found.

Bug: 672263, 746726
Change-Id: I6df2516b1bc0e604c3a496838804bc6ee5c8292c
Reviewed-on: https://chromium-review.googlesource.com/581633
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488817}
      7830751b
    • Catherine Chung's avatar
      Passing in a promo string for the NewTabInProductHelp trial. · 9fd3a29a
      Catherine Chung authored 
      This modifies the trial in http://crrev.com/2a248c5

Bug: 734132
Change-Id: I6f0453465451023d33c8505f8b9f997004d5a094
Reviewed-on: https://chromium-review.googlesource.com/566335
Commit-Queue: Catherine Chung <catherinechung@google.com>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488816}
      9fd3a29a
    • Alexei Svitkine's avatar
      Add more instrumentation to diagnose an Android memory corruption. · 2e8a3a3b
      Alexei Svitkine authored 
      This change:
  - Does a separate pass on all histograms, validating them, before
    starting to prepare their deltas. This will confirm that data is
    bad already before we start processing them (i.e. verify that it's
    not the processing code having some side effect).
  - Counts the number of corrupted histograms to tell us if it's a single
    bad value or more widespread corruption.
  - Keeps track of the last histogram that someone logged something to,
    so that we could have a trail of the last thing that happened before
    corruption.
  - Moves a previously added instrumentation call to within the correct if
    block.

BUG=736675,744734

Change-Id: I4b860ad6e977c1555409bd628f9e4e5147e61654
Reviewed-on: https://chromium-review.googlesource.com/581418
Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488815}
      2e8a3a3b
  3. 21 Jul, 2017 27 commits