- 21 Aug, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e8b16af30f4ca8d13f9a17a7522c0c7be53c14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800498}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7f343135480a..7a2e3f83964f 2020-08-21 jleconte@google.com WebRtcTest quest needs a longer execution timeout. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: eseckler@google.com Change-Id: I890eabaf50920f623819d8536b0ce31923dc2e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368812Reviewed-by:
-
Maggie Cai authored
This reverts commit 7d2d8cc1. Reason for revert: This is likely the cause of build breakage for Linux ChromiumOS MSan Tests since https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20301 The failed test is MediaNotificationViewImplTest.UnfreezingWaitsForArtwork_Timeout Original change's description: > GMC: Redesign audio picker UI > > Implement the new UI for the audio device picker in global media > controls. As part of this change, the MediaNotificationBackground will > draw a gradient between the device picker and notification artwork if > the picker is availabile. > > Screenshots of this updated UI will be posted on the crbug. > > Change-Id: Ic7186c770102663b08e85b56eeddfbfa13833c3c > Bug: 1117160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358512 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800243} TBR=steimel@chromium.org,noahrose@google.com Change-Id: I2b9d9d6df1afc9ca8fdb967fad0a35c3273db879 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367427Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800496}
-
Jose Dapena Paz authored
GCC: default move constructor of ServiceWorkerRunningInfo noexcept requires StrongAlias noexcept too. Fix for this GCC compilation error: ../../content/public/browser/service_worker_running_info.cc:26:1: error: function ‘content::ServiceWorkerRunningInfo::ServiceWorkerRunningInfo(content::ServiceWorkerRunningInfo&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ 26 | ServiceWorkerRunningInfo::ServiceWorkerRunningInfo( | ^~~~~~~~~~~~~~~~~~~~~~~~ Problem comes from blink::ServiceWorkerToken move constructor being declared noexcept, but its parent StrongAlias not having noexcept. Fix making StrongAlias move constructor noexcept too. Bug: 819294 Change-Id: I127a435b3d1f52f01a40700457ce6e67d5d67af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359077Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#800495}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.59-1597657121-benchmark-86.0.4237.0-r1 to 86-4183.59-1597657121-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7277c5f06a7d3b68a99ec3aad0c7dd07d5f79aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368915Reviewed-by:
-
Maksim Sisov authored
Even though, this config is not in the upstream yet, there are many patches that allow to build with use_x11 && use_ozone. The https://crrev.com/c/2361502 broke the build and my cq dry run. Thus, fixing the problem with this patch. Bug: 1085700 Change-Id: Id64052453811c6928b55a1ed62340ace667fe0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366797 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#800493}
-
Maggie Cai authored
This reverts commit d35f5dac. Reason for revert: This CL is the possible cause of the breakage of build Linux ChromiumOS MSan Tests since https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20302 Original change's description: > Modify Privacy Budget UKM Entry Filter to measure identifiable surfaces. > > Add a "SurfaceTracker" to IdentifiabilityStudyState to keep track of > surfaces that have been previously reported for each source. This is > used for deduplication and to limit the number of metrics sent in each > UKM report. > > Bug: 1112787 > Change-Id: I00eb2360849ea6772fbfdcc9b1cf91680f8c6173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363398 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Commit-Queue: Russ Hamilton <behamilton@google.com> > Cr-Commit-Position: refs/heads/master@{#800332} TBR=asanka@chromium.org,behamilton@google.com Change-Id: I0a349740361db768696be0703020b229d8e274be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367590Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.59-1597659923-benchmark-86.0.4237.0-r1 to 86-4183.59-1597659923-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic23f990e8cb243e7b91bd1de185b2d319088aa7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368914Reviewed-by:
-
Ramin Halavati authored
Incognito Dynamic Quota experiment is changed to enabled by default and its arguments are modified to the value that was set by latest active finch trials. The following three ranges where experimented: 0.1 - 0.2, 0.1 - 0.15, and 0.15 - 0.2. Since there was no significant stability difference between the three, kept the highest one which gives more quota and adds maximum uncertainty to detection. Bug: 1017120 Change-Id: I4039f37c3badad5b00552dd3c92bd734e5b245fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363751 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800490}
-
Zhuoyu Qian authored
This CL renames Web IDL |TreatNonObjectAsNull| to |LegacyTreatNonObjectAsNull| to make its usage more clear. Bug: 1072773 Change-Id: I2081296552ea0862a84f763243254af020f43fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364312Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#800489}
-
Maksim Sisov authored
Remove dependency on ui/views and ui/aura. This is required to be able to move them down to ui/platform_window/x11/tests Bug: 789065 Change-Id: Ie4c0bd3056f9627b13b4bdfc9511010aaf249515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367072 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#800488}
-
Viviane Yang authored
This CL will check for and remove expired subscriptions after the profile is initialized. By enabling the feature flag for push subscriptions with expiration time, a expiration time of kPushSubscriptionExpirationPeriodTimeDelta specified in chrome/browser/push_messaging/push_messaging_constants.h is added to push subscriptions. These subscriptions become invalid after they expired and need to be removed from the browser. Bug: 1119690 Test: unit_tests --gtest_filter=Push*Remove* Change-Id: I1d899daa0e79ff7fd4b08b0bc70ef273f9a54872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365953Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#800487}
-
Alan Cutter authored
This is a reland of c4de5e43 Fixed test flake due to not waiting for the first OnBackgroundColorChanged() event during page load. https://chromium-review.googlesource.com/c/chromium/src/+/2367584/2..3/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc Original change's description: > Use document background color as active tab color for tabbed web apps > > This CL hooks up the document's background color as the active tab > background color for experimental tabbed web app. > Tabbed web apps are hidden behind the DesktopPWAsTabStrip feature flag. > > This CL plumbs background color through from the renderer process along > the same route as document theme color. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460591&signed_aid=NcgKQaq5Y47QkcbQbbgNiw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460590&signed_aid=RlnBzb7mQq1SIW1fGBY-oA==&inline=1 > > Bug: 1104083 > Change-Id: If1c3e2172f80375a1a4619c17ee52594ef813005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342426 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800051} Bug: 1104083 Change-Id: If4a1b525af77ccd4697f6931b59a759a8bf3e3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367584 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#800486}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1597658380-benchmark-86.0.4237.0-r1 to 86-4183.59-1597658380-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idf4e780d0c2895043dd76fe65b8a11eaf06edf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368111Reviewed-by:
-
Alice Wang authored
This CL adds an espresso test to check that the clicking on |Try again| button shown on sign-in general error screen leads to the sign-in in progress screen. Bug: 1117471 Change-Id: I2ad1aef270e36b1a09628b077e59a4c71ba77b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366932 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800484}
-
Alan Ding authored
Provide chrome switch to ignore arcvm_dev.conf file directives during ARCVM start while in dev mode. Setting this switch provides default arcvm configuration parameters. BUG=b:159953121 BUG=b:164956421 TEST=tast run DUT arc.PerfBoot.vm and compared logs with flag. Change-Id: I9f8dd5b21dd62f8312ce0a88c1e4a38cbc76ecd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360946 Commit-Queue: Alan Ding <alanding@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800483}
-
Findit authored
This reverts commit feab4f74. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 800423 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZlYWI0Zjc0YzQ5ZmQ2MDBlMTJkNWE1M2IyYjA5M2IyNjdjMWE3MzYM Sample Failed Build: https://ci.chromium.org/b/8871393632014939696 Sample Failed Step: compile Original change's description: > cros: Add alternate keys for interacting with window cycler (alt+tab). > > Currently a user can only cycle the window cycle list using alt+tab or > alt+shift+tab. Also, the user can only confirm their selection by > releasing the alt key. > > This CL improves the interactivity of window cycler by introducing the > following changes. Pressing the left and right arrows now move the > selection while the window cycler is open. Pressing enter or space > now confirms the selection. > > WindowCycleControllerTest.KeysConfirmSelection > > Test: WindowCycleControllerTest.LeftRightCycle, > Bug: 1067327 > Change-Id: I03682c5545bf82415b9e71a4814bf5c1b0c196bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358586 > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800423} Change-Id: I026a93cb1506ff6e0dc8d9f0e0d49e7236c0aee5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368813 Cr-Commit-Position: refs/heads/master@{#800482}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e689d3164f34..4909d08c1410 2020-08-21 cclao@google.com Vulkan: Rename mStagingBufferStorage to mStagingBuffer 2020-08-21 jmadill@chromium.org Vulkan: Restart RenderPasses in DS read-only mode. 2020-08-21 cclao@google.com Vulkan: Use context staging buffer for immutable texture update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I4b9181ca884733500d3fa0533ce6ce8b69b8ffce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368545Reviewed-by:
-
Roman Sorokin authored
Bug: 753698 Change-Id: Iffc2dcf47b0635a737057755455225b008478c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367035Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800480}
-
Maggie Cai authored
This reverts commit 1240db1f. Reason for revert: This CL is likely the cause of build breakage for Win10 Tests x64 build starting from: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48700 Original change's description: > FontAccess: Windows Platform Implementation > > This implements Font Enumeration and Data Access for Windows. The > implementation uses DirectWrite APIs that will work on Windows 7 > with Platform Update KB2670838 and above. > > Furthermore, the enumeration data is cached in the browser > process and shared with renderers using Read Only Shared Memory. > > Font Data Access is implemented using the backend for @font-face > src: local() matching. > > Fixed: 1103400, 1113876 > Change-Id: I31a16a90e980cd50b16a8f99a1633c1954555e11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364009 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800338} TBR=jsbell@chromium.org,jam@chromium.org,mbarbella@chromium.org,schenney@chromium.org,oyiptong@chromium.org Change-Id: I381b449e8f0546f0f46bd9f21b4b95cc19ee683a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368616Reviewed-by:
-
Maggie Cai authored
This reverts commit cfb42f4a. Reason for revert: The upstream CL of this CL (https://crrev.com/c/2364009) is likely the cause of build breakage for Win10 Tests x64 build starting from: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48700 Original change's description: > FontAccess: Replace web_tests with WPT tests > > Replaces web_tests with WPT tests to ensure cross-browser compatibility > in the future. > > Bug: 535764 > Change-Id: Ice3b2bd0589a8aff83a0f50f7bcd2d2ff6938989 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365332 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800345} TBR=jsbell@chromium.org,oyiptong@chromium.org Change-Id: I6f85c0cb68f8c30ab29a618f3365d2473c9a8b99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 535764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367585Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13a12ff3de9a..27bbbaa9714f 2020-08-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iafccb7c76dcba5cb58ad0ed415d6441bd7bd3ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368547Reviewed-by:
-
Caleb Raitto authored
Bug: 973801 Change-Id: If6d0c1a481b29cecd64430d8444d7e19a667b4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365096 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77419b0f04e8..9869f187b5ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibaef9e9923a27ad59e30b2fd0408c578ca7133ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368425Reviewed-by:
-
Maksim Sisov authored
They are X11 specific. Disable them for ozone now. In the future, we need to make them work with Ozone/X11. It seems to be easy to do by switching to use WidgetActivationWaiter, but Ozone/Wayland doesn't support activation/deactivation for windows. We either need to make that work or let test know the platform so that the test isn't run. Alternatively, these tests can be moved to x11_unittests. Bug: 1085700 Change-Id: Ic1333dfec1dea8ba6ad0a3beb8dc224ba435ca23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367059Reviewed-by:
-
Maksim Sisov authored
When use_x11 && use_ozone are enabled, lacros no longer runs with Ozone platform by default. This is incorrect, it mustn't run anything else except Ozone. Fix that. Bug: 1085700 Change-Id: Ic7d7ad8badb867ccf779348442db7bc5c6d36c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367076Reviewed-by:
-
Maksim Sisov authored
These overlay tests are not even compiled for use_x11 case. However, when use_ozone is also set, they start to run and fail. AFAIK, X11 doesn't support overlays and there is no stub impl (???). Thus, the tests just fail/crash. Disable them to fix the problem. Bug: 1085700 Change-Id: Ic0a1c61ba191477a1a0b5b76b7f29b07e201acf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366738Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800472}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3d23ea2b66d4b72c67e0846d350a681adb978e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367494Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800471}
-
Jiewei Qian authored
This CL adds a chrome feature AlwaysReinstallSystemWebApps. If enabled, it will always reinstall system apps instead of only doing so after a version upgrade or a locale change. This is useful for testing. Bug: 1095524 Change-Id: I0e806f5dd0e8c10d8d971b0db2004940ec9b86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366334 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#800470}
-
Maksim Sisov authored
After https://chromium-review.googlesource.com/c/angle/angle/+/2210151 it's required to pass platform type for X11 so that correct backend is chosen so that X11/Linux doesn't become broken when compiled with use_x11 && use_ozone. Bug: 789065 Change-Id: Ia2e11a89fc358c9976d216f6729c49a28d4661aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366755Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
TBR=adithyas@chromium.org Bug: 1120213 Change-Id: I97e4a5c755488cdc797e1a491c3c367c1edefae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368543Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800468}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If30c793062ea360ddc9fe5449b0cd1fe94ceb984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368542Reviewed-by:
-
Kenichi Ishibashi authored
Similar to crrev.com/c/2352268, accessing browser context in weblayer seems to initialize BackgroundFetchContext, which depends on ServiceWorkerStorage::GetUserDataForAllRegistrationsByKeyPrefix(). Tests should wait for the completion of GetUserDataForAllRegistrationsByKeyPrefix() to avoid hitting DCHECK() in mojo generated bindings. Bug: 1115172 Change-Id: I5836e962cd35f07ab46e20b64352f8ef8eb9f353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368652Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800466}
-
Mei Liang authored
This CL makes the taller GTS group card contain mini thumbnails with the same aspect ratio as the big thumbnail. Bug: 1116475 Change-Id: I3d92e30259a17b4f7125ff14fcf317f683557709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359395 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now the feature is launched in the stable channel, and this experiment is not needed any more. The feature should be enabled by default. Bug: 1096677 Change-Id: I8dad4f56fdc8bbd85c4dd9f3a819d88d5a9f114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355154 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800464}
-
Stephen Sigwart authored
For time picker, and for date&time picker, the initial focus when opening a picker is always at the 'Hour' column cell. When opening the picker from 'Minute' or 'AM/PM' from the input box, the intent is likely to change the originated column value, and the expectation is likely to see the focus on the originated column value as well. The user might immediately start arrowing up or down to change the intended value, e.g. Minute, but the outcome is the Hour being changed. Matching the focused column cell seems more expected (vs. always focusing the 'Hour' column cell). Bug: 1053797 Change-Id: I0ca7467d40cfe46d3750e649e58c3924c3693660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358479 Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#800463}
-
Jit Yao Yap authored
This CL adds a network traffic annotation for the network request to download the app's icon. Bug: 1101208 Change-Id: I4a4e4236d0fc74fb36228626408927fbccd3b48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362820Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#800462}
-
Hirokazu Honda authored
Bug: 1045825 Test: None Change-Id: I97faf171a0636ea45d69a0fe638c888b34ecf9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361902Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800461}
-
Wei-Yin Chen (陳威尹) authored
TBR=dmazzoni@chromium.org Bug: 1120210 Change-Id: Ia4a1e44945adbcb64eae3247403734af0be115c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368752Reviewed-by:
-
Donn Denman authored
Adds a new In Product Help bubble that suggests that the user should enable access to page content in order to improve translations. This includes handling of the IPH, but not any triggering of the IPH or noting that the expected user response event has occurred. Following instructions here: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/translation_screenshots.md BUG=1120080 Change-Id: Ib929b40d9b0954bfba5ed80ba02d3913ec30f1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368472 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800459}
-
