- 16 Dec, 2017 40 commits
-
-
Dale Curtis authored
http://crrev.com/524139 moved WatchTimeRecorderProvider and VideoDecodeStatsRecorder into MediaMetricsProvider, but forgot to update the manifest. BUG=779192 TEST=no more connection errors Change-Id: I5cc2c4401545979b788dd028fee9a76c8584edbd Reviewed-on: https://chromium-review.googlesource.com/831220 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524596}
-
Lei Zhang authored
BUG=521776 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I166b8e48a70cfbbc37f72490b4bcedc383653123 Reviewed-on: https://chromium-review.googlesource.com/674751 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#524595}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cb66d9d95233..ad4583d06ecd $ git log cb66d9d95..ad4583d06 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 dtu [pinpoint] Defer Commit creation when resolving DEPS. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia7b193f41ca6a1894ee6541d2e19013ea330b5e1 Reviewed-on: https://chromium-review.googlesource.com/831388 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524594}
-
Stuart Langley authored
We removed this typemap when moving the mojom into WebKit, now we add it back to do the marshaling between ClipboardBuffer and ClipboardType on the browser side. As we don't intend at this time to send messages of this type in the opposite direction we only implement the FromMojom method in clipboard_struct_traits. Bug: 775830 Change-Id: Ib3dacbcc5b3c029167e902afbf7c8c5c809f1ee9 Reviewed-on: https://chromium-review.googlesource.com/823542Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524593}
-
Istiaque Ahmed authored
GetHashes() doesn't modify ComputedHashes::Reader. Bug: None Change-Id: I879d164539ed905e5fcb80c8eaa333ba04c42d5a Reviewed-on: https://chromium-review.googlesource.com/827614Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524592}
-
Eric Lawrence authored
The original landing broke EGTests for iOS Simulator and Device which were not run by the CQ. This change includes updated EGTests. TBR=pkasting@chromium.org Bug: 789163, 643458 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie30afcb7bcba5affc7266d72a10b7f8dc0074314 Reviewed-on: https://chromium-review.googlesource.com/830093Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#524591}
-
Istiaque Ahmed authored
ContentHashReader doesn't need to remember whether each of "verified_contents.json" and "computed_hashes.json" were found correctly, the caller only cares whether both of them are present or not. Collapse the two bools into one. Bug: None Change-Id: Idc0b0538f66ff88767acee87eba048ecd429df00 Reviewed-on: https://chromium-review.googlesource.com/828543 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524590}
-
John Chen authored
Update the handler for Generate Page Bundle button, so that output text has information needed by UI automation test. Bug: 794011 Change-Id: I67894eab2fac59cb0368e5dda53552bb889a0009 Reviewed-on: https://chromium-review.googlesource.com/823210Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524589}
-
sczs authored
Before crrev.com/c/695934, a top message was always being displayed. Now thats not the case, this CLremoves the top cell that contains the message if there's no message. Also, on iOS11 the contentInset was being adjusted automatically, causing an even larger blank space on top. This is fixed by setting the ContentInsetAdjustmentBehavior to never. Screenshots: https://drive.google.com/open?id=1N6egGvEOeSF2uags3w4hmLupWy7Vk4v3 https://drive.google.com/open?id=1hCW15FIUtw2o5rJ7MiqDcRd1z6Xq42O0 Bug: 778571 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b9f2b5f92e22f955fb10c5ea609f4ee4f130836 Reviewed-on: https://chromium-review.googlesource.com/830911 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#524588}
-
Dmitry Gozman authored
Bug: none Change-Id: Ic7cc7e665a8dd5f8999b2243b3fae342f5c8d960 Reviewed-on: https://chromium-review.googlesource.com/830681Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524587}
-
Jungshik Shin authored
Chrome's copy of ICU is built with U_CHARSET_IS_UTF8=1 so that |char *| buffer is treated as UTF-8 when constructing UnicodeString() regardless of the default encoding of the current locale on Linux or non-Unicode code page on Windows. However, some Linux distros do not set U_CHARSET_IS_UTF=1 when building ICU and Chromium build with system_icu crashes when Chromium is run in non-UTF-8 locale (e.g. 'C'). To make Chromium work in a non-UTF-8 locale (which is pretty rare these days), use 'icu::UnicodeString::fromUTF8(StringPiece)' instead of 'icu::UnicodeString(const char*)'. Bug: 772655 Test: components_unittests --gtest_filter=*IDN* Test: Chromium built with system_icu does not crash in C locale. Change-Id: I0daa284ec06b8e83814fc70eb8e9e5c96444ebfa Reviewed-on: https://chromium-review.googlesource.com/831247Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524586}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/29c14a760682..dd821bc56488 $ git log 29c14a760..dd821bc56 --date=short --no-merges --format='%ad %ae %s' 2017-12-16 ericrk Revert "Increase accuracy of float -> fixed in ICC code" 2017-12-15 ericrk Revert "Remove SkImage deferred texture image data APIs." 2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ e42ec189c..647dca767 (2 commits) 2017-12-15 benjaminwagner Add Goma to CQ as experimental. 2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ 9fc873318..e42ec189c (1 commit) 2017-12-15 reed Revert "Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code"" 2017-12-15 reed Revert "Revert "hide SkImageDeserializer"" 2017-12-15 brianosman Remove unnecessary includes from Viewer 2017-12-15 reed hide unused var 2017-12-15 brianosman Increase accuracy of float -> fixed in ICC code 2017-12-15 caryclark move homogenous with stride to matrixpriv 2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ 195be9424..9fc873318 (2 commits) 2017-12-14 bsalomon Remove fallback in GrRenderTargetContext for using coverage to draw paths with msaa 2017-12-15 benjaminwagner Use n1-highcpu-64 machines for Windows Builds. 2017-12-15 mtklein add 0->0 path to approx_powf() 2017-12-15 reed Revert "hide SkImageDeserializer" 2017-12-11 halcanary SkQP: make_gmkb, gm_knowledge (GM Knowledgebase) 2017-12-15 bsalomon Transform vertices for distance field glyphs on CPU. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Idf78fbf655920981240cc56a07d78147265fd634 Reviewed-on: https://chromium-review.googlesource.com/831262Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524585}
-
Yves Arrouye authored
We want to be able to recognize when the PCA rejects an improper request versus a transient failure. We use the bad request status to upload an empty enrollment certificate to the Cloud to indicate that a machine cannot obtain en enrollment certificate because it is not able (setup) to do attestation-based enrollment. BUG=chromium:778535 TEST=unit tests Change-Id: Ic8b3684dc85895fe23bd192d534393fe45fc1a07 Reviewed-on: https://chromium-review.googlesource.com/823173 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Darren Krahn <dkrahn@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524584}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Ib4c1c3948cd9880d3904d7f6e85bc50686ee90b7 Reviewed-on: https://chromium-review.googlesource.com/831073Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524583}
-
Victor Miura authored
BeginGpuRaster / EndGpuRaster should be used to scope use of GPU raster via a GrContext, so that GrContext and RasterImplementationGLES state can be correctly invalidated. crrev.com/c/828079 depends on this change. BUG=757607 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3c0b8267bc42a051673fc5ef0f91d89dc8f3686e Reviewed-on: https://chromium-review.googlesource.com/830888 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#524582}
-
Zhuoyu Qian authored
As ThreadDebugger is well-known, not need to rename it. Just remove the "TODO" in ThreadDebugger.h BUG= R=dgozman@chromium.org Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I777eb79936b484dacb45cc3fe42c64bb017d7c92 Reviewed-on: https://chromium-review.googlesource.com/826822Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524581}
-
David Tseng authored
- chrome.tabs.create is unavailable when all windows are closed. Use chrome.windows.create instaed - open learn mode in a panel window (e.g. no address bar) - detect when a load complete fires with focus on an ancestor window such as when the learn mode window appears. This interrupts ChromeVox from reading the entire url of the root web area on initial showing of the root which happens before load complete. Since the window never explicitly places focus on the root web area, ChromeVox never reads the title or triggers focus recovery. that a friendly (non-url) title gets read in both cases. Test: launch both options page and learn mode from empty desktop. Verify Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5f564cbaa2dedb07c50878368a371b54bf1ac2a Reviewed-on: https://chromium-review.googlesource.com/825629 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524580}
-
Sunny Sachanandani authored
Flaky on --mus. TBR=oshima@chromium.org Test: none Bug: 765794 Change-Id: I61cae8ce1b1e016ad1dfb2dd294b043ef548e409 Reviewed-on: https://chromium-review.googlesource.com/831342Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524579}
-
dpapad authored
Latest version includes a fix that allows breaking lines within the include attribute of a <style include="...">..</style> tag. Bug: 792748 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I67f56530565b028864d99d980e2bbeefa136c916 Reviewed-on: https://chromium-review.googlesource.com/809889 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524578}
-
Devlin Cronin authored
Rename ExtensionErrorReporter to LoadErrorReporter, and move it into the extensions:: namespace. This is more accurate, since it only handles extension load errors, rather than generic errors, and also helps differentiate it from the ErrorConsole. Bug: 134010 TBR=benwells@chromium.org (apps) TBR=sky@chromium.org (c/b/ui) Change-Id: Ie4c398634674c8a041e0b621c331408483d8bb8c Reviewed-on: https://chromium-review.googlesource.com/820973 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
catmullings <catmullings@chromium.org> Cr-Commit-Position: refs/heads/master@{#524577}
-
Sunny Sachanandani authored
Simplify GenSyncTokenCHROMIUM and GenUnverifiedSyncTokenCHROMIUM to implicitly insert the fence and issue ordering barrier or flush. Change all call sites and update the documentation to reflect this. R=piman BUG=NONE Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8551f8d0ccf3b7f6027f3e54443ae06cfa0d074b Reviewed-on: https://chromium-review.googlesource.com/826007 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524576}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3f769a71026..99da619f6cdc $ git log d3f769a71..99da619f6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: If26ca77e65c921c21b2e1eeaa7d218cbda0d5bf1 Reviewed-on: https://chromium-review.googlesource.com/831256Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524575}
-
Kenneth Russell authored
This is now redundant with "Win10 Release (NVIDIA)". The hardware will be put in the Swarming pool to aid that bot. BUG=786737 TBR=jmadill@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5054e85ff952d1b7e66914be5c2cd067f60621ef Reviewed-on: https://chromium-review.googlesource.com/831333 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524574}
-
Kenneth Russell authored
Thanks to the Maps team for a new benchmark that supports manual control and which can be checked in, and Ned from the Telemetry team for illustrating how this would work, both the benchmark and correctness test have been updated to be simpler and more robust. The new benchmark required new pixel expectations to be sampled for the various colors on the map. The old wprgo archive's SHA1 and associated JSON file have been deleted. BUG=784418 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I662f85e3e8262957231266b8bd1988accca6a750 Reviewed-on: https://chromium-review.googlesource.com/828541Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524573}
-
Scott Chen authored
TBR=dpapad Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic67f14f22a044e68ba9ee84d6fa0674cdfb59f8b Reviewed-on: https://chromium-review.googlesource.com/830491Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524572}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bf4fdf50244..c4c0a915669c $ git log 0bf4fdf50..c4c0a9156 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I5c89cdf6c0e8d3de621fff682d7ce22450a6da84 Reviewed-on: https://chromium-review.googlesource.com/831261Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524571}
-
David Tseng authored
- minimal setup for enabling and creating vk which routes key events - add a test for native find - eliminate double speak in find handler by checking current range Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I13000974b3fe917c4179191b72d8940551612fbb Reviewed-on: https://chromium-review.googlesource.com/827166 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524570}
-
Jared Saul authored
Bug: 778436 Change-Id: I3ec512db30efcd1d3cdefa45d867debde9ec5863 Reviewed-on: https://chromium-review.googlesource.com/823524 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524569}
-
Dirk Pranke authored
This adds the initial support to MB to be able to build and run a binary under swarming easily. It builds on the existing code in MB for building and isolating targets, and just adds uploading the isolate, triggering the task, waiting for and collecting the results. e The end goal is that it should be this easy to reproduce a failure in a bot config: $ fetch chromium && python src\tools\mb\mb.py run --swarmed \ --master tryserver.chromium.win \ --builder win-msvc-rel \ out\Release base_unittests Adding this gives us a starting framework that we can build on for the bit.ly/chromium-test-runner-api cleanup work. R=jbudorick@chromium.org, maruel@chromium.org BUG=794783 Change-Id: I160706b1a563bceb36b8465857d32692a3ca004d Reviewed-on: https://chromium-review.googlesource.com/825925 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524568}
-
Devlin Cronin authored
Currently, ExtensionService unittests explicitly look at the value of the "state" pref in an extension's preference entry to check if it was an externally-uninstalled extension. This is bad because it is fragile and relies entirely on implementation details of ExtensionPrefs. Instead, use ExtensionPrefs::IsExternalExtensionUninstalled() to verify uninstalled external extensions and ExtensionPrefs::GetInstalledExtensionInfo to look for install state. Bug: 794205 Change-Id: I14ea2ce0390c37ccdcdbeea4e23b48b968baaebb Reviewed-on: https://chromium-review.googlesource.com/825943 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524567}
-
Dale Curtis authored
Now that opus is supported in containers outside of ogg, we shouldn't allow negative timestamp fixups to imply the need for chained ogg support. I.e. we shouldn't apply chained ogg workarounds to mp4 files or any other container that opus is allowed in now. This has been broken for a while, but h264+bframes and opus is not common, so the issue hasn't arisen before. The fix is simply to separate these workaround flags and restrict the chained ogg one to only content which we expect to support. BUG=795392 TEST=new unittest. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3a7465110fd1f1defe4b41f1f471e5050d8c469a Reviewed-on: https://chromium-review.googlesource.com/830831 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#524566}
-
Wez authored
Previously the order of std::move() versus dereference to fetch the |indexed_db_observer_|'s TaskRunner was unspecified, potentially leading to a null dereference. Bug: 794842 Change-Id: If08358fcf017bfebe0d615c9230f8af7a02177c9 Reviewed-on: https://chromium-review.googlesource.com/827603Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524565}
-
Kurt Horimoto authored
This CL contains several fixes related to prerendered pages: - Updates the scroll view padding for replaced Tabs. - Updates FullscreenWebStateListObserver, WebScrollViewMainContentUIForwarder, and LegacyToolbarUIUpdater to account for replaced active WebStates. - Updates FullscreenWebStateObserver to stop observing destroyed WebStates. - Updates FullscreenWebStateObserver to use ScopedFullscreenDisablers to prevent unbalanced increment/decrement disabled counter calls. - Updates DCHECKs in MainContentUIState that failed for side-swipes. - Creates TestFullscreenController for internal disabling tests. Bug: 793891, 793966, 793989 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7ed1cd0607e23f34f0991b06386d7d66bf8d86ed Reviewed-on: https://chromium-review.googlesource.com/826266 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#524564}
-
Pavel Feldman authored
This change also does not force extension popup close upon inspect session termination. Bug: 795403 Change-Id: I9ab3e8f0f6b5360f1475f302ab34d18b5b53939f Reviewed-on: https://chromium-review.googlesource.com/830983Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524563}
-
Kyle Horimoto authored
In order to utilize Instant Tethering, Android phones must have their "Google Play Services" notifications enabled. When a Chrome OS device contacts an Android phone without these notifications, the phone returns a special error code. This CL adds information to be displayed in the settings page when this occurs so that the user will know the steps needed to use Instant Tethering, but for now, this information is never displayed. A follow-up CL will integrate this code with the handler for the special error code returned by the phone. Bug: 765966, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I318ebf00301301142bcb73e34b5be2e9c208c737 Reviewed-on: https://chromium-review.googlesource.com/827564 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524562}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9d4d7f06facb..647dca7672f7 $ git log 9d4d7f06f..647dca767 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 jmadill Revert "Vulkan: Roll loader/validation layers SDK. (2/2)" 2017-11-01 fjhenigman Support ozone/gbm back end in standalone gn build. 2017-12-11 fjhenigman Add angle_link_glx arg to standalone gn build. 2017-12-13 brandon1.jones Fix Bug in Intel Workaround 2017-12-06 xinghua.cao ES31: Implement image state query 2017-12-04 oetuaho Always create TVariables for TIntermSymbol nodes 2017-12-12 jmadill D3D11: Fix program uniform buffer dity bits. 2017-11-16 jiawei.shao ES31: Remove support of GL_OES_geometry_shader in compiler 2017-12-13 jmadill Vulkan: Roll loader/validation layers SDK. (2/2) Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1c856a03f0c73ae666ea199b2a475e63060d089e Reviewed-on: https://chromium-review.googlesource.com/831129Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524561}
-
Dave Schuyler authored
This CL fixes the font family when overriding a <button> element with is="cr-link-row". <button> was defaulting to Arial. This CL will inherit its parents font family, which for MD WebUI is Roboto (with some fallbacks). Bug: 795362 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3303425f2dd2e10c95a7f30bf6b919ec7140d4be Reviewed-on: https://chromium-review.googlesource.com/830651Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#524560}
-
dpapad authored
Bug: 794794 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I021ce4292149c6d86302d7b3285f062decff4fd1 Reviewed-on: https://chromium-review.googlesource.com/827590 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524559}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/667fa571db51..175f01bb081b $ git log 667fa571d..175f01bb0 --date=short --no-merges --format='%ad %ae %s' 2017-12-16 thestig Configure CQ to use Windows ASAN bots. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9c380f5b1b60a7d6f3be4837a8f151288f736a7d Reviewed-on: https://chromium-review.googlesource.com/831208 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524558}
-
Lei Zhang authored
TBR=boliu@chromium.org,mkwst@chromium.org,mseaborn@chromium.org,rdsmith@chromium.org,yuweih@chromium.org Change-Id: I9df8549cd56a2a1977b704f091cefe1738bdaf11 Reviewed-on: https://chromium-review.googlesource.com/830979 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524557}
-