- 16 Aug, 2012 40 commits
-
-
kbr@chromium.org authored
Revert 151932 (caused gpu_throughput_tests to start failing on Mac GPU bots) - Hook up Mac OSX VSync parameters to compositor thread Also fixes precision error on Windows. BUG=137794 Review URL: https://chromiumcodereview.appspot.com/10830347 TBR=jbates@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151982 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151979 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
This pulls in the following Native Client changes: r9435: (shcherbina) Validator_ragel: move checkdecoder test from Makefile to scons r9436: (halyavin) Remove commented out code. r9437: (dschuff) Update pnacl TC revision to 9432 r9438: (kschimpf) Define baseline classes for instruction in table simd_dp of ARM validator. r9439: (jvoung) Actually ignore -export-dynamic flag from rev r9423, instead. r9440: (jvoung) Bump gold rev to pull in Tdata change and llvm for cherry pick: r9441: (bradchen) Update enuminsts/ragel_tester.c to fully check base register usage. r9442: (mcgrathr) Extend fpu_control_word test for ARM r9443: (mseaborn) Fix compile-time assertions to check what was intended r9444: (bsy) LOG_FATAL if NACL_EXE_STDERR style I/O redirection fails. handle /dev/null. r9445: (mseaborn) Cleanup: Remove unused #defines of "_WINDOWS" and "_CONSOLE" r9446: (mseaborn) x86-32: Cleanup: Remove "union PtrAbstraction" r9447: (phosek) Make the NaClVmmapUpdate internal and provide NaClVmmapAddWithOverwrite and NaClVmmapRemove public interface r9448: (mseaborn) Debug stub: Remove std_types.h, which duplicates NaCl's portability.h r9449: (mseaborn) Debug stub: Remove unused IPlatform::CreateThread() function r9450: (mseaborn) Debug stub: Cleanup: Remove IPlatform::Log*() functions r9451: (mseaborn) Cleanup: Remove unneeded NaClOopDebugger*() hook functions r9452: (halyavin) Update cygwin version which includes latest crash fixes. r9453: (halyavin) Update scripts to include new cygwin core libraries snapshot. r9454: (shcherbina) Validator_ragel build script: properly call python on windows r9455: (jvoung) Update pnacl version to 9453. r9456: (jvoung) Add pnacl precise bot to trybots list. r9457: (khim) Add options argument to the ValudateChunk{AMD64,IA32} function. r9458: (mcgrathr) Save and restore FPSCR register in ARM trusted<->untrusted context switch r9459: (mseaborn) Cleanup: Remove NaClAppThread's unused "sysret" field r9460: (mseaborn) Debug stub tests: Remove disabled pyauto-based browser test r9461: (khim) Initialize variables in the decoder r9462: (sehr) Add an API to MCSectionData that tracks known offsets for text emitted into a r9463: (phosek) Removed NaClMemObj because it is no longer needed and replaced its use with enumerator. r9464: (jfb) Refactor ARM validator register interfaces. r9465: (shcherbina) Validator_ragel: factor out ProcessInvalidJumpTargets r9466: (mseaborn) Debug stub: Switch to a thread-suspension-based model for catching faults r9467: (mseaborn) Cleanup: Use "#if NACL_WINDOWS" instead of #ifdefs on WIN32 or _WIN32 r9468: (dschuff) Build LLVM from gerrit instead of hg/codesite r9469: (jvoung) Update llvm rev to pull in revert of MC changes: r9470: (dschuff) Dont auto-update depot tools when getting pnacl DEPS. r9471: (noelallen) Fix PyAuto issues on integration bots. r9473: (mcgrathr) Do not leak VFP/NEON register state to untrusted code r9474: (mseaborn) Debug stub test: Ignore "Access denied" error from terminating sel_ldr r9475: (mseaborn) Debug stub: Remove the now-unused IEvent class r9476: (halyavin) Fix modifying parameters in CommandSelLdrTestNacl. r9477: (kschimpf) Don't allow rex.w and data 66 prefixes for instructions with default 64 size. r9478: (ncbray) Fix bug where SConstruct choked on failiures with multiple outputs. r9479: (dschuff) Add script for merging in LLVM git repo r9480: (bradnelson) Revert 9471 - Fix PyAuto issues on integration bots. r9482: (dschuff) add git-has-changes back to common-tools.sh r9483: (mseaborn) Cleanup: Remove unused "tools/tests" directory and CommandGdbTestNacl() r9484: (jvoung) Add 1 elem structs to the calling conv test (mainly to test r9485: (mseaborn) Thread suspension: Remove unused SuspendAllButOne()/ResumeAllButOne() functions r9486: (phosek) The protection for anonymous mapping is stored incorrectly. r9487: (khim) Refactoring the R-DFA validator interface. r9488: (shcherbina) Validator_ragel dfacheckdecoder: change binutils revision r9489: (mseaborn) Debug stub: Disallow memory accesses outside of the sandbox address space r9490: (dschuff) Update Pnacl toolchain revision to 9476 r9491: (khim) Disable branch prediction prefixes for loop/loope/loopne. r9492: (kschimpf) Make loop a conditional jump, and don't allow branch hints on loop, loope, r9493: (bradnelson) Prefer SCons environment methods for functions acting on environments. r9494: (mseaborn) x86-64: Undo removal of the "unused_padding" field from r9443 BUG=none TEST=nacl_integration Review URL: https://chromiumcodereview.appspot.com/10854186 TBR=mseaborn@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151978 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@google.com authored
Reason for revert: See bug 143214. CredentialCacheService::GetLastUpdatedTime() is causing a crash in canary builds during upgrade scenarios from older versions. A real fix for the root cause is under review. The earlier revert in https://chromiumcodereview.appspot.com/10830362 is unlikely to fix the root cause. Until then, the safe thing to do is to disable the feature, by reverting r151169. Original CL description: Sync credential caching is a Win 8 feature that allows Metro and Desktop to share sync credentials under some circumstances. The feature is slated to ship with M23, and was disabled for the M22 branch point. Now that M22 has been branched off, it is time to re-enable the feature. This patch turns on the feature by default, and provides users with the "--disable-sync-credential-caching" flag if the feature must be disabled. BUG=139712,143214 TEST=Sign in on Win 8 and make sure that "Sync Credentials" is written to the default profile directory Old review URL: https://chromiumcodereview.appspot.com/10855063 TBR=tim@chromium.org,zea@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151976 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
This should get rid of the spurious ERROR messages when closing tabs, and log backtraces when we need them. BUG=141055 Review URL: https://chromiumcodereview.appspot.com/10834355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151975 0039d316-1c4b-4281-b951-d872f2087c98
-
hallielaine@chromium.org authored
Currently planning 6 steps for this feature: 1. (this step) Create/delete shortcuts in general (few edge cases) 2. Add functionality for the checkbox- allow the user to select whether they want a shortcut or not from the create/manage profile dialogs 3. Find shortcuts on the desktop by their arguments instead of the path. 4. Handle edge case of 1 to 2 and 2 to 1 profiles (adding/removing icon and name from the shortcut) 5. Update shortcuts when the user changes their name/icon 6. Repopulate shortcuts map when browser starts up (to allow delete/update on new browser instances) This CL depends on: Issue 10826188 BUG=133585 TEST=manual testing Review URL: https://chromiumcodereview.appspot.com/10823217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151974 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
The host process is launched in in two steps now. An instance of remote_service.exe is launched in a user session (CreateProcessAsUser) and then it launches the host requesting elevation (ShellExecuteEx). This is needed because Windows 8 refuses to inject Alt+Tab unless uiAccess='true' is specified in the manifest, which in its turn requires ShellExecuteEx() to be used. Lifetime of launched processes is controlled by assigning them to a job object. Message loop changes are required to be able to process job object notifications on the I/O message loop. BUG=135217 Review URL: https://chromiumcodereview.appspot.com/10831271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151973 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
This makes the ImageSkia resizing code mirror the SkBitmap resizing code more closely. BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10823358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151972 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/10829353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151970 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Also fixed several issues with managing chromoting from the webapp. Now it is possible to start the app and change PIN. BUG=120950 Review URL: https://chromiumcodereview.appspot.com/10824286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151969 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=122753 Review URL: https://chromiumcodereview.appspot.com/10836296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151968 0039d316-1c4b-4281-b951-d872f2087c98
-
vangelis@chromium.org authored
Track crashes when running the s/w rasterizer separately. Also fix an off by one error in the crash counts. BUG= Review URL: https://chromiumcodereview.appspot.com/10825378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151966 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Also, add OWNERS file BUG=none TEST=no spam on console Review URL: https://chromiumcodereview.appspot.com/10827372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151965 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@chromium.org authored
Add the ability to build and run Linux host changes. Add the ability to specify which version of the example to run. Prints a warning the TOOLCHAIN and/or CONFIG specified are invalid. Review URL: https://chromiumcodereview.appspot.com/10827363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151964 0039d316-1c4b-4281-b951-d872f2087c98
-
ncbray@google.com authored
The smoke test is simple - it checks that Chrome can load nexes. The more interesting part of this CL is that it lays the groundwork for adding more NaCl tests to browser_tests. This will allow many nacl_integration tests to be rewritten as browser_tests. This CL adds an extensible jig for decoding messages from Javascript, which makes it easier to add test logic in the web page. This CL also establishes locations in the build directory for nexes and other test data. There are two followup CLs planned: 1) simplify how nexes are built in GYP and 2) share the code for running tests in Javascript with the PPAPI test suite. This is a recommit of r151716 with Linux ASAN tests disabled and GYP tweaks for VS2010. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959 TEST= browser_tests --gtest_filter=NaClBrowserTest* Review URL: https://chromiumcodereview.appspot.com/10827357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151963 0039d316-1c4b-4281-b951-d872f2087c98
-
khorimoto@chromium.org authored
BUG=143209 Review URL: https://chromiumcodereview.appspot.com/10854169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151962 0039d316-1c4b-4281-b951-d872f2087c98
-
mkwst@chromium.org authored
BUG=115482 Review URL: https://chromiumcodereview.appspot.com/10837255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151961 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
BUG=141537 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10831249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151959 0039d316-1c4b-4281-b951-d872f2087c98
-
penghuang@chromium.org authored
BUG=130222 TEST=unittest & browser_test Review URL: https://chromiumcodereview.appspot.com/10692160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151956 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=142966 TEST=dunno repro steps; hope we crash less Review URL: https://chromiumcodereview.appspot.com/10831340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151955 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10830341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151954 0039d316-1c4b-4281-b951-d872f2087c98
-
khorimoto@chromium.org authored
BUG=143013 Review URL: https://chromiumcodereview.appspot.com/10855191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151953 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151952 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r9435: (shcherbina) Validator_ragel: move checkdecoder test from Makefile to scons r9436: (halyavin) Remove commented out code. r9437: (dschuff) Update pnacl TC revision to 9432 r9438: (kschimpf) Define baseline classes for instruction in table simd_dp of ARM validator. r9439: (jvoung) Actually ignore -export-dynamic flag from rev r9423, instead. r9440: (jvoung) Bump gold rev to pull in Tdata change and llvm for cherry pick: r9441: (bradchen) Update enuminsts/ragel_tester.c to fully check base register usage. r9442: (mcgrathr) Extend fpu_control_word test for ARM r9443: (mseaborn) Fix compile-time assertions to check what was intended r9444: (bsy) LOG_FATAL if NACL_EXE_STDERR style I/O redirection fails. handle /dev/null. r9445: (mseaborn) Cleanup: Remove unused #defines of "_WINDOWS" and "_CONSOLE" r9446: (mseaborn) x86-32: Cleanup: Remove "union PtrAbstraction" r9447: (phosek) Make the NaClVmmapUpdate internal and provide NaClVmmapAddWithOverwrite and NaClVmmapRemove public interface r9448: (mseaborn) Debug stub: Remove std_types.h, which duplicates NaCl's portability.h r9449: (mseaborn) Debug stub: Remove unused IPlatform::CreateThread() function r9450: (mseaborn) Debug stub: Cleanup: Remove IPlatform::Log*() functions r9451: (mseaborn) Cleanup: Remove unneeded NaClOopDebugger*() hook functions r9452: (halyavin) Update cygwin version which includes latest crash fixes. r9453: (halyavin) Update scripts to include new cygwin core libraries snapshot. r9454: (shcherbina) Validator_ragel build script: properly call python on windows r9455: (jvoung) Update pnacl version to 9453. r9456: (jvoung) Add pnacl precise bot to trybots list. r9457: (khim) Add options argument to the ValudateChunk{AMD64,IA32} function. r9458: (mcgrathr) Save and restore FPSCR register in ARM trusted<->untrusted context switch r9459: (mseaborn) Cleanup: Remove NaClAppThread's unused "sysret" field r9460: (mseaborn) Debug stub tests: Remove disabled pyauto-based browser test r9461: (khim) Initialize variables in the decoder r9462: (sehr) Add an API to MCSectionData that tracks known offsets for text emitted into a r9463: (phosek) Removed NaClMemObj because it is no longer needed and replaced its use with enumerator. r9464: (jfb) Refactor ARM validator register interfaces. r9465: (shcherbina) Validator_ragel: factor out ProcessInvalidJumpTargets r9466: (mseaborn) Debug stub: Switch to a thread-suspension-based model for catching faults r9467: (mseaborn) Cleanup: Use "#if NACL_WINDOWS" instead of #ifdefs on WIN32 or _WIN32 r9468: (dschuff) Build LLVM from gerrit instead of hg/codesite r9469: (jvoung) Update llvm rev to pull in revert of MC changes: r9470: (dschuff) Dont auto-update depot tools when getting pnacl DEPS. r9471: (noelallen) Fix PyAuto issues on integration bots. r9473: (mcgrathr) Do not leak VFP/NEON register state to untrusted code r9474: (mseaborn) Debug stub test: Ignore "Access denied" error from terminating sel_ldr r9475: (mseaborn) Debug stub: Remove the now-unused IEvent class r9476: (halyavin) Fix modifying parameters in CommandSelLdrTestNacl. r9477: (kschimpf) Don't allow rex.w and data 66 prefixes for instructions with default 64 size. r9478: (ncbray) Fix bug where SConstruct choked on failiures with multiple outputs. r9479: (dschuff) Add script for merging in LLVM git repo r9480: (bradnelson) Revert 9471 - Fix PyAuto issues on integration bots. r9482: (dschuff) add git-has-changes back to common-tools.sh r9483: (mseaborn) Cleanup: Remove unused "tools/tests" directory and CommandGdbTestNacl() r9484: (jvoung) Add 1 elem structs to the calling conv test (mainly to test r9485: (mseaborn) Thread suspension: Remove unused SuspendAllButOne()/ResumeAllButOne() functions r9486: (phosek) The protection for anonymous mapping is stored incorrectly. r9487: (khim) Refactoring the R-DFA validator interface. r9488: (shcherbina) Validator_ragel dfacheckdecoder: change binutils revision r9489: (mseaborn) Debug stub: Disallow memory accesses outside of the sandbox address space r9490: (dschuff) Update Pnacl toolchain revision to 9476 r9491: (khim) Disable branch prediction prefixes for loop/loope/loopne. r9492: (kschimpf) Make loop a conditional jump, and don't allow branch hints on loop, loope, r9493: (bradnelson) Prefer SCons environment methods for functions acting on environments. r9494: (mseaborn) x86-64: Undo removal of the "unused_padding" field from r9443 BUG=none TEST=nacl_integration Review URL: https://chromiumcodereview.appspot.com/10854186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151951 0039d316-1c4b-4281-b951-d872f2087c98
-
cduvall@chromium.org authored
Handlebar renders much faster. Thanks Ben! TBR=kalman@chromium.org BUG=142011 Review URL: https://chromiumcodereview.appspot.com/10857042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151950 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
This removes webview_core and moves the deps directly into the libwebview target. The reason for this change is that make doesn't work correctly with a shared_library that doesn't contain any source files. BUG= Review URL: https://chromiumcodereview.appspot.com/10827382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151949 0039d316-1c4b-4281-b951-d872f2087c98
-
markusheintz@chromium.org authored
(GTK only) When a user closes the Website Setting UI after changing at least one permission setting, then display an info bar that asks the user to reload the website on order the apply the changed setting. BUG=140450 Review URL: https://chromiumcodereview.appspot.com/10857032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151948 0039d316-1c4b-4281-b951-d872f2087c98
-
justinlin@chromium.org authored
BUG=139255 Review URL: https://chromiumcodereview.appspot.com/10834345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151947 0039d316-1c4b-4281-b951-d872f2087c98
-
flackr@chromium.org authored
TBR=jamesr BUG=141439 Review URL: https://chromiumcodereview.appspot.com/10857039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151946 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
This gets rid of an implicit ImageSkia -> SkBitmap conversion. BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10857019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151945 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
The Android NDK compilers, both on GCC 4.2 and on GCC 4.6, throw a warning about incompatible pointer signedness in one of harfbuzz' APIs. That's where the fun comes in: no flag is currently able to disable the warning when using Android's GCCs. We therefore have to disable all warnings. This is unfortunate, but we should still be getting sufficient coverage for other warnings from Linux and Android-clang builds. BUG= Review URL: https://chromiumcodereview.appspot.com/10829354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151944 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=138550 Test=Manual Run ChromeOS with --force-device-scale-factor=2 Go to a website for the first time. Favicon appears in HiDPI in tab strip on CrOS. Review URL: https://chromiumcodereview.appspot.com/10824296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151942 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
The old code incorrectly assumed RenderView frame IDs were globally unique, and used them to track main frame reloads. The corrected version tracks the provisional RenderViewHost instead. The new code also will now never send two LoadStart events to the CaptivePortalReloader without an intervening load committed/aborted event. R=cbentzel@chromium.org BUG=87100,115487 Review URL: https://chromiumcodereview.appspot.com/10837146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151941 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
WorkspaceManager. This will allow introducing different behavior. BUG=137342 TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151939 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
We haven't used libpam for ages :) BUG=None Review URL: https://chromiumcodereview.appspot.com/10829346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151937 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Some of the URLs can include both the scale factor and user email. However, either/both may be missing at times. So make sure the path and scale-factor are parsed correctly from the URL in these cases. BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10837270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151936 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Revert 151364 - [sync] Auto-create credential cache for users who are already signed in and go on to upgrade Chrome Reverted due to crashes in GetLastUpdatedTime(). See crbug.com/143214 CredentialCacheService on Windows 8 writes to the local credential cache when a user actively signs in / reconfigures sync. Existing cached credentials are not updated when Chrome is merely restarted after the user is signed in. This causes a problem when a user is already signed in, and then upgrades (and restarts) chrome from a version that didn't originally support credential caching. In such cases, we never end up caching credentials, and therefore, the user will have to sign in separately to Metro and Desktop. This patch contains the following changes: 1) Adds logic to auto-heal already-signed-in users who upgrade from older versions, by writing existing credentials to the local cache if during restart, we notice that there is no local cache file, and the user is already signed in to sync. 2) Simplifies the logic around checking if an alternate credential cache file exists, and only then initializing |alternate_store_|. It turns out that JsonPrefStore returns a useful PrefReadError field, and there is no need for CCS to do funky stuff on the FILE thread. 3) Simplifies OnInitialzationCompleted, which was being used to observe two separate JsonPrefStores. Instead of having CCS be a PrefStore::Observer, we now use two helper classes -- LocalStoreObserver and AlternateStoreObserver to cleanly divide what is done when each pref store is initialized. 4) Updates prefs::kGoogleServicesUsername by listening to the notifications NOTIFICATION_GOOGLE_SIGNED_OUT and NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL instead of directly listening to the pref change. 5) Fixes a stray instance where we were accessing the gaia username pref via SyncPrefs instead of via the SigninManager. BUG=141555 TEST=Sign in to chrome, exit the browser, and delete "Sync Credentials" from the default profile directory. Restart Chrome and make sure that the credential cache file is freshly written using existing sync credentials. Review URL: https://chromiumcodereview.appspot.com/10830239 TBR=rsimha@chromium.org Review URL: https://chromiumcodereview.appspot.com/10830362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151934 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
BUG=139039 TEST=Check KEY_WLAN (Fn+F11) toggles Wi-Fi on Parrot. Review URL: https://chromiumcodereview.appspot.com/10830346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151933 0039d316-1c4b-4281-b951-d872f2087c98
-
jbates@chromium.org authored
Also fixes precision error on Windows. BUG=137794 Review URL: https://chromiumcodereview.appspot.com/10830347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151932 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
Contributed by: newt@chromium.org BUG=136951 TBR=estade@chromium.org (copied from http://codereview.chromium.org/10824324/ so I can dcommit for newt@) Review URL: https://chromiumcodereview.appspot.com/10836294 Patch from Newton Allen <newt@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151931 0039d316-1c4b-4281-b951-d872f2087c98
-