- 15 Jun, 2018 40 commits
-
-
Dominic Battre authored
This CL increases password readablity by preventing sequences of -- and __ which are rendered as long strokes in some fonts. At the same time it adds some new special characters that are "not scary" ('!' and ':'). Bug: 846694 Change-Id: I19d5b9007725943ac8eafe512339ef85a8c232e5 Reviewed-on: https://chromium-review.googlesource.com/1101208 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567632}
-
Francois Doray authored
This reverts commit 7a59e081. Reason for revert: https://crbug.com/853194 Original change's description: > GPU: Don't flush when destroying transfer buffers. > > Destroying a transfer buffer now requires only an ordering barrier, not > a full flush. This removes a source of unnecessary flushes and makes > resizing the transfer buffer more efficient. > > Bug: 850271, 835353, 828363 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9bfe43c46c00f8e9fc29e6450da788f86e74bc52 > Reviewed-on: https://chromium-review.googlesource.com/1093580 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567494} TBR=sunnyps@chromium.org,rsesek@chromium.org,piman@chromium.org,jdarpinian@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850271, 835353, 828363 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7cd21d6cee9beca02ae28da8614a58e2f53dc848 Reviewed-on: https://chromium-review.googlesource.com/1102346 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567631}
-
Emily Hanley authored
system_health.memory_mobile/browser:media:youtube system_health.memory_mobile/browse:new:cnn TBR=charliea@chromium.org NOTRY=true Bug: 853190 Change-Id: Id51228dccae8dc8d1f03f608f03183b54c79eec6 Reviewed-on: https://chromium-review.googlesource.com/1102344Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567630}
-
Nico Weber authored
When the chromium.clang waterfall was converted to have its json files autogenerated in https://chromium-review.googlesource.com/c/chromium/src/+/818075 ToTMac was the only bot that ran 'isolated_scripts': 'chromium_isolated_scripts', in waterfalls.pyl (to get telemetry tests and crash tests). chromium_isolated_scripts also includes webkit_layout_tests, but until https://chromium-review.googlesource.com/c/chromium/src/+/1060293 it was excluded on ToTMac. Since that CL landed, ToTMac is the only tot bot running layout tests. (We should probably add chromium_isolated_scripts to the other bots too.) It looks like layout tests don't fully pass on macOS 10.13 yet, so pin them to 10.12 swarming slaves, like the Mac10.13 Tests bot does. Bug: 843511 Change-Id: I92c02169e49dd9cce729e32f200149e6bceb5eb7 Reviewed-on: https://chromium-review.googlesource.com/1102478Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567629}
-
Mark Pilgrim authored
TBR=sdefresne@chromium.org Bug: 844974 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie3e26e7fb7ce5e2624c45927f03f0ee8613f766a Reviewed-on: https://chromium-review.googlesource.com/1097213 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#567628}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 853188 Change-Id: I97662b6f615018d4e792185f5bf8786527e9b0b1 Reviewed-on: https://chromium-review.googlesource.com/1102343Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d02fd6682709..31767de5cf0a git log d02fd6682709..31767de5cf0a --date=short --no-merges --format='%ad %ae %s' 2018-06-15 nednguyen@google.com Add wait to make sure that activate tab call wait for the tab to be foregrounded Created with: gclient setdep -r src/third_party/catapult@31767de5cf0a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851463 TBR=sullivan@chromium.org Change-Id: I41847b83c6fbe4d7c0052e9a49dc38ef2f46c464 Reviewed-on: https://chromium-review.googlesource.com/1102399Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567626}
-
David Roger authored
This CL makes DicePrepareMigration the default in profile_management_switches. The entry fieldtrial_testing_config can now be removed. sync_confirmation_handler tests are updated to no longer require or test the OneClickSigninSyncStarter Change-Id: I214b4c50da08f5c2ae49883b21ed18a717157a19 Bug: 781761 Reviewed-on: https://chromium-review.googlesource.com/1088612Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Yuki Shiino authored
ExceptionState is a fundamental utility to throw an exception. Moving ExceptionState into platform/ enables us to implement utilities in platform/ that need to throw exceptions. Bug: 849607 TBR: jbroman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic3b3e5ad09e80510049399a70b7d9e5de0b81a9f Reviewed-on: https://chromium-review.googlesource.com/1100732 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#567624}
-
Mathieu Perreault authored
Permanent error string and "Update card" links. Bug: 850571 Test: none Change-Id: Ic5f726363336ac7c2e860d8794e3614d3654627d Reviewed-on: https://chromium-review.googlesource.com/1102038 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567623}
-
David Bokan authored
These are all currently failing in ToT when run with --enable-slimming-paint-v2 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4b74131b00a26bfc5ba074472aac863cafad484 Reviewed-on: https://chromium-review.googlesource.com/1102170 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567622}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 853062 Change-Id: I3cc1727fb5696b53810589994d864dcd579ddfc9 Reviewed-on: https://chromium-review.googlesource.com/1102325Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#567621}
-
Kush Sinha authored
Bug: 851455 Change-Id: I4570ad8ae909ec32015f38deb1d3d8339f55582f Reviewed-on: https://chromium-review.googlesource.com/1095102Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567620}
-
Thomas Tangl authored
The consent bump now is only shown when there is no refresh token error, i.e. when the user is in a sync-paused state. This can happen because of a local sign-out of Gmail for instance. Bug: 819909 Change-Id: I57e3d0427897acea095ff33933126bbf1dde20a9 Reviewed-on: https://chromium-review.googlesource.com/1102326 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
We always pass kNavigationPolicyCurrentTab from FrameLoader, which is turned into kNavigationPolicyNewForegroundTab. This observation allows us to remove dead branches in EffectiveNavigationPolicy and simplify some calls there. Bug: 849055 Change-Id: I9d1c08fba784111f3a544685da3f69c69380bedc Reviewed-on: https://chromium-review.googlesource.com/1100243Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567618}
-
Allen Bauer authored
The previous CL (https://crrev.com/c/1089723) only focused on getting the tab colors from the browser frame. This CL focuses on ensuring the tab strip is notified of activation and color changes so those colors can be recalculated. Bug: 852388 Change-Id: Ib66c43038e1e8ea823fe991e55239754e5fce097 Reviewed-on: https://chromium-review.googlesource.com/1099048Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#567617}
-
Saman Sami authored
Use NavigationAndFirstPaintWaiter to ensure we wait for the first paint. Bug: 843921 Change-Id: Ia469d2460adf71f7151e2874bed034d6d3acbf10 Reviewed-on: https://chromium-review.googlesource.com/1101641Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#567616}
-
Thomas Tangl authored
When the user is signed into Chrome and clicks the profile card in the user menu, they are now directed to chrome://settings/people. Bug: 852092 Change-Id: I89c770869232956ae8fb00a61cad8ebb6375532f Reviewed-on: https://chromium-review.googlesource.com/1102422Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#567615}
-
Rune Lillesveen authored
Do style recalc for re-attachment in the RecalcStyle machinery. Change-Id: Ic16542e1914fbaf0fa4ed743e67762f577a3f320 Reviewed-on: https://chromium-review.googlesource.com/1098968 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#567614}
-
Vadym Doroshenko authored
Bug: 853149, 831123 Change-Id: I973730d248c560859bc1328fd655bc24fb28ecee Reviewed-on: https://chromium-review.googlesource.com/1102423Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567613}
-
kylechar authored
Things stored in the various FrameSinkManagerImpl maps have pointers back to SurfaceManager and HitTestManager. Ensure the maps are destroyed first. Bug: 850198 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iadb554ff7079ec91a8220c211790af0671c36335 Reviewed-on: https://chromium-review.googlesource.com/1101545Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567612}
-
jonross authored
Update skip list for telemetry_perf_unittests on viz. Bug: 799594 Change-Id: I18737703c6e98e0275a2fa2b3f99e339529e6c49 Reviewed-on: https://chromium-review.googlesource.com/1101457Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567611}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/67c2514bf571..d02fd6682709 git log 67c2514bf571..d02fd6682709 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 perezju@chromium.org [Telemetry] Do not clear Chrome command line on Android after create Created with: gclient setdep -r src/third_party/catapult@d02fd6682709 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849703 TBR=sullivan@chromium.org Change-Id: I6c647e93a0655db67aed5c093f5b0eb0bcc23b70 Reviewed-on: https://chromium-review.googlesource.com/1102397Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3df694fe1174..b7a72a501713 git log 3df694fe1174..b7a72a501713 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@b7a72a501713 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I7d714f4c900aee21c7f81e150394c44ffe6cd60a Reviewed-on: https://chromium-review.googlesource.com/1101733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567609}
-
Maksim Sisov authored
It's now possible to create menu/popup windows in ozone/wayland. What is more, Ozone/Wayland now implements xdg popup objects, which are used for such windows as menus. Basically, popup windows are the only windows, which clients are able to set to whatever place they want on top of a parent window (global coordinates are not available). The FakeServer has also been extended to support xdg popup and positioner objects. What is more, ownership model for the new added objects is a bit different. Instead of keeping them owned by surfaces, they are making use of helper template methods with wl_resource_set_implementation, which automatically take and release unique_ptrs. In the future, all the other mock objects must be turned to that model for simplicity. TEST=XdgVersionV5Test or XdgVersionV6Test WaylandWindowTest.CreateAndDestroyMenuWindow/0, WaylandWindowTest.CreateAndDestroyNestedMenuWindow/0, WaylandWindowTest.CanDispatchEventToMenuWindowNested/0, WaylandWindowTest.CanDispatchEventToMenuWindowNonNested/0 (1 ms) Bug: 578890 Change-Id: Ia644862cce34375d3a758d8c0ff398c75dd47772 Reviewed-on: https://chromium-review.googlesource.com/1075309 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#567608}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9eb38866cd65..8643b78750bb git log 9eb38866cd65..8643b78750bb --date=short --no-merges --format='%ad %ae %s' 2018-06-15 ilnik@webrtc.org Moved NackModule and VCMPacket to their own targets 2018-06-15 kwiberg@webrtc.org Remove support for old test modes in EncodeDecodeTest 2018-06-15 kwiberg@webrtc.org Remove dead RED code in TestRedFec 2018-06-15 kwiberg@webrtc.org Remove executable insert_packet_with_timing 2018-06-14 titovartem@webrtc.org Revert "Drop tools/gyp from dependencies." 2018-06-14 zhihuang@webrtc.org Use RTC_HISTOGRAM_ENUMERATION to report SRTP/SRTCP unprotect error. Created with: gclient setdep -r src/third_party/webrtc@8643b78750bb The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng // All bots passed except for a bot that is purple (unrelated to changes). NOTRY=True BUG=chromium:b/110121202 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I33ad7e85945fd9c2bbeca37c2e94a9557ee77fd0 Reviewed-on: https://chromium-review.googlesource.com/1101734Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#567607}
-
Greg Kraynov authored
Removed outdated TODO. Removed unnecessary use of ThreadTaskRunnerHandle. Change-Id: Ib9f36222c6fd8745d94177fe0762188fdd551fa9 Reviewed-on: https://chromium-review.googlesource.com/1102327 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567606}
-
Noel Gordon authored
Add coverage for MTP to the openQuickView<VolumeType> test group, with a test variation - the initial ephemeral volume (here MTP) mounts with non-empty file content (BASIC_FAKE_ENTRY_SET). Test: browser_test --gtest_filter="QuickView/FilesApp*" Bug: 836254 Change-Id: I21562e5b4905c3b57609b11bd8f231a137ec8884 Reviewed-on: https://chromium-review.googlesource.com/1099096 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567605}
-
Matt Falkenhagen authored
Starts recording the following in NetS13nServiceWorker: - ServiceWorker.FetchEvent.MainResource.Status - ServiceWorker.FetchEvent.Subresource.Status These are important health metrics for service worker interception, and can be used for comparisons in a field trial for NetS13nSW. Bug: 762357 Change-Id: I34d735fdde34b535d0604ce187de3c1acb450ddc Reviewed-on: https://chromium-review.googlesource.com/1098855 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567604}
-
Stuart Langley authored
Previously the passed callback was only called if we actually decided to do the load, now we always call it. This is to support chaining together async loading operations. I have no insight into why the callback is dropped in the original code. Bug: 715355 Change-Id: I5c40f862c0894ce5261880482b5da87ccaf6edfa Reviewed-on: https://chromium-review.googlesource.com/1098737 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567603}
-
Michael van Ouwerkerk authored
This reverts commit 5d3c459e. Reason for revert: Suspected cause of crashes in WebVrTransitionTest Original change's description: > Merging WebVR 1.1 RequestPresent into WebXR RequestSession > > In the WebVR 1.1 spec, the blink code was informed about devices then sent requests > for pipelines to those devices via the mojo interfaces. In the WebXR spec, the > decision about which device to use is left up to the browser, and not decided > until the pipline request has been made. This CL moves the blink<->device interface > pointers from being call parameters to being return parameters to better align > with WebXR. > As WebVR is being deprecated, as much of the old VR code as is possible > has been cleaned out. > > Bug: 842042 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr > Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564 > Reviewed-on: https://chromium-review.googlesource.com/1080967 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567430} TBR=vollick@chromium.org,dcheng@chromium.org,mthiesse@chromium.org,klausw@chromium.org,billorr@chromium.org,offenwanger@chromium.org,ijamardo@chromium.org Change-Id: Ic45c3afc5059a6ee9e3b2ef8dcc9b3eebd59b613 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842042,853147 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1102357Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#567602}
-
Maksim Sisov authored
In particular, there is now a PlatformWindowInitProperties structure, which brings initial properties to ozone windows. It can be initialized (in the future, when other code is in place) with a desired window type, bounds and parenting model, which is very important for Wayland's xdg_popup windows (used for menu windows, for example). Bug: 578890 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr Change-Id: I573912d462d698b19b1bb09cf687971965e951e0 Reviewed-on: https://chromium-review.googlesource.com/1068746 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567601}
-
Jose Dapena Paz authored
GCC fails to implicitely move an T to a base::Optional<T> in return. So this causes a build error. Explicitely std::move(). In this case the issue happened in AuthenticatorGetAssertionResponse. ../../device/fido/authenticator_get_assertion_response.cc: In static member function ‘static base::Optional<device::AuthenticatorGetAssertionResponse> device::AuthenticatorGetAssertionResponse::CreateFromU2fSignResponse(base::span<const unsigned char, 32ul>, base::span<const unsigned char>, base::span<const unsigned char>)’: ../../device/fido/authenticator_get_assertion_response.cc:48:10: error: could not convert ‘response’ from ‘device::AuthenticatorGetAssertionResponse’ to ‘base::Optional<device::AuthenticatorGetAssertionResponse>’ return response; ^~~~~~~~ Bug: 819294 Change-Id: I6410e3d4b10a9e50cae06f5a0b3dfe75d61d8b5d Reviewed-on: https://chromium-review.googlesource.com/1101684 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567600}
-
Tatsuhisa Yamaguchi authored
Bug: 845805 Change-Id: Ia9783b8499ed61e29a7257ba25f414a7db216dc8 Reviewed-on: https://chromium-review.googlesource.com/1100727Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567599}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, notification list should have Clear All button at the bottom of the list. UX spec: http://shortn/_SbJoaT9xpn Screenshot: http://screen/xdFEFjJTs5x TEST=manual BUG=851830 Change-Id: Ia08f4c773d6b155c53e3b189cc9cca743e12150d Reviewed-on: https://chromium-review.googlesource.com/1096808Reviewed-by:
-
Chris Dziemborowicz authored
Bug: 853046 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4843a076212a21ed49bdabe4ec8bc88bda5f94e5 Reviewed-on: https://chromium-review.googlesource.com/1102027Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Chris Dziemborowicz <chrisdz@google.com> Cr-Commit-Position: refs/heads/master@{#567597}
-
Yoshifumi Inoue authored
This patch makes |AXLayoutObject::NextOnLine()| and |PreviousOnLine()| to work with LayoutNG with exporting |NextSiblingOf()| and |PreviousSiblingOf()| via |NGPaintFragmentTraversal|. This patch also introduces |back()| and |front()| in |NGPaintFragment::FrameRange| for ease of getting the last fragment in range and following STL container convention as other functions in |NGInlineFragmentTraversal|. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I51771896882e797ca58f0a88d5513f28bccf3e97 Bug: 591099 Reviewed-on: https://chromium-review.googlesource.com/1096915 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567596}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b520f6298c3e..67c2514bf571 git log b520f6298c3e..67c2514bf571 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 jdoerrie@chromium.org Telemetry: Disable testPlayWaitForEnded On Mac Created with: gclient setdep -r src/third_party/catapult@67c2514bf571 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852495 TBR=sullivan@chromium.org Change-Id: Ifc95d7a8bf8b94c216fee96d8666b1ab47dbf069 Reviewed-on: https://chromium-review.googlesource.com/1101730Reviewed-by:
-
edchin authored
Previously, the section header in recent tabs in tab grid was a little low, and content would scroll up behind the section header. This CL fixes that by adjusting the content inset behavior so that the section header is flush up against the top toolbar. Bug: 852721 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1ab1f2f926b41cc7c874fc8b2250163b90bc4615 Reviewed-on: https://chromium-review.googlesource.com/1102194Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567594}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I9ce6a2d781a7ac718043664f33420b782e5a3d9b Reviewed-on: https://chromium-review.googlesource.com/1101035 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
