GitLab

Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/554583003/)

Reason for revert:
It looks like the moto E perf bots are broken. This change looks like it makes sense so I'm reverting.

crbug.com/414267

Original issue's description:
> Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.
>
> BUG=413481
>
> Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6
> Cr-Commit-Position: refs/heads/master@{#294703}

TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
NOTREECHECKS=true
NOTRY=true
BUG=413481

Review URL: https://codereview.chromium.org/562243004

Cr-Commit-Position: refs/heads/master@{#294816}

TBR=yurys,dsinclair
BUG=409733,361045

Review URL: https://codereview.chromium.org/567383002

Cr-Commit-Position: refs/heads/master@{#294815}

Add visual feedback to AppListButton. The background will draw active in response to touch downs.

TEST=ShelfViewTest.AppListButtonTouchFeedback, ShelfViewTest.AppListButtonTouchFeedbackCancellation
BUG=398398

Review URL: https://codereview.chromium.org/558703002

Cr-Commit-Position: refs/heads/master@{#294814}

Paths of stripped libs in the device used to look like:

    /data/app-lib/*/*.so

But they now look like

    /data/app/*/.../*.so

This patch fixes this function, so that now its associated unittest
(the most time consuming one in telemetry) does not fail.

BUG=396367

Review URL: https://codereview.chromium.org/554283004

Cr-Commit-Position: refs/heads/master@{#294813}

Revert of Telemetry: Fix exact_matches in telemetry.test_runner. (patchset #4 id:60001 of https://codereview.chromium.org/560153004/)

Reason for revert:
Can't find the webrtc tests.

http://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf%20%281%29/builds/2649

Original issue's description:
> Telemetry: Fix exact_matches in telemetry.test_runner.
>
> Previously, if exact_matches was True but there were no exact matches,
> it would return fuzzy matches instead. This is not what the caller asked
> for.
>
> GPU test names are changed to match the buildbot config, since they were
> previously relying on fuzzy matching.
>
> SHERIFFS: May cause errors like:
>
>   No test named "some_test_name".
>
>   Available tests are:
>     ...
>
> If so, this CL can be safely reverted.
>
> BUG=413334,413442
>
> Committed: https://crrev.com/566ed9f6e71cea313c88e8f259eca76581b72d67
> Cr-Commit-Position: refs/heads/master@{#294757}

TBR=nednguyen@google.com,ariblue@google.com,dtu@chromium.org,kbr@chromium.org,tonyg@chromium.org,jbroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413334,413442

Review URL: https://codereview.chromium.org/555703005

Cr-Commit-Position: refs/heads/master@{#294812}

This CL changes the app list item drag zones to use the app icons as
folder creation zones and the space between icons as reorder zones.

The main difference from the previous implementation is that the space
between icons no longer is a drop zone of both adjacent tiles.

These new drag zones attempt to allow the user to move apps into the
gaps between icons which will then create a space for it by moving other
apps out of the way.

The non-folder drag has been unified with the folder drag, causing the
non-folder drag to lose the ability to drop onto the page switcher.

BUG=411775

Review URL: https://codereview.chromium.org/553753003

Cr-Commit-Position: refs/heads/master@{#294811}

BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c

Committed: https://chromium.googlesource.com/chromium/src/+/40979bf265c3ffbe1736a87935418da72be5d1f1

Review URL: https://codereview.chromium.org/548323003

Cr-Commit-Position: refs/heads/master@{#294810}

Cr-Commit-Position: refs/heads/master@{#294809}

The number of buckets should be one more than currently specified.
Otherwise the histogram buckets the values 3 and 4 in the same bucket.

BUG=

Review URL: https://codereview.chromium.org/547693002

Cr-Commit-Position: refs/heads/master@{#294808}

In EmptyTabObserver tabBase needs to be renamed to tab
as per patch https://codereview.chromium.org/148523013

BUG=339423

Review URL: https://codereview.chromium.org/549803003

Cr-Commit-Position: refs/heads/master@{#294807}

Revert of Remove deprecated extension notification from ProcessManager. (patchset #2 id:20001 of https://codereview.chromium.org/566863002/)

Reason for revert:
One of the tests crashes with a UAF: http://crbug.com/414245

Original issue's description:
> Remove deprecated extension notification from ProcessManager.
>
> This patch used EntensionRegistryObserver instead of DEPRECATED extension
> NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED removed now.
>
> BUG=411568
>
> Committed: https://crrev.com/1bd52ffda33ffc5614dab8e3f3d677f0a528e763
> Cr-Commit-Position: refs/heads/master@{#294799}

TBR=bauerb@chromium.org,rockot@chromium.org,limasdf@gmail.com,jitendra.ks@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=411568

Review URL: https://codereview.chromium.org/570073002

Cr-Commit-Position: refs/heads/master@{#294806}

Removed memory leak suppression for crbug.com/381584 as it's not triggered on bots http://chromium-build-logs.appspot.com/suppression_query?suppression_query=bug_381584 since https://codereview.chromium.org/552363002.

BUG=381584
TEST=unit_tests:DeviceOAuth2TokenServiceTest.*
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/563943004

Cr-Commit-Position: refs/heads/master@{#294805}

https://chromium.googlesource.com/chromium/blink/+log/721cecc2cc0843108a454e494f359dfc108e5a84..4f50841c49c5e333a874d1a06d9d4972b79e6896
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/572633002

Cr-Commit-Position: refs/heads/master@{#294804}

BUG=412247
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/565673002

Cr-Commit-Position: refs/heads/master@{#294803}

https://chromium.googlesource.com/chromium/blink/+log/a82af42995715c70007c56509477062160a52754..721cecc2cc0843108a454e494f359dfc108e5a84
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/564413002

Cr-Commit-Position: refs/heads/master@{#294802}

The only way to get the tracing data used to be by reading the file
provided in TracingController::DisableTracing() interface. This does
not fit well for most usages, so this introduces a TraceDataSink
interface that is backed either by a file, string, or, in case of
DevTools, by the protocol client.

This resolves the OOM in browser and imporves performance while
recording very large traces through DevTools, streamlines
TracingController core and reduces coplexity of code for most
TracingController clients.

BUG=409733,361045

Review URL: https://codereview.chromium.org/541763002

Cr-Commit-Position: refs/heads/master@{#294801}

HTML Tags: object, ins, mark, i, legend, frameset, caption, body, th
Aria role: row, spinbutton
Aria state/property: aria-atomic

BUG=170580

Review URL: https://codereview.chromium.org/570983002

Cr-Commit-Position: refs/heads/master@{#294800}

This patch used EntensionRegistryObserver instead of DEPRECATED extension
NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED removed now.

BUG=411568

Review URL: https://codereview.chromium.org/566863002

Cr-Commit-Position: refs/heads/master@{#294799}

BUG=none

Review URL: https://codereview.chromium.org/563923006

Cr-Commit-Position: refs/heads/master@{#294798}

Review URL: https://codereview.chromium.org/555953005

Cr-Commit-Position: refs/heads/master@{#294797}

https://chromium.googlesource.com/chromium/blink/+log/6a1d3229384c77529ed15332451294d07c8ab4f5..a82af42995715c70007c56509477062160a52754
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/567313002

Cr-Commit-Position: refs/heads/master@{#294796}

Avoid keeping track of returned tiles. Instead of that, determine the
tree which should return shared tiles and use that information to skip
shared tiles in the other tree.

Review URL: https://codereview.chromium.org/541843002

Cr-Commit-Position: refs/heads/master@{#294795}

This reverts commit 40979bf2.

BUG=398856

Review URL: https://codereview.chromium.org/570053002

Cr-Commit-Position: refs/heads/master@{#294794}

BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c

Review URL: https://codereview.chromium.org/548323003

Cr-Commit-Position: refs/heads/master@{#294793}

https://chromium.googlesource.com/chromium/blink/+log/3f1bcc4d1f8057a7da5bc204180939f7fbc4e7d9..6a1d3229384c77529ed15332451294d07c8ab4f5
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/569983003

Cr-Commit-Position: refs/heads/master@{#294792}

It's tickling some strange leaks out of allocations in system libraries.

TBR=glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414191

Review URL: https://codereview.chromium.org/552743006

Cr-Commit-Position: refs/heads/master@{#294791}

SearchResultView::SetResult() was missing a call to
OnPercentDownloadedChanged().

This CL adds one.

BUG=402859

Review URL: https://codereview.chromium.org/568383002

Cr-Commit-Position: refs/heads/master@{#294790}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/572583002

Cr-Commit-Position: refs/heads/master@{#294789}

This adds GN rules for everything in mojo except for python bindings
targets and the android packaging rules. The group //mojo builds all
targets in the subdir, just like the gyp 'mojo' target.

R=brettw@chromium.org
TBR=acolwell@chromium.org for //media/build/BUILD.gn

Review URL: https://codereview.chromium.org/563953003

Cr-Commit-Position: refs/heads/master@{#294788}

Minor changes needed to avoid requiring TestingProfile.

BUG=373244

Review URL: https://codereview.chromium.org/501393004

Cr-Commit-Position: refs/heads/master@{#294787}

Revert of [Mac] Implement a new WebSandboxSupport method to get the display's color space. (patchset #1 id:1 of https://codereview.chromium.org/549213004/)

Reason for revert:
Not needed, used https://codereview.chromium.org/554033002 instead.

Original issue's description:
> [Mac] Implement a new WebSandboxSupport method to get the display's color space.
>
> This new interface is defined at https://codereview.chromium.org/554033002/.
>
> BUG=397642,306348
> R=avi@chromium.org
>
> Committed: https://crrev.com/b6ae4d0ecc983a71a32ab1480a70e065c718c195
> Cr-Commit-Position: refs/heads/master@{#293852}

TBR=avi@chromium.org,rsesek@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397642,306348

Review URL: https://codereview.chromium.org/563943003

Cr-Commit-Position: refs/heads/master@{#294786}

To maintain synchronous scripting backward compatibility, v8 arrays should
always be converted to object vars when allowed. I have added a comment
explaining the conversion of objects in more detail.

This CL also adds a check to ensure that when we convert an object var to
a v8 value that it is never nested inside of an array or dictionary. Before
we switched from NPObject to gin, this was never possible so there is no
need to add this functionality now and we should restrict this case from
ever happening.

BUG=411445

Review URL: https://codereview.chromium.org/566463002

Cr-Commit-Position: refs/heads/master@{#294785}

https://skia.googlesource.com/skia/+log/8e45c3777d886ba3fe239bb549d06b0693692152..e6cb48382db869f8e194b83aec80fd495be76db7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/570963002

Cr-Commit-Position: refs/heads/master@{#294784}

This reverts commit 80931e51.

Linux GN build failed:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12251

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/571853002

Cr-Commit-Position: refs/heads/master@{#294783}

Revert of PPAPI: Fix GetBrowserInterface race conditions (patchset #6 id:100001 of https://codereview.chromium.org/568793002/)

Reason for revert:
Sorry to revert but I randomly noticed this to be causing a top crasher e.g. go/crash/75090c1e31f33cfd

The reason is because the patch explicitly calls PluginGlobals::SetPluginProxyDelegate with NULL from PpapiThread::Shutdown but the pointer is used immediately inside the function.

I guess it should be a simple fix. I was going to put up a fix which just reset the browser_sender_ to NULL in that case, but then I noticed there were cases where we call GetBrowserSender() and use it without checking whether it is NULL (e.g. https://code.google.com/p/chromium/codesearch#search/&q=%22PluginGlobals::Get()-%3EGetBrowserSender()-%3ESend%22&sq=package:chromium&type=cs)

I felt it would be better to just revert for now, sorry :(

Original issue's description:
> PPAPI: Fix GetBrowserInterface race conditions
>
> BUG=413513
>
> Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a
> Cr-Commit-Position: refs/heads/master@{#294715}

TBR=teravest@chromium.org,piman@chromium.org,dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413513

Review URL: https://codereview.chromium.org/566243004

Cr-Commit-Position: refs/heads/master@{#294782}

https://skia.googlesource.com/skia/+log/abaef86f2b37d8a939506a2076da07f6db456951..8e45c3777d886ba3fe239bb549d06b0693692152

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/557833005

Cr-Commit-Position: refs/heads/master@{#294781}

BUG=

Review URL: https://codereview.chromium.org/477923004

Cr-Commit-Position: refs/heads/master@{#294780}

This change:
- Adds running the GC until the v8 heap size reaches steady state during
  ModuleSystemTest::TearDown. This is necessary to ensure that
  gin::Wrappable objects are freed, as finalizers for JS objects aren't
  run during isolate shut down.
- Removes a racy check that failed under valgrind.

BUG=389016,406487

Review URL: https://codereview.chromium.org/502893002

Cr-Commit-Position: refs/heads/master@{#294779}

graph.py in dmprof needs to support policies without l2

R=dmikurube@chromium.org,kouhei@chromium.org
BUG=413999

Review URL: https://codereview.chromium.org/567173002

Cr-Commit-Position: refs/heads/master@{#294778}

This CL splits the common drop_target_ member of AppsGridView into
reorder_drop_target_ and folder_drop_target_. This more clearly shows
the purpose which a drop target is being used for.

This also slightly changes the behavior when dropping an app into a
full folder as the latest reorder drop target will be used for
reordering instead of the common drop target which would have pointed
at the folder.

BUG=411775

Review URL: https://codereview.chromium.org/557673002

Cr-Commit-Position: refs/heads/master@{#294777}