- 07 Nov, 2019 40 commits
-
-
Ahmed Fakhry authored
This CL remove the "--enable-virtual-desks-gestures" flag entirely and enables the 4-finger swipes to switch desks on M-80 going forward. BUG=1005340 TEST=Tested manually on device, updated existing tests. Change-Id: Ic5cd4a4042433ef3828038e2675df2838ea31d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902080 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713319}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64036088..80def79b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3cb7ac93017f56ba7a4beff00aa3db2f99659371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902586Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713318}
-
Khushal authored
Instead of assuming that the child initializes the filter on the received resource to a known state, always initialize it before using. If the client sends the resource with the specified |filter| on TransferableResource, then it is returned with the same state. If the client sends it in any other state, then it should assume that it is returned in an unknown state. R=sunnyps@chromium.org Change-Id: Idd2cc884d27c053edd2ac48078faf324914cc8b0 Bug: 1018898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888951 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#713317}
-
Miyoung Shin authored
This change converts MimeHandlerService mojom interface client in components to use BrowserInterfaceBroker Since MimeHandlerViewGuest is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482 Change-Id: Ib47255e7cbcdc0701491357bb21aea8d18d0602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895018Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#713316}
-
Fergal Daly authored
We just disable bfcache for these tests. Bug: 1019077 Change-Id: I77245839258af1b842a736d5058fa244813f5d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889830 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713315}
-
John Lee authored
Previously, there was a race condition between when the IntersectionObserver's callback would get fired for the first time each TabElement was added into the view, and when the callback would be expected to have been called for an individual test's setup. Ran 100 times with no failures. Fixed: 1022008 Change-Id: I5e418cb8fc691fd4ecd32c3d88a9805f1bdc2f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902070Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713314}
-
Victor Vasiliev authored
Roll src/net/third_party/quiche/src/ dfbd3df88..fa63b6e14 (21 commits) https://quiche.googlesource.com/quiche.git/+log/dfbd3df88865..fa63b6e147fd $ git log dfbd3df88..fa63b6e14 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 wub Fix a gfe_quic_fuzzer issue caused by uninitialized packet number. 2019-11-05 fayang gfe-relnote: In QUIC T049+, support sending coalesced packets. 2019-11-05 wub gfe-relnote: (n/a) Add QuicCircularDeque to third_party/quic/core. Code not used yet. 2019-11-05 bnc Remove QuicheMakeUnique. 2019-11-05 wub gfe-relnote: In quic_framer.cc, replace PacketNumberIntervalLength(interval) by interval.Length(). Not protected. 2019-11-05 wub Internal QUICHE change 2019-11-04 quiche-dev Add support for creating a persistent TUN device (that survives across Bonnet restarts). 2019-11-04 renjietang Change name of QuicStream::HasFinalReceivedByteOffset() to HasReiceivedFinalOffset(). 2019-11-04 vasilvv Add a simple QuicTransport server for testing and demo purposes. 2019-11-04 fayang gfe-relnote: In QUIC, add a connection option to use 2 * rttvar when calculating PTO timeout. Protected by existing gfe2_reloadable_flag_quic_enable_pto. 2019-11-04 bnc Add QuicDispatcherPeer::GetTimeWaitListManager() method. 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_donot_process_small_initial_packets. 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_simplify_stop_waiting. 2019-11-04 fayang gfe-relnote: In QUIC, add SetSoftMaxPacketLength to set a soft max packet length in creator. If a single frame is failed to be serialized, restore the actual max packet length. Not used yet. Not protected. 2019-11-04 renjietang Use connection's encryption level at QuicCryptoStream::OnCryptoFrame(). 2019-11-04 dschinazi Enable all versions in toy server 2019-11-04 dschinazi Deprecate quic_parse_prox_source_connection_id 2019-11-04 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames3. 2019-11-04 fayang gfe-relnote: In QUIC, add connection option to enable IETF loss detection with both adaptive packet and adaptive time threshold. Protected by existing gfe2_reloadable_flag_quic_enable_ietf_loss_detection. 2019-11-04 fayang gfe-relnote: In QUIC, add 2 connection options to set the start point of exponential backoff when calculating PTO timeout. Protected by exisiting gfe2_reloadable_flag_quic_enable_pto. 2019-11-04 fayang gfe-relnote: In GFE, add two QUIC connection options for cwnd bootstrap experiments with different multipliers. Protected by existing gfe2_reloadable_flag_quic_use_ip_bandwidth_module. Created with: roll-dep src/net/third_party/quiche/src Roll src/net/third_party/quiche/src/ fa63b6e14..7a4d20901 (7 commits) https://quiche.googlesource.com/quiche.git/+log/fa63b6e147fd..7a4d20901fbb $ git log fa63b6e14..7a4d20901 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 quiche-dev Send an ICMP6_PACKET_TOO_BIG when we try to send a message that is too big. 2019-11-06 wub gfe-relnote: (n/a) Make QuicCircularDeque compile in Chromium. Code not used yet. 2019-11-06 vasilvv Replace kMaxIetfVarInt with UINT32_MAX, as size_t on 32-bit platforms is smaller than kMaxIetfVarInt, thus causing a compile error on those platforms. 2019-11-05 wub gfe-relnote: (n/a) Remove a QUIC_BUG in quic::PacketNumberQueue::AddRange. Test only. Not protected. 2019-11-05 renjietang Remove redundant stream finding code when STOP_SENDING frame is received. 2019-11-05 dschinazi Update to IETF draft 24 2019-11-05 fayang gfe-relnote: Remove QuicPacketGenerator. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I2ba2a6140544cd2f07f43b4fa68c36873c65e6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900429 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#713313}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c1501a6caf64..62303e032c7c git log c1501a6caf64..62303e032c7c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 cjmcdonald@chromium.org DependencyService: Return empty source paths for empty package list Created with: gclient setdep -r src/third_party/chromite@62303e032c7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic79b8a0e58316189ecfd35ae362c8ac1e265718a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4b80864f88f..12e6d18c4860 Created with: gclient setdep -r src-internal@12e6d18c4860 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: I9338f4f8015bfe840ca7ee8cf8e34d3557023f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713311}
-
Peter Kasting authored
Bug: 1003612 Change-Id: I6102b7923150414c339745b3831dc607b5c145ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902719 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713310}
-
Jarryd authored
Rename QuotaDiskInfoHelper to QuotaDeviceInfoHelper and add another method to it, AmountOfPhysicalMemory. This allows mocking physical memory in unit tests, particularly useful for testing code having to do with incognito mode. This change also removes a specialized function in QuotaSettings that was used exclusively for testing. Follow up to https://crrev.com/c/1890055 Bug: 1017120 Change-Id: If28105bba658cdff1e3f58340b6dc7bda8285289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895074Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713309}
-
tby authored
We want clients to be able to make logging calls from any sequence. The data flow of the framework looks like this: (client) -----> Recorder -----> Metrics Provider <----- UMA | | | sends sends grabs cached logging log info log info calls periodically The UMA backend requests log info on the browser UI sequence, so we must ensure all Recorder -> Metrics Provider calls also happen on the UI sequence for thread safety. This CL adds logic to the Recorder that checks which sequence a client called on. If it is *not* the UI sequence, it re-calls itself on the UI sequence. This changes the picture to: maybe reschedule on UI seq _______ | | | V (client) -----> Recorder -----> Metrics Provider <----- UMA | | | any seq UI seq UI seq Bug: 1016655 Change-Id: I81d5168eef8b0ad138e09e89a28b6efca3c6c0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902179Reviewed-by:Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#713308}
-
Matt Falkenhagen authored
The intent is to experiment to get data and safely merge to beta with the option to killswitch if necessary. This temporary disables the feature so it can be merged to 79 in that state, a subsequent patch will re-enable it. Bug: 1012143 Change-Id: Idf5cc9de833c0999a233b943dc856ef020182951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900797 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713307}
-
cjamcl@google.com authored
Bug: 772558 Change-Id: I93accea011a5671016e0985ca416c485e08e72c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902771 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#713306}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I23243efe308bcd4ed9e2ddc0dfe38db14bb360b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902921Reviewed-by:
-
Kuo Jen Wei authored
We currently only support pinning camera app from its internal app id (Unified id in shelf mapping from android camera app and chrome camera app). While the default camera app id showing on admin console is chrome camera app id. This CL apply map logic to pinned app id syncing from admin console. Bug: 1017018 Change-Id: Ibc2386da04806a282cc921f1457d962fdb36778c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895019Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713304}
-
Dan Beam authored
Bug: 1020725 Change-Id: I71b1458601374e4024c42e044e6d1ff625ec4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900614 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#713303}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed392790fed1..866bde58907c git log ed392790fed1..866bde58907c --date=short --no-merges --format='%ad %ae %s' 2019-11-06 treehugger-gerrit@google.com Merge "Disable fdsan after clone(2)." Created with: gclient setdep -r src/third_party/perfetto@866bde58907c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I07202cbe452b7987965b80ab4e335568cc8798d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902190Reviewed-by:
-
Kuo-Hsin Yang authored
Some log messages are incorrectly identified as IPv6 address, e.g. function identifiers with namespace. Requiring word boundaries around IPv6 address with alphanumeric character at the start/end, e.g. "e::ab" in "State::abort" is not an IPv6 address. Also avoid adding empty string to identifier_space. Bug: 1019577 Test: components_unittests --gtest_filter="AnonymizerToolTest.*" Change-Id: Ib57508a3189f5518c10e4169120eece02ec2dfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893486Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713301}
-
Chris Lu authored
This new property will be important for Infobars whose actions will take some time and require the banner persisting to visualize that process. This change also adds InfobarTranslateCoordinator as implementing InfobarCoordinatorImplementation. Bug: 1014959 Change-Id: Iaa21fd9f3025e9797f9d0b63f6337efd0e3cb89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899635 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713300}
-
Jenny Zhang authored
TBR=xiyuan@chromium.org Bug: 1016026 Change-Id: I22637b311ac3c69029504ff7cedf5df5943f145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899802 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/714f8cc3ff4b..67d43fe58187 git log 714f8cc3ff4b..67d43fe58187 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 csmartdalton@google.com Rename stencil face terminology to clockwise/counter-clockwise 2019-11-06 herb@google.com Allow more sub-pixel position bits Created with: gclient setdep -r src/third_party/skia@67d43fe58187 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ia2603d7acd27b36a9c0eb37efd682e7dc50dc561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902470Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4dffa04d4f00..361d1c3e5ab4 git log 4dffa04d4f00..361d1c3e5ab4 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 peah@webrtc.org Simplifications/refactoring of the analog AGC to make it multichannel 2019-11-06 alessiob@webrtc.org RNN VAD: Optimize GRU (recurrent) weights optimized layout 2019-11-06 yvesg@webrtc.org Expose OpusTest class for re-use as chromium test. Created with: gclient setdep -r src/third_party/webrtc@361d1c3e5ab4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1002973 Change-Id: Ieda0e47db3b117ef433dfe3a3b14dd66fb15ea8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902469Reviewed-by:
-
Christian Biesinger authored
See stack trace below. We set the override container logical height to -1 for the initial layout of a flex item so that we compute the correct size for min-height. However, that messes with our cache for definite heights because we would always set it to indefinite in such a case. Instead, just don't cache these values. That way we will later compute the right thing for resolving flex-basis, etc. (FlexNG can't come soon enough...) #0 blink::LayoutBox::ContainingBlockLogicalHeightForPercentageResolution (this=0x3dda8d434198, out_cb=0x7f6e7d42d8c0, out_skipped_auto_height_containing_block=0x0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:3833 #1 0x00007f6ee84ad0a1 in blink::LayoutFlexibleBox::MainAxisLengthIsDefinite (this=0x3dda8d434010, child=..., flex_basis=Length(0%, Percent), add_to_cb=false) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:762 #2 0x00007f6ee84af930 in blink::LayoutFlexibleBox::MainSizeIsDefiniteForPercentageResolution ( this=0x3dda8d434010, child=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1125 #3 0x00007f6ee84ad7f5 in blink::LayoutFlexibleBox::UseOverrideLogicalHeightForPerentageResolution ( this=0x3dda8d434010, child=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1137 #4 0x00007f6ee83f2b9d in blink::LayoutBlock::AvailableLogicalHeightForPercentageComputation ( this=0x3dda8d434198) at ../../third_party/blink/renderer/core/layout/layout_block.cc:2333 #5 0x00007f6ee845e745 in blink::LayoutBox::ContainingBlockLogicalHeightForPercentageResolution ( this=0x3dda8d4243d0, out_cb=0x0, out_skipped_auto_height_containing_block=0x0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:3830 #6 0x00007f6ee86dcc5c in blink::LayoutBoxUtils::AvailableLogicalHeight (box=..., cb=0x3dda8d434198) at ../../third_party/blink/renderer/core/layout/ng/layout_box_utils.cc:64 #7 0x00007f6ee86eafea in blink::LayoutNGMixin<blink::LayoutBlockFlow>::ComputeIntrinsicLogicalWidths ( this=0x3dda8d4243d0, min_logical_width=0px, max_logical_width=0px) at ../../third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc:48 #8 0x00007f6ee83ef53a in blink::LayoutBlock::ComputePreferredLogicalWidths (this=0x3dda8d4243d0) at ../../third_party/blink/renderer/core/layout/layout_block.cc:1509 #9 0x00007f6ee8451f01 in blink::LayoutBox::MaxPreferredLogicalWidth (this=0x3dda8d4243d0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:1395 #10 0x00007f6ee84adba2 in blink::LayoutFlexibleBox::ComputeInnerFlexBaseSizeForChild (this=0x3dda8d434198, child=..., main_axis_border_and_padding=0px, child_layout_type=blink::LayoutFlexibleBox::kForceLayout) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:890 #11 0x00007f6ee84ae5d1 in blink::LayoutFlexibleBox::ConstructAndAppendFlexItem (this=0x3dda8d434198, algorithm=0x7f6e7d42ed70, child=..., layout_type=blink::LayoutFlexibleBox::kForceLayout) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1203 #12 0x00007f6ee84aa27b in blink::LayoutFlexibleBox::LayoutFlexItems (this=0x3dda8d434198, relayout_children=true, layout_scope=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:934 #13 0x00007f6ee84a9cff in blink::LayoutFlexibleBox::UpdateBlockLayout (this=0x3dda8d434198, relayout_children=true) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:369 Bug: 1019138 Change-Id: Ie94e69a5f3fe6accc3623d358315b174088d5597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902514 Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713296}
-
Becca Hughes authored
The Media.Engagement.SessionFinished UKM event has lots of fields from when we were experimenting. We should remove these prior to our storage cleanup. BUG=998685 Change-Id: I87bbd5221d97161e042345e00b778096c3729523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775195Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#713295}
-
Tsuyoshi Horo authored
This reverts commit 3e01d61b. Reason for revert: Caused build failure https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/5699 [56914/72140] CXX obj/content/test/content_browsertests/render_frame_impl_browsertest.o FAILED: obj/content/test/content_browsertests/render_frame_impl_browsertest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../content/renderer/render_frame_impl_browsertest.cc:50:10: fatal error: 'third_party/blink/public/mojom/frame/frame_host_test_interface.mojom.h' file not found #include "third_party/blink/public/mojom/frame/frame_host_test_interface.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > [mojo] Remove DocumentInterfaceBroker > > This change removes the DocumentInterfaceBroker mojom interface and all > related plumbing. No functional changes since the interface was not used > by anything (clients migrated to BrowserInterfaceBroker). > > TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org > > Bug: 985120 > Change-Id: I893f940bc2c5d237aac5fb6b3962c06bfa98e938 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881394 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713278} TBR=dcheng@chromium.org,kenrb@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org,alexmos@chromium.org,chcunningham@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,oksamyt@chromium.org Change-Id: I6c25e96111dca691e007353a27710251b125659e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902181Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713294}
-
Oriol Brufau authored
There are already some perf tests with lots of grid items, but they only span a single track. The track sizing algorithm handles contributions from items with a span of 1 in a simpler way than when the span is greater than 1. So testing the >1 case is useful. This patch adds a copy of the auto-grid-lots-of-data.html perf test, but using items with a span of 2 instead of 1. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-items Bug: 1021929 Change-Id: Ifd73e28a72128113416b20d7934b96c353e93969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901286Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#713293}
-
Takashi Sakamoto authored
This reverts commit f7860793. Reason for revert: suspect causing compile failure on linux-chromeos-google-rel. Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8776 Original change's description: > assistant: add audio ducking for internal media > > Bug: b/135064564 > Test: locally build and run with multiple media playing > Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713200} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: I6595ecc2d3ea93a762996386f3af9bf297daed70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/135064564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902180Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#713292}
-
Ahmed Mehfooz authored
Bug: 1021639 Change-Id: If65812f8a2d961f88fc66c9b060671e7b7d8e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900293Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713291}
-
Theresa Wellington authored
Move android_chrome_strings.grd to its own separate build target and merge ui widget strings back into android_chrome_strings.grd. BUG=1002534 Change-Id: I179e2d74ba8dc169574fd2596915067ebb357787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895971Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713290}
-
Chris Lu authored
The banner should not be dismissed if the Infobar's action has not finished. This is because Infobars that have a non-instantaneous action will persist the banner until completion. Bug: 1014959 Change-Id: I3b9a442c60163a29ef37ec6a1e39ae66734e74d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900136 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Junbo Ke authored
Bug: b/143499157 Test: CQ Merge-With: eureka-internal/332932 Change-Id: I98b2331231a85c84dda4f894bf5336fae37a16af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894298Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
-
Zhongyi Shi authored
The QuicChromiumPacketReader upon finishing the socket read, will dereference the socket to get local and peer addresses and report packet back to the visitor unconditionally even if the connection is closed. The patch landed in crrev.com/c/1900569 nulls out the socket upon connection close, leading to null dereference when fetching local and peer addresses. Bug: 1014092, 1021938 Change-Id: I9af79f03b3e2ffbe1ed036af8980efa6b6d1478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901946 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Marina Sakai authored
Remove a macro-generated function for a private property of MessageEvent and all the macros in v8_private_property.h This CL removes a macro-generated function for a private property of MessageEvent, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Now we can remove all the macros in v8_private_property.h. Bug: 715418 Change-Id: Id4ce8e9cc45deea7e9e8bf2064bc44b8559cc0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899227Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#713286}
-
Anupam Snigdha authored
Display attributes may not be available for all compositions so added a null check to avoid crashes in ui::TSFTextStore::GetDisplayAttribute while querying for attribute info using ITfDisplayAttributeInfo object. Bug: 1017313 Change-Id: Icac383a03729ba62cca0b45a67c324eb359e2283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902111Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713285}
-
Alan Cutter authored
This text used to be for a model dialog but is now used by a bubble. Bubble dialogs don't use title text on any platform. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419504&signed_aid=U0mvxY1dLrVi4TEDJKYtrA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419505&signed_aid=_YtJNSAFtjqMsLVgd1Foqg==&inline=1 Fixed: 1020310 Change-Id: Ia613fe934041fec7326550d8a438a4ab07f0d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898905 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#713284}
-
Rahul Arakeri authored
This CL deletes this VirtualTestSuite because it is not a configuration that is shipped on Windows or Linux. This config is run only on Mac which already has coverage. Bug: 1022096 Change-Id: Ia54bbd71c458c51fdbbe058c7564801f62b28afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901640Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713283}
-
Sajjad Mirza authored
This fixes link-time undefined symbol errors that occur because the Clang profiling runtime uses symbols from the C runtime. Bug: 1020445 Change-Id: Ic7b1f9cb970ff26592a934675ee5bc204249f4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896238Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6072d056a7cb..322220a0b205 git log 6072d056a7cb..322220a0b205 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 timvp@google.com Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData Created with: gclient setdep -r src/third_party/angle@322220a0b205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ia934d70c5748bc80c845e831afde719855b76709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902082Reviewed-by:
-
Michael Spang authored
This shouldn't be necessary any longer; it was fixing small errors introduces by computing rotations using trig functions. Bug: 1019015 Change-Id: Ia6c273454f96c556f34d0adca391eb0e121a98b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885635 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713280}
-
