GitLab

If a non-client frame is set to a system modal, its embedded sub-window
should be able to receive events.

For example, creating a JS alert() creates a non-client frame and sets it
to MODAL_TYPE_SYSTEM. Previously users couldn't click on the OK inside
the client window since all events were routed to the non-client frame.

BUG=699213

Review-Url: https://codereview.chromium.org/2737003002
Cr-Commit-Position: refs/heads/master@{#456058}

Passing null to AccountManagerHelper.updateCredentials would cause
NullPointerException, which led to creation of unnecessary callbacks,
for example in SyncCustomizationFragment. This CL fixes it.

BUG=NONE

Review-Url: https://codereview.chromium.org/2740873004
Cr-Commit-Position: refs/heads/master@{#456057}

BUG=

Review-Url: https://codereview.chromium.org/2742973002
Cr-Commit-Position: refs/heads/master@{#456056}

This CL adds 6 custom accessibility actions to Reading List:
- Delete entry
- Mark Read/Unread
- Open in New Tab
- Open in New Incognito Tab
- Open Offline in New Tab
- Copy Link

BUG=676290
TEST=Enable custom action with VoiceOver.
Test that the Reading List entries have the custom actions described in the CL
description.
Test that the current edit behavior (using the toolbar) is undisturbed.

Review-Url: https://codereview.chromium.org/2737663005
Cr-Commit-Position: refs/heads/master@{#456055}

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item,  CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737793003
Cr-Commit-Position: refs/heads/master@{#456054}

This CL adds 6 custom accessibility actions to Reading List:
- Delete entry
- Mark Read/Unread
- Open in New Tab
- Open in New Incognito Tab
- Open Offline in New Tab
- Copy Link

For now the actions are no-op.

BUG=676290

Review-Url: https://codereview.chromium.org/2743713002
Cr-Commit-Position: refs/heads/master@{#456053}

This allows Custom Tabs and Web Apps to use video persistence.

BUG=

Review-Url: https://codereview.chromium.org/2742983002
Cr-Commit-Position: refs/heads/master@{#456052}

https://skia.googlesource.com/skia.git/+log/6e1e27b7fccd..0e5a9906e350

$ git log 6e1e27b7f..0e5a9906e --date=short --no-merges --format='%ad %ae %s'
2017-03-09 iannucci [recipes.cfg] manually roll recipes to get skia recipe roller unstuck.

Created with:
  roll-dep src/third_party/skia
BUG=699379


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I520d94e4ec7d08adacf7934ca7cb25af20c15c85
Reviewed-on: https://chromium-review.googlesource.com/452668Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456051}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2ae07fc28bb3..bd893d0c2c9d

$ git log 2ae07fc28..bd893d0c2 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 nednguyen Remove legacy v8_execution metric

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2739233004
Cr-Commit-Position: refs/heads/master@{#456050}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fbffc377..5362e552

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2739383002
Cr-Commit-Position: refs/heads/master@{#456049}

Records (https://heycam.github.io/webidl/#idl-record) are ordered
associative arrays mapping instances of K to instances of V, where K must be
a ByteString, a DOMString or an USVString.

In C++, we represent records as Vector<std::pair<k,v>> (or HeapVector),
which are converted from V8 objects via

    NativeValueTraits<IDLRecord<K, V>>::nativeValue()

To convert the C++ Vectors back to V8 objects, we piggyback on already
existing ToV8() overloads for Vector<std::pair<>> and HeapVector.

The majority of the required work to support this new IDL type has already
landed and concerned making it possible to convert JS values to arbitrary
C++ types without knowing much about them (there is a single JS->C++
conversion function that needs to work for pretty much any JS data type).

This CL mainly makes the Python bindings code aware of this new type and
allows it to generate the appropriate JS->C++ and C++->V8 calls, and adds
the IDLRecord NativeValueTraits template specialization mentioned above. All
the rest is new tests and updates to existing expectations.

It is also important to note that the JS->C++ conversion code relies on a
NativeValueTraits specialization existing for the record value types, and
they are always used regardless of whether they are the fastest way to
convert data or not -- for example, it always creates and uses an
ExceptionState even if the actual conversion functions do not use it (as is
the case for toDOMWindow() or ScriptValue()).

Finally, while here rename IDLSequence::MaybeWrappedCppType to IDLSequence::MaybeMemberCppType to avoid confusion (and do the same for IDLRecord), as "wrapper" in a bindings context tends to refer to the V8 wrapper for DOM objects, which is not the case here.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2732093003
Cr-Commit-Position: refs/heads/master@{#456048}

We keep track of last seen text node for more efficient whitespace
re-attachment. When style recalc and layout tree building was split,
the text node is still tracked during recalc, stored in a hash map, and
retreived when needed during layout tree building.

However, the text nodes are also traversed during layout tree building
so that we can track the nodes during that phase instead.
StyleReattachData is removed and this CL reverts back to using the
m_nonAttachedStyle map for ComputedStyle.

The comment about reversed traversal of children for avoiding n^2
performance is moved to rebuildChildrenLayoutTrees() since that's where
the issue is. We should be able to do the child recalc first-to-last
now if we want to.

R=nainar@chromium.org,esprehn@chromium.org
BUG=595137

Review-Url: https://codereview.chromium.org/2740823005
Cr-Commit-Position: refs/heads/master@{#456047}

Its one remaining member, GetOmniboxView, can be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the
OmniboxView* itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747

Review-Url: https://codereview.chromium.org/2739943005
Cr-Commit-Position: refs/heads/master@{#456046}

std::vector has no such limitations, so let's drop them either.
Vector unit test is updated accordingly.

BUG=698998

Review-Url: https://codereview.chromium.org/2739813003
Cr-Commit-Position: refs/heads/master@{#456045}

BUG=700271
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2738403003
Cr-Commit-Position: refs/heads/master@{#456044}

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927

Review-Url: https://codereview.chromium.org/2741443003
Cr-Commit-Position: refs/heads/master@{#456043}

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927

Review-Url: https://codereview.chromium.org/2738823004
Cr-Commit-Position: refs/heads/master@{#456042}

This is a temporary set of reverts so they can go into M58.

Revert "clean up LayoutTestNotificationManager overrides"
This reverts commit 0e9764ee.
Revert "Test the platform notification context synchronize operation"
This reverts commit f3f824cd.
Revert "Fix a couple of notification TODOs"
This reverts commit e50bfa20.

BUG=571056,700343

Review-Url: https://codereview.chromium.org/2739943006
Cr-Commit-Position: refs/heads/master@{#456041}

The page zoom factor is not applied to the ICB for printing, yet the
ICB basis for media queries and viewport units were. Use 1 as a page
zoom factor in viewportSizeForViewportUnits and use that method to get
the size for the ICB for evaluating media queries.

BUG=699014,699910

Review-Url: https://codereview.chromium.org/2738173002
Cr-Commit-Position: refs/heads/master@{#456040}

This CL adds another device attribute to the report which is uploaded to admin console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589

Review-Url: https://codereview.chromium.org/2736903004
Cr-Commit-Position: refs/heads/master@{#456039}

In the Custom Tabs benchmark, in the case where mayLaunchUrl isn't
called, launchUrl shouldn't be called immediately. This change causes
launchUrl to be called after the delay specified by delayToLaunchUrl.

BUG=655980

Review-Url: https://codereview.chromium.org/2742563003
Cr-Commit-Position: refs/heads/master@{#456038}

Our implementation had unnecessary precondition check for detached
CharacterData, and it's not defined by the DOM standard. This CL removes it.

* fast/dom/Range/31684.html: Removed
 This CL changes the exception message in this test. We remove this because
 It's well tested in WPT.

BUG=700275

Review-Url: https://codereview.chromium.org/2740293002
Cr-Commit-Position: refs/heads/master@{#456037}

Reland of duce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #1 id:1 of https://codereview.chromium.org/2743733004/ )

Reason for revert:
Was likely a false alarm.

Original issue's description:
> Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )
>
> Reason for revert:
> Speculative revert, it doesn't look related but am trying changes in the blame range.
>
> Will update if the revert has changed things / will revert the revert otherwise.
>
> https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030
>
> Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor
>
> Original issue's description:
> > Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
> >
> > In particular, changes return values from FloatClipRect to const FloatClipRect&,
> > to avoid extra data structure copies.
> >
> > In local testing, this CL produces up to a 10% improvement on the
> > rasterize_and_record_micro.partial_invalidation benchmark.
> >
> > BUG=692614
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Review-Url: https://codereview.chromium.org/2745563004
> > Cr-Commit-Position: refs/heads/master@{#456011}
> > Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=692614
>
> Review-Url: https://codereview.chromium.org/2743733004
> Cr-Commit-Position: refs/heads/master@{#456032}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125d5ba415cce54

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2741103005
Cr-Commit-Position: refs/heads/master@{#456036}

Review-Url: https://codereview.chromium.org/2743893002
Cr-Commit-Position: refs/heads/master@{#456035}

Mac10.11
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=17334
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=17335

Mac10.10
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.10&number=31189

BUG=402805
NOTRY=true
TBR=enne@chromium.org

Review-Url: https://codereview.chromium.org/2744803002
Cr-Commit-Position: refs/heads/master@{#456034}

Also, change some apostrophes.

BUG=699932

Review-Url: https://codereview.chromium.org/2740113002
Cr-Commit-Position: refs/heads/master@{#456033}

Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )

Reason for revert:
Speculative revert, it doesn't look related but am trying changes in the blame range.

Will update if the revert has changed things / will revert the revert otherwise.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030

Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor

Original issue's description:
> Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
>
> In particular, changes return values from FloatClipRect to const FloatClipRect&,
> to avoid extra data structure copies.
>
> In local testing, this CL produces up to a 10% improvement on the
> rasterize_and_record_micro.partial_invalidation benchmark.
>
> BUG=692614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2745563004
> Cr-Commit-Position: refs/heads/master@{#456011}
> Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2743733004
Cr-Commit-Position: refs/heads/master@{#456032}

R=stgao@chromium.org, tandrii@chromium.org
BUG=665059

Review-Url: https://codereview.chromium.org/2738123003
Cr-Commit-Position: refs/heads/master@{#456031}

BUG=402805
NOTRY=true
TBR=enne@chromium.org

Review-Url: https://codereview.chromium.org/2742713006
Cr-Commit-Position: refs/heads/master@{#456030}

To diagnose an audio thread crash condition, verify that the lock
over audio consumers that MediaStreamSource keeps, isn't held when it is
being finalized. If it is, then the audio thread is active using the
MediaStreamSource object..which is not a well-formed state to be in.

R=
BUG=682945

Review-Url: https://codereview.chromium.org/2741663004
Cr-Commit-Position: refs/heads/master@{#456029}

BUG=none

Review-Url: https://codereview.chromium.org/2740953004
Cr-Commit-Position: refs/heads/master@{#456028}

BUG=517741
TEST=Tested manually that reloading is fast.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2737383003
Cr-Commit-Position: refs/heads/master@{#456027}

MFStartup() usually returns S_OK.  However, being a system library
function it doesn't have to, and we have no control over it.  It can
return an error when something goes wrong within Media Foundation, or
simply on an "N" edition of Windows that doesn't even have Media
Foundation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735783002
Cr-Commit-Position: refs/heads/master@{#456026}

The edited spec is here:
https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap

Broadly, the changes are:

- Rename ImmutableStylePropertyMap -> StylePropertyMapReadonly
- Switch StylePropertyMap to inherit from StylePropertyMapReadonly
instead of the other way around
- Update all references appropriately

BUG=545318

Review-Url: https://codereview.chromium.org/2730633004
Cr-Commit-Position: refs/heads/master@{#456025}

Network traffic annotation is added to network request of
NetMetricsLogUploader.

BUG=656607

Review-Url: https://codereview.chromium.org/2703363002
Cr-Commit-Position: refs/heads/master@{#456024}

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2723883005
Cr-Commit-Position: refs/heads/master@{#456023}

BUG=None

Review-Url: https://codereview.chromium.org/2736233002
Cr-Commit-Position: refs/heads/master@{#456022}

CryptString is intended for secret data, such as passwords, and the
memory is cleared on deallocation. However, where it is used in
libjingle_xmpp, the password is copied to other objects without any
magic clearing, so the security benefit is questionable.

In addition, CryptString is yet another string class, it's unused
within webrtc, and essentially unmaintained. If we can replace its use
in Chrome, it will be deleted.

BUG=webrtc:6424

Review-Url: https://codereview.chromium.org/2738973004
Cr-Commit-Position: refs/heads/master@{#456021}

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740893003
Cr-Commit-Position: refs/heads/master@{#456020}

Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (patchset #3 id:40001 of https://codereview.chromium.org/2732223002/ )

Reason for revert:
Looks like the test still keeps failing on Mac10.11.  Could look into this?

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7814

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7815

Original issue's description:
> Update DevTools animation timeline to handle TransitionKeyframeEffectModels
>
> CSS Transitions was refactored to use TransitionKeyframes instead of
> AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
> This patch updates the DevTools animation timeline to handle the new
> data type for transitions.
>
> BUG=698669
>
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Original-Commit-Position: refs/heads/master@{#455333}
> Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Commit-Position: refs/heads/master@{#455995}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d4576783ae03f5d3a9

TBR=dgozman@chromium.org,samli@chromium.org,alancutter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698669

Review-Url: https://codereview.chromium.org/2738983005
Cr-Commit-Position: refs/heads/master@{#456019}