GitLab

This is to avoid inconsistent (half-destructed) RenderFrameHostImpl instance
in WebContentsObserver::DidFinishNavigation, acessible through NavigationHandle
instance.

This happens in DevToolsManagerTest.ReattachOnCancelPendingNavigation, added
DCHECK to RenderFrameDevToolsAgentHost.

See crrev.com/2544893002 and crrev.com/2387353004 for more context.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2563863002
Cr-Commit-Position: refs/heads/master@{#437658}

Currently the TracedValues were being created even when the tracing category was
disabled. This CL moves the creation of the TracedValues into a function, which
is called only when the TRACE macro arguments are evaluated, which, in turn,
only happens when the tracing category is enabled.

Measuring on a linux workstation using the linux perf tools, the instrumentation
overhead with the tracing category disabled is now below 2% of the cost of the
ResourceFetcher::requestResource function, as opposed to the 12% measured
before.

Review-Url: https://codereview.chromium.org/2537143005
Cr-Commit-Position: refs/heads/master@{#437657}

Adding dependencies needed by libGL.so and libpam.so.

BUG=668205

Review-Url: https://codereview.chromium.org/2558343002
Cr-Commit-Position: refs/heads/master@{#437656}

BUG=555865

Review-Url: https://codereview.chromium.org/2389613002
Cr-Commit-Position: refs/heads/master@{#437655}

While main frame loads already disabled the load being handled by the browser (in RenderViewTest::LoadHTML), requests from subframes are created inside Blink and so were missing that flag. Fix this by adding it in TestRenderFrame. Note this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2557223002
Cr-Commit-Position: refs/heads/master@{#437654}

This CL does two things to the Plugins Block Omnibox popup:

 1. Removes the radio buttons. They are misleading and irrelevant in the HBD world, and weren't actually that useful in the pre-HBD world either.

 2. Hides the Run All Plugins link in the policy-managed BLOCK case or the HBD BLOCK case.

 3. Hides the Manage... link in the policy-managed case. User cannot manage the setting anyways.

BUG=655899

Review-Url: https://codereview.chromium.org/2552343005
Cr-Commit-Position: refs/heads/master@{#437653}

We measure frame time so the granularity of frame cycle affects the
accuracy (small load sometime causes 1 cycle flakiness) and visibility
(performance difference of a too small load is hidden by the smallest
frame cycle) of the results. See https://goo.gl/wGEsdM for samples of
the flakiness.

Increase load to avoid the above issues, especially after we excluded
GC time from the measured time (https://codereview.chromium.org/2559893002/)
for crbug.com/667811.

Now most of the measured times on my local Linux machine are between
100ms and 300ms.

Modified some tests to avoid the increased load from causing too much
layout time.

NOTRY=true (try bots help nothing for this CL)

Review-Url: https://codereview.chromium.org/2564773003
Cr-Commit-Position: refs/heads/master@{#437652}

This makes client side (in-process / proxy) command buffer state thread-
safe and adds release count to the client-server shared state. This
allows the compositor thread to monitor worker context sync token in the
service.

Client side command buffer state is synchronized using a lock. Extra
caching of the state is added to command buffer helper so that it
doesn't acquire the lock for every command.

Also fixes command buffer memory tracing so that it happens on the same
thread which the context provider is bound to.

R=piman@chromium.org,jbauman@chromium.org
BUG=514813,638862
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550583002
Cr-Commit-Position: refs/heads/master@{#437651}

The drop-down list closes on a GestureTapDown, and the next GestureTap
cannot open the same list. The regression was because of the following
cl: https://codereview.chromium.org/2517253002/

BUG=670185, 569092
Test=LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html

Review-Url: https://codereview.chromium.org/2558113002
Cr-Commit-Position: refs/heads/master@{#437650}

Forcing this through the CQ to roll dEQP.

https://chromium.googlesource.com/angle/angle.git/+log/023c2b1..e735511

BUG=chromium:671021
TBR=geofflang@chromium.org
TEST=bots
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563643004
Cr-Commit-Position: refs/heads/master@{#437649}

Specify the ColorBehavior from GraphicsLayer to GraphicsContext.

Use the GraphicsLayer's ColorBehavior to determine if the
WebDisplayItemList has an implied color space.

This does not change any behavior, but makes implied behavior
explicit.

The ColorBehavior in GraphicsLayer is unused, but will be used by
future patches.

BUG=667411

Review-Url: https://codereview.chromium.org/2552893005
Cr-Commit-Position: refs/heads/master@{#437648}

crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API.

BUG=647296

Review-Url: https://codereview.chromium.org/2555743008
Cr-Commit-Position: refs/heads/master@{#437647}

These histograms were added in
https://codereview.chromium.org/2545593003, but the entries in
histograms.xml were incorrect. This change fixes the naming error.

Review-Url: https://codereview.chromium.org/2560103002
Cr-Commit-Position: refs/heads/master@{#437646}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e050386b..0a12a619

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2567703002
Cr-Commit-Position: refs/heads/master@{#437645}

Timeouts caused by race condition where the web page executes before
the test has fully initialized the proxy objects has caused
BluetoothInternalsTest to fail.

To fix this problem, the proxy objects are fully initialized with a copy of the test data right after they are created in the test fixture
so that the order of execution doesn't matter.

BUG=667970

Review-Url: https://codereview.chromium.org/2532383005
Cr-Commit-Position: refs/heads/master@{#437644}

advance whether to use a SurfaceView for the overlay or not.  If the
overlay turns out to be skipped for promotion by chrome's overlay
processor, then it simply won't be visible.

This CL adds functionality for a resource to request a hint about
whether it would be promoted or not, even though it's not backed by
a SurfaceView.  This allows the producer of the resource to decide
whether SurfaceView is appropriate or not.

Initial use case will be AndroidVideoDecodeAccelerator, which likes
to promote to SV as much as possible for power savings.

BUG=671354
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2508203004
Cr-Commit-Position: refs/heads/master@{#437643}

TBR=xiyuan@chromium.org
BUG=470893
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1866813002
Cr-Commit-Position: refs/heads/master@{#437642}

The class name ManifestUpgradeDetector does not make sense in the context of
the new ManifestUpgradeDetector#Callback. The new callback can be called up to
twice:
- Once after the initial page load. (Regardless of whether the page uses the
correct Web Manifest)
- Once after a page which uses the correct Web Manifest has finished loading.
If a Web Developer removes the Web Manifest from their site, the second call is
never done.

This CL:
- moves the check for "whether the fetched Web Manifest requires a WebAPK
upgrade" into WebApkUpdateManager.
- merges the manifest fetching parts of ManifestUpgradeDetector and
ManifestUpgradeDetectorFetcher into a new class WebApkUpdateDataFetcher

BUG=639536

Review-Url: https://codereview.chromium.org/2460253002
Cr-Commit-Position: refs/heads/master@{#437641}

BUG=648292

Review-Url: https://codereview.chromium.org/2562103002
Cr-Commit-Position: refs/heads/master@{#437640}

Remove SpdySessionPoolPeer::SetSessionMaxRecvWindowSize() and
SpdySessionPoolPeer::SetStreamInitialRecvWindowSize(): |session_deps_| has
corresponding members and is more widely used in tests, so use them
instead.

BUG=622737

Review-Url: https://codereview.chromium.org/2567493002
Cr-Commit-Position: refs/heads/master@{#437639}

This CL moves a button that is only shown in the plugins category to
the instantiation of that category. That helps clean up the
site-settings-category page. This also changes the cookies-control
selector to an extra-options selector that is shared with the adobe
storage settings button.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563893002
Cr-Commit-Position: refs/heads/master@{#437638}

Disable the test until it is clear why it is flaky.

BUG=641708
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2560253002
Cr-Commit-Position: refs/heads/master@{#437637}

https://skia.googlesource.com/skia.git/+log/291c62a0ff2c..e29ce641d378

$ git log 291c62a0f..e29ce641d --date=short --no-merges --format='%ad %ae %s'
2016-12-09 kjlubick Move 6p arm64 CPU tests to Pixel C
2016-12-09 brianosman Make command buffer sRGB mip-mapping more predictable
2016-12-09 herb Revert "SkImageEncoder::* going away"
2016-12-09 mtklein Run bin/fetch-gn as a gclient hook.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2564893003
Cr-Commit-Position: refs/heads/master@{#437636}

BUG=615870

TEST=Load http://codepen.io/zen-co/pen/jrOxEg and check that the animation is
clipped properly

Review-Url: https://codereview.chromium.org/2558633005
Cr-Commit-Position: refs/heads/master@{#437635}

This works in conjunction with
https://codereview.chromium.org/2557273004/ to workaround
crbug.com/664341. That CL ramdomizes the order of the named services to
avoid collision, which is not actually effective unless there is a large
number of named services to choose from.

Sandboxed service already has 20 named services, so up the privileged
(gpu) count to 20 as well.

BUG=664341

Review-Url: https://codereview.chromium.org/2555303004
Cr-Commit-Position: refs/heads/master@{#437634}

With PlzNavigate the navigation starts in the browser, so LaunchAppWithUrl cancels the prerender before we get the PrerenderHostMsg_AddLinkRelPrerender IPC from the renderer. Fix this by noticing that the prerender was already cancelled when the IPC arrives.

This fixes
PlatformAppUrlRedirectorBrowserTest.PrerenderedClickInTabIntercepted
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2554573012
Cr-Commit-Position: refs/heads/master@{#437633}

Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset #4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707

Review-Url: https://codereview.chromium.org/2564943002
Cr-Commit-Position: refs/heads/master@{#437632}

This is almost the same exact code, so it might be worthwhile to find a way
to abstract it out, but I think it's probably not in scope for this CL.

BUG=648557

Review-Url: https://codereview.chromium.org/2563593003
Cr-Commit-Position: refs/heads/master@{#437631}

This lands server change 127437330 by jamessynge.

BUG=488484

Review-Url: https://codereview.chromium.org/2558243002
Cr-Commit-Position: refs/heads/master@{#437630}

BUG=none
R=anthonyvd@chromium.org

Review-Url: https://codereview.chromium.org/2561163004
Cr-Commit-Position: refs/heads/master@{#437629}

arm devices require the OPUS_FIXED_POINT. This define got lost at some
point. Add a public_dep so the media_unittests gets the necessary
config.

BUG=672352
TEST=gn desc out/ //media:media_unittests

Review-Url: https://codereview.chromium.org/2562513003
Cr-Commit-Position: refs/heads/master@{#437628}

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests

Review-Url: https://codereview.chromium.org/2565823002
Cr-Commit-Position: refs/heads/master@{#437627}

BUG=648557

Review-Url: https://codereview.chromium.org/2559243002
Cr-Commit-Position: refs/heads/master@{#437626}

Before this CL, blink::Resource class would define 2 almost identical methods:
- Same const-ness
- Same return type
- Same body
- Different name and access:
  public |getDataBufferingPolicy| and protected |dataBufferingPolicy|.

This CL removes the redundant dataBufferingPolicy() and tweaks the only
caller of the removed method to call getDataBufferingPolicy() instead.

This CL helps with rewrite_to_chrome_style which would have renamed
dataBufferingPolicy to getDataBufferingPolicy to avoid type-vs-method
name conflict (see r414550 and r417471).  Such rename would mean two
definitions of the same method and so would mean a build error.

BUG=582312

Review-Url: https://codereview.chromium.org/2561403003
Cr-Commit-Position: refs/heads/master@{#437625}

BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2564813002
Cr-Commit-Position: refs/heads/master@{#437624}

BUG=672859

Review-Url: https://codereview.chromium.org/2568533002
Cr-Commit-Position: refs/heads/master@{#437623}

BUG=671349

Review-Url: https://codereview.chromium.org/2559873002
Cr-Commit-Position: refs/heads/master@{#437622}

BUG=671718

Review-Url: https://codereview.chromium.org/2550413004
Cr-Commit-Position: refs/heads/master@{#437621}

When a large number of rows are present in the device table, scrolling
performance drops considerably. This is due to the table recalculating its size
due to button elements being in each row of the table.

Replaces buttons in device table with action links to speed up rendering of the
device table.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2558493004
Cr-Commit-Position: refs/heads/master@{#437620}

Document::themeColor() only looks for meta-theme-color inside <head>, however,
the spec for meta-theme-color does not restrict it to <head>.

BUG=671823

Review-Url: https://codereview.chromium.org/2566523003
Cr-Commit-Position: refs/heads/master@{#437619}