- 15 Aug, 2014 40 commits
-
-
yzshen@chromium.org authored
This CL only turns on the non-nullable check for validation tests. There will be separate CLs for: - add DCHECK at the sending side. - make the existing APIs pass the non-nullable check and turn on the check everywhere. BUG=324170 TEST=New and revised validation tests. Review URL: https://codereview.chromium.org/466613002 Cr-Commit-Position: refs/heads/master@{#290002} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290002 0039d316-1c4b-4281-b951-d872f2087c98
-
evy@chromium.org authored
Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released. Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state. TEST=TouchExplorationTest.SingleTapLongPress BUG=402544 Review URL: https://codereview.chromium.org/465543003 Cr-Commit-Position: refs/heads/master@{#290001} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290001 0039d316-1c4b-4281-b951-d872f2087c98
-
gunsch@chromium.org authored
R=lcwu@chromium.org,byungchul@chromium.org BUG=403104,403101 Review URL: https://codereview.chromium.org/467043002 Cr-Commit-Position: refs/heads/master@{#290000} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290000 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
This doesn't do anything effective anymore. BUG=245900 Review URL: https://codereview.chromium.org/469003006 Cr-Commit-Position: refs/heads/master@{#289998} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289998 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Nothing registers for the callback in WasShown if using synchronous compositor, so this does not change any behavior. So this is only removing unneeded RequestVSyncUpdate BUG= Review URL: https://codereview.chromium.org/476233002 Cr-Commit-Position: refs/heads/master@{#289997} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289997 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store. TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest* TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore* BUG=397545 Review URL: https://codereview.chromium.org/381073002 Cr-Commit-Position: refs/heads/master@{#289996} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289996 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
The webui cert viewer was still using x509_certificate_model::GetCertChainFromCert instead of X509Certificate::GetIntermediateCertificates. This was fixed in the gtk cert viewer in r135231, but the webui cert viewer was missed. (x509_certificate_model::GetCertChainFromCert was not implemented on OpenSSL, and on NSS the chain it returned may differ from the the chain that was actually used.) BUG=77757,338887 Review URL: https://codereview.chromium.org/376753002 Cr-Commit-Position: refs/heads/master@{#289994} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289994 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
BUG=403872 Review URL: https://codereview.chromium.org/478453002 Cr-Commit-Position: refs/heads/master@{#289993} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289993 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289988} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289988 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
This updates the entries in DEPS for the w3c repos to track the tip-of-tree on the 'blink' branch. This is patch 4 of 6 in the roll. TBR=phoglund@chromium.org BUG=404022 Review URL: https://codereview.chromium.org/475173003 Cr-Commit-Position: refs/heads/master@{#289987} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289987 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=398062 R=sadrul@chromium.org TBR=volick@chromium.org TEST=manually Review URL: https://codereview.chromium.org/473113002 Cr-Commit-Position: refs/heads/master@{#289986} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289986 0039d316-1c4b-4281-b951-d872f2087c98
-
alemate@chromium.org authored
BUG=317718 TEST=manually tested Review URL: https://codereview.chromium.org/382973002 Cr-Commit-Position: refs/heads/master@{#289985} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289985 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Introduce WindowListProviderImpl that simply works with the stacking order of child windows of the container. This changes the behaviour of repeated bezel swipes from the left edge to swipe between the last two active windows, which is the desired behaviour. BUG=403444 R=mfomitchev@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/470083004 Cr-Commit-Position: refs/heads/master@{#289984} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289984 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=403868 R=sadrul@chromium.org TEST=manually Review URL: https://codereview.chromium.org/464213006 Cr-Commit-Position: refs/heads/master@{#289982} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289982 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
SearchProvider enforces that if the user is in keyword mode, the only suggestions allowed to be the default match are keyword mode suggestions, lest they break the user out of keyword mode. Previously, this constraint was applied with an after-the-fact correction to allowed_to_be_default_match. This change sets allowed_to_be_default_match correctly when the AutocompleteMatches are created. All tests pass. (And yes, this constraint enforcement is tested. Here you can see the tests that were added when the constraint was put in place: https://codereview.chromium.org/67693004 .) BUG=398135 R=msw@chromium.org Review URL: https://codereview.chromium.org/476263002 Cr-Commit-Position: refs/heads/master@{#289981} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289981 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289980} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289980 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
This picks up: 3186999 Fix for incorrect builtin with clang 3.6 BUG=400849 R=fdegans@chromium.org, navabi@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/479623003 Cr-Commit-Position: refs/heads/master@{#289979} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289979 0039d316-1c4b-4281-b951-d872f2087c98
-
ricea@chromium.org authored
The "Resource-Freshness" header was temporarily named "Chromium-Resource-Freshness" during development. Since Chrome policy is to avoid using vendor prefixes, we should not ship the browser to stable with this header name. Rename the header to "Resource-Freshness". TEST=net_unittests BUG=348877 Review URL: https://codereview.chromium.org/469993008 Cr-Commit-Position: refs/heads/master@{#289978} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289978 0039d316-1c4b-4281-b951-d872f2087c98
-
hwennborg@google.com authored
The inner class needs to be exported in case any uses in inline methods or vtable of the outer class causes it to potentially be referenced across a shared library boundary. On non-Windows, the visibility attribute is already inherited by nested classes, but on Windows, they must be marked explicitly. BUG=82385 R=thakis@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/476013002 Cr-Commit-Position: refs/heads/master@{#289977} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289977 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289976} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289976 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Focus and activation are closely related. Focus could perhaps be considered a view manager concept, but activation is window-manager specific, and cannot. Event dispatch is influenced by (among other things) focus. So, move event dispatch to the window manager. I still like the idea of the view manager client lib providing a "flattened" API to users that allows setting/querying focus state & observing changes, rather than obliging everyone connect to the window manager independently (though they may want to do so for other reasons). So I'm having the view manager client connect to the window manager & continue to provide the SetFocus()/FocusChanged APIs. This causes a minor dilemma in that we have two window managers but only one view manager client. Right now I resolved this by defaulting to the original window manager and allowing others to be specified on the command line to the shell, but I think we will eventually want a way to register a default window manager. R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/474883003 Cr-Commit-Position: refs/heads/master@{#289975} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289975 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
This pulls in the following Native Client changes: r13624: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13625: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13626: (dschuff) Update revision for PNaCl r13616->r13625 BUG=none TEST=browser_tests and nacl_integration Review URL: https://codereview.chromium.org/480473003 Cr-Commit-Position: refs/heads/master@{#289974} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289974 0039d316-1c4b-4281-b951-d872f2087c98
-
dcaiafa@chromium.org authored
This makes the following changes to media.gyp to make it compile for iOS (for the Chromoting iOS client): - Don't use ffmpeg or libvpx in media (just like Android) - Do use libyuv - Add yasm flag to decorate functions correctly for iOS (just like in the Mac) BUG=134226 Review URL: https://codereview.chromium.org/474693002 Cr-Commit-Position: refs/heads/master@{#289973} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289973 0039d316-1c4b-4281-b951-d872f2087c98
-
jiayl@chromium.org authored
BUG=https://code.google.com/p/webrtc/issues/detail?id=3601 Review URL: https://codereview.chromium.org/466843002 Cr-Commit-Position: refs/heads/master@{#289972} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289972 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
BUG=403515 Review URL: https://codereview.chromium.org/474573003 Cr-Commit-Position: refs/heads/master@{#289971} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289971 0039d316-1c4b-4281-b951-d872f2087c98
-
pmonette@google.com authored
verifier_test_dll_1.dll.exp : warning LNK4070: /OUT:verifier_test_dll.dll directive in .EXP differs from output filename 'verifier_test_dll_1.dll'; ignoring directive BUG= Review URL: https://codereview.chromium.org/473693003 Cr-Commit-Position: refs/heads/master@{#289970} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289970 0039d316-1c4b-4281-b951-d872f2087c98
-
markdittmer@chromium.org authored
BUG=377978 Review URL: https://codereview.chromium.org/420543002 Cr-Commit-Position: refs/heads/master@{#289969} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289969 0039d316-1c4b-4281-b951-d872f2087c98
-
dominik.rottsches@intel.com authored
The header include order checks were running on all affected files, including third_party for example, this causes issues when rolling harfbuzz-ng. BUG=404105 NOTRY=true Review URL: https://codereview.chromium.org/462323003 Cr-Commit-Position: refs/heads/master@{#289968} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98
-
tommycli@chromium.org authored
CRX file code currently lives under extensions/. However, component_updater also uses them to package components. The CRX code should therefore live as its own component. BUG=371463 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/474633005 Cr-Commit-Position: refs/heads/master@{#289966} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289966 0039d316-1c4b-4281-b951-d872f2087c98
-
smaslo@chromium.org authored
Metrics to track how many times users open a distilled page or distilled page preferences. BUG=383630 Review URL: https://codereview.chromium.org/476953002 Cr-Commit-Position: refs/heads/master@{#289965} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289965 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=404066 Review URL: https://codereview.chromium.org/476133002 Cr-Commit-Position: refs/heads/master@{#289964} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289964 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#289962} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289962 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=402113 TEST=none NOTRY=true R=jwd@chromium.org Review URL: https://codereview.chromium.org/468433003 Cr-Commit-Position: refs/heads/master@{#289961} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289961 0039d316-1c4b-4281-b951-d872f2087c98
-
mikecase@chromium.org authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/481513002 Cr-Commit-Position: refs/heads/master@{#289960} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289960 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Verbatim queries do not see an answer. If the previous query had an answer with a suggestion that matches the current verbatim text, reuse that answer. BUG=401486 Review URL: https://codereview.chromium.org/462963002 Cr-Commit-Position: refs/heads/master@{#289959} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289959 0039d316-1c4b-4281-b951-d872f2087c98
-
awoloszyn@chromium.org authored
R=danakj Review URL: https://codereview.chromium.org/471233002 Cr-Commit-Position: refs/heads/master@{#289958} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289958 0039d316-1c4b-4281-b951-d872f2087c98
-
maniscalco@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/470133005 Cr-Commit-Position: refs/heads/master@{#289957} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289957 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Without this some telemetry tests and canary XP build fail to load. BUG=404175 Review URL: https://codereview.chromium.org/477173002 Cr-Commit-Position: refs/heads/master@{#289956} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289956 0039d316-1c4b-4281-b951-d872f2087c98
-
bcwhite@chromium.org authored
BUG=303883 Review URL: https://codereview.chromium.org/473213002 Cr-Commit-Position: refs/heads/master@{#289955} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289955 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
We need to copy these png images first because tryserver does not work very well with binaries in patches. So in order to run the trybots in the next CL, we need to copy them first. BUG=338338 TEST=None R=avi@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/471343002 Cr-Commit-Position: refs/heads/master@{#289954} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289954 0039d316-1c4b-4281-b951-d872f2087c98
-