- 04 May, 2017 40 commits
-
-
johnme authored
The final waitForContentsFullscreenState(false) occasionally times out, probably because the KEYCODE_BACK got waylaid by some kind of dialog. This patch adds @RetryOnFailure in the hopes of working around this. BUG=711005 TBR=mlamouri NOTRY=true SKIPTREECHECKS=true Review-Url: https://codereview.chromium.org/2859243002 Cr-Commit-Position: refs/heads/master@{#469345}
-
siggi authored
BUG=682299 Review-Url: https://codereview.chromium.org/2848883005 Cr-Commit-Position: refs/heads/master@{#469344}
-
gambard authored
The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax. BUG=717974 Review-Url: https://codereview.chromium.org/2860713002 Cr-Commit-Position: refs/heads/master@{#469343}
-
isandrk authored
In Public Sessions, apps and extensions are force-installed by admin policy so the user does not get a chance to review the permissions for these apps. This is not acceptable from a security standpoint, so we: - scrub the URL available to chrome.tabs.executeScript context (through activeTab permission) down to the origin. This change also causes the tab object passed to the [page|browser]Action.onClicked to be scrubbed for the given extension. TEST= unit_tests --gtest_filter=DeviceLocalAccountManagementPolicyProviderTest.IsWhitelisted unit_tests --gtest_filter=ExtensionTabUtilDelegateChromeOSTest.* unit_tests --gtest_filter=ExtensionTabUtilTest.Delegate BUG=717945 Review-Url: https://codereview.chromium.org/2858643002 Cr-Commit-Position: refs/heads/master@{#469342}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b59a9da7eba4..40c0f249e60d $ git log b59a9da7e..40c0f249e --date=short --no-merges --format='%ad %ae %s' 2017-04-28 benjaminwagner Turn on verbose logging for Valgrind_PreAbandonGpuContext bot. 2017-04-29 benjaminwagner Remove Nexus5 experimental tryjob. 2017-05-04 robertphillips Add GrGpuTextureProxyRef 2017-05-04 msarett Reland "Add SkImage::makeColorSpace() with correct transfer fn behavior" 2017-05-04 ethannicholas Revert "Revert "Revert "eliminated GrGLSLExpr""" 2017-04-17 halcanary src/pdf: code cleanup 2017-05-02 msarett Finish removal of SkImageInfo from SkPixelRef Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I2f58a1a412d86bf2da18c1c50978c37806794221 Reviewed-on: https://chromium-review.googlesource.com/495570Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469341}
-
tansell authored
TBR=dpranke@chromium.org,mcgreevy@chromium.org BUG=718379,717347 NOTRY=true Review-Url: https://codereview.chromium.org/2859173002 Cr-Commit-Position: refs/heads/master@{#469340}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/342edbef..dabdeb4d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2863613002 Cr-Commit-Position: refs/heads/master@{#469339}
-
davidben authored
This case was missing test coverage and had a bug, due to it repurposing HandleIOError, despite not using any of the existing code. Before https://codereview.chromium.org/2771263002/, HandleIOError had an invariant: it would either return an error code (thus continuing to report failure), or it would reset the state machine and continue. The new logic had a case where it returned OK without reseting the state machine, bypassing all logic after the 421 check. Notably, response_.ssl_info would not get filled in. Should a lower-level layer of the stack fail with ERR_MISDIRECTED_REQUEST, the new HandleIOError would also get confused. Instead, inline the logic. This avoids needing a funny error code at all. Since logging is still valuable, just add a new event type for it, which will probably be easier to diagnose anyway. (Otherwise one needs to know that ERR_MISDIRECTED_REQUEST never comes out of lower layers.) Add a test that we do not retry in a loop (useful to test), and that ssl_info is properly filled in (regression test). BUG=546991 Review-Url: https://codereview.chromium.org/2856313003 Cr-Commit-Position: refs/heads/master@{#469338}
-
fsamuel authored
Prior to this CL, SurfaceLayerImpl would always emit a SharedQuadState for the primary and one for the fallback. This is adding unnecessary serialization/deserialization overhead. This CL allows the two DrawQuads to share a SharedQuadState if the device scale factor has not changed and we are not stretching the surface. In those cases, we don't need a different scaling transform and thus we don't need a different SharedQuadState. BUG=672962 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2857143004 Cr-Commit-Position: refs/heads/master@{#469337}
-
ellyjones authored
PlatformFontMac::GetExpectedTextWidth() was wildly over-estimating text widths, causing dialogs that try to size using Widget::GetLocalizedContentsWidth to be extremely wide on Mac. This change replaces the guess in PlatformFontMac's CalculateMetricsAndInitRenderParams() with a more empirically accurate guess. BUG=654128 Review-Url: https://codereview.chromium.org/2839873003 Cr-Commit-Position: refs/heads/master@{#469336}
-
chrishtr authored
(and its callsites) The only remaining callsites are in tests. BUG=718149,557160 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2857343002 Cr-Commit-Position: refs/heads/master@{#469335}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/28b44b03c133..cbdf926884c4 $ git log 28b44b03c..cbdf92688 --date=short --no-merges --format='%ad %ae %s' 2017-05-03 tsepez Move O_BINARY and O_LARGEFILE defintions 2017-05-03 tsepez Remove FXSYS_wfopen(), it is totally unused. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I5bf662c7a67f9a67e36237024cc53a1274f1155e Reviewed-on: https://chromium-review.googlesource.com/495432 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469334}
-
jlebel authored
https://drive.google.com/open?id=0ByXziH_JVCGJXzVLNmx6cTVtczA https://drive.google.com/open?id=0ByXziH_JVCGJQ3BKS2JpOXA5a1k BUG=661794 Review-Url: https://codereview.chromium.org/2844253003 Cr-Commit-Position: refs/heads/master@{#469333}
-
https://codereview.chromium.org/2846893003thakis authored
BUG=none Review-Url: https://codereview.chromium.org/2860753004 Cr-Commit-Position: refs/heads/master@{#469332}
-
csharrison authored
This also modifies the ownership of the subresource filter client, which now must outlive the throttle manager / driver factory. BUG=717590 Review-Url: https://codereview.chromium.org/2850373002 Cr-Commit-Position: refs/heads/master@{#469331}
-
emaxx authored
Add a minimum test that only enables the login screen apps functionality via the command line flag. The purpose of this test is to investigate whether just specifying this command line flag may lead to tests being timed out. The plan is to remove this test once this investigation finishes, in favor of more complete end-to-end tests. BUG=626343 Review-Url: https://codereview.chromium.org/2861723002 Cr-Commit-Position: refs/heads/master@{#469330}
-
nednguyen authored
This removes the overhead of emitting trace events from run time measurement. On tests like Layout/character_fallback_aat.html, this reduces the test's duration 3x (0.015ms --> 0.005ms) BUG=716394, 701059 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2857403002 Cr-Commit-Position: refs/heads/master@{#469329}
-
skyostil authored
BUG=718242 Review-Url: https://codereview.chromium.org/2858043005 Cr-Commit-Position: refs/heads/master@{#469328}
-
szager authored
Previously, percent-height svg elements in a pure-svg doc would get their size based on the LayoutView's logical height from the previous layout pass. In practice, this didn't show up much because FrameView always does at least one extra initial layout pass to add and then subtract scrollbars. The extra layout pass would cause the percent height descendants to get the right size. Setting overlay scrollbars on the FrameView eliminates the extra layout passes and allows the bug to manifest. Review-Url: https://codereview.chromium.org/2835153002 Cr-Commit-Position: refs/heads/master@{#469327}
-
rhalavati authored
Network traffic annotation is added to network request of . headless/public/util/http_url_fetcher.cc headless/public/util/generic_url_request_job_test.cc BUG=656607 Review-Url: https://codereview.chromium.org/2857623002 Cr-Commit-Position: refs/heads/master@{#469326}
-
geofflang authored
ANGLE now exposes this extension to indicate that floating point textures are renderable so it is the preferred way to determine if these extensions should be exposed. BUG=angleproject:1958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2795123003 Cr-Commit-Position: refs/heads/master@{#469325}
-
johnme authored
Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 (patchset #1 id:1 of https://codereview.chromium.org/2862563003/ ) Reason for revert: Caused net_unittests to consistently time out on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 because of a large number of QUIC tests crashing. Original issue's description: > Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 > > There are no flags to be updated > > deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state. > > It achieved results that were in general comparable to "measuring > aggregation" approach, but it had worse rtx rate, and worse QoE, and did > not actually seem to be better in other regards. > > Merge internal change: 154601526 > > https://codereview.chromium.org/2859913003/ > > fix packet conservation to remove packets from recovery window when they are lost. Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2. > > This causes a dramatic reduction in losses compared to the previous patch. > > The transfer time is approximately the same. > > Merge internal change: 154590929 > > https://codereview.chromium.org/2857243002/ > > Fix typo in comments. > > Merge internal change: 154539040 > > https://codereview.chromium.org/2854823004/ > > QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation. > > This CL is in preparation for HTTP stream pairs changes. A prototype > of the entire HTTP stream pairs work is in progress. This CL is one > subset of that (2nd in the series). > > [ HTTP stream pairs builds upon this, by having new QuicSpdySession > overrides that implicitly create headers streams, and abstracting > stream accounting as needed. ] > > Add a new factory like method QuicSession::CreateStream(), that > unconditionally creates a new stream. It's virtual so subclasses of > QuicSession can create streams that are appropriately specialized from > QuicStream. There are new versions of Create*DynamicStream() called > MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called > ShouldCreate*DynamicStream2(). > > Separating this out means that fewer overrides of Create*DynamicStream() > and ShouldCreate*DynamicStream() will necessary, because many of those > were actually only needed to specialize the steam types. Those will go > away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is > deprecated. > > Merge internal changes: 154351257, 154373998. > > https://codereview.chromium.org/2861673004/ > > QUIC - stream id refactor for tests. > > // AKA - http stream pairs bikeshed #1. > > This CL is in preparation for HTTP stream pairs changes. A prototype > of the entire HTTP stream pairs work is in progress. This CL is one > subset of that. > > Rework QUIC tests so that they do not hard code the assumption that > all headers are on stream 3. Also, prepare to calculate stream ids > according to whether stream pairs are enabled, i.e. whether they > increment by 2 or 4. > > Merge internal change: 150949425 > > https://codereview.chromium.org/2854833005/ > > > R=rch@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2862563003 > Cr-Commit-Position: refs/heads/master@{#469218} > Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f TBR=rch@chromium.org,ckrasic@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2856243003 Cr-Commit-Position: refs/heads/master@{#469324}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/64dbb89efc9d..b59a9da7eba4 $ git log 64dbb89ef..b59a9da7e --date=short --no-merges --format='%ad %ae %s' 2017-05-04 msarett Revert "Add SkImage::makeColorSpace() with correct transfer fn behavior" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Iabccfd6819f93e0002473c67ae54d80122db3941 Reviewed-on: https://chromium-review.googlesource.com/495410Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469323}
-
mgiuca authored
Flaky on Windows because file handles may be open during shutdown (which causes TestingProfile to crash on shutdown). BUG=717648 Review-Url: https://codereview.chromium.org/2860463003 Cr-Commit-Position: refs/heads/master@{#469322}
-
dsinclair authored
This Cl switches chrome/browser/resources/pdf OWNERS to list myself and remove raymes@. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2857163002 Cr-Commit-Position: refs/heads/master@{#469321}
-
rhalavati authored
Network traffic annotation is added to network request of: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc BUG=656607 Review-Url: https://codereview.chromium.org/2793193003 Cr-Commit-Position: refs/heads/master@{#469320}
-
morlovich authored
we can avoid having to do expensive crc32_combine computation on the I/O thread, and can also immediately verify the checksum on the final block, improving read locality (and avoiding a bit of thread ping-pong) Using the very-synthetic benchmark from https://codereview.chromium.org/2838403003/ on a Mac with SSD, I got -18% mean cold read time change, -26% warm read time change. Speadsheet: https://docs.google.com/a/google.com/spreadsheets/d/1ri_AF3va-yZWIfo66-ZrQHiDpjOcziRdXoprzlqPeVU/edit?usp=sharing I was unable to produce meaningful numbers on Windows, however. BUG= Review-Url: https://codereview.chromium.org/2821923002 Cr-Commit-Position: refs/heads/master@{#469319}
-
tansell authored
TBR=dpranke@chromium.org,mcgreevy@chromium.org BUG=718379,717347 NOTRY=true Review-Url: https://codereview.chromium.org/2857343003 Cr-Commit-Position: refs/heads/master@{#469318}
-
alexilin authored
BUG=631966 Review-Url: https://codereview.chromium.org/2856893004 Cr-Commit-Position: refs/heads/master@{#469317}
-
kylechar authored
By default use_ozone=false if target_os="chromeos". This causes use_11=true and the X11 Chrome OS configuration to get built. Make trybots that have implicit GN arg use_ozone=false specify it explicitly. This will allow the default value for use_ozone to get changed without changing the current trybot configurations. BUG=671355 Review-Url: https://codereview.chromium.org/2854923002 Cr-Commit-Position: refs/heads/master@{#469316}
-
mstarzinger authored
The tests in question need to be rebaselined after V8 has been rolled with the new asm.js validator enabled. This feature is not yet enabled. R=machenbach@chromium.org BUG=chromium:718394 NOTRY=true Review-Url: https://codereview.chromium.org/2860073002 Cr-Commit-Position: refs/heads/master@{#469315}
-
yoav authored
ImageSet context resources, namely <picture> and srcset based images, are blockable mixed-content, yet we were sending out such requests, even if not displaying them, due to the preloadScanner ignoring the difference between them and `<img src>` based images This CL fixes that, by blocking such images. BUG=713440 Review-Url: https://codereview.chromium.org/2855163002 Cr-Commit-Position: refs/heads/master@{#469314}
-
sdefresne authored
With ARC, the order in which -dealloc is invoker is sometimes changed. This means that some of CRWWebController delegates may end up calling methods of CRWWebController between call to -close and -dealloc (until the autorelease pool is cleared). Since WebStateImpl calls CRWWebController -close just before releasing its reference, and CRWWebController becomes unusable once -close has been called (as -navigationManagerImpl will return nullptr), this does not introduce an API change of CRWWebController while ensuring that the delegate registration happens as part of WebStateImpl destruction. Fixes the crash that caused the revert of http://crrev.com/2846233002/ with the following callstack (truncated): 0 org.chromium.gtest.generic-unit-test 0x000000010169d83a -[CRWWebController setNavigationItemTitle:] + 266 1 org.chromium.gtest.generic-unit-test 0x000000010169b2df -[CRWWebController nativeContent:titleDidChange:] + 47 2 org.chromium.gtest.generic-unit-test 0x0000000101e545c3 -[StaticHtmlViewController observeValueForKeyPath:ofObject:change:context:] + 515 3 com.apple.Foundation 0x000000010e3ee70c NSKeyValueNotifyObserver + 351 4 com.apple.Foundation 0x000000010e3edfa7 NSKeyValueDidChange + 495 5 com.apple.Foundation 0x000000010e3be00e -[NSObject(NSKeyValueObserverNotification) didChangeValueForKey:] + 118 6 com.apple.WebKit 0x000000010fcb356a WebKit::PageLoadState::commitChanges() + 1538 ... BUG=None Review-Url: https://codereview.chromium.org/2854943003 Cr-Commit-Position: refs/heads/master@{#469313}
-
skyostil authored
Instead of //headless/public/domains, headers under //headless/public/devtools should now be used. BUG=718242 Review-Url: https://codereview.chromium.org/2854823006 Cr-Commit-Position: refs/heads/master@{#469312}
-
thakis authored
Sanitizer stacks are supposed to be run through tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer. llvm-symbolizer can do a better job at symbolizing than google::Symbolize if google::Symbolize doesn't throw away the data llvm-symbolizer needs. Stack before (both with and without filtering through asan_symbolize): BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000007ea911 __interceptor_backtrace #1 0x0000082e2afc base::debug::StackTrace::StackTrace() #2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f04d9814cb0 <unknown> #4 0x00000fbd5624 BrowserActionsContainer::Layout() #5 0x00000fbd3c3e BrowserActionsContainer::Redraw() #6 0x00000f91d38e ToolbarActionsBar::UndoPopOut() Stack after, not filtered through asan_symbolize: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000007ea911 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910) #1 0x0000082e2afc (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb) #2 0x00000979d5ce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd) #3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf) #4 0x00000fbc96b4 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3) #5 0x00000fbc7cce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd) #6 0x00000f91141e (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d) Stack after, filtered through asan_symbolize: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000007ea911 in __interceptor_backtrace ??:0:0 #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41 #2 0x00000979d5ce in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5 #3 0x7fda947f5cb0 in killpg ??:? #4 0x7fda947f5cb0 in ?? ??:0 #5 0x00000fbc96b4 in BrowserActionsContainer::Layout() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13 #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3 #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16 BUG=none Review-Url: https://codereview.chromium.org/2857643002 Cr-Commit-Position: refs/heads/master@{#469311}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff8039d7..342edbef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2858183003 Cr-Commit-Position: refs/heads/master@{#469310}
-
rune authored
While matching rules for elements, we mark elements as affected-by-* for user action pseudo classes like hover. It means that when the element is later hovered, we need to recalculate style to apply hover styles to that element. In general, we currently don't support pseudo classes after pseudo elements, but for scrollbar pseudo elements we do: ::-webkit-scrollbar:hover {} However, we do not want such rules to mark the element as affected-by- hover. The hover style on scrollbar parts get their hover style updated when hovered regardless of any flags, and making scrollbar pseudo element rules affect hover updates on the actual elements causes unnecessary style recalcs. BUG=716006 Review-Url: https://codereview.chromium.org/2850743003 Cr-Commit-Position: refs/heads/master@{#469309}
-
olka authored
The outcome is: if device authorization for a renderer is taking too long it will be interupted. Page load will continue normally, some of the audio playback on it may not work. BUG=647498 Review-Url: https://codereview.chromium.org/2862823002 Cr-Commit-Position: refs/heads/master@{#469308}
-
tansell authored
Swarming has only a single Win10-10240 bot but about 30-40 Win10-10586 bots. TBR=dpranke@chromium.org,mcgreevy@chromium.org BUG=718379,717347 NOTRY=true Review-Url: https://codereview.chromium.org/2857213004 Cr-Commit-Position: refs/heads/master@{#469307}
-
peconn authored
BUG=709042 Review-Url: https://codereview.chromium.org/2854143002 Cr-Commit-Position: refs/heads/master@{#469306}
-