GitLab

Moved sent_nodes and changed_nodes to DocumentSession, it makes
the code more clear, and improves the performance a little bit,
because the node is regroup to a number of small one according
to the document.

This patch also ignores the content change of the unsent node,
adds test for this case.

Bug: 1137463
Change-Id: Id8146bdbd374d09ba27e22851e13ede4f1511b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469220Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818086}

Omnibox context menu show full URLs option is fully launched, so these
histograms are no longer needed. This CL removes instrumentation from
code and marks the histograms as obsolete.

Bug: 1138297
Change-Id: I511b460e9358a433ecd50d4c83577361d641f743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472583
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818085}

Roll Chrome Mac PGO profile from chrome-mac-master-1602849330-a9b7aee9583f24ea33d238dab5bbe64a57e40269.profdata to chrome-mac-master-1602870879-c4d95eb6e866d4e52485aa00dae385a889389fa8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I925e885a2815d0df50e9ffc186c907b7a8467695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481410Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818084}

This change adds support for MockFeedback.prototype.replay() to be used in an async function.

For example:
async function test() {
  await doSomething();
  await mockFeedback.expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

Alternatively, the following is similar, but bad usage:
async function test() {
  await doSomething();
  mockFeedback.expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

because the return statement is |undefined|. In CallbackHelper, test functions are only expected to return promises, and an async function that returns undefined automatically converts that value to a promise which automatically gets resolved.
Such a promise passes the test incorrectly even if the test throws an assertion. THis occurs when MockFeedback which loops over all actions, gets an assertion, and does not hault execution and keeps trying to match expectations. If at some point, the expectation is matched in the future, the test passes.

For existing tests that are not async, this change does not make any diffference.

e.g.

function test() {
  mockFeedback.call(() => doSomething)
      .expectSpeech('foo')
      .call(() => doSomethingElse)
      .replay();
}

because CallbackHelper, when it receives no return value, goes back to the standard way of counting callbacks; when it hits zero, it finishes the test.
The promise returned by replay doesn't make any impact on the test since the test is not async so returning undefined (implicitly here) does not convert it to a promise.

AX-Relnotes: n/a

Change-Id: I61509222a28730ee3bf8b80349bd11f4b9516636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473805
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818083}

Bug: 1137474
Change-Id: I4dd8d3af9d978d5f99c7fc3a7dc8264b801eff37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480966
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818082}

Making a context current could fail if context is lost. Hence account
for that correctly while destroying |texture_|.

Bug: 1135073
Change-Id: I232e92a1dac27606e2e4762d0b4856e7ab85c058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469372Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818081}

TBR=govind@chromium.org

Change-Id: Ib61a0a7db3e3683fbe146694001970c41d80a188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481303Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818080}

No behavior change expected.

The CL also removes a trailing include to
chrome/.../ash/tablet_mode_page_behavior.h

BUG=1113900
R=jamescook@chromium.org, sky@chromium.org

Change-Id: I1fe091dbe400afe974fb0f7da90263a2c4cd4f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472203
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818079}

In RTC video en-/decoder factories, wait until codec support status in
GPU factory is known before querying supported formats and creating
codecs.

This feature is controlled by kRTCGpuCodecSupportWaiter field trial and
is enabled by default with 3 seconds timeout.

Bug: 1047994
Change-Id: Ia822b399b3007815e2f5a15270bbc7cec1801aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453251
Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818078}

https://skia.googlesource.com/skia.git/+log/7db7139f4032..fd0b15801ff8

2020-10-16 michaelludwig@google.com Visualize perspective scaling in filter bounds sample
2020-10-16 bungeman@google.com Cannot create SkFontData with no data.
2020-10-16 jlavrova@google.com ICU project: script iterator in SkShaper
2020-10-16 fmalita@chromium.org Cleanup gn_to_bp_utils
2020-10-16 bsalomon@google.com fix always true comparison in assert
2020-10-16 mtklein@google.com update SkTPin()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: robertphillips@google.com
Change-Id: I1194c2bddb25e72ba9dc07577e379d43ee71ac71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818077}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/acbaac2aa7cd..97cf11a427e8

2020-10-16 bmgordon@chromium.org service/sdk: Explicitly request chroot image type
2020-10-16 chrome-bot@chromium.org Update config settings by config-updater.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: Ia690744e3d334c5434c3b77b687c302e0062ff1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480931
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818076}

This is a reland of 2c428e54

Reason for revert: Breaking:
- win7 All/DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionChange/uia
https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/72572

This reland updates the failing win7 test.

Original change's description:
> Fix TextChanged UIA events
>
> Blink fires the TextChanged event for all sorts of reasons, and it
> leads to flakiness and difficulty fixing other bugs.
>
> Instead, fire this event when a static text node has changed its text
> using AXEventGenerator, which is more stable and predictable.
>
> When static text changes under UIA, fire a text-changed event
> rather than raising a property-changed for UIA_NamePropertyId.
>
> Add AXEventGenerator::Event::EDITABLE_TEXT_CHANGED which is fired on an
> editable root when static text within an editable text region changes.
>
> Bug: 904977, 1062063, 1085481, 1105262
> Change-Id: Ic655deba0d1a5ab1fb575ffa8a56cef1c538c923
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393067
> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#816341}

Bug: 904977
Bug: 1062063
Bug: 1085481
Bug: 1105262
Tbr: dmazzoni@chromium.org
Change-Id: Ia485dee949d063e22befd3532475f0136775bcf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465213Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818075}

Bug: 1114563
Change-Id: Ia6115e15bfcd377e517c4877c014a2ef4c186857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481003Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#818074}

Roll Chrome Linux PGO profile from chrome-linux-master-1602849330-e626db1a42614bd1b3dbd5e4d956205e419c269d.profdata to chrome-linux-master-1602870879-71fddc22f2ceb12188759a1d8869c82a8b2155fa.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia1adbba45d703b5709fcbc3e285021baa7f0ce1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481405Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818073}

Seeing reports of printers failing to setup in Settings.  Trying
to get to the root cause.  I suspect that the settings UI is getting
out of sync with CupsPrintersManager.

Bug: chromium:1138599
Change-Id: Ia7ab5f5d4e72379dcf4cbf54237e8fb8e94a9e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476619Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Auto-Submit: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818072}

This is a reland of 1dbaf3e8

Fix: Was previously calling on the private constructor rather than
using delegate constructing.

Original change's description:
> Add connection time outs to ConnectionManager
>
> If we cannot establish a connection within 15 seconds, we time out
> the connection and cancel
>
> Bug: 1106937
> Test: chromeos_components_unittests
> Change-Id: Iad731f6119a900fa411d75a9c53869baabf33498
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470321
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817371}

Bug: 1106937
Change-Id: I60c08848db19b104251e9b31ae85e18faea8ea9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477922
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818071}

The test was previously structured as several separate blocks, with no
state shared between them except for the test fixture. There is no
particular reason to do this and it makes the test harder to understand
compared to several smaller tests.

This change *just* splits the test up into separate tests, but does not
outdent the now-split-up test bodies, deduplicate code between them,
or make any other fixes.

Bug: 1128436
Change-Id: If524b32dbe7d5ea2ce0d913b854e4819c1fb51ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481352Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818070}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae3dc89611ac..19ef525ade8e

2020-10-16 changhaohan@chromium.org Revert "Fix missing settings/ModuleUIStrings.js in build config"
2020-10-16 pfaffe@chromium.org TypeScriptify SASSSourceMapping
2020-10-16 pfaffe@chromium.org TypeScriptify ResourceMapping
2020-10-16 changhaohan@chromium.org CSS <angle> component
2020-10-16 pfaffe@chromium.org TypeScriptify ResourceScriptMapping
2020-10-16 tvanderlippe@chromium.org Revert "Localization: Migrating Settings Folder"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1126178,chromium:1136655
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I616b7b76d3d31f037fd9d377252acc2d978c84b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818069}

There were enums that were duplicated in IOS C++ code, and Android Java code. Added a way for the C++ enum to generate a Java enum. This way any future changes will automatically be reflected in both parts of the code.

Bug: 933371
Change-Id: I92a2d49d14790023b996d95dc95e340c6f7ba62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404471
Auto-Submit: Max Curran <curranmax@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Max Curran <curranmax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818068}

Move TrustedWebActivityModel, Disclosure{Infobar|Notification|Snackbar}
out of trustedwebactivity folder as they are/will be shared between
Webapk/TWA

Bug: 1128675
Change-Id: I9d852b3c488b956cd09a84d66a6ab7187bbbded0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476495
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818067}

This should hopefully reduce flakiness and unexpected timeouts.

Bug: chromium:1136900
Change-Id: I279ee5f823f32d3ab91021f6fb50203f99982aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479565Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818066}

This CL refactors Windows file handler registration in a way that
exposes shared logic useful for protocol handler registration. Protocol
handler registration that consumes the shared logic will be added in a
subsequent CL. This design is detailed in section 4.4 of [1] with a
summary given below.

The refactor splits up registration by functional concerns,
with pieces that may be shared with protocol handler registration living
in web_app_handler_registration_utils_win.h/.cc.
web_app_file_handler_registration_win.h/.cc is now significantly smaller
and addresses file-handler-specific concerns in addition to consuming
the utils API.

File handler registration consists of several pieces:

 1) Create an app registry entry: HKCU\Software\Classes\<app_progid>
 2) Copy (or hardlink) chrome_pwa_launcher.exe from browser install
    directory to <profile_dir>\web_applications\<app_id>\<app_name.exe>
 3) Reregister an app (steps 1 and 2) with a profile-specific name when
    the same app is installed to a different profile
    (e.g. "App" -> "App (Profile 1)")
 4) Create a file type association registry entry:
    HKCU\Software\Classes\.<file_ext>

In this approach, 1 & 4 are contained in the existing
ShellUtil::AddFileAssociations function. 2 & 3 are moved to utils
(CreateAppLauncherFile and CheckAndUpdateExternalInstallations).

Important note about this design:
- Reregistration logic (3) is altered in this approach. Currently,
pieces 1, 2, 4 are all executed during reregistration. Because (4) is a
file-handler only concern, it wouldn't make sense to use existing logic
from the protocol registration flow. Reregistering (1) and (2) are
sufficient to rename a duplicate app - this is because file handler
registry entries (4) only reference the progid of an app which doesn't
change if its display name is updated (or if the update fails).
CheckAndUpdateExternalInstallations only updates necessary registration
pieces to reflect an updated name while leaving existing file/protocol
pieces in place.

Alternative design:
crrev.com/c/2309759 previously attempted this refactor by splitting the
registration process into a shared app-level API instead of a Utils API.
As a result, ShellUtil functions that are currently atomic
(AddFileAssociations) were split into non-atomic app-level and file
handler pieces. The design was abandoned for this reason.

[1] https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit#heading=h.qsh70q

Bug: 1019239
Change-Id: I5f727a5ca1483efd21935c0201ee54474a94e598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462383Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818065}

Currently, TabCaptureApitTest.GrantForChromePages is flaky due to the
permission not being granted properly occasionally. I believe that this
is due to the permission granter not granting the correct tab permission
due to a race condition between the page load and the permission
granting.

This patch fixes this issue by adding a new message and standardizing
this test to work similarly to other stable tests.

Bug: 1134562
Change-Id: Iea40786bbfb86b6a5f6e47731ecc29939068e878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466489
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818064}

https://webrtc.googlesource.com/src.git/+log/a667f878b15c..9cee07983fc9

2020-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 17855e1b..e7588486 (817792:817908)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I327bc4c73d3b7ec429a7b25de1787b03b3563534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481043Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818063}

The default audio buffer sizes for a device are not currently chosen
with real-time communication in mind, and are also set independently of
the sample rate of the audio used. We want minimal latency, so we set
the buffer size to always be 10ms of audio regardless of the sample
rate.

Bug: internal 170432827
Test: On device. Ensured correct size is set.
Change-Id: Ifb7e37ef1c033e6efbabd07eb01b6c58476addc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481287Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Adam Whiteside <awhiteside@google.com>
Cr-Commit-Position: refs/heads/master@{#818062}

Adds the ability to pass in --code-review-system to specify the code
review system being used for a Skia Gold-backed gtest pixel test. This
defaults to "gerrit" if not passed in, which is what it was hard-coded
to before, but can now be set to "gerrit-internal" for internal code
reviews.

Bug: skia:10532
Change-Id: I28848158efbf83f223f5d56acdf5bd62271ce95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476669Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818061}

It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.

For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.

Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818060}

Bug: None
Change-Id: Iba44c99b6146eef187f4d5a5b0492610f58649cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481122Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818059}

The new IDs are submitted to GWS and are in range to be Finch-eligible.

Bug: 1135401
Change-Id: Idc92402627fe73d2560783faa7268784708c9c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480814
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818058}

These flags were incorrectly added to the default flags for all
js_type_check() targets at r813273, which is unnecessary.

Fixed: 1138171
Change-Id: I049c00a13345aad6cad2bf444730514a25e8bd11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474573
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818057}

This deflakes the test by resetting the SystemNetworkContextManager's
URLLoaderFactory remote in OnNetworkServiceCreated() (which is called
when the network service restarts) to avoid old URLLoaderFactory
instances from being used. This also adds two missing steps to the test:
(1) flushing the network interfaces for the storage partition and the
SystemNetworkContextManager, and (2) setting back up the mock
CertVerifyResult for the test host.

Bug: 1131803
Change-Id: Id14ea7351cfec959c7fa79155d4fb87340cd3250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480810Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818056}

Should not mutate the object/list.

Change-Id: I3efe2e7726b2671b32ac7d9a0bc44b48621bcd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480823Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#818055}

Bug: 772945
Change-Id: I70086bea566951bf153eee521e2ec76102470dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469440
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818054}

TBR: triploblastic@chromium.org
Bug: 1139399
Change-Id: Ie13bb7d23ee953f871bfd98426d7bb73cf563381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480888Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818053}

This CL detects and allows signed exchange cache URLs even if they are
lookalikes.

Signed Exchange cache URLs (the initial URL that redirects to the
SXG) serve application/signed-exchange Content-Type response header.
In this case, the navigation will always either fail or redirect to
the primary URL (getting the content either from inside the SXG or the
network depending on whether the validations succeed).

Bug: 1110151
Change-Id: I5a15c0248402e563bb34b9643c483d80770bd121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441276
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818052}

Also fixes having multiple test-launcher-filter-file in buidbot JSON.
As well as parsing multiple test-launcher-filter-file on Android.

TBR=bsheedy

Bug: 1139118
Change-Id: I5c27b358286cdb66402ec75a0409e2e8fb900ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476837Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818051}

Bug: None
Change-Id: If7fb029fa54bad0908695d087e3f5350ca42bf31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481064Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818050}

Most of the DelegatedInkTrail pixel tests are using a fuzzy comparator,
but a few are expecting exact results. They should all be using the
fuzzy off by one comparator to ensure they are consistently passing.

Also disable DelegatedInkTest.TrailExtendsBeyondPresentationArea on Dawn
as it is slightly above the pass threshold for this comparator.

Bug: 1139340
Change-Id: I52e6e1695beec4804be6f14174015e0112872957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480813Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818049}

The Search Engine check DCHECK's on empty URL. Empty Referrers exist,
so it's better to handle that case than DCHECK on it.

Bug: 1131107
Change-Id: Ic238ff86ccc6cee912baea37d8f549b99b685f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480963Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818048}

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: If347312a688734df64e475f44cc2c54344fecb11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476622Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818047}