GitLab

Change the PhaseBegan to not cause a vertical scroll.

Deltas for PhaseBegan events are incorrectly
ignored by ScrollElasticityController. The PhaseBegan deltas are not
ignored by impl-side scrolling, which causes the test to fail. If
ScrollElasticityController is corrected to not ignore PhaseBegan deltas,
the test fails as well.

By changing the delta for PhaseBegan, the test passes both with
impl-side scrolling and with the corrected ScrollElasticityController.

BUG=133097

Review URL: https://codereview.chromium.org/811383003

Cr-Commit-Position: refs/heads/master@{#310148}

BUG=none
TEST=compiled locally with clang
NOTRY=true

Review URL: https://codereview.chromium.org/835383003

Cr-Commit-Position: refs/heads/master@{#310147}

Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/824063002/)

Reason for revert:
The reason for the revert was resolved: crbug.com/445051

Original issue's description:
> Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/)
>
> Reason for revert:
> Breaks devtools highlight on hidpi screens. See crbug.com/445051.
>
> Original issue's description:
> > Enable display list 2D canvas by default
> >
> > With this change, display list 2D canvas will become enabled by
> > default in Chrome. Content shell with --dump-render-tree will
> > continue to have display lists disabled by default.
> > Currently, having display lists enabled in blink means
> > that display lists will be used whenever 2d canvases would
> > not be GPU-accelerated.
> >
> > BUG=386601
> >
> > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae
> > Cr-Commit-Position: refs/heads/master@{#309453}
>
> TBR=avi@chromium.org,junov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=386601
>
> Committed: https://crrev.com/5b6f044b9bc14af9b265746d31db547be18d9dbb
> Cr-Commit-Position: refs/heads/master@{#309635}

TBR=avi@chromium.org,pfeldman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=386601

Review URL: https://codereview.chromium.org/837773003

Cr-Commit-Position: refs/heads/master@{#310146}

Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/)

Reason for revert:
Appears to have caused bug 446212

Original issue's description:
> Special check on Supervised User creation flow added to prevent misleading shelf alignment.
>
> BUG=405361
>
> Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
> Cr-Commit-Position: refs/heads/master@{#309555}

TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405361

Review URL: https://codereview.chromium.org/830393004

Cr-Commit-Position: refs/heads/master@{#310145}

This is https://codereview.chromium.org/835193005 rolled a little further and
with some additional changes:

It fixes the FallbackSCSV tests to no longer be a no-op. It also accounts for
BoringSSL's handling of a handshake_failure in response to a ClientHello to
match NSS's behavior and our test expectations. See https://crbug.com/446505
for details.

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/306e520..aac2f6a

BUG=446505

Review URL: https://codereview.chromium.org/834313002

Cr-Commit-Position: refs/heads/master@{#310144}

Although the sub-pictures already have the layer hoisting
data, Skia cannot access it unless the wrapping picture has
also gone through the hoisting analysis. Fortunately or
unfortunately, this is piggy-backed upon BBH creation (so
providing the kComputeSaveLayerInfo_RecordFlag by itself
is not sufficient).

BUG=383085

Review URL: https://codereview.chromium.org/797793005

Cr-Commit-Position: refs/heads/master@{#310143}

Interstitial pages are loaded via data url and cannot access
chrome://text_default.css. Until the way they're loaded is changed,
we have to use the old way.

While I'm at it, I made supervised_user_block_interstitial.html use
IDS_WEB_FONT_FAMILY instead of the hard-coded fonts in the corresponding
css. This change is for bug 303849.

BUG=443203,303849
TEST=See comment 4 in the bug 443203. See also http://crbug.com/444698

Review URL: https://codereview.chromium.org/808753006

Cr-Commit-Position: refs/heads/master@{#310142}

Linux Zygote sandboxing code keeps an fd for /proc while starting the
BPF sandbox (but ensures that it is closed later). This moves the
responsibility to the caller to ensure that no directory fds are present
after sandboxing is enabled.

Also adds WARN_UNUSED_RESULT to some important functions that return a
bool indicating success or failure.

BUG=312380

Review URL: https://codereview.chromium.org/835623005

Cr-Commit-Position: refs/heads/master@{#310141}

On platforms where libusb supports hotplug events this observer interface
allows clients of UsbService to be notified when devices are added and
removed from the system. When hotplug events are not available these
events are only generated in response to an explicit enumeration request.

The UsbDevice::Observer interface has been removed so that UsbDevice can
be a truly thread-safe object.

BUG=411715

Review URL: https://codereview.chromium.org/809743006

Cr-Commit-Position: refs/heads/master@{#310140}

In order to allow Vsync to be toggled by dev tools we need to both set the swap
interval to 0 on systems that support it and prevent the scheduler from
throttling frames.

BUG=437172

Review URL: https://codereview.chromium.org/811523002

Cr-Commit-Position: refs/heads/master@{#310139}

BUG=none

Review URL: https://codereview.chromium.org/819683002

Cr-Commit-Position: refs/heads/master@{#310138}

BUG=None

Review URL: https://codereview.chromium.org/836203002

Cr-Commit-Position: refs/heads/master@{#310137}

https://codereview.chromium.org/831863003 has enabled strict checks
for {virtual,override,final} on Linux. This CL fixes build issues
for Ozone on Linux.

BUG=417463

Review URL: https://codereview.chromium.org/825783003

Cr-Commit-Position: refs/heads/master@{#310136}

On the bots the rsync technique to download packages (see bug for more details)
takes too long. It takes almost 30 seconds even when the package is already on
the bot. Instead always download the zip and unzip it.

BUG=350151

Review URL: https://codereview.chromium.org/799673003

Cr-Commit-Position: refs/heads/master@{#310135}

BUG=446332

Review URL: https://codereview.chromium.org/815573004

Cr-Commit-Position: refs/heads/master@{#310134}

The checkbox controlling syncing of WiFi credentials should
be labeled "Wi-Fi networks", since that's easier for users
to understand. This CL makes it so.

BUG=chromium:436916
TEST=manual (open chrome://settings/syncSetup, verify text)

Review URL: https://codereview.chromium.org/838523002

Cr-Commit-Position: refs/heads/master@{#310133}

switches::kSkipGpuDataLoading causes the content_shell to not load
the blacklist and driver bug list.  This is preventing another cl
from landing that enables GPU rasterization.

Note for sherrifs, this flag was introduced to fix flake with
GpuTabTest, if we see this test flaking out, it may be as a
result to this change.

BUG=445500

Review URL: https://codereview.chromium.org/827293002

Cr-Commit-Position: refs/heads/master@{#310132}

See: https://codereview.chromium.org/831863003

R=lcwu@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/837453003

Cr-Commit-Position: refs/heads/master@{#310131}

https://chromium.googlesource.com/angle/angle/+log/2609bf4c..edd84e41

BUG=435726,445406

Review URL: https://codereview.chromium.org/839593002

Cr-Commit-Position: refs/heads/master@{#310130}

Review URL: https://codereview.chromium.org/837763002

Cr-Commit-Position: refs/heads/master@{#310129}

media_caps.h is included by some of the Chromecast code,
but none of the functions from there are being used at the
moment.

BUG=none

Review URL: https://codereview.chromium.org/830423005

Cr-Commit-Position: refs/heads/master@{#310128}

BUG=442514

Review URL: https://codereview.chromium.org/825323002

Cr-Commit-Position: refs/heads/master@{#310127}

BUG=446347
TBR=eustas@chromium.org

Review URL: https://codereview.chromium.org/837753003

Cr-Commit-Position: refs/heads/master@{#310126}

Previously, it was impossible to select infobars when using explore by
touch and traversing through the views using forward and backward
swipes. The problem was that ContentView contained both the
InfoBarContainer (a real View) as well as virtual views for all the
elements in the webpage -- but Android doesn't support ViewGroups that
contain both real and virtual views.

The fix is to add a FrameLayout, which is now a common parent of both
the ContentView and the InfoBarContainer. Here's the new view hierarchy:

  CompositorViewHolder
           |
      FrameLayout
       |        \
  ContentView  InfoBarContainer

Tab.getView() now returns the parent FrameLayout, rather than the
ContentView itself.

BUG=416663

Review URL: https://codereview.chromium.org/821393004

Cr-Commit-Position: refs/heads/master@{#310125}

The method RenderWidgetHostImpl::WaitForSurface() synchronously blocks the
browser's main thread, waiting for a frame of the right size to arrive from the
GPU process. It has a timeout of 50 milliseconds. This CL adds a metric
recording the time blocked by this method.

BUG=446369

Review URL: https://codereview.chromium.org/841443002

Cr-Commit-Position: refs/heads/master@{#310124}

I added a test that executed code on an uninited variable.  This
existed before, but wasn't being hit before.

BUG=446540

Review URL: https://codereview.chromium.org/808573006

Cr-Commit-Position: refs/heads/master@{#310123}

As a first step toward moving the chrome.idle API to
//extensions, update it to use content::BrowserContext
rather than Profile.

BUG=446320

Review URL: https://codereview.chromium.org/826933003

Cr-Commit-Position: refs/heads/master@{#310122}

that take scoped_ptr.

Mark the non-scoped_ptr versions as deprecated. Update tests. Update one client.

BUG=446238

Review URL: https://codereview.chromium.org/829333004

Cr-Commit-Position: refs/heads/master@{#310121}

By request, add subdomains flag to roddis.net and include
cs50.harvard.edu.

Cr-Commit-Position: refs/heads/master@{#310120}

SkDrawPictureCallback is going to be renamed
(https://codereview.chromium.org/837693002/). This CL
updates the includes to stage the transition.

Review URL: https://codereview.chromium.org/806553004

Cr-Commit-Position: refs/heads/master@{#310119}

This may have caused the audio power save blocker to not be created
or released appropriately when tabs move in and out of the background.

BUG=367785
TEST=tab audio indicator works as expected.

Review URL: https://codereview.chromium.org/817143006

Cr-Commit-Position: refs/heads/master@{#310118}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d445ce8..f48415c

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/839583003

Cr-Commit-Position: refs/heads/master@{#310117}

It is too late in the cycle to allow this to ship.

BUG=383085

Review URL: https://codereview.chromium.org/835343002

Cr-Commit-Position: refs/heads/master@{#310116}

We were at 0.9.35 with a few cherry-picks from the upstream. It's time
to catch up with the upstream.

BUG=445658
TEST=blink layout tests

Review URL: https://codereview.chromium.org/810153004

Cr-Commit-Position: refs/heads/master@{#310115}

Found when building with Ozone and use_xkbcommon=1 on Linux.

BUG=417463

Review URL: https://codereview.chromium.org/831373004

Cr-Commit-Position: refs/heads/master@{#310114}

Don't show prediction in placeholder text, because changing the placeholder text can alter the field's parsing.

BUG=445327

Review URL: https://codereview.chromium.org/833473003

Cr-Commit-Position: refs/heads/master@{#310113}

Since a profile name can be a Gaia name, we can't really have this
distinction around anymore (people can sign in to two different profiles with
accounts that have the same Gaia name. Since that's allowed, then
the UI should allow this too)

BUG=445037
TEST=Go to chrome://settings and try to rename a profile to an already existing
profile's name. The UI should allow that.

Review URL: https://codereview.chromium.org/834673005

Cr-Commit-Position: refs/heads/master@{#310112}

run in tests.

Updating Oilpan's infrastructure, its behavior may change.
We expect that a GC runs in this test, but we cannot promise that
it is a precise GC.

Background:
We expected precise GC ran in those tests, but at some point,
they changed to call conservative GCs.

BUG=446301
TEST=./tools/perf/run_tests --browser=content-shell-release OilpanGCTimesTest

Review URL: https://codereview.chromium.org/818653004

Cr-Commit-Position: refs/heads/master@{#310111}

SetCurrentLayoutByName has needed support for ChromeOS. It would be
nice to have needed non-ChromeOS support, so that other Ozone implementations
can re-use all this work. This patch adds needed support for retrieving Key
maps from the passed string.

Review URL: https://codereview.chromium.org/822383002

Cr-Commit-Position: refs/heads/master@{#310110}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1b74730..3f4e045

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/838593002

Cr-Commit-Position: refs/heads/master@{#310109}