- 13 Apr, 2018 28 commits
-
-
Tommy C. Li authored
When Steady State Elisions is on, when the user clicks the mouse once, it should focus and select all in the text field. When the user places the caret inside the text by clicking on the text a second time, it should unelide on mouseup only. This adds a test for that. It also places the View inside a Widget to make the focus behave correctly. It also adds a fake clock to the Steady State Elisions test, so we can control the click being not interpreted as a double-click. Bug: 797354 Change-Id: If72235dd88b6918f9071fffea800723a24c555f7 Reviewed-on: https://chromium-review.googlesource.com/1007492 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550449}
-
Wenzhao Zang authored
1) Changed all the observers in //chrome to use the mojo interface. 2) Since views-based login may still take some time to be fully ready, prefer to remove the dependency in signin_screen_handler now. Since app list and login screen are two main observers of wallpaper events we'll be able to clean up some mojo interface after both are moved to //ash. Bug: 827062 Test: --enable-features=Mash Change-Id: I81a26faa8ccb29c472ed4dc2257604d67f56e897 Reviewed-on: https://chromium-review.googlesource.com/998814Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550448}
-
Kim Paulhamus authored
Bug: 828958 Change-Id: Ie24fb55ddf5b8180036e830cd73ae58b0fb2ccd5 Reviewed-on: https://chromium-review.googlesource.com/994177 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550447}
-
Kevin Marshall authored
This reverts commit 9213e261. Reason for revert: Very flaky on Win7 Tests (x64) Example run: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/37006 Original change's description: > Added export policy session to Linux > > This feature allow users to export the policies in a JSON file. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I708abc3465ecf2a469979fb7d13b22ed947ed392 > Reviewed-on: https://chromium-review.googlesource.com/966590 > Commit-Queue: Martin Rodriguez <rodmartin@google.com> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550246} TBR=pastarmovj@chromium.org,georgesak@chromium.org,dschuyler@chromium.org,zmin@chromium.org,rodmartin@google.com Change-Id: Ibbaa930b23638ec9abc10dc3bdce234e11a7cbcf No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1011625Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550446}
-
https://chromium.googlesource.com/catapult.git/+log/19b3dfed02a8..67d01a21077f $ git log 19b3dfed0..67d01a210 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 sullivan Pinpoint: only update bug status if bug is open and unassigned. 2018-04-12 simonhatch Dashboard - Use same names as chromium.perf for annotations Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I12b500d2e34f6eede77b5480b393c531252f4656 Reviewed-on: https://chromium-review.googlesource.com/1011233Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550445}
-
Shridhar Sundarraj authored
In Viz, PageHandler will no longer know that a CompositorFrame has been submitted. This CL makes use of FrameSinkVideoCapturerImpl for screencasting, so that PageHandler doesn't need to rely on knowing about CompositorFrame submissions. Some information from CompositorFrameMetadata is required for screencasting. This is sent to PageHandler by FrameSinkVideoCapturerImpl along with each frame. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie7a191944579bb7f6dda0e5384e5955764c24850 Reviewed-on: https://chromium-review.googlesource.com/969711 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550444}
-
Mitsuru Oshima authored
This is reland of crrebu.com/c/990203 with ASH_EXPORT This will be used for ARC++ windows. This a) is always placed at the topof the display and covered full width. b) supports immersive mode c) is resized when the display metrics changes. TBR=mukai@chromium.org BUG=b/33693796 TEST=covered by unittest Reviewed-on: https://chromium-review.googlesource.com/990203Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550278} Change-Id: Ib60a03017c724c62d5912a472fa6e32dd9a02e99 Reviewed-on: https://chromium-review.googlesource.com/1011323Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550443}
-
Hector Carmona authored
Bug: 832012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c1b7499de7085f1ca109748b28b5067754b5aaa Reviewed-on: https://chromium-review.googlesource.com/1010481Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#550442}
-
Xiaoqian Dai authored
Previously it was OverviewWindowDragController who is responsible to remove the window from overview before trying to snap it. It should be SplitViewController's responsibility to do this work. Bug: None Change-Id: I157d8cff294fd43ecbefeff01fc20cd61cb95361 Reviewed-on: https://chromium-review.googlesource.com/1008966 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550441}
-
Yuwei Huang authored
Previously we report connection failure both before and after CONNECTED as CONNECTION_FAILED, which makes it harder to calculate durability. This CL makes sure connection failures after CONNECTED are reported as CONNECTION_DROPPED. Bug: 828210 Change-Id: I8689718a5741aec6b1ea49172838b44857ca4108 Reviewed-on: https://chromium-review.googlesource.com/1011354Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550440}
-
Kent Tamura authored
This CL is a preparation to change references to them in build bots. This CL has no behavior changes. Bug: 829697 Change-Id: I3d69dbae6520e3b2c6ca95a7b3c05a7322eeaa0a Reviewed-on: https://chromium-review.googlesource.com/1009543Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550439}
-
Yuwei Huang authored
_session is only valid when the session is connected. This CL adds tests before using _session in RemotingClient. Bug: 831954 Change-Id: I0f12221f2c80b55d0a784dc8771fbec573fd1deb Reviewed-on: https://chromium-review.googlesource.com/1010917Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550438}
-
Ryan Hansberry authored
Bug: 819279 Change-Id: Iae36309deae890bfa84ac251eb6bfb4dca94d8f9 Reviewed-on: https://chromium-review.googlesource.com/1009066 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#550437}
-
Eugene But authored
iOS 11.4 introduced "Policy requirements not met." error which is used in varios sutuations. This error is mapped to CERT_STATUS_INVALID and CERT_STATUS_AUTHORITY_INVALID. cert_verify_proc_ios_unittest was changed to be Objective-C source file to use @available keyword (the only clean way to test for OS version). PlatformTest is needed for every Objective-C test to drain autorelease pool. Bug: 830127, 830125 Change-Id: I99d4d3e6a580c16fdbb8e47359418a0a68b0fb48 Reviewed-on: https://chromium-review.googlesource.com/1008128Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#550436}
-
Jungshik Shin authored
There are two changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/d888fd2..aff99f5 $ git log d888fd2..aff99f5 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 jshin@chromium.org Cherry pick 3 patches from the upstream 2018-04-10 jshin@chromium.org Update IANA tzdb to 2018d and apply a fix for long word selection TBR=mark@chromium.org,inferno@chromium.org Bug: chromium:799850, chromium:796807, chromium:796752 Bug: chromium:829144, chromium:473288 Test: See the two ICU cls above. Change-Id: I0adf27e01c0349bd00d4916567bdc0bc70483439 Reviewed-on: https://chromium-review.googlesource.com/1011238Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550435}
-
Michael Thiessen authored
Reverts some code I thought wasn't necessary anymore in https://chromium-review.googlesource.com/c/chromium/src/+/951926 Bug: 831332 Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885 Reviewed-on: https://chromium-review.googlesource.com/1011406Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550434}
-
Xiangjun Zhang authored
The accidentally starting Media Remoting on Android caused the crash since it is currently not supported on Android. Bug: 827990 Change-Id: I1416993a2e3c03084e694c342d67becc44ec0fce Reviewed-on: https://chromium-review.googlesource.com/1008847Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550433}
-
Fergal Daly authored
The original doc was mistaken about MatchScopedRules and actually described the V0 process. Update it to describe the V1 process. This includes removing the reference to TreeBoundaryCrossingScopes as these are only part of V0. Also a few small updates: - splitting the classes up into 2 groups - more detail on :host - a bit more detail on the compiling phase - some random fixes Change-Id: Ifc2b26ccf82c1b9a24f52afb7ce74e0fea768fb7 Reviewed-on: https://chromium-review.googlesource.com/1006743Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550432}
-
Biao She authored
Note that it depends on https://chromium-review.googlesource.com/c/chromium/src/+/1010479 This CL replaces the support library's AlertDialog with a VrAlertDialog IFF we are in VR. Bug: 831233 Change-Id: I4ef0586625e3ae447f55b1e6045f2fb2dfef09ff Reviewed-on: https://chromium-review.googlesource.com/1010916Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#550431}
-
Menglu Huang authored
This reverts commit f6c12979. Reason for revert: <INSERT REASONING HERE> Breaks ios-device-xcode-clang and ios-simulator-xcode-clang ../../base/stl_util_unittest.cc:120:33: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] std::array<int, 4> array = {1, 2, 3, 4}; ^~~~~~~~~~ { } https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/57071 Original change's description: > [base] Implement std::size(), std::empty() and std::data() > > This change provides C++14 implementations of C++17's std::size(), > std::empty() and std::data(). > > Bug: 828324 > Change-Id: If1b83826a23b26fd557f7854962bcbc771a7ffe0 > Reviewed-on: https://chromium-review.googlesource.com/992236 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550137} TBR=dcheng@chromium.org,kylechar@chromium.org,jdoerrie@chromium.org Change-Id: I0335a72133de226a435c1f215f886850a108ef01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828324 Reviewed-on: https://chromium-review.googlesource.com/1011565Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#550430}
-
Sidney San Martín authored
Any view that implements drawRect: and/or sets needsDisplay on itself gets a view-sized backing store. This was costing ~100MB per large window on my MBP, and nothing was using it: 10.9 is no longer supported and menu backgrounds are no longer blurred (and if they were, it'd be a different way). Bug: 832197 Change-Id: I2aeaa53a19c12f23a2e05d33883eabf76e318f1c Reviewed-on: https://chromium-review.googlesource.com/1011022Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550429}
-
Joy Ming authored
There were surplus offline pages notifications (unintended prefetch notifications and double offline pages notifications) because of a doubled pathway when OfflineContentAggregatorNotificationBridgeUi is activated. Temporarily disable OCANBUi for offline pages until a more long-term fix is in place that can filter out notifications. Bug: 831083,832282 Change-Id: I49095de6cb9138c2081147342fa76aab9fc8c857 Reviewed-on: https://chromium-review.googlesource.com/1011227 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550428}
-
Ryan Hansberry authored
Bug: 819279 Change-Id: I8b323b5a713b1d95b349b813aaff88072ccb12f2 Reviewed-on: https://chromium-review.googlesource.com/999016 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#550427}
-
Devlin Cronin authored
Manifest v1 extensions have been deprecated for a long time. Stop loading these extensions unless a special (existing) commandline flag is present. There are a few straggling tests (which rely on packaged extension resources, like .crx files) that still need to be updated; use the commandline flag (or a runtime variant) in those tests. These will be cleaned up in follow-up CLs. Bug: 831909 Change-Id: If2323829cd75f826d54a34b713eecf7c28973667 Reviewed-on: https://chromium-review.googlesource.com/1009070Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550426}
-
wutao authored
This cl made 3 string changes based on TC feedback. Bug: b/77862935, b/77862860 Test: manual Change-Id: Ic73441d6b5d246927eacc56daffdfbf2c65fb526 Reviewed-on: https://chromium-review.googlesource.com/1008409Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550425}
-
Travis Skare authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4bdb81dd016abb71951a08c86f965a4128be0eed Reviewed-on: https://chromium-review.googlesource.com/887300Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#550424}
-
Yuly Novikov authored
conformance2/transform_feedback/switching-objects.html on Linux AMD R7 240, no_angle BUG=696345 TBR=kbr@chromium.org No-try: True Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I55e92720c7d129b3ca6a249fefb517cb33318137 Reviewed-on: https://chromium-review.googlesource.com/1010520 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550423}
-
Sammie Quon authored
This is a reland of fc2d77d5 TBR=oshima@chromium.org Original change's description: > overivew: Animate blur when there are no maximized windows. > > See bug(s) for spec. This CL adds an animated blur on wallpaper when entering/existing > overview when no maximized/fullscreen windows. > > Bug: 823533, 812004 > Change-Id: Icf8bdababedaaefe869f62768aacf7abcb3643d2 > Reviewed-on: https://chromium-review.googlesource.com/979167 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549780} Bug: 823533, 812004 Change-Id: I3aa8ded00f07209108f144bddfa401a35d90ff2d Reviewed-on: https://chromium-review.googlesource.com/1007742Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#550422}
-
- 12 Apr, 2018 12 commits
-
-
Menglu Huang authored
This reverts commit ca9c8b38. Reason for revert: <INSERT REASONING HERE> Breaks browser_tests on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6852 Original change's description: > Use PostTask to schedule cross-process postMessage forwarding. > > Previously, we sent the IPC to forward a cross-process postMessage > immediately. This caused a behavioral difference from the > same-process case where the postMessage is always scheduled. Namely, > in a scenario like this: > > frame.postMessage(...); > doSomethingThatSendsIPCsToFrame(frame); > > the IPCs from JS following the postMessage would've been ordered > incorrectly, causing |frame| to see their side effects after the > postMessage dispatch in the cross-process case, whereas they would be > seen before the postMessage dispatch in the same-process case. One > example of this is frame.focus(), and another is a frame element > onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after > a postMessage dispatched from an inline script while the frame was > still loading. > > To resolve these ordering concerns, this CL changes cross-process > postMessage to do a PostTask on the sender side before sending the > message to the browser process. This improves the current state of > the world, but does not yet achieve a perfect match for the IPC > ordering in the same-process case - see discussion on the bug. > > Bug: 828529 > Change-Id: I1138bcdcd18c458a92dec92e145761b226596c7a > Reviewed-on: https://chromium-review.googlesource.com/999182 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550284} TBR=xiyuan@chromium.org,wjmaclean@google.com,dcheng@chromium.org,alexmos@chromium.org Change-Id: I11e88ed08c096be2534a6ab103f5553f3a4cfb9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828529 Reviewed-on: https://chromium-review.googlesource.com/1011564Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#550421}
-
Oliver Chang authored
- Append '_' to parameter names which are also reserved keywords in JavaScript. Struct field names remain unchanged as such keywords still work there. - Rename "params" variable in generated Proxy.prototype.{{method.name}} to prevent a parameter named "params" from breaking the bindings. Bug: 826070 Change-Id: I29046179929df18e14f63ff4d1cc3a74c1ef71e0 Reviewed-on: https://chromium-review.googlesource.com/1009347Reviewed-by:Ken Rockot <rockot@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550420}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8aa3eac3b786..6bf1af11228f $ git log 8aa3eac3b..6bf1af112 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:828611,chromium:721137 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3bed21a455afe7a33c4bec5c7b99f5806d5bcea6 Reviewed-on: https://chromium-review.googlesource.com/1010830Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550419}
-
Fabio Tirelo authored
This parameterizes tests in password_manager_interactive_uitest.cc to run with feature kAutofillExpandedPopupViews either enabled or disabled. The goal is to ensure it's safe to enable the feature for Canary/Dev. Some of the tests don't actually run the code enabled by the feature, but parametrize only those tests would lead to a much more complicated structure. This would be specially annoying since the feature will eventually be deleted after it becomes the default and we can get rid of the deprecated code paths. There are tests in password_manager_browsertest.cc also affected by the feature, but they will be updated on a follow up CL. Bug: 768881 Change-Id: I0403765e8da19037cef5d8f5381300621882a323 Reviewed-on: https://chromium-review.googlesource.com/1007782Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550418}
-
Chris Palmer authored
When we see the header, print a warning to the console. Adapted from a suggestion from elawrence@. Bug: 779166 Change-Id: Id68495a37f43436cd51833391dbf140d5eb9aef3 Reviewed-on: https://chromium-review.googlesource.com/1006194Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#550417}
-
Sergey Ulanov authored
Added AsyncDispatcher class which implements async dispatcher interface for Fuchsia. It will be used in MessagePumpFuchsia. This will allow to run FIDL on Chromium threads. The implementation is based largely on the default async loop. That code has been translated to C++ with all features that we don't need in chromium removed. Bug: 831384 Change-Id: I76459d364e1a4864dbe6f76f582b9fb87c79e027 Reviewed-on: https://chromium-review.googlesource.com/1003073 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550416}
-
lgcheng authored
Since ArcTos page can be loaded before it's shown, focus status is not correctly set in the case. Try to set the focus status of default button when the page is shown. Bug: 831104 Test: Manual. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b62ee8a45de1bfa69152f1b7813918185aaa276 Reviewed-on: https://chromium-review.googlesource.com/1011225 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550415}
-
Daniel Murphy authored
This reverts commit 6ccc199f. Reason for revert: The blob perf tests for Android should now work due to us fixing https://crbug.com/829410 Original change's description: > Disabling blink_perf.owp_storage on Android one > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 823357 > Change-Id: Ia44f54405c5b6ad0dd0f3b859753de3cea7c35b4 > Reviewed-on: https://chromium-review.googlesource.com/978478 > Reviewed-by: Emily Hanley <eyaich@chromium.org> > Commit-Queue: Emily Hanley <eyaich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545511} TBR=eyaich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823357 Change-Id: Iae4ecaab40550d8dd49c74ef74a75fdaf02926aa Reviewed-on: https://chromium-review.googlesource.com/1008022Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#550414}
-
Sorin Jianu authored
This is a mechanical change. The intention is to make it more obvious how a transition to a final state occurs and what is_handled means. Bug: 822990 Change-Id: I00bff79618e1128617f5655010a17dd8eadd954e Reviewed-on: https://chromium-review.googlesource.com/1011243Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550413}
-
Ted Choc authored
When the homepage is enabled, Chrome is automatically closed when closing the last tab. This ensures the homepage is shown when the user next uses Chrome. When the homepage is set to the NTP, this does not make sense as the homepage is the primary surface that you can actually open from the empty state. BUG=466410 Change-Id: Ib3f0c1c14840220088214c7dd97a96273cf4a26e Reviewed-on: https://chromium-review.googlesource.com/1010885Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550412}
-
Jennifer Apacible authored
This change allows the user to toggle play/pause from the Picture-in-Picture window. Left clicking alternates between sending play and pause messages to the media player. Middle/Right click does nothing. Future work includes adding UX affordances for media controls. BUG: 726619 Change-Id: Icb9f431b6e343182849f4dc8304d367b166cfe67 Reviewed-on: https://chromium-review.googlesource.com/974565 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550411}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If60370c0af378fa1d0a4f970d3cf3fe0f2f4925b Reviewed-on: https://chromium-review.googlesource.com/1011234Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550410}
-