- 31 Jul, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium d49fdae6. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22133 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ieb00afc969b11febcf390776bc67c46cb0ad06f8 Reviewed-on: https://chromium-review.googlesource.com/1155934 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579281}
-
Koji Ishii authored
Following bot results are included. 8458 8465 8466 8469 8473 8475 8488 8492 8494 8496 1 lines were removed and 7 lines were deflaked by consecutive results since 8447. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4cc7a150cc87dd0f259508fc5637d0b85cbc25c7 Reviewed-on: https://chromium-review.googlesource.com/1154241 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579280}
-
Jiajia Qin authored
This patch implements bindImageTexture API so that users can load/store image data in shader. Meanwhile, we adds all types of image unit for getUniform. With this, users can use getUniform to get the image unit's binding point in API side. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I22052ad4c15102ce73727a79dd4269302efadab2 Reviewed-on: https://chromium-review.googlesource.com/1152690Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#579279}
-
Peter Boström authored
This test has started to flake recently, disabling during investigation. Bug: chromium:868706 Tbr: tommycli@chromium.org Change-Id: Icb9767c98885c76dece2f4b39449bf6e04a6ddcb Reviewed-on: https://chromium-review.googlesource.com/1155993 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579278}
-
Giovanni Ortuño Urquidi authored
Moves the ownership of PendingAppManager up to WebAppProvider. PendingAppManager will be used by any client that wishes to install a WebApp. For now this is only WebAppPolicyManager and ScanForExternalApps. Bug: 864904 Change-Id: I0599c896accdd74ceabfc16bf403d4eec501c97e Reviewed-on: https://chromium-review.googlesource.com/1154744 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#579277}
-
Patti authored
Currently, the All Sites list only includes sites with non-default content settings. Update it to include sites that use local storage (disk space) as well. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I722c659b551aaf5023bb82a7475151df39a092be Reviewed-on: https://chromium-review.googlesource.com/1137812Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#579276}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f7d4cd62a0b..946a162a5239 git log 9f7d4cd62a0b..946a162a5239 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@946a162a5239 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I83b10022c951b044d591aef781bf4f345686bccb Reviewed-on: https://chromium-review.googlesource.com/1155865Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579275}
-
Yue Cen authored
shadow effect. Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I677cbf3a3e34a84afabb839a2e8adc61fb27c1bb Reviewed-on: https://chromium-review.googlesource.com/1139177 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579274}
-
Han Leon authored
This CL is the 2nd step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 - Remove the typemapping of blink.mojom.FetchAPIResponse. The mojom struct blink.mojom.FetchAPIResponse describes a Response in terms of the concept from the Fetch spec, currently it's defined under blink/public/platform/modules/fetch/ and is used only by Cache Storage API implementation (by both Browser and Renderer code), as this struct meets the 2 conditions below, it should be fine to go into blink/public/mojom/: - it is expected to be used by both Browser and Renderer code. - it is expected to be passed over Mojo between Browser and Renderer (Blink). But, currently for Chromium Mojo binding variant it is typemapped to content::ServiceWorkerResponse being used in content/browser/cache_storage/, this blocks it being moved to blink/public/mojom/. So we need to remove this typemapping first, this removal also helps reduce 1 user of content::ServiceWorkerResponse. 2nd step: (This CL) Now we can just move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/, which makes the next steps possible. 3rd step: - Use blink.mojom.FetchAPIResponse to represent the response a service worker provides to FetchEvent#respondWith. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse in content/common/service_worker/service_worker_fetch_response_callback.mojom. Thus we can reduce another 1 user of content::ServiceWorkerResponse. More importantly, this makes it possible for us to move service_worker_fetch_response_callback.mojom into blink/public/mojom/service_worker/ in future. 4th step: - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: I9afad29a89887369c211cb46bce5bc98df16064f Reviewed-on: https://chromium-review.googlesource.com/1149706 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579273}
-
Yuri Wiitala authored
Reduce thrash on content/browser/OWNERS and content/renderer/OWNERS for trivial adds/deletes from the BUILD.gn file. All of content/OWNERS, chrome/browser/OWNERS, and chrome/renderer/OWNERS already has this, so there is precedent. BUG=869232 Change-Id: I535294fd904da1739fa7abb95ce18da162eb42bb Reviewed-on: https://chromium-review.googlesource.com/1150815 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#579272}
-
David Black authored
Root cause of the crash was committing a query without first having pended a query. This can occur in a notifications flow or a device actions flow in which an interaction did not originate from the UI. We rely on pending/committing the query in the interaction model to clear the previous query from the UI. The fix, in this case, was just to pend an empty query so that we have something to commit. Bug: b:111923411 Change-Id: I53848f856375cf220538738634e7543a455c0dcc Reviewed-on: https://chromium-review.googlesource.com/1155153Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#579271}
-
Vlad Tsyrklevich authored
JPEGImageReader::AllocateSampleArray() can call the function pointer (*info_.mem->alloc_sarray) which can be set by the systems non-CFI enabled libjpeg DSO when chromium is built with use_system_libjpeg=true. Disable cfi-icall for that method. Bug: 866290 Change-Id: I6d9bbf08c514d6d5f48ad34c3802c63419ed1223 Reviewed-on: https://chromium-review.googlesource.com/1155927Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#579270}
-
Kyle Milka authored
The mouse navigation class was not applied when the Google Photos option was clicked resulting in a focus ring showing up. Bug: 869134 Change-Id: I53551a7819db8ea8fd098cc670c7713cee00788e Reviewed-on: https://chromium-review.googlesource.com/1155761 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579269}
-
Mike Dougherty authored
TBR=eugenebut@google.com Bug: 869176 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9155f518e23fd6c739e2bd13c16eceff1d9f04b2 Reviewed-on: https://chromium-review.googlesource.com/1155793Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579268}
-
Hector Carmona authored
Bug: 833914 Change-Id: I1720bd1f3711b74cef11ae9f5158cdea069bfb11 Reviewed-on: https://chromium-review.googlesource.com/1155936 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579267}
-
edchin authored
Voiceover reads nothing for NTP tabs in the tab grid. It should read 'new tab'. Recently, the titles for NTP tabs were removed to improve the look of the tab grid. However, this meant that voiceover had nothing to read. This CL brings back titles for NTP, but instead hides them. This allows voiceover to read the title, even though it is not visible. Bug: 868401 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I37fe3782e6ee68822e59ff1de7ef18e619cece42 Reviewed-on: https://chromium-review.googlesource.com/1152239Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579266}
-
sczs authored
When the last incognito tab is closed, it re-creates the TabModel. This CL updates the tabGridLoader with the new TabModel browserState and WebstateList. Bug: 865937 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I707dc818eed50736fc0d35922075ecb3360d014a Reviewed-on: https://chromium-review.googlesource.com/1154146 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
Brandon Jones authored
New type provides origin and direction for the ray as DOMPointReadOnly values. Bug: 868461 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I918d8cad2569919b3d159eb910da4dddb31d3562 Reviewed-on: https://chromium-review.googlesource.com/1153475 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579264}
-
Jinsuk Kim authored
Tap disambiguation is a desktop-site-viewed-on-Android-phone-specific feature designed to save users from fat-fingered touches on tiny, close-together links. When a taps falls between two small touch targets when zoomed-out, the screen grays out, a magnified version of that section of the page appears, and the user must tap again to execute the tap. It looks like this: https://gigaom.com/wp-content/uploads/sites/1/2014/12/chrome-android-zoom-links-804x512.jpg Chrome for Android has had this since inception, but no other browser supports this. Chrome for Windows had an abortive attempt at adding it in http://crbug.com/385249 , but it mostly caused user complaints and was removed. It only applies to desktop sites, which are much rarer than they were when Clank initially launched in 2012. This feature has had years to prove itself by now, and it seems nobody especially loves it. You can always pinch zoom in these cases instead, and I prefer pinch zooming because you can't ever be 100% sure this feature will trigger. Its fullscreen-takeover UX is unusual and disruptive, so users might be surprised/confused to see it rather than pleased. This hasn't been an enormous maintenance burden so far, but it's 1000 lines or so spanning from Blink to the browser process, it's accumulated paint and overtriggering bugs over time like http://crbug.com/695754, and I think it will be especially painful to support it with OOPIF. This CL deletes the code. Bug: 704323 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I46cb7f103a6fa00ca4d8212c26f5232c95501aba Reviewed-on: https://chromium-review.googlesource.com/689054 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579263}
-
Nate Fischer authored
This reverts commit df22b814. Reason for revert: breaks generate_build_files (http://crbug.com/869231) Original change's description: > Use proguard version 6.0.3 for monochrome_public_apk. > > MonochromePublic.apk release builds are very close to the main dex limit > and updating proguard reduces the number of methods by about 3000. > > 6.0.3 cannot be used for all APKs yet due to a bug which causes > cronet_test_instrumentation_apk to fail. > > The version mismatch should be temporary as we plan to switch to R8 in the > future (https://crbug.com/868770). > > Bug: 857572 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester > Change-Id: I3676a42908c5046dc3f3831e282150702038140d > Reviewed-on: https://chromium-review.googlesource.com/1154366 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579250} TBR=yfriedman@chromium.org,estevenson@chromium.org Change-Id: I1d7e50cf720e9a128a62f06bb34a4c9f6d25c60d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857572 Bug: 869231 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1155502Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579262}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/87c1fdcc9a56..b53ef1e52d40 git log 87c1fdcc9a56..b53ef1e52d40 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 tsepez@chromium.org Replace m_bIsContentLayoutItem with proper enum for type. Created with: gclient setdep -r src/third_party/pdfium@b53ef1e52d40 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7cb0dd7ebf3def2a01c40482a2fa5fb655617d85 Reviewed-on: https://chromium-review.googlesource.com/1155885Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579261}
-
Dale Curtis authored
Per chromium style guide we should not be DCHECK'ing handled cases; these cases must be handled in release builds and thus should not have special handling in debug mode. BUG=868695 TEST=none Change-Id: I1c17d5c2aadeda43fcc4193746623edaadae45e6 Reviewed-on: https://chromium-review.googlesource.com/1155825Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579260}
-
Peter Boström authored
This reverts commit 35be1bb5. Reason for revert: Causing test flakes. Bug: chromium:869225 Original change's description: > Add MimeSniffingThrottle for navigation and requests from renderer > > This CL adds MimeSniffingThrottle which can intercept the response in > ThrottlingURLLoader. Typically mime sniffing happens in network::URLLoader and > MimeSniffingThrottle is skipped in this case. If a request goes to a service > worker or other interceptors, the MimeSniffngThrottle intercepts the response > when a set of the mime type and the url is eligible to sniff the mime > type. Sniffable mime types are defined in net::ShouldSniffMimeType(). When a > mime type for performance sensitive components like "text/html", > "text/javascript",or "text/css" is provided, it doesn't sniff. > > Bug: 858975 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib6e5b29867494fc0c0876952b4fec2a141288b36 > Reviewed-on: https://chromium-review.googlesource.com/1141744 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578971} TBR=kinuko@chromium.org,shimazu@chromium.org Change-Id: I88721b279e5f38685b96d2d6f2813e423ff49540 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 858975 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1155501Reviewed-by:
-
Etienne Bergeron authored
This CL is fixing a flakiness caused by a random trigger. A slow-report is triggered for a control population for every 1/3000 case. Unfortunately, that will cause other tests to be flaky 1/3000 times. This CL is fixing this by adding a virtual method to hide the random behavior. R=erikchen@chromium.org Change-Id: I32190b4b8786c5b1b7b3d2684ba952928a043085 Reviewed-on: https://chromium-review.googlesource.com/1155736Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579258}
-
Eric Karl authored
Previous CL assumed that if we were not using GL, we wouldn't need a default_offscreen_surface(). While true, a SW Viz process tried to query the format of this surface leading to a crash. Instead we should allow this surface to be null. R=piman Bug: 868777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I37377396c6e172eac17c3d6db00b600eb9896d15 Reviewed-on: https://chromium-review.googlesource.com/1155473 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Derek Cheng authored
Certain Cast-enabled devices also advertise via SSDP for the purpose of improving discovey reliability. However, they also (incorrectly) claim to support DIAL apps, only for the DIAL app launch to fail. We currently prevent such cases of Cast devices showing up as a duplicated (incorrect) DIAL sink by relying on a hardcoded list of model names to determine whether a DIAL sink is "discovery only", i.e., DIAL sink queries should not be performed on them. Unfortunately the list is not exhaustive and it would be challenging if not impossible to obtain and maintain an acccurate list, as seen from the recent regression. This patch takes a different approach, by noting that if a Cast sink can be derived from a DIAL sink (or if it already exists), then the DIAL sink can be removed from DialMediaSinkServiceImpl as it has no further use by the DIAL MRP. This ensures that no further DIAL queries will be issued to that sink, and that the sink will not show up on a sink query. Change-Id: Icdd3fc35baf6e3898537d38e1b059fc5c2714007 Bug: 869112 Reviewed-on: https://chromium-review.googlesource.com/1155258 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579256}
-
Kyle Qian authored
This CL includes a concrete implementation for the abstract class SystemClock defined in the Nearby library. SystemClock currently contains a single method elapsedRealtime(), which is expected to return time in milliseconds since boot, including time spent in states such as suspension (closed lid). The implementation in this CL, however, does not include time spent in suspension due to a current limitation of the POSIX implementation of base::TimeTicks::Now(). See https://crbug.com/166153 for info. Because the actual Nearby library has yet to be merged into the CrOS directory, this CL includes stand-in Nearby abstract classes under the temporary directory //chromeos/components/nearby/library. This directory will be removed after the Nearby library gets imported to //third_party. Bug: 861813 Change-Id: I194880c75c4a8ba3afa37b6b3c916485c065f20f Reviewed-on: https://chromium-review.googlesource.com/1150822Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Qian <kyleqian@google.com> Cr-Commit-Position: refs/heads/master@{#579255}
-
Peter Mayo authored
Some layers under --enable-bloink-gen-property-trees at least have no element_id. Don't unregister them since they were never registered. Bug: None Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1d9cf412e56ce088819157f7b43d5214fdcf39d7 Reviewed-on: https://chromium-review.googlesource.com/1155821Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579254}
-
Nate Chapin authored
Two behavior changes: * Previously, DidReceiveRedirectTo() was called for almost all redirects (barring a few early-exits), but WillFollowRedirect() was only called for same-origin redirects. Now the single callback, WillFollowRedirect(), is called whenever DidReceiveRedirectTo() used to be called. * Previously, due to a bug in https://chromium-review.googlesource.com/c/chromium/src/+/1147890, the return value of WillFollowRedirect() was ignored when out-of-blink CORS was enabled. That return value is now honored. Change-Id: I9c1ebb30b23aea77114711e0ee1b5dd0409c7166 Reviewed-on: https://chromium-review.googlesource.com/1150695 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#579253}
-
codeimpl@gmail.com authored
As following specification in url[1], return value was wrong in idl. So I fixed the return value. [1] https://immersive-web.github.io/webxr/#xrdevice-interface Bug: None Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I87adbd6e3dfe73a6a7707c282fda625b233b4d3b Reviewed-on: https://chromium-review.googlesource.com/1155027Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Scott Violet authored
ScopedTabbedBrowserDisplayer takes care of creation and showing if necessary. BUG=none TEST=none Change-Id: Iba7055bddce6aa0cfe2b5d564ec3b653fd0ab9aa Reviewed-on: https://chromium-review.googlesource.com/1155937Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579251}
-
Eric Stevenson authored
MonochromePublic.apk release builds are very close to the main dex limit and updating proguard reduces the number of methods by about 3000. 6.0.3 cannot be used for all APKs yet due to a bug which causes cronet_test_instrumentation_apk to fail. The version mismatch should be temporary as we plan to switch to R8 in the future (https://crbug.com/868770). Bug: 857572 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I3676a42908c5046dc3f3831e282150702038140d Reviewed-on: https://chromium-review.googlesource.com/1154366Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579250}
-
kristipark authored
Screenshots: https://screenshot.googleplex.com/871EngQdhMQ.png https://screenshot.googleplex.com/nUQPvKxaBiR.png Bug: 851194 Change-Id: I97e8474bc79b18d579aaeb3c13e202dd1c7748b0 Reviewed-on: https://chromium-review.googlesource.com/1154196 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579249}
-
Wez authored
Change-Id: I31eebb83d523e906ba2752b26abf098f373a9ac2 Reviewed-on: https://chromium-review.googlesource.com/1155932Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579248}
-
Roger Tawa authored
This reverts commit b43fa6db. Reason for revert: Caused three bugs open for flaky tests: https://bugs.chromium.org/p/chromium/issues/detail?id=869043 https://bugs.chromium.org/p/chromium/issues/detail?id=868769 https://bugs.chromium.org/p/chromium/issues/detail?id=868839 The speculation is that new calls to ScanDirForExternalWebApps() are not being done on the correct thread. Original change's description: > Allow (auto-installed) external web apps > > These are the Web App analogs of external extensions, described at > https://developer.chrome.com/apps/external_extensions > > On start up, *.json files (often but not necessarily named > external_extensions.json) are scanned in a number of directories. Prior > to this CL, such .json files can install regular extensions (.crx files) > or, on Chrome OS, Android apps. New in this CL is being able to install > Web Apps (sometimes known as Progressive Web Apps or PWAs). > > For example, the chrome::DIR_USER_EXTERNAL_EXTENSIONS path (defined in > chrome/common/chrome_paths.h) can correspond to file system directory > like "$HOME/.config/chromium/test-user/.config/chromium/External > Extensions". Placing a foo_bar.json file containing: > > { > "web_app_manifest_url": "https://www.chromestatus.com/static/manifest.json", > "web_app_start_url": "https://www.chromestatus.com/features" > } > > in that directory will install the Chrome Platform Status web app. > > Bug: 855281 > Change-Id: I716fead81d407076a0dda32f5c0b3e8869351c83 > Reviewed-on: https://chromium-review.googlesource.com/1127214 > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578944} TBR=ortuno@chromium.org,loyso@chromium.org,dominickn@chromium.org,nigeltao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855281 Change-Id: I976928b151910bcc39ea372a6f80d9d833fc8253 Reviewed-on: https://chromium-review.googlesource.com/1155496Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579247}
-
Lukasz Anforowicz authored
We plan to make --site-per-process mode the default mode on ToT for //content layer (//chrome layer will continue to be controlled by field trials and disable --site-per-process on Android). To make this switch slightly easier, this CL inlines the test expectations from //testing/buildbot/filters into the source code of the tests - this should avoid having to keep passing the filter files to the default test steps after making the switch. Bug: 856734 Change-Id: Ic0983cb667d7904caeb18d46705f7721147a6354 Reviewed-on: https://chromium-review.googlesource.com/1153975Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#579246}
-
Anand K. Mistry authored
crrev.com/1ffee348 changed these methods to no longer be pure-virtual. This change is intended to make the code more consistent (and delete a bunch of useless code). BUG=None Change-Id: I27c5ee5b58e94deeed380603e10f54ea316f30ef Reviewed-on: https://chromium-review.googlesource.com/1152345Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#579245}
-
Reid Kleckner authored
Consider this code: const String& attribute_value = AtomicString(html_attribute.second); It gets a String member, creates a temporaty AtomicString, and then returns a reference to its String member. The AtomicString object is not lifetime extended. However, if we change the type of the variable to 'const AtomicString&', then it will be lifetime extended, and there is no bug. This is causing the Linux and Windows ASan ToT bots to time out, so I will TBR this. TBR=csharrison@chromium.org BUG=869067 Change-Id: Ie90c7f07038c4d394b8cba5d03fec4569476ed91 Reviewed-on: https://chromium-review.googlesource.com/1155832Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579244}
-
Kenichi Ishibashi authored
When S13nServiceWorker is enabled these tests requre an instance of URLLoaderFactory. Add a mock URLLoaderFactory and set them in tests. This makes tests pass. Bug: 860361 Change-Id: I2cfa371c1c1076d895398686b3df36340664e30b Reviewed-on: https://chromium-review.googlesource.com/1152337Reviewed-by:
-
Scott Violet authored
Shell keeps a reference to the connector, so it shouldn't be needed on the delegate. BUG=none TEST=none Change-Id: I8e1342d4f887575f7b35d7a8a05233927743f222 Reviewed-on: https://chromium-review.googlesource.com/1155810 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
