- 15 Oct, 2020 40 commits
-
-
Christian Biesinger authored
A small float number will convert to a zero layout unit, leading to a division by zero. R=ikilpatrick@chromium.org, mstensho@chromium.org Fixed: 1137262, 1137264, 1137471, 1137227 Change-Id: Iea57ab61369570f08e74384a763e6ec4f2fa155e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475453 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817454}
-
Stepan Khapugin authored
Plumbs dispatcher to BVC. Makes the browser coordinator zero it out during shutdown before stopping child coordinators to avoid a crash. Bug: 1137686 Test: No repro steps available. Change-Id: Ica001018459d3667c53f010487292ffae774d8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471737Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817453}
-
Noel Gordon authored
Tune up the current API doc comments as it stands today. There is more discuss and we might amend our public methods or update them, given V8 bugs preventing collection to background extension page code coverage, decide if GetCoverage() API should implicitly stop code coverage (what it does today and works for the browser test used-case) and so on. Tbr: benreich Bug: 1113941 Change-Id: I5684e399cd601c5119652a15966cf874b3c56ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474954Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817452}
-
Noel Gordon authored
Similarly to SpanToStringPiece just above, a {} can in-place construct a type: it calls the type constructor with the provided {values...}, a shorthand to save writing the constructor std::string(...). The same code is used in file manager browser test, where it is called EncodeURI, and used for files app DocumentsProvider integration tests. Change it to use {} type construction. Note the subtle distinction b/w encodeURI, encodeURIComponent (the web APIs) still needs addressing for our DevtoolsListener use-case, so TBD once the URLs in our code coverage output is being post-processed with the chromium bot coverage tools. Tbr: benreich Bug: 1113941 Change-Id: I58ec172ef738d3314fbd1a008ffdc76f1f89c1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474533Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2ef814426ee..481fb88fee33 2020-10-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 20d60a85 to 312a2b1c (473 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ie98dd1c0e5663116eb69e1d4f80c273b255abad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817450}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58a1323e..23b0ebb5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2bfaee0ca79b73c7058db503d435e3818ff3cb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475293Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817449}
-
Anqing Zhao authored
Currently, MGS (Managed Guest Session) i.e.,public session has already hidden the personalization (including wallpaper settings) in the OS settings page, but user still can open it by right clicking the desktop. Such an inconsistent behavior confuses MGS users. After the discussion with MGS PM and the OS setting team, we decide to disallow such an option triggered by right-click because such a setting is useless since MGS is an ephemeral session. Bug: 1135906 Change-Id: Ia1b2f7e21d4face03859510f901ee7029f873db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471838 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#817448}
-
Polina Bondarenko authored
Add policy managing ARC data snapshotting mechanism for MGS. If this policy is set, ARC data snapshotting mechanism is turned on for MGS and snapshot update intervals are specified. ARC data snapshot update process is allwed to be started automatically during those intervals if no user session is running. BUG=b:170187468 TEST=browser_tests Change-Id: I4e78a3f66bb08ee511ed4e58623fba372308a070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467861 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#817447}
-
Anton Bikineev authored
This requires making slot span metadata iterable and therefore introduces a notion of a placeholder PartitionPage - a page that corresponds to metadata area (tag bitmap or quarantine bitmap). Bug: 11297512 Change-Id: I34a7c515272935e62960d620949bd1c5dc60b2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465903 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817446}
-
Greg Thompson authored
Historically, in-use updates for desktop Chrome (Win, Mac, Linux) have been detected by a periodic task that runs every two hours. In this CL, desktop browsers now use an InstalledVersionMonitor to observe changes to the installation. Any change schedules a poll ten seconds in the future. The result of this is that observers of the BuildState will be notified of an update closer to the actual time of the update. On Windows, InstalledVersionMonitor reacts to changes in the browser's "Clients" registry key. On macOS and Linux, InstalledVersionMonitor reacts to changes in the browser's installation directory. The UpgradeDetector.PollType UMA metric is reported in response to the first poll that detects a version change. This will be used to determine if the new monitor-based strategy is sufficiently reliable to retire the periodic polling. BUG=1099386 Change-Id: Ifcd130b8330b733a3f248ec058dc7af7093ef425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464922 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#817445}
-
Sylvain Defresne authored
The code to rebase the path to the sdk was duplicated between clang and swift. Use a local variable initialised with the value that was computed in the two location, then use it to configure "-isysroot" for clang and "-sdk" for swiftc. Bug: none Change-Id: Ic3794ceeea84c67404763cf5d86fc32c201e3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471357 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#817444}
-
Thanh Nguyen authored
Rename SearchMetricsReporter to SearchMetricsReporterSync. We need to do this to make the metrics reporter working while we make changes to local search service. See go/lss-sandboxing-impl for mor details. Bug: 1137560 Change-Id: I38300e031cdfd6f9f11c33fe320705845087c9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469648Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817443}
-
Martin Šrámek authored
..on TSan. The test is almost consistently failing Bug: 1138712 Change-Id: Ib106ae4e53ef6f57302e250ee41a2dd483a2e0b0 TBR: guidou@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474695Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#817442}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=sdefresne@chromium.org Change-Id: Ia84a3141bc4b84c6ced69dba12784cb448b2091c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474694 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817441}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/84b70a6e4d93..6298d2b70cb6 2020-10-15 cwallez@chromium.org Format: Move the TexelBlockInfo inside an AspectInfo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I7bdde2e029172fe8a5165a6078dd50057f2e06c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474597Reviewed-by:
-
Michael Ershov authored
Postpone expiration date of ChromeOS.SAML.SamlChallengeKeyHandlerResult UMA metric. Bug: 1000589 Change-Id: If94f95b000fc313210d942255b114dfa14df9c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462132Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#817439}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c57737e35b47..10e5c20c9931 2020-10-15 dberris@chromium.org pinpoint: Fix error with cc list management If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: Ieb4311f1d265f9fda2bd576fdd7975268d01edb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474596Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/09d2653233eb..3351394f225e 2020-10-15 pfaffe@chromium.org Update DEPS and gitignore for building with emscripten 2020-10-15 bmeurer@chromium.org [wasm] Add toolbar hint for UISourceCodes loaded by language plugins. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128888,chromium:1136484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6bbce40bbee75f91c2ec5df0c539f635cd6c787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474434Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie246358f3606f0123de510a9da196050b333e10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474634Reviewed-by:
-
Hidehiko Abe authored
Currently OS_LINUX is defined for Chrome OS Build, but it is being unset. This is the preparation for the change to keep the current behavior. Bug: 1110266 Test: built locally. Change-Id: Ie6409ec3398cc32602e6c88224532e392eeb6cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474834 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817435}
-
Nico Weber authored
It's been unused since #816267 (we now automatically pick a good value), and no bots should set it anymore. Bug: 1132930 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Change-Id: Id56b440f9b9ed859611b495cf8fa76b045112aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472959 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817434}
-
Hidehiko Abe authored
Currently OS_LINUX macro is defined on Chrome OS build, but it will be unset. This is the preparation of the change to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I4b9c9cee9f811f31ac56c8ba28b6ee913a033d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474953 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#817433}
-
Omer Katz authored
This CL updates the TraceEphemeron method to deduce the right trace callback via the relevant TraceTrait. Drive-by: TraceMaybeDeleted is no longer needed for Members and replaced with TraceStrongly for WeakMembers. Bug: 1056170 Change-Id: I01b7ec0cec261e195d92e0e8125236a82ff07f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471358Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817432}
-
Marc Treib authored
In various places around sync/engine_impl (like ServerConnectionManager and HttpPostProviderInterface and their subclasses) passed around URLs in various split-up forms (host, port, path) and did manual string manipulation on them. Additionally, some methods had a "path" parameter that in fact also included a query part. This was all particularly silly, since we do start out with a GURL (in SyncManagerImpl) and eventually need a GURL again. So now, we pass around a (base) GURL instead, plus (where appropriate) the path and query to add to that. Bug: 951350 Change-Id: If69a834500d88c285545c3d3703d81be3480e8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470562 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#817431}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4b4f9aae75..f3f785ab59 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4b4f9aae75..f3f785ab59 No .def file changes. Bug: None Change-Id: I257c47c54566b2fb08cfe1318fc3460b97beb4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472398 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#817430}
-
Sylvain Defresne authored
With the soon-to-be release Apple Silicon mac devices, using the target_cpu to determine whether the build is targeting a device or a simulator is no longer a good heuristic. Introduce a new gn variable "target_environment" to explicitly control the environment in which the build is going to be used (simulator, device or catalyst). Bug: 1138425 Change-Id: I99fc84bdc88b1ed630d11e2fef73cffa82466f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471497Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817429}
-
Nico Weber authored
The bots currently take around 24h or longer to cycle (they time after 24h; we've seen one build in 23h xx min on the 64-bit bot). We need to consistently come in under the timeout so that we can measure if speedup attempts have an effect. So for now, reduce the number of targets we build. Hopefully we can undo this at some point. Bug: 1132930 Change-Id: Icb2d4bc7f7ee14d5f3c758cd0b296afb0740f30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472520 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Leo Zhang authored
This will launch IME service with 'ime' sandbox instead of 'utility'. So that IME service will be able to load IME decoder from image. TEST=local betty VM. BUG=b/161491092 Change-Id: Id44963ce3fa4e94d9f577b8fda75db33b908fc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465347 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#817427}
-
Sylvain Defresne authored
Instead of using -target for swift and -arch/-mios-*-version-min for clang, consolidate everything to use -target. This converts the command-line from (for a x64 simulator build of Chrome on iOS): clang ... -arch x86_64 ... -mios-simulator-version-min=12.2 ... to: clang ... -target x86_64-apple-ios12.2-simulator ... Bug: 1136055 Change-Id: I92668bfd23d25937eb8038b5b6dcf88e14f55f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471377 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: Ib6fe8aeb7e8c65bcf2ee57a6f2024a3a15ce83c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472003Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817425}
-
Daoming Qiu authored
This CL is part1 of converting base::Bind to Once/Repeating in //chrome/browser/download/. Bug: 1007635 Change-Id: I771350334ee6c07deab1c224cb186e53ab5466b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465095 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#817424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d3dc7daedbd..e6f2d01f0096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: If79ed30202bb897279a5f0f86adc903bd530d0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474333Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Alexey Baskakov authored
This reverts commit 6757c99a. Reason for revert: It was wrong culprit. Still failing here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/59863 Original change's description: > Revert "Enable vaapi decoding on linux x86/64 by default." > > This reverts commit 7bc2776d. > > Reason for revert: A culprit that breaks > WebRtcCaptureFromElementBrowserTest.CaptureFromMediaElement > test on Linux TSAN: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/59853 > > Original change's description: > > Enable vaapi decoding on linux x86/64 by default. > > > > Bug: 1097029 > > > > Change-Id: Ib3105a11e5ad76f7ef22930246014a702e39d0dd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436704 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817228} > > TBR=dalecurtis@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org > > Change-Id: I73a5d50738122ef5c81a0c7a92ec9016ac1420eb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097029 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474233 > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817384} TBR=dalecurtis@chromium.org,loyso@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097029 Change-Id: I99ac6f3950373f1c0786c26795186787bff8b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473865Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817422}
-
Noam Rosenthal authored
Extended StylePath to contain windRule. Extended path CSS property parser to account for wind-rule, e.g. path(oddeven, '...'). Pass through a zoom parameter when requesting a path for a ShapeClipPath. Allow PathInterpolationFunction to try to handle clip-path animations, when the shape is a path. Patched the necessary bits to allow CSSPathValue in clip-path. Unskipped relevant WPT tests, and added 3 new ones to handle page zoom. Those tests use zoom css property, in lieu of page-zoom support in WPT Bug: 880983 Change-Id: I0bf8d7a4ec746f656c33c0f99c37e0af1e3ff7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442797 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#817421}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602719900-429a2df71c95e6dc087ec01302b187e7e9fb6918.profdata to chrome-linux-master-1602741093-4d55155af2d57fc162c54eb0d019ea99dc26a80f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f03a2508a799e61c26fd141afb8148a5e571434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474007Reviewed-by:
-
Peter Kotwicz authored
BUG=1138737 TBR: dcheng@chromium.org Change-Id: I7c31b95b48be172e3305f02e7e71951aa3aa455d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473760 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#817419}
-
Michael van Ouwerkerk authored
Sadly this removes the settings shortcut feature from WebAPKs, but I intend to reland this without the androidx dependency. Revert "Add site settings to WebApks" This reverts commit 8d9ec21b. Revert "Remove hashes of site settings images" This reverts commit b9122c79. Revert "Check category before adding site settings shortcut" This reverts commit 2c8911bf. Revert "Add webapk site settings category" This reverts commit abbc3f13. Revert "Fix flaky webapk site settings test" This reverts commit 77442252. Change-Id: I37f6c7bc2e3b4a5f52ed8bdabd5ddd6a3e4c5d47 Bug: 1138210 Change-Id: I37f6c7bc2e3b4a5f52ed8bdabd5ddd6a3e4c5d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470631Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#817418}
-
Mariam Ali authored
This CL: 1. Adds a browser test for GetGuestBrowserCount method (calculates the number of open guest windows). 2. Merges Incognito and Guest window count tests with a parameterized fixture. Bug: 1105763 Change-Id: I8af67507962d71c5665a6026f8bc45c16a99d4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463579Reviewed-by:David Roger <droger@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#817417}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602719900-0adf1708ffdf07a3257db3881b100b59132f390a.profdata to chrome-mac-master-1602741093-813b9f30d38756007f17b964e7014a850d40bedc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4704c7bc4c3bcec58fb6bf9f50c56fdbc2e93905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474005Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40217a30c5c6..c4de62d51fff 2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 914c0473..37c343f0 (817219:817356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I463a951b11d6f3f15bdd0cd4ba1192894f6498f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473832Reviewed-by:
-
