GitLab

The idea is simple. Use Autocomplete dynamic field trial group names to indicate which providers should be disabled. This information, due to limitations in field trial design, is passed in the group name in a string form of "DisabledProviders_<bitmask>".

For instance, in order to run a SHORTCUTS ablation, one need to create a field trial with a group name that contains "DisabledProviders_512" (1<<9).

BUG=174694
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12220004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182018 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr

Review URL: https://codereview.chromium.org/12250012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182017 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly the Interceptor logic which is now unused.
Also switch DebugDevToolsInterceptor (the last remaining
Interceptor) to a ProtocolHandler.

BUG=146602,161529

Review URL: https://chromiumcodereview.appspot.com/12217095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182016 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182015 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142637&stop_rev=142593&verbose=on

TBR=

BUG=

Review URL: https://codereview.chromium.org/12225138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182013 0039d316-1c4b-4281-b951-d872f2087c98

and unit test to test yielding + async during Read.

A test that crashes when scoped_refptr to SpdySession deleted
from DoLoop.

Added the following test per rch to test interactions of
yielding + async during Read.

Do the following MockReads and verify all the data is consumed
and SpdySession has yielded during Read.
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K
  ASYNC 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K

R=rch@chromium.org
BUG=175574,166958
TEST=net unit tests

Review URL: https://chromiumcodereview.appspot.com/12207122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:175463
TEST=policy_ui_browsertest.cc, see bug.


Review URL: https://chromiumcodereview.appspot.com/12221141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182011 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12218112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182010 0039d316-1c4b-4281-b951-d872f2087c98

In theory it should be disabled when can_lose_context is set to true on XP.  However, this happens in GPU process and we need it in renderer process earlier.

BUG=175149
TEST=content_unittests
TBR=senorblanco
Review URL: https://codereview.chromium.org/12212146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182009 0039d316-1c4b-4281-b951-d872f2087c98

Defend against a compromised renderer sending junk to the browser.

BUG=174895


Review URL: https://chromiumcodereview.appspot.com/12208119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182008 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bauerb@chromium.org
BUG=175815
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12226123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182007 0039d316-1c4b-4281-b951-d872f2087c98

Skip policy registration if the user is already signed in.

BUG=175473


Review URL: https://chromiumcodereview.appspot.com/12217135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182006 0039d316-1c4b-4281-b951-d872f2087c98

Preview can update page count, so PageNumberSet may represent page ranges incorrectly. Now PageNumberSet is used as temporarily objects which never stored.

PreviewGenerator stores PageRange which can be compared with other independently of current document size.

Removed code duplication in page ranges parsing code and parse directly to page ranges.

BUG=173822

Review URL: https://chromiumcodereview.appspot.com/12209086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182005 0039d316-1c4b-4281-b951-d872f2087c98

Syzygy is unable to instrument some of the Chrome tests (browser_tests and unit_tests) due to interactions with RTC. Disable them so that we can collect full coverage stats.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12207129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175665


Review URL: https://chromiumcodereview.appspot.com/12220122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182003 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some more native desktop only BrowserList::const_iterator.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12213053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175629

Review URL: https://codereview.chromium.org/12209110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182001 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA records for:
* portal detection result
* portal detection duration
* discrepancy with shill's result

BUG=174047
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12211111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181999 0039d316-1c4b-4281-b951-d872f2087c98

Make this function visible on about:tracing since it used to show up as a hotspot during early startup.

BUG=162838


Review URL: https://chromiumcodereview.appspot.com/12207125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181998 0039d316-1c4b-4281-b951-d872f2087c98

1. Instead of using "new" to create cloud print URL fetchers,
use protected virtual ::CreateCloudPrintURLFetcher()

2. Instead of having a private destructor, have a protected one,
allowing for sub-classing (useful for testing purposes)

BUG=


Review URL: https://chromiumcodereview.appspot.com/12208089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181997 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12223102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181996 0039d316-1c4b-4281-b951-d872f2087c98

TBR=petewil@chromium.org,MHX348@motorola.com
BUG=175744
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12210146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181995 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the flaky tests this was causing is now better-understood
and we can re-enable this (the flaky tests are still disabled).

Note that this flag is also enabled by default on phones from Java,
so we should turn it on here to get the behavior everywhere and
stop needing to support the old path.

NOTRY=true
BUG=161945


Review URL: https://chromiumcodereview.appspot.com/12210132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12246003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181993 0039d316-1c4b-4281-b951-d872f2087c98

clang-tools-extra contains several useful utilities for refactoring such
as clang-format and (eventually) clang-format-diff.py.

BUG=none

Review URL: https://codereview.chromium.org/12213081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175509
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12217133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181991 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181989 0039d316-1c4b-4281-b951-d872f2087c98

R=reveman,ccameron
BUG=174572


Review URL: https://chromiumcodereview.appspot.com/12208123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172404


Review URL: https://chromiumcodereview.appspot.com/12207099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175000
TEST=run_all_tests.py


Review URL: https://chromiumcodereview.appspot.com/12224116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181985 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some of the last BrowserList:: iterator methods :)!

Also making BrowserListImpl const-safe (otherwise GetLastActive(), required in this CL, couldn't be used on a const BrowserListImpl*).

BUG=129187

Review URL: https://codereview.chromium.org/12213091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181984 0039d316-1c4b-4281-b951-d872f2087c98

through the ViewsDelegate::OnBeforeWidgetInit(). This way if the
delegate needs top_level (as we do for win-aura) its set correctly.

BUG=175115
TEST=covered by unit test now.
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12212136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181983 0039d316-1c4b-4281-b951-d872f2087c98

The grey bar is added to the primary display to denote the launcher.
This doesn't make sense because now we provide a launcher for each
display, and we decided to just remove the launcher rather than
keeping it to every displays.

BUG=175569


Review URL: https://chromiumcodereview.appspot.com/12208121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Tested with x64 Linux build with chromeos=1.

Review URL: https://codereview.chromium.org/12217144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181981 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this is a bug in https://codereview.chromium.org/10910242.

BUG=175211
TEST=manual. see bug

Review URL: https://chromiumcodereview.appspot.com/12211121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181980 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12209080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164555
TEST=content_unittests
TBR=wiltzius
Review URL: https://codereview.chromium.org/12225142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181977 0039d316-1c4b-4281-b951-d872f2087c98

Add makefile rules to install the built webkit string paks into
the system image.



Review URL: https://chromiumcodereview.appspot.com/12223093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181976 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the dialog-like confirm "bubble" class.
(make it a window-modal dialog delegate subclass)
Call new SpellingBubbleModel::SetPref(false) on 'No thanks'.
(clicking ok then cancel in two windows yields feature off)

See pics of the change at http://crbug.com/166075#c31

TODO(followup): Remove ConfirmBubble*? (only used by spelling).
TODO(followup): Fix insets after tweaking the new dialog style.
TODO(followup): Fix dialog 'extra view' placement.

BUG=166075
TEST=Spelling bubble (web textfield context menu -> "Spell-checker options" -> "Ask Google for suggestions") looks/works reasonable on Win/CrOS/Aura.
R=rlp@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12222003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181975 0039d316-1c4b-4281-b951-d872f2087c98

The check being removed here basically says "if you're offscreen, and have no time to visible, then you should go in the never bin."

The problem is that when a layer stops moving, then its offscreen tiles are put in never bin. That means that we lose all those tiles we put effort into painting. This increases the frequency at which one sees blurry tiles after the page goes stationary. 

R=ccameron,reveman
BUG=175276

Review URL: https://chromiumcodereview.appspot.com/12220115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181974 0039d316-1c4b-4281-b951-d872f2087c98