GitLab

Adds UMA to help us understand how often writes result in failure due to max-size violations.

Bug: 472740
Change-Id: I1ee875c4bc36a208d0f9a3df550cbeb6050dc567
Reviewed-on: https://chromium-review.googlesource.com/559889
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487245}

With newer Chromebooks having a dedicated key to show system tray we
want to be able to also hide it by pressing the same button.

BUG=b:63576567

Change-Id: Icd6cf6855c6d0ff8c3e587ed875869f2d2c4c91f
Reviewed-on: https://chromium-review.googlesource.com/572071Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487244}

Bug: chromedriver:1879
Change-Id: I09672785cd3c2821755479a21856ff68ca9266db
Reviewed-on: https://chromium-review.googlesource.com/572367
Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487243}

CSSPreloadScannerTest and HTMLPreloadScannerTest
both use a local MockHTMLResourcePreloader class for
testing. That is normally no big deal but in jumbo builds they
can be compiled in the same translation unit and then the classes
will collide. This patch gives the classes unique prefixes.

R=fs@opera.com

Change-Id: I29cd360e919c6b708a6021b6930b3347e5ae8194
Reviewed-on: https://chromium-review.googlesource.com/574707
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487242}

It's banned; other approaches are preferred in C++11.

Change-Id: I9aa36d895b0d4eb9a290ba6a4df049731faf5cb3
Reviewed-on: https://chromium-review.googlesource.com/574429Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487241}

When search fails, the filter list may show "No results" when it should
show the pseudo sink again.  This change addresses this by re-running
the filter after the search state has been cleared in the container.

Bug: 743126
Change-Id: I74993ab95d36d2a614b4257b6d2a9ff48f99a7db
Reviewed-on: https://chromium-review.googlesource.com/571115
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487240}

When force-sign-in policy is enabled and ProfileSigninConfirmationDialog is being displayed,
lock the profile temporarily so that there is no new browser window for that profile can be opened.

Unlock the profile after dialog being confirmed and Chrome begins to download policy.

Bug: 642059
Change-Id: Ib4ab0e9172cae3646ae855cc48a9564bc2fef0a3
Reviewed-on: https://chromium-review.googlesource.com/572425
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487239}

This adds four metrics to the PLM UKM for previews: "opt_out", set to true when the user hit "Show Original" on a preview;
"server_lofi", "client_lofi", and "lite_page" set to true when a preview was shown. When no preview is
shown, no metrics are added to the UKM.

Similarly, when the user does not opt out, nothing is added for opt_out.

This does not track offline previews yet, but may in the future.

The infobar posts an event to page_load_metrics for the web contents when the user clicks "show original" on the page.

BUG=701514,723711,728707

Review-Url: https://codereview.chromium.org/2952343004
Cr-Commit-Position: refs/heads/master@{#487238}

std::is_trivially_copyable should return false for classes with nontrivial
destructors.

C++11 standard section 9.6 says a trivially copyable class is a class that:
  — has no non-trivial copy constructors (12.8),
  — has no non-trivial move constructors (12.8),
  — has no non-trivial copy assignment operators (13.5.3, 12.8),
  — has no non-trivial move assignment operators (13.5.3, 12.8), and
  — has a trivial destructor (12.4).

The current implementation for _GNUC_VER < 501 didn't detech the destructor
case. This is important because when is_trivially_copyable returns true,
container code may implement moves as memcpy, when in fact it needs to me a
memcpy + a destructor.

Bug: 
Change-Id: I5739856ca7eaf5ddcf3eeb716bdc2dc33b0de0f2
Reviewed-on: https://chromium-review.googlesource.com/575020Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487237}

Profile sync service relies on the lifetime of
SyncSetupInProgressHandles to determine if setup is in progress.
Currently, none of these handles are alive in the period between the
closure of the sync confirmation dialog and the loading of the sync
setup page. This causes profile sync service to think that setup is both
incomplete and not in progress, which surfaces an error icon on the
avatar.

This CL causes PeopleHandler to acquire its SyncSetupInProgressHandle
earlier if it detects that it's navigating directly to the syncSetup
page.

R=
BUG=738789

Review-Url: https://codereview.chromium.org/2971353002
Cr-Commit-Position: refs/heads/master@{#487236}

pdf_plugin.html shows the file name and a View PDF link. When View PDF is
clicked, the callback function sends a message. When this message is
handled in PluginObserver, the URL for the PDF file is opened in a new
tab. However, in guest view, when the message is handled, nothing is
done.

BUG=737787

Review-Url: https://codereview.chromium.org/2972123002
Cr-Commit-Position: refs/heads/master@{#487235}

BUG=689520

Change-Id: I755c689e1de877e78f0ac22886fd330b2242bf95
Reviewed-on: https://chromium-review.googlesource.com/573604Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487234}

Also exposes counts of 'identity' transform.

Bug: 740245
Change-Id: Ia13fccbc7bab1e8f90b88a1e8e422749194e298a
Reviewed-on: https://chromium-review.googlesource.com/563595
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487233}

This reverts commit 535fbc0b.

Reason for revert: Failed tests on internal.bling.main bot. Configuration updates look like they are needed in this bot as well.

https://uberchromegw.corp.google.com/i/internal.bling.main/waterfall?builder=iphone10-simulator

Original change's description:
> [Payment Request] Adds tests for accessibility on main pages of Payment Request - Reland
> 
> Two build bot json files have been edited so that they run with the appropriate 
> command line flags. Given that these build bot changes are related to adding to this
> test this is all being packaged as one CL.
> 
> From original CL description:
> "The added HTML file and JS file have been downloaded from here:
> 
> https://rsolomakhin.github.io/pr/multi/
> 
> And thus do not need to be thoroughly reviewed. The only changes made to these
> files are as follows
> 1) In the html file an "id" attribute is added to the "buy" button, the 2016
> copyright is changed to 2017, and the stylesheet and favicon links are removed.
> 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName"
> is added to options on line 106, the JSLint directives are removed from the top of
> the file, and the long line on line 137 was changed into two lines."
> 
> TBR=@lpromero@google.com -- Reviewed already in last past. Only addition here is the
> build bot changes.
> 
> Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482
> Reviewed-on: https://chromium-review.googlesource.com/570879
> Commit-Queue: Randall Raymond <rayraymond@google.com>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: mahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487162}

TBR=eugenebut@chromium.org,lpromero@chromium.org,michaeldo@chromium.org,rayraymond@google.com,mahmadi@chromium.org

Change-Id: Ib69b8365f7e45f8f7df9113fa2980052bf0cc361
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/574675Reviewed-by: Ed Chin <edchin@chromium.org>
Commit-Queue: Ed Chin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487232}

Recently we replaced the controller event timestamps with timestamps
generated by the VR Controller. However, these timestamps aren't in the
same timebase, and so cannot be used.

Bug: 732830
Change-Id: I33cb642e0008eb1676a65596c83e3982fe5a59f6
Reviewed-on: https://chromium-review.googlesource.com/568687Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487231}

GetAppOutputWithExitCode() is implemented for Windows, but not exposed.

Bug: 741926
Change-Id: Ib0518a8c6b28bc0946e6e820756e264d13028312
Reviewed-on: https://chromium-review.googlesource.com/571239Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487230}

Bug: 643937
Change-Id: I884264b415d2eb0e4a08cde6f2ed0f314ed72e4b
Reviewed-on: https://chromium-review.googlesource.com/574657Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487229}

Bug: 
Change-Id: I75fdcceae4f3e757019f9cf890ad9a9d3dba8b31
Reviewed-on: https://chromium-review.googlesource.com/572123
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487228}

Load flags were being read from the CronetURLRequestContextAdapter
on the main thread, which could potentially happen before they were
initialized on the network thread if a UrlRequest is created immediately
after the CronetEngine. Now they are read at request start time on the
network thread, which must be after context initialization.

BUG=743232

Change-Id: I3f9c5cd1cde906555c5ba68b4a45a9a3ee71b014
Reviewed-on: https://chromium-review.googlesource.com/574827Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487227}

password_manager_handler.cc currently passes the FILE thread task runner to
code for importing and exporting passwords. That code uses the runner each time
for posting a single task. The FILE thread is deprecated and more generic API
needs to be used instead.

This CL, in accordance with the migration guide [1], pushes the task of finding
the task runner to the callsite in the component. Because the task runner has
always only been used for a single posting, single thread or even same-sequence
guarantees are unnecessary, hence the tasks are simply posted with the generic
TaskRunner base::PostTaskWithTraits* methods. The traits chosen are MayBlock()
because the tasks involve IO operations, and USER_VISIBLE priority because the
impact of the tasks is user visible.

[1]
https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md

Bug: 689520
Change-Id: I26ac50f15a0ea52240027c31b7d06b06aa1ce21b
Reviewed-on: https://chromium-review.googlesource.com/572980Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487226}

TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I5e5362aa6c5547b3a93fba48020b42c21f0ab6a1
Reviewed-on: https://chromium-review.googlesource.com/575349Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487225}

This CL migrates ArcTtsService.

BUG=672829
TEST=Ran try.

Change-Id: Ia635f234c7bd03ce19a2ffd2f78bc20bbe9ecc19
Reviewed-on: https://chromium-review.googlesource.com/572473
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487224}

Bug: none
Change-Id: Ie2b12dd21b061282111dec4f0fd1654e7ff695c8
Reviewed-on: https://chromium-review.googlesource.com/572824Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487223}

The old AppListView did not respond to scroll events from PEEKING mode.
Now the AppListView transitions from PEEKING to FULLSCREEN_ALL_APPS when
a scroll event (mousewheel or touchpad gesture) is received via
AppListView::HandleScroll.

I had to make a fix to ensure that events are properly propogating, and
I had to explicitly pass MouseWheel events from the SearchBoxView
widget.

New Tests:
MouseWheel Scroll events from the SearchBoxView from PEEKING.
MouseWheel scroll events from the AppListView shield from PEEKING.
Ditto, from other states.

BUG=739408

Review-Url: https://codereview.chromium.org/2982453002
Cr-Commit-Position: refs/heads/master@{#487222}

Bug: 729183
Change-Id: I4e5b3251048d57d592bb82e933d23adab146a31d
Reviewed-on: https://chromium-review.googlesource.com/568662
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487221}

Anticipating ~140 layout test diffs:
  https://skia-review.googlesource.com/c/20968/13

Change-Id: Ia5de315a6b04249ad5042add8f193da7c4db7269
Reviewed-on: https://chromium-review.googlesource.com/574871Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487220}

chromium.android.fyi: Memory Infra Tester
chromium.fyi: Site Isolation Android

Bug: 670879
Change-Id: Ia7baa91881a626dcd0a743d3f93510c27772d3bb
Reviewed-on: https://chromium-review.googlesource.com/572544Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487219}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6e3bfad0debc..64ca2b5ad4d4

$ git log 6e3bfad0d..64ca2b5ad --date=short --no-merges --format='%ad %ae %s'
2017-07-17 sullivan Add a 'benchmark' parametr to alerts API, to allow for limiting to just one benchmark. This makes it possible to get a much longer timeframe of data.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I3f9cf9ac78883357558206c02b1bde2f3d9d7fde
Reviewed-on: https://chromium-review.googlesource.com/574764
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487218}

This CL changes the clear (X button) in the upper right of a cr_dialog
from a paper-icon-button to a paper-icon-button-light. It also moves
some of the paper-icon-button-light styling from settings to cr CSS so
that it can apply in cr_*.

Bug: 736891
Change-Id: Idc211b5dc42d18261d5e0906fea6f5d385421f0e
Reviewed-on: https://chromium-review.googlesource.com/567728Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487217}

This updates the change picture screen to use the new layout.

It does not update the profile pictures, that will be done behind
a flag in a followup.

Bug: 730031
Change-Id: I0645eb1cd034188f438062cc7cba8662e81f6e91
Reviewed-on: https://chromium-review.googlesource.com/572302
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487216}

This removes the GET_ACCOUNTS permission from the manifest which is no
longer needed. Also removes some permissions-related code.

Change-Id: I111a97b433ef0c9129a5486b1a22662725ea5c8e
Reviewed-on: https://chromium-review.googlesource.com/572600Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487215}

Surface synchronization unit tests use CompositorFrameSinkSupport and
FrameSinkManager which makes them part of the frame_sinks layer.
This CL moves the file to components/viz/service/frame_sinks,
updating includes, namespaces and forward declarations as appropriate.

Bug: 722935
TBR: piman@chromium.org
Change-Id: Ic8395dd78dfdcbe10caaef8377998843d01bad0f
Reviewed-on: https://chromium-review.googlesource.com/572385Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487214}

Release with 12 shards and debug with 20.

A release shard:
https://chromium-swarm.appspot.com/task?id=374bad1c5c50b910

A debug shard:
https://chromium-swarm.appspot.com/task?id=374bc4c487af1810

Bug: 670879
Change-Id: I3a9a0e2936269df5a8c72212cc2233803656ef3b
Reviewed-on: https://chromium-review.googlesource.com/567370Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487213}

Make TabletPowerButtonController disable the touchscreen
when powerd reports that the display was turned off
automatically (typically due to user inactivity).

This is intended to remove an inconsistency from the user's
perspective where the touchscreen turns the screen on when
the device is awake but in a screen-off state due to
inactivity, but doesn't wake the device when it's in S3
(i.e. suspended, asleep).

BUG=743291
TEST=manual: run set_short_powerd_timeouts, then:
     a) tap power button and verify touchscreen is disabled.
        after tapping power button again, screen turns on
        and touchscreen works.
     b) wait 20 seconds for screen to turn off due to
        inactivity and verify touchscreen is disabled. after
        hitting a key, screen turns on and touchscreen works
        again.
     c) manually decrease brightness to 0, wait five
        seconds, and then verify that touchscreen increases
        backlight brightness to min-visible level

Change-Id: I16c9769f587fe91bf2e6c3e68d06ccb83b299294
Reviewed-on: https://chromium-review.googlesource.com/572766Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487212}

PasswordStoreWin has a complex way of retrieving stored logins, due to an
implicit import from IE7 stored logins in case of Chrome own password store
being empty for a given site. This CL adds histograms to see whether this
importing from IE7 is used sufficiently often to help the user to justify the
code complexity.

Bug: 456119
Change-Id: I46e8ee4977cbf1f5bdc99638596e28ae4ef860bc
Reviewed-on: https://chromium-review.googlesource.com/571228Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487211}

Specifically if an ancestor of the focused window moves to a different
display, then the FocusController is left in a base state. This is
because the FocusController is per display.

BUG=none
TEST=covered by test

Change-Id: I3fbcaf91f5991bd5bb3a8aa7113503937e4c97a2
Reviewed-on: https://chromium-review.googlesource.com/574927Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487210}

Checks browser history after navigating to two pages in the VR browser. Both
the VR browser and regular "2D" Chrome are supposed to share history, which
up until now was only tested manually.

Bug: 728779
Change-Id: I48b3c075e9a043c9a2fadb67e71e9080cb9f7e9b
Reviewed-on: https://chromium-review.googlesource.com/570120
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487209}

BUG=706512

Change-Id: I51f6817dd9267ce842d77e8a85c5c2e15dacba22
Reviewed-on: https://chromium-review.googlesource.com/574436Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487208}

Previously, this was only done for /var/log/messages.

BUG=715263
R=afakhry@chromium.org

Change-Id: I1ece80c22d9a74f2ab28eab6c63fd3b6d5772ba7
Reviewed-on: https://chromium-review.googlesource.com/572582Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487207}

* Removes protocol compatibility tests since all the baselines haven't
been maintained for a while and this work won't be done for a while.
* Removes a couple of console tests that have been migrated to the new
test infrastructure (they were copied in an earlier CL)

Bug: 667560
Change-Id: Ie73e4aeb0e238aa63cda0a9a96165480dfa6a03d
Reviewed-on: https://chromium-review.googlesource.com/572331Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487206}