- 05 Nov, 2019 40 commits
-
-
Renato Silva authored
This commit improves the reliability of the EULA browser test EulaTest.LoadOffline. This test was disabled due to its flakiness in the past and is now enabled again. Tested locally. Ran 100 tests under stress without any errors. Bug: 1015948 Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#712516}
-
Rune Lillesveen authored
Failing due to missing typed attr() implementation. Skip with the other tests for that feature. Bug: 246571, 931214 Change-Id: Ifa70b33ac8c82873ad9ed6a5308093cde7c23ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899491 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#712515}
-
Lei Zhang authored
This is a reland of c7dc2cd8 Original change's description: > Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest. > > This TwoClientPreferencesSyncTestWithSelfNotifications test case is > flaky. > > TBR=mastiz@chromium.org > > Bug: 1012688 > Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705625} Bug: 1012688 Change-Id: Idb70d277042bcb98a94130da3f2bab59ffaf0d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898651Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712514}
-
Maksim Moskvitin authored
Bunch of tests not passing with USS implementation of Nigori and this is expected due to the implementation of these tests. SingleClientCustomPassphraseForceDisableScryptSyncTest.* covers behavior specific for Directory implementation: disable kSyncUSSNigori. SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted is likely not working due to having no Directory datatypes. Since Directory is subject for removal it's not worth to further invest into this test. TwoClientBookmarksSyncTest.* encryption related tests use EnableEncryption() and has no direct mapping to custom passphrase test. They also exercises EnableEncryption() logic instead of bookmarks logic. They are removed (we have / planning to add analogues whenever possible into custom passphrase tests). FirstClientEnablesEncryptionWithPassSecondChanges is an exception, because it already works with custom passphrase and actively manipulate bookmarks, so it's worth to keep as is (minor changes, to not rely on IsEncryptionComplete()). TwoClientPreferencesTest.* and TwoClientSessionsSyncTest.* encryption related tests are removed (same motivation as for bookmarks tests). Bug: 922900 Change-Id: Ib95db74830b1d5d43b20d7dfacf3045694f80014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890050 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712513}
-
Marc Treib authored
This renames some methods and updates comments. No behavior changes. Bug: 1021092 Change-Id: Iab7d289e707a86cfaa79a45a7d2cdf071dbcb87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898066 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#712512}
-
Michael Lippautz authored
Bug: 1019191 Change-Id: I4a256adc5511f4cd1cbbbd13f600aa812d87ede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899486 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712511}
-
Greg Thompson authored
BUG=546640 R=guidou@chromium.org Change-Id: I7d5b4aefd1ea485d44f331d05e5e3f7b8207513a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899487 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712510}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3a91730e33e..69dd6b02511c git log c3a91730e33e..69dd6b02511c --date=short --no-merges --format='%ad %ae %s' 2019-11-04 tsepez@chromium.org Check for NaN in CFXJSE_FormCalcContext::WordNum() 2019-11-04 dhoss@chromium.org Change variable target_type to static_component_type in //:pdfium Created with: gclient setdep -r src/third_party/pdfium@69dd6b02511c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:947876 Change-Id: I43ade48f66c0b64a4e8199dc77e404af1dd49659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712509}
-
Himanshu Jaju authored
Adds SignallingMessage and IceCandidateMessage protos used for p2p connection in webrtc. Bug: 1020246 Change-Id: I4968cb73cae26169f2c6815aef1f91140ee02d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893857Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f1e5cd73f658..e0d5544c9864 git log f1e5cd73f658..e0d5544c9864 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jmadill@chromium.org Add missing headers to GN. (#3009) 2019-11-05 chris@chris-lamb.co.uk Correct "environment" typo (#3007) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e0d5544c9864 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I0bb09de61d7304556fad1607a28ee36532e2ee06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899354Reviewed-by:
-
Richard Townsend authored
Windows inconsistently #define's _alloca as alloca in malloc.h, the conditions required are not present on Windows on Arm. To fix, we check and (possibly redefine) alloca on all Windows targets. Bug: 1020541, 893460 Change-Id: Ife80ce3e7478d39d36e67686d70a74ff2319c714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892976Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#712506}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7f77b2e8669a..5d0e01d9e7f9 git log 7f77b2e8669a..5d0e01d9e7f9 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 johnkslang@users.noreply.github.com Merge pull request #1961 from zoddicus/fixChromiumRoll 2019-11-04 johnkslang@users.noreply.github.com Merge pull request #1953 from null77/gn-add-missing-headers 2019-11-04 johnkslang@users.noreply.github.com Merge pull request #1954 from corporateshark/master 2019-11-03 cepheus@frii.com Tests: Add more test results for the previous generator version bump. 2019-11-03 cepheus@frii.com Bump up the generator version, which is exposed in SPV test results. 2019-11-01 cepheus@frii.com Merge branch 'dneto0-dead-code' Created with: gclient setdep -r src/third_party/glslang/src@5d0e01d9e7f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I0c02ba75ec1709fd70dfd6719100fe81b7bb01ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899360Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/835991798ff9..b3914918d320 Created with: gclient setdep -r src-internal@b3914918d320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I48786d70431d254682c363016f237e8f63cb9264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899356Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712504}
-
Hiroki Nakagawa authored
> Introduction When PlzDedicatedWorker (off-the-main-thread dedicated worker script loading) is enabled, top-level dedicated worker script is fetched on a worker thread, not on the main (or parent) thread. This causes a problem when a dedicated worker is created from blob URL registered in a sandboxed iframe. > Problem A sandboxed iframe has an opaque origin. Blob URL registered in the frame also has the same opaque origin. When sending a network request to the blob URL, requester's SecurityOrigin takes the origin from the blob URL, and then conducts security check (see SecurityOrigin::CanRequest()). However, it's not straightforward on the opaque origin because the opaque origin is serialized into the blob URL (KURL) as "null" string like "blob:null/{UUID}", and there is no direct way to rebuild the origin from the KURL. To deal with the case, in the current implementation, the pair of the blob URL and the opaque origin is stored in thread-specific BlobURLNullOriginMap, and then the security check refers to the map. This mechanism works well when PlzDedicatedWorker is disabled, but not work when PlzDedicatedWorker is enabled. This is because the pair of the blob URL and the opaque origin is stored in the thread-specific map on the main (parent) thread, but the network request and the security check are conducted on the worker thread. As a result, the security check always fails. > Solution Making BlobURLNullOriginMap thread-safe could be one of solutions, but actually it's quite hard and not practical. This is because SecurityOrigin is not thread-safe, and widely used with an assumption that it's not shared among threads. Alternatively, this CL makes SecurityOrigin::CanRequest() check the opaque origin of the blob URL using SecurityOrigin::Nonce. Nonce is uniquely assigned to SecurityOrigin when it's constructed as an opaque origin, and SecurityOrigin instances (isolated-)copied from the same opaque origin share the same nonce. The nonce is base::UnguessableToken, and shareable among thread unlike SecurityOrigin. This CL introduces BlobURLNullOriginNonceMap that is the process-global singleton object to contain pairs of blob URL and opaque origins's nonce. The map is protected by Mutex, so any threads can access it. SecurityOrigin::CanRequest() compares the nonce stored in the map to its own nonce in addition to the existing checks. This fixes the problem. > Test This enables to pass some tests that were skipped because of timeout. Several test cases are still failing even after this change, but it should be caused by https://crbug.com/1017034. Bug: 987130 Change-Id: I6bf2212aa4f4b1a37035c41866b3faeffe68c2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873831 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712503}
-
Maksim Moskvitin authored
New test mimics server-side behavior for triggering keystore key rotation: generation of new keystore key with touching the Nigori node. After that client should receive updated keystore keys and the same Nigori node as it already has (modulo metadata update). The client should commit the new Nigori node with rotated keystore key and this verified by checking |encryption_keybag| encryption key name. Bug: 922900 Change-Id: I91b86bbb0f68a55fdcc10049fa90afa70dc32155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887611Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: I12693287a5f005bd3b6d8e2dcb4f40e6baaad938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898133 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#712501}
-
Yifan Luo authored
Currently, frame is detected as iframe in `destination` which will be fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=1019716. Bug: 1011724 Change-Id: I722bcbccac3bfc914844711fb6feb1e21f859a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886863Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#712500}
-
Yuki Shiino authored
It's not yet been fully understood, but it seems like doubly-proxying (ReferenceType = Proxy -> RefById -> DefinitionType/TypedefType) is causing trouble. This patch fixes the trouble, and makes a ReferenceType an instance of IdlType (actually of ReferenceType). Bug: 839389 Change-Id: Iccaa3ef78a1a77318e796248a1bf92a2eac40c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892986Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712499}
-
Adam Rice authored
Add use counters for the constructors of CountQueuingStrategy and ByteLengthQueuingStrategy. This will help us evaluate their usage, with a view to possibly deprecating them. See https://github.com/whatwg/streams/issues/1005#issuecomment-549184328. Change-Id: I633ab863fd93da8e74ecdd7001815d6a1728c82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899236Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712498}
-
Dana Fried authored
" This reverts commit 9932d106. Reason for revert: Broke a test with insufficient testing (see crbug.com/1021332) - will require additional investigation. Original change's description: > Layout invalidates when child view's visibility changes. > > > > Exactly what it says on the tin. > > > > This is a fix for legacy layouts (fill, box, grid) which aren't derived > > from LayoutManagerBase and which do not benefit from the logic in that > > class which handles the invalidation. LayoutManagerBase still overrides > > this logic with something more sophisticated. > > > > If in the future a legacy layout overrides ViewVisibilitySet(), it > > should either call the base implementation or handle the invalidation on > > its own. > > > > > Bug: 1003500 > > Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711966} TBR=siyua@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003500 Change-Id: I9f82556592e9e8db02900620085250e696ab30c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899387Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712497}
-
Eero Häkkinen authored
Request and Response's formData() multipart/form-data parsing uses "UTF-8 decode without BOM" which should not strip BOMs. Spec issue: https://github.com/whatwg/fetch/issues/650 Spec fix: https://github.com/whatwg/fetch/pull/915 WPT fix: https://github.com/web-platform-tests/wpt/pull/17589 Bug: 796192 Change-Id: I24721899006a8c09cf657b3638f1cb17e7953171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796367 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
-
Joanmarie Diggs authored
Originally landed: crrev.com/c/1749145 Reverted: crrev.com/c/1751830 The revert was due to Trusty not supporting ATK_ROLE_STATIC. The change is something which can wait but should be made eventually. Original commit message: Text leaf nodes and line breaks were being exposed as ATK_ROLE_TEXT. However, the definition of ATK_ROLE_TEXT is: An interactive widget that supports multiple lines of text and optionally accepts user input, but whose purpose is not to solicit user input. In contrast, ATK_ROLE_STATIC is defined as: A generic non-container object whose purpose is to display a brief amount of information to the user and whose role is known by the implementor but lacks semantic value for the user. Thus text leaf nodes and line breaks should be exposed with the latter role; not the former. Bug: 984590 Change-Id: I7da4ea79dcac546a96e55d5ef57c9a052e9bd578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872409 Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#712495}
-
Roberto Carrillo authored
This reverts commit 677b08ef. Reason for revert: This seems to be messing with the code coverage builders. Original change's description: > Check for counter overflows when merging profraw files. > > R=sajjadm,liaoyuke > > Bug: 1020404 > Change-Id: I28e27f40aebbc9743da1fa7cc42deb03f77cee13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894619 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712266} TBR=robertocn@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org Change-Id: Ib7e3c45ac146977c13e133be2200433778558741 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899546Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712494}
-
Jan Wilken Dörrie authored
This is a reland of 83ced150 Original change's description: > [base] Introduce base::CheckedContiguousRange > > This change introduces base::CheckedContiguousRange, which similarly to > base::span is a light-weight wrapper around a contiguous container > performing bound CHECKs. > > However, in contrast to base::span this class keeps a pointer to the > underlying container, and thus is able to respond to changes to data() > and size(), which base::span can't do. > > Furthermore, this change provides a constexpr overload of base::data() > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > Bug: 990059 > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712120} Bug: 990059 Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#712493}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/167e7ad444..2cf0518ef4 TBR=bmeurer@chromium.org Change-Id: Id494978d845223c4ff796e15f8819f53bea25d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898650Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712492}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/67527cb45293..df415528411f git log 67527cb45293..df415528411f --date=short --no-merges --format='%ad %ae %s' 2019-11-05 sunny.sun@arm.com Vulkan: Enable VK_IMAGE_USAGE_STORAGE_BIT when it is needed Created with: gclient setdep -r src/third_party/angle@df415528411f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I2456863799c8973de10966ceaeb10fdb85feaad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899210Reviewed-by:
-
Mikel Astiz authored
There are multiple datatypes that are platform-dependent and nevertheless the types and enum values are compiled (no ifdef). This patch does the same for READING_LIST which is no different. Bug: 950874 Change-Id: I5598d1e7b221c1f4a1338bb83397066c2b79be60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893198 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712490}
-
dpapad authored
README.js is clearly not holding JS contents, and is causing ESLint errors. This is in preparation of turning on ESLint PRESUBMIT checks for src/components. Bug: 1019312 Change-Id: Id32353b0f1e4bcd1cc62bd3983739c16fe0d24bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898868 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL removes the check to make sure rfh exists when ServiceWorkerProviderHost::OnBeginNavigationCommit is called. For tests this function is called with a fake frame, and this was causing ServiceWorker tests to fail. Bug: 1020884 Change-Id: I5d750e50ca19409cf94867b5e07a7ce35eaa33d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898165 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712488}
-
Dominic Farolino authored
This CL moves logic from NetworkServiceNetworkDelegate that performs a DumpWithoutCrash() on incorrect referrer detection, to where serialization of a network::ResourceRequest is performed before being passed to the network service. This is a temporary migration to aid in debugging long-standing referrer mismatches (crbug.com/912680) as well as recently-introduced referrer mismatches (crbug.com/1020592). Bug: 912680,1020592 Change-Id: Id6d7db1c7105bd86f125004868a49beea8c2c3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896251Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9eccfe81. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idd3c89fe559b3991fb1288ed5475a0757a5276ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898180Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712486}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f35966470fb..835991798ff9 Created with: gclient setdep -r src-internal@835991798ff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0963bf0ec1df35b86efb094bf3c8ec00dc5a5e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899066Reviewed-by:
-
Chih-Yu Huang authored
Bug: none Test: none Change-Id: I1aa70508f9e6a131dc39cf67827bf691558a6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899235Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712484}
-
Keiichi Watanabe authored
Added a new rule to allow the user 'crosvm' to use libvda D-Bus service because crosvm is run as 'crosvm' when it's started by vm_concierge. Bug: b:142864350 Test: Play a video on VM with virtio-vdec Signed-off-by:
Keiichi Watanabe <keiichiw@chromium.org> Change-Id: I35562356b9a475fc3f72ec7de743cfe636b4a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883451Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712483}
-
Takashi Toyoshima authored
Please see the comments in the file before removing. NOTRY=true Bug: 1019501, 1001450 Change-Id: I99beba1bc7d3bacd25208ce1e8d5ab8356808e43 TBR: wangxianzhu@chromium.org, yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899237Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712482}
-
Eric Roman authored
Bug: 1021236 Change-Id: I96599537914475508a3404b4771aeab9fa117a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896341 Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
To avoid inefficient AtomicString concatting when the header value has multiple commas. Bug: 930150 Change-Id: I33439d188be20d130278a961ec6ad82d2ba7fa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893608Reviewed-by:
-
Dana Fried authored
We now use an overlay with opacity to show the hover card transition between adjacent tabs as the hover card slide-animates between them. This is done with a second title and domain label that starts out displaying the old title and domain (obscuring the title and domain labels displaying the new values) and fades away as the hover card animates. We also looked at using layer opacity but the results were less attractive. Change-Id: I5098838596ea1e674cdeb884520ac7ea3a328623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895945 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#712479}
-
Michael Lippautz authored
In the strongification case the callbacks should return false indicating that the key is alive and value should be traced. Bug: 1019191 Change-Id: I508dcb6fa90d91417788302aef1f448a8fc9a744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897928Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 178 179 180 A large number of new failures are probably due to r712444 crrev.com/c/1869076 . TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: If425fdfa62d25435f08f891742626d79ecb61c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898146Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712477}
-
