GitLab

R=einbinder@chromium.org,dgozman@chromium.org

Bug: chromium:681333
Change-Id: Id844ed73938074f2b9035f17479a016403132d9e
Reviewed-on: https://chromium-review.googlesource.com/724203
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509661}

This allows CreateTransferBuffer to succeed still when the context
is lost. That means context loss doesn't look like other fatal errors
with shared memory when setting up a context, allowing us to tell if
we should retry making a context. If CreateTransferBuffer fails, then
we should not retry unambiguously.

R=piman@chromium.org

Bug: 772574
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia4c9f75ed40aa0483fed94552d6689b84efc379b
Reviewed-on: https://chromium-review.googlesource.com/720269
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509660}

Bug: 766964
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3ea67c04d2c1f825848ba015714a45661c0771bb
Reviewed-on: https://chromium-review.googlesource.com/724125Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509659}

Goma gce staging bots on win fails on content_unittest.
I'm suspecting it is due to inappropriate setting of vm.
Let me enable swarming for those bots to pass test.

Bug: 687037
Change-Id: Ib89cb0716ca26a69392471d5c77e8d4a12e640cc
Reviewed-on: https://chromium-review.googlesource.com/721224Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#509658}

We add layout tests for CSSStyleValue.parse and parseAll [1]. These
two methods are very similar so we test them in the same file to avoid
code duplication.

This will be first of many patches to add tests for CSS Typed OM.

We follow WPT guidelines for these tests, with the intent that these
tests will eventually be incorporated into WPT. Of note:

- We organise the directory structure based on the heading structure of
  the spec.
- We include metadata containing links to sections of the spec.
- We use modern javascript features like 'const' and 'let'.

As recommended by [2], we will land these tests in Chromium first. Once
the spec has stabilised enough, we will upstream them to WPT.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse
[2] https://chromium.googlesource.com/chromium/src/+/lkcr/docs/testing/web_platform_tests.md#write-tests-against-specifications

Currently failing:
- parseAll is not implemented.
- parsing a custom property doesn't seem to be implemented.
- parsing list value properties doesn't seem to work.
- parsing an invalid cssText should throw.

Bug: 774887
Change-Id: If7fd3ed222dd6371a8a6077777742860a81ff4dc
Reviewed-on: https://chromium-review.googlesource.com/720577
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509657}

ThreadSafeInterfacePtr wraps a non-thread-safe InterfacePtr, it may be
created/used to make mojo function call on another thread other than the
binding thread of the InterfacePtr it wraps.

Currently async calls are posted to the sequence that the InteracePtr is
bound to, and the responses are posted back, but when the InterfacePtr
encounters error or destroyes, it is destroying the response callbacks
directly on the binding thread.

Because the response callbacks are providerd from the caller thread, it
should be better to destroy them also on the caller thread to avoid some
thread hostile issues possibly. This CL aims to do this.

BUG=775395

Change-Id: Ifd289e0c07ec52fd22674c8d049724d102598a8c
Reviewed-on: https://chromium-review.googlesource.com/722719Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#509656}

TBR=metzman@chromium.org, ochang@chromium.org, rharrison@chromium.org

Bug: 775615
Change-Id: I2aaa15cfcde324974ca9352169aa595fc571f5e1
Reviewed-on: https://chromium-review.googlesource.com/724732Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509655}

To determine what printers users are having difficulty setting up,
record the printer if setup is abandoned from the PPD selection screen.
This will tell us where our PPD coverage is lacking.

Bug: 756576
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1e0913a3096d8a674a14cf230f6b97af456b330
Reviewed-on: https://chromium-review.googlesource.com/602696
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509654}

Bug: 684616
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0398a6195459918550b8e90e6c8236c7a1e11487
Reviewed-on: https://chromium-review.googlesource.com/723719
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509653}

Now, BleScanner is a base class with a BleScannerImpl implementation and
a FakeBleScanner test double; additionally, BleScannerImpl has a
factory.

This will be used in a follow-up CL to improve the robustness of the
initialization flow.

Note that some other files were edited slightly due to compiler errors
which resulted from the change.

Bug: 761532, 672263
Change-Id: I95bf3686dd1074275db670ef2791a38cb75c7805
Reviewed-on: https://chromium-review.googlesource.com/724269
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509652}

Bug: 
Change-Id: I96727d1c6b4cd09303eba6ca88630d83405623e2
Reviewed-on: https://chromium-review.googlesource.com/722362
Commit-Queue: Iris Uy <irisu@chromium.org>
Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509651}

TBR=rsesek@chromium.org

Bug: 687076
Change-Id: Ia3e3f412fe8fa61c19887573e01cffd0ed751bff
Reviewed-on: https://chromium-review.googlesource.com/724729Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509650}

SendAlgorithmTest tests are failing on iOS due to a memory issue. This
CL disabled them to make the tree green.

TBR=rch

Bug: 775492
Change-Id: I179b0a56495335008c728fa6054f6159236470cd
Reviewed-on: https://chromium-review.googlesource.com/724619Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509649}

When an ancestor clip changes, we set kSubtreeVisualRectUpdate to update
descendant visual rects which may be affected by the clip change.
Previously we early returned in PaintInvalidator::InvalidatePaint() for
descendants that had only kSubtreeVisualRectUpdate flag set. This caused
other visual rects (of e.g. scrollbars, carets) that are updated during
LayoutObject::InvalidatePaint() not updated.

Now move the early return from PaintInvalidator::InvalidatePaint() into
ObjectPaintInvalidator::ComputePaintInvalidationReason() to ensure the
visual rects are updated.

Bug: 727155
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I28f92281363c693b16121f48d21ab4f808990f14
Reviewed-on: https://chromium-review.googlesource.com/719716
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509648}

scoped_comptr.h is going away.

BUG=638327

Change-Id: Iedfc41cda41e717eda28f593b129207c3749891e
Reviewed-on: https://chromium-review.googlesource.com/724232
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509647}

- Added OnUserGesture() method to MediaSinkService, which gets called
on MRDesktop::OnUserGesture().
- The method is meant to signal the MediaSinkService that a user
gesture has occurred. It can then use this signal to "force" sinks to
be discovered right away, if supported.
- CastMediaSinkService::ForceDiscovery is renamed to OnUserGesture().
- DialMediaSinkService::OnUserGesture will re-sync DIAL-discovered
sinks to CastMediaSinkService. This helps in a very specific scenario:
if mDNS stopped working and a Cast sink that was discovered before was
lost due to network flakiness, then this gives CastMediaSinkService a
chance to recover sinks via this "forced" dual discovery mechanism.

- Another thing we can try in a future patch is to have
CastMediaSinkService retry connections for sinks stored in the
per-networkID cache. We should also have a mechanism to evict stale
entries from the cache.

Bug: 752310, 753175
Change-Id: I77cdca84e607699b581d189d8d00380979ef5451
Reviewed-on: https://chromium-review.googlesource.com/714639
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509646}

This is a mostly automated refactor.

BUG=638327
TBR=garykac@chromium.org

Change-Id: I579160fb7c69c7b5cbc77e1d8349e144320319bd
Reviewed-on: https://chromium-review.googlesource.com/724261Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509645}

Now that the service manager has moved back into the browser process
these tests have become reliable again. The last 100 FYI runs have had
other test suites fail, but not mash_browser_tests:

https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/?limit=100

* Eliminate single_mash_browser_tests step (which was running 1 test) and
  fold into mash_browser_tests
* Put mash_browser_tests back with ~125 tests
* Synchronize mash.browser_tests.filter with mojo.fyi.browser_tests.filter

Bug: none
Test: bots
Change-Id: I44d5280ab69dcd1c27c11228737b357bece22154
Reviewed-on: https://chromium-review.googlesource.com/722107Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509644}

ChromeKeyboardUI used to be a trivial class that implemented
KeyboardContentUI. Because it was the only implementer, these two 
classes were flattened into one in crbug.com/739083
However, this inadvertently caused us to lose OWNERS control over this
code.

Bug: 
Change-Id: I980ef970f1a8467e7f8dcc0a675068d8b6d22a00
Reviewed-on: https://chromium-review.googlesource.com/720718Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509643}

These are the cases in which URLFetcher supports retries.
Unlike URLFetcher, there's a single method to enable both
types of retries, and a single counter.

Unlike URLFetcher, this does not support backoff via the
ThrottleManager (Something only used in the service process).
We may want to implement something simpler, or just let the
service process consumers themselves deal with backoff.

Bug: 746977
Change-Id: I31c81652176856231289ad88d082713bad6df61d
Reviewed-on: https://chromium-review.googlesource.com/701215
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509642}

Change-Id: Ib636810dc68a8d39adf486397123e5000787aa49
Reviewed-on: https://chromium-review.googlesource.com/724020
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509641}

It turns out the first attempt (#502428) got the flag backwards.
*headdesks*

Bug: 761633,765793,775258
Change-Id: I6ef2203822c4b0a5d04d6c8d564e0d347b2d104d
Reviewed-on: https://chromium-review.googlesource.com/724263Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509640}

For Unregister related codes:
kServiceWorkerUpdateErrorPrefix --> kServiceWorkerUnregisterErrorPrefix

BUG=775412

Change-Id: Ib2a0dff68caef88cacd7ce6d449a7ef6adb4a8c6
Reviewed-on: https://chromium-review.googlesource.com/724439Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#509639}

This is a re-attempt at crrev.com/c/715576 which was rolled back due
to memory issues.

The problem is that some callers pass in their own InputMethod and also
manage the lifecycle themselves, whereas the Fake is created locally
and needs to be cleaned up in the destructor.

This CL is identical to the previous with the exception of the added
is_input_method_owner_ field and its use in the destructor.

Bug: 
Change-Id: If3f911fb42bc34a2805beceb49143a96ac7e6098
Reviewed-on: https://chromium-review.googlesource.com/720722Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509638}

This patch fixes modal permission prompts so that in RTL:
- The text direction is RTL as per the locale, instead of following the
  first strong directional character (typically the first character of
  the URL)
- The icon occurs on the right side of the dialog (i.e. before it)

Bug: 774926
Change-Id: I8677cf61c30bdce95113e0e414531c343ed302c2
Reviewed-on: https://chromium-review.googlesource.com/722382Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509637}

A bug was not recording LevelDB.SharedCache.BytesUsed.InMemory
on small memory devices. However, because the in-memory shared
cache size is always zero the correct fix is to simply not
record this value.

Bug: 750798
Change-Id: Ib5e1188aa857aae6510118bb9ccf27e06ac8c8eb
Reviewed-on: https://chromium-review.googlesource.com/723607
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509636}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1319ba43..7a12bb43

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Id86f1530e1f596cb10196ad21f5bbf923354ae10
Reviewed-on: https://chromium-review.googlesource.com/723169Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509635}

Previously when the parent-child relationship is changed in
CoordinationUnit graph, the coordination unit will notify the observers.
However, there's no need to do that beucase:
1. we can query the relationship from coordination unit;
2. observer is not supposed to maintain or bookkeep such information.

BUG=775691

Change-Id: I0dfcb7df699b39984e0304558d79cd878c497a67
Reviewed-on: https://chromium-review.googlesource.com/724210Reviewed-by: Zhen Wang <zhenw@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509634}

This adds a wide blacklist for failing cfi-icalls that will pass all
unit tests on Linux. This is functionally a to-do list of libraries and
routines that need to be fixed or refactored to work with cfi-icall.

Bug: 772906
Change-Id: Ie483a818f95b594d799622b52a13086686522c25
Reviewed-on: https://chromium-review.googlesource.com/719733
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509633}

This is for
https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs/edit?pli=1#heading=h.2st2zzoz32x8
and that we plan to reuse NetworkLocationRequest from there,
and a different "setting" and/or "chrome_policy" field will be
appropriate depending on the caller.

Bug: 718694,769158
Change-Id: Ie966a1ec6139f1d613ba2e0c5f83d02b9dc42ace
Reviewed-on: https://chromium-review.googlesource.com/717596Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509632}

This change removes a stray reference to VS 2015, clarifies when VS
2017 became required, and clarifies which VS 2017 components must be
installed.

Bug: 699375
Change-Id: Ia06240a4581afb784a25330170c61ce3f124cf17
Reviewed-on: https://chromium-review.googlesource.com/724284
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509631}

Bug: 761806
Change-Id: I92f67e2ae97847d7484c53ba461d9f7f1a5b401a
Reviewed-on: https://chromium-review.googlesource.com/710231
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509630}

Adds a LIMITED_MEDIA_LOG(INFO) entry that logs effective changes
to WMPI's |playback_rate_|, capped at 10 logs per WMPI instance.
These changes may come from users, web apps, or from algorithms
in HTMLMediaElement.

BUG=771002

Change-Id: Ic7bb5073f6980ebbcd41ad84a1fff693872443ae
Reviewed-on: https://chromium-review.googlesource.com/723777
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509629}

Bug: 775320
Test: manual.
Change-Id: I763adcb2ff287cb4594984eec3d494ff93fb8f10
Reviewed-on: https://chromium-review.googlesource.com/723787Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509628}

This library shouldn't be needed, and after some build changes on the
Chrome OS side, is no longer present.

BUG=b:67860772
TEST=deploy_chrome, confirmed browser works fine.

Change-Id: Id0be85f5f36da6435dcc605a2b73a7c5ac095e16
Reviewed-on: https://chromium-review.googlesource.com/722109Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509627}

Referenced in some configs that we weren't trying to build before.

Bug: 706592
Change-Id: Ieae810b39ef6c99a2aedbda8db12763e81ff692a
Reviewed-on: https://chromium-review.googlesource.com/724422Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509626}

The state is not used anymore.

BUG=765039

Change-Id: I155134799c87614e4e8d8429b96aeef1f8bdf63a
Reviewed-on: https://chromium-review.googlesource.com/693555Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509625}

This test fails occasionally in test automation run for Android build.


Bug: chromedriver:2081
Change-Id: I2a77764bd6d34e3c7bb0858a97c12916835648ce
Reviewed-on: https://chromium-review.googlesource.com/724278Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509624}

This makes the origin secure so that getUserMedia() doesn't fail.
Updated expected file too.

Bug: 771540
Change-Id: I2717e195d6fb52cd2dedf45dd5c48b05b1058823
Reviewed-on: https://chromium-review.googlesource.com/716719
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509623}

R=qyearsley@chromium.org

Bug: 658880
Change-Id: Ifd2ea784a589fba1e34cf2289eba488a25528ebd
Reviewed-on: https://chromium-review.googlesource.com/724172
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509622}