- 05 May, 2018 16 commits
-
-
Erik Staab authored
Bug: 731967 Change-Id: I94e8f9d5342293f8ac9e6e2af4ee0c33f082282c Reviewed-on: https://chromium-review.googlesource.com/1045445Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#556275}
-
Paul Jensen authored
Maven modules will be generated with a new script as part of http://crrev.com/c/1044349 instead of via GN build targets. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I02353acf51951b4d57fba2b846fca1fff8dfcf07 Reviewed-on: https://chromium-review.googlesource.com/1044357Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556274}
-
Edward Jung authored
Bug: 834899 Change-Id: I9bcbcda4b121d8c732f808e0745b8b33a1da647f Reviewed-on: https://chromium-review.googlesource.com/1043872Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#556273}
-
Xi Cheng authored
Methods GetProfileIdFromLaunchId() and HandleActivation() are both called in a single notification activation run. They log the same failure to UMA, which skews the UMA failure metrics. This CL fixes it. Bug: 734095, 839942 Change-Id: If7e7cd63869a19b815052bd2b470577e06660252 Reviewed-on: https://chromium-review.googlesource.com/1040349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#556272}
-
wutao authored
Currently lots of white space between description and the shortcut. This cl dynamically adjusts the width of the desciption to fill available space. Bug: 839913 Test: manual. Change-Id: Ic39f662183faec9eb1ef9b5bfc62bda91ccc61e5 Reviewed-on: https://chromium-review.googlesource.com/1044650 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#556271}
-
Xu Xing authored
Exception is OutputSurfaceMockContext, will be handled next. BUG=837155 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If098503da8a0f52b4c9442eecdb194c41b4731ee Reviewed-on: https://chromium-review.googlesource.com/1032238Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#556270}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The WebContentsDestroyed observer notification is no longer necessary since we use strong ownership semantics for WebContents everywhere, and this class is the only one that can destroy its WebContents. Bug: 832879 Change-Id: I22fef7e4296995f6d3f6a948c1be4bc537695cd1 Reviewed-on: https://chromium-review.googlesource.com/1044891Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556269}
-
David Black authored
- Mic state is newly added to the interaction model. - DialogPlate observes model and updates its icon independently in response to input modality and mic state change events. - Icon used in DialogPlate is currently a stub, state is simulated with background colors. See bug for additional details. Bug: b:79221729 Change-Id: Ic58b11257d12157579b048fb89e83d591c9632b1 Reviewed-on: https://chromium-review.googlesource.com/1043051Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#556268}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: I4c86d936907595a631fb9e603c55af90292ff724 Reviewed-on: https://chromium-review.googlesource.com/1044892Reviewed-by:
-
Xianzhu Wang authored
Table section paints table col's background on its display item, so when table col's background changes, we invalidate all table sections. See https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/table_paint_invalidator.cc?rcl=597a899086d4baebb543eb55b7bd283a3b2068a1&l=43 Now let LayoutObject::BackgroundChangedSinceLastPaintInvalidation() be initially true, so that a new col will be treated as background changed. Bug: 837258 Change-Id: Ic8efcbeb45ee879106f045b262fc4ee8e27cf891 Reviewed-on: https://chromium-review.googlesource.com/1043350Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556266}
-
Matt Wolenetz authored
This feature has been on-by-default since M62. Included in the CL are updates of MSE-FLAC tests to not require proprietary codecs (some of these were still requiring proprietary_codecs previously). BUG=750868 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I005c1ba91fa08c9a9dac5ca616ccfda660196e6a Reviewed-on: https://chromium-review.googlesource.com/1045273Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556265}
-
Erik Chen authored
BrowserCloseManager was deleting a WebContents owned by the TabStripModel. Instead, it should ask the TabStripModel to release the WebContents. Bug: 832879 Change-Id: I9f1c079e638d423d9f22e6c0be341d418e096354 Reviewed-on: https://chromium-review.googlesource.com/1044886Reviewed-by:
-
sczs authored
Screenshots: Old (CollectionView): https://drive.google.com/open?id=1XXJ_WzhtvtR26Q-Dk-iVCeUBfp3h48VX New (TableView): https://drive.google.com/open?id=15lDg6Cl07IVkXI3itntUL5lMhaeIsa-F Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c354af2472449f92f4abf8bd8728fc04136f8aa Reviewed-on: https://chromium-review.googlesource.com/1043052 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556263}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: I3dd4b70362671bd15c7581c363147652cf2f1917 Reviewed-on: https://chromium-review.googlesource.com/1045645 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556262}
-
Yafei Duan authored
OPMTaskified has never used the event logger to log anything. So adding the usage similar with old OPMImpl for page saved and deleted. We might want to add more logging to the internal page but that's better for future CL. Also cleaning up methods which are no longer used. Bug: NONE Change-Id: I654499c8806edcfdacbe7955d7ef6d4eb19e52b8 Reviewed-on: https://chromium-review.googlesource.com/1045385Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#556261}
-
khmel@google.com authored
Fix issue when in some cases (usually reproducible on next user login) folders are rendered blank. Test: Locally Bug: 838750 Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453 Reviewed-on: https://chromium-review.googlesource.com/1045518 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
- 04 May, 2018 24 commits
-
-
Andrey Kosyakov authored
Works for me now, I think the DCHECK it was hitting was removed as a drive-by here: https://chromium-review.googlesource.com/c/chromium/src/+/1008974/11/content/browser/devtools/devtools_url_loader_interceptor.cc#b478 TBR: dgozman@chromium.org, lushnikov@chromium.org Bug: 721408,831887 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I886a1e302b94b5de685e4ef4442c10564df78539 Reviewed-on: https://chromium-review.googlesource.com/1044539Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#556259}
-
Daniel Cheng authored
The following methods have been made constexpr: - the implicit conversion constructor base::StringPiece(const value_type*) - the comparison operators and base::StringPiece::compare() - base::StringPiece::starts_with() and base::StringPiece::ends_with() Since std::char_traits<> isn't constexpr-ified in C++14, this CL also implements base::CharTraits<> to provide constexpr versions for the base::StringPiece implementation. Finally, this also updates a few callers in Chrome to take advantage of the new constexpr functionality. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo Change-Id: Id3cf2be14bfb5adb53a5ca1bd74ec2a48e411f60 Reviewed-on: https://chromium-review.googlesource.com/1038746Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Khushal authored
Ensure that we cache the result of color conversion in the GpuImageDecodeCache for images larger than max_texture_size, which are color converted on the cpu during scaling. R=ericrk@chromium.org Bug: 791828, 759188 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0940e516ef6b36ccac961c1c15057eee2c73d64e Reviewed-on: https://chromium-review.googlesource.com/1041465 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#556257}
-
Majid Valipour authored
We should not tick cc:WorkletAnimation on main thread. The local time is actually not updated on main thread so the produced value is incorrect and more importantly causes superfluous commits. Note: We may decide to avoid ticking all animations on main thread (See http://crbug.com/762717) in which case we can remove this. TEST: cc/animation/worklet_animation_unittest.cc Bug: 839555 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3335bfd452cc284a585e84a87b8912207b843813 Reviewed-on: https://chromium-review.googlesource.com/1042875 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556256}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I6ee797db0275cfd8ef49de57fe010e3c293bd0cc Reviewed-on: https://chromium-review.googlesource.com/1044488 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#556255}
-
crystallambert@chromium.org authored
Quick change to two links in get started document: /manifest linked to /apps/manifest - corrected to /extensions/manifest Background page link sent to 404 - updated TOC contained "packaging" which has a redirect to "Hosting and Updating" Removed it from side nav. Change-Id: I06a927a3d4cb52707aa5fdc214435482bedac5e2 Reviewed-on: https://chromium-review.googlesource.com/1045446Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#556254}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/870dc3a4f6b3..39e3bc6ed30a $ git log 870dc3a4f..39e3bc6ed --date=short --no-merges --format='%ad %ae %s' 2018-05-04 dtu [pinpoint] Remove `required=True` from isolate_server. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie1b0c574d80da7a3d53c07b9db3d79a30da1b741 Reviewed-on: https://chromium-review.googlesource.com/1045305Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556253}
-
Ben Pastene authored
Building "all" for linux-chromeos is currently broken due to this target getting built despite no board being set. Bug: None Test: built "all" w/ linux-chromeos Change-Id: I79383869d3617269753db461b99068f73f7f0cfb Reviewed-on: https://chromium-review.googlesource.com/1045107Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#556252}
-
Emily Stark authored
We decided not to launch in-form warnings for nonsecure forms, so this cleans up the implementation. Bug: 838578 Change-Id: I43a8d6e4efb8dbc63826a4880f2b086dc70286bf Reviewed-on: https://chromium-review.googlesource.com/1036288Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556251}
-
Qiang Xu authored
changes: - Show `Assistant`, metalayer mode option in palette tool - Currently `Assistant` option is still disabled. - This CL doesn't trigger assistant mini bubble yet. Bug: b/78193960 Test: test on device with enabled flag Change-Id: I18196e03a7b4906f76daa6dc21adcbee6e3ee1d7 Reviewed-on: https://chromium-review.googlesource.com/1030855Reviewed-by:
-
danakj authored
Each caller of CreateContentLayer() calls SetDrawsContent() explicitly already, which sets this same bool, so there is no need to call it in the constructor or add any other calls. R=pdr@chromium.org Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec4c50d3334c733ac62f6756a3e40f392e1dd983 Reviewed-on: https://chromium-review.googlesource.com/1044897Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556249}
-
Eric Noyau authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20f55719c1f8ab5bf29af553eac25a5978098519 Reviewed-on: https://chromium-review.googlesource.com/1043966Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#556248}
-
Kurt Horimoto authored
This function animates the toolbar to the fully visible position without affecting the disabled counter. This is now used to show the toolbar for new foreground tab animations. It's now called by FullscreenWebStateListObserver rather than a separate NewForegroundTabFullscreenEnabler class. This CL also moves the FullscreenForegroundAnimator functionality into a new class called ToolbarRevealAnimator, and removed references to private FullscreenAnimator subclasses from the public API. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie8f7b45100675227619d2277d0283bdabe7c9ba3 Reviewed-on: https://chromium-review.googlesource.com/1009068 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556247}
-
Khushal authored
The RasterDecoder only partially populates the context capabilities which results in incorrect max texture size. Ensure that we use the correct size. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I931cc1d60b8b4f95daa5aa59a1f65c33616185fe Reviewed-on: https://chromium-review.googlesource.com/1041425Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556246}
-
Theresa authored
Add experiment arms to limit EoC triggering to navigations that originated from a Google search results page. One arm limits triggering to pages reached immediately after a search. The other walks the navigation stack looking for a search results page as long as the page transition type is one of the accepted types. This relies on the PageTransition type, so there are several limitations: - PageTransition is "reload" after a cold start, so only tabs opened/navigated during the current session may have accepted transition types. - PageTransition is "auto_bookmarked" for most links opened from the UI (e.g. bookmarks, most visited tiles, NTP articles, EoC suggestions). "auto_bookmarked" is not in the accepted list so pages opened from these surfaces won't trigger EoC. - Links opened in a new tab are the start of a new NavigationHistory. As such, there will be no search results page in the history chain and EoC will not trigger. BUG=839392 Change-Id: Ifb8746b69d15b6d1f835e991655d41caaa58dd0b Reviewed-on: https://chromium-review.googlesource.com/1043163 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556245}
-
David Bokan authored
This check existed because changing the root scroller used to require synchronously calling UpdateLayoutAndStyle which would reach up and dirty layout in an ancestor frame. This violated the lifecycle because updating the root scroller can happen from the ancestor's layout. Since we no longer need to recompute style (root scroller used to change the background style), this is no longer needed. Test added to verify. For a detailed description of how this could happen, see: https://crrev.com/6f14d2bf37f56f73d1875b5c15298c70b77c4dac Bug: 798719 Change-Id: I40cba8d8564d7365b4c7815bb6cfca7a1ad6d76c Reviewed-on: https://chromium-review.googlesource.com/1044363Reviewed-by:
-
danakj authored
This eliminates the WebLayerScrollClient type, and makes the setter method in WebLayerImpl a simple pass-through method, enabling removing the WebLayer type. R=bokan@chromium.org Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I94376a764783abad5ca86d25cefa80ee49cb5b25 Reviewed-on: https://chromium-review.googlesource.com/1044950 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/983460e6cd51..e88e454803a7 $ git log 983460e6c..e88e45480 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 geofflang Implement extensions exposing ETC2 compressed texture formats in ES2. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If48faf856e16f23624cad179094d1c265ee3e1c3 Reviewed-on: https://chromium-review.googlesource.com/1045179Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556242}
-
https://pdfium.googlesource.com/pdfium.git/+log/ad178855775d..36b3d19281e2 $ git log ad1788557..36b3d1928 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 thestig Check CJBig2_Image is valid before filling. Created with: roll-dep src/third_party/pdfium BUG=chromium:838347 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id353b8ca581db7d5524071241aca74b382bea919 Reviewed-on: https://chromium-review.googlesource.com/1044759Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556241}
-
Matthew Jones authored
This patch updated the toolbar swipe tests to not depend on criteria helpers and operate on about:blank pages rather than the ntp. Most importantly, this fixes an issue where we assert tab selection before waiting for the callback. Bug: 813584 Change-Id: I1e743291add6398bc3eebc06c03c6c69cefc21f9 Reviewed-on: https://chromium-review.googlesource.com/1044538Reviewed-by:
-
Ben Pastene authored
Magically, this is the only failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests/1864 TBR=dpranke@chromium.org, nednguyen@google.com Bug: 836447 Change-Id: Iccce216208b418ea7b34b1793a902400ed084c97 Reviewed-on: https://chromium-review.googlesource.com/1044877Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Emil A Eklund authored
The supplied test case, line-layout-repeat-append.html, measures inline- layout performance by appending 100 lines of text, triggering layout for each line, to a container. Each line is a number followed by one of five panagrams. Given that very limited the number of strings this represents a best-case scenario for the legacy inline layout implementation. The reason for this being that text shaping is by far the most expensive part of line layout. The legacy implementation achieves acceptable shape performance by segmenting text by word and caching the results. Thus for this test case a low number of words (<150) are shaped once and then re- used repeatedly. The total number (<150) is well below the cache limit. LayoutNG on the other hand does not use a shape cache, instead retaining shape results for the individual layout objects. Removing an object thus also removes the shape results. Thus no shape results are shared between test runs. Given that, this particular test case represents something of a worst-case scenario for LayoutNG. Results on my local machine, HP Z840, running tip of tree: Legacy layout: 110 runs/s LayoutNG w/o patch: 0.1 runs/s LayoutNG with patch: 120 runs/s With this patch LayoutNG is now slightly *faster* than legacy layout for this test case even though it was written specifically to take advantage of the performance characteristics of our current legacy implementation. Note that further optimizations are possible as other stages of the pre- layout pipeline may be bypassed for retained items as well. Design doc: https://docs.google.com/document/d/1saBKHRrIJaKSN1sHWnBY253zY8rbLFzhm_2fS0Eaxcw/ Bug: 636993 Test: perf_tests/layout/line-layout-repeat-append.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9ea4da582dd545a7e21e13a3ffc8ccd4687d5ff2 Reviewed-on: https://chromium-review.googlesource.com/986982Reviewed-by:Ned Nguyen <nednguyen@google.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#556238}
-
Patrick Noland authored
Bug:837340 Change-Id: I41b6b4e3164e2fd5ca555afba0dec9b5e15ed447 Reviewed-on: https://chromium-review.googlesource.com/1038731 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#556237}
-
Sadrul Habib Chowdhury authored
Notable changes: . Introduce CLANG_COVERAGE define if use_clang_coverage gn arg is set. . For child processes to be able to correctly write the coverage profile during teardown, it is necessary to allow them to shut-down cleanly. So avoid terminating the processes from ~ChildProcessLauncher() when CLANG_COVERAGE is set. . Child processes can do fast-shutdown by calling _exit(0). So force the profile file to be written from the child process before calling that. With both changes, it is still necessary to run with --no-sandbox, since otherwise the child processes are not able to write to the profile file. BUG=838582, 834781 Change-Id: I742521e756a7dead983f40462798f7c4dac2ac02 Reviewed-on: https://chromium-review.googlesource.com/1041271Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
-
