- 28 Nov, 2018 40 commits
-
-
Hector Carmona authored
Bug: 894499 Change-Id: I698b51eac47cdb7af63e4bb2ace338f87c5e7493 Reviewed-on: https://chromium-review.googlesource.com/c/1351779Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#611759}
-
Hiroshige Hayashizaki authored
Bug: None Change-Id: I10debc9f1636250545b4bf9508d2df7ecf0e62e1 Reviewed-on: https://chromium-review.googlesource.com/c/956234Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#611758}
-
Xianda Sun authored
We previously use other hit test data providers whenever there is one created, regardless of whether we enable VizHitTestSurfaceLayer or not. This makes the flag no longer effective in some conditions as we can create a draw quad hit test data provider arbitrarily sometimes. It accounts for the async hit testing of approximately 1% of all hit testing requests when VizHitTestSurfaceLayer is enabled. This patch makes us use layer tree hit test data when the flag is enabled. Bug: 901882 Change-Id: I833b693368721b09e1d2922274d21170a24125d7 Reviewed-on: https://chromium-review.googlesource.com/c/1348949 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611757}
-
Dan Elphick authored
Since BooleanValue cannot actually throw, the Maybe version of the function is now deprecated. Bug: v8:7279, v8:8238 Change-Id: I8ec2cf1a305fdcf79681a8b39db4728f205428c4 Reviewed-on: https://chromium-review.googlesource.com/c/1353938Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611756}
-
sebsg authored
It should be shown only if: - The feature is enabled - The user is not syncing - The user has server cards - The user has not already opted-in - The user is in sync transport mode for Wallet The last point is checked implicitly by the fact the the user is not syncing and has some cards. Bug: 909026 Change-Id: Id0976ea98a2be295968f825f1269888b3d820f0d Reviewed-on: https://chromium-review.googlesource.com/c/1351944 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611755}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I43de3ccb29bcb978c0a426094e996638b352d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1352762Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611754}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ib283fca5ff7e09a4e24bde1f728e195ad365e6ce Reviewed-on: https://chromium-review.googlesource.com/c/1352761Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611753}
-
Henrik Boström authored
The state tracker is already well-tested. What is new is reporting the existing states. This is done at Dispose()-time because we cannot generally speaking know when an RTCPeerConnection is done with the call setup. We cannot trust close() is called because not all apps call it, but even if they do this will not happen if the user closes the tab. Dispose() will happen even if the tab is closed even if close() was never called, though it only happens when the GC decides to clean things up (which may happen at a much later time, and which does not happen if all of Chrome is shut down). Making the reporting independent of any API calls is a good thing to do regardless since this should reduce the risk of additional sampling bias. There are two flavors of the enums: One that always reports, and one that only reports if the RTCPeerConnection belongs to a document that has ever performed getUserMedia(). This is a heuristic for "is this a media use case?" that does not depend on looking at the SDP. Because Dispose() most likely happens after the context/document is destroyed, the flag for if a document uses media is stored within the CallSetupStateTracker, and is updated along side other state changes. Bug: 906029 Change-Id: Icf6b983119ef52f3cf9901695968bc3236073cd5 Reviewed-on: https://chromium-review.googlesource.com/c/1352257Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611752}
-
chrome://flagsLukasz Anforowicz authored
Bug: 901522 Change-Id: I6c0f672a3544641bc44b218773e4db9fb1fa64b2 Reviewed-on: https://chromium-review.googlesource.com/c/1340579 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611751}
-
Robert Liao authored
This test now presents a consistent set of supported scale factors invariant of the running platform, avoiding any surprises in expectations. BUG=298406 Change-Id: Ibcfa08f42f4e97ce7cf6244fa2a50ccab309c1c9 Reviewed-on: https://chromium-review.googlesource.com/c/1351769Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611750}
-
Vaclav Brozek authored
The autofill server may issue CREDIT_CARD_VERIFICATION_CODE hints for fields. These should be used by password manager to understand that a CVC field is not a password field. The old parser had this functionality (see IsPredictedTypeNotPasswordPrediction), although it generally did not have the data at the right time. This CL teaches also the new parser to understand that server hint. Bug: 899331 Change-Id: Iddff8c03014ca9cf26ace5d259e33a56eaec1d1d Reviewed-on: https://chromium-review.googlesource.com/c/1353939 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611749}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I23c823f9391b84eb3cb97143bf0482dba64f9101 Reviewed-on: https://chromium-review.googlesource.com/c/1352424Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611748}
-
Adithya Srinivasan authored
- Converts IPC messages in midi_messages.h to mojo interfaces (in midi_service.mojom) - Updates MidiHost and MidiMessageFilter to use mojo - Changes MidiMessageFilter to do all work on the main task runner - Renames MidiMessageFilter to MidiClientImpl Bug: 582328 Change-Id: I1a62af005dc31118aad0081c30b6fbd1f63068a3 Reviewed-on: https://chromium-review.googlesource.com/c/1238815 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
It was using the SigninManager API, but the only test using it was removed in crrev.com/c/1346400. Just removing the leftover includes. Bug: 903881 Change-Id: Idb35dbff7a1b4f1d48140f4d2a6955cc8788dc63 Reviewed-on: https://chromium-review.googlesource.com/c/1352423Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#611746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5403e4fde106..fd13c06f14de git log 5403e4fde106..fd13c06f14de --date=short --no-merges --format='%ad %ae %s' 2018-11-28 fmayer@google.com Merge "profiling: Set startup system properties." Created with: gclient setdep -r src/third_party/perfetto@fd13c06f14de The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2eed4aa06a24fd91d35193435ab2f402a69f282f Reviewed-on: https://chromium-review.googlesource.com/c/1352862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611745}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0d86a6b9d74..da575ec6b7fc Created with: gclient setdep -r src-internal@da575ec6b7fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I70670194c920cf5d90b8a4ffd29725e6cc41fe6a Reviewed-on: https://chromium-review.googlesource.com/c/1351300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611744}
-
liberato@chromium.org authored
Makes TrainingDataStorage refcounted, and causes TrainingData to keep a reference to the underlying backing store. Change-Id: Id675a57571ff5a6137527f966959dc1953e88351 Reviewed-on: https://chromium-review.googlesource.com/c/1351568 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#611743}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9bbc291e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If86fa53b0cc0380d4324eb108e98719873ee9f9b Reviewed-on: https://chromium-review.googlesource.com/c/1352988 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611742}
-
Ken Rockot authored
This reverts commit 965f2dd7. Reason for revert: Still broken, unfortunately: https://crbug.com/909760 Original change's description: > Reland "[ios] add credit card test for manual fallback" > > This is a reland of 30e1dd18 > > Adding feature flags to slimnav. > Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970 > > Original change's description: > > [ios] add credit card test for manual fallback > > > > Also adds AutofillManualFallbackPhaseTwo to test bots. > > > > Bug: 845472 > > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d > > Reviewed-on: https://chromium-review.googlesource.com/c/1337347 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611171} > > TBR=rohitrao@chromium.org > > Bug: 845472,908970 > Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29 > Reviewed-on: https://chromium-review.googlesource.com/c/1352328 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611679} TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: Ie4ab90910a6c9b63c0b15044663c2dab68637ae9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845472, 908970 Reviewed-on: https://chromium-review.googlesource.com/c/1352934Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611741}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I044cd0590ade65e2a8620b0e9e4c463eb2d3c9ac Reviewed-on: https://chromium-review.googlesource.com/c/1353879Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#611740}
-
Elly Fong-Jones authored
Not using an IME here makes certain keyboard layouts very difficult to use. Bug: 895434 Change-Id: I76e6121ca6512c8804fdb4afd2bceba10160bef0 Reviewed-on: https://chromium-review.googlesource.com/c/1351151 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611739}
-
Robert Ogden authored
This is needed for ChromeDriver testing. See bug. Bug: 908491 Change-Id: Ifaf1505757badc0b9c39b2a98e48a733a26564d7 Reviewed-on: https://chromium-review.googlesource.com/c/1351097Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#611738}
-
edchin authored
Explicit property synthesis is no longer necessary. Change-Id: Ib70f7b876297a50368c2e8167d3eba809bb259e8 Reviewed-on: https://chromium-review.googlesource.com/c/1352983Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611737}
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Iafeabd00f6dde0c1ecf055a5f9f006059e43c9f7 Reviewed-on: https://chromium-review.googlesource.com/c/1346449 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Tom Anderson authored
On Trusty, the file is called libpulsecommon-4.0.so. On gLinux (debian testing), the file is libpulsecommon-12.2.so. This causes some log spam due to not being able to find the file. However, the library does get loaded indirectly by libpulse.so.0 (which is also in the list of libraries loaded by LoadAudioLibraries()): $ ldd libpulse.so.0 | grep libpulsecommon libpulsecommon-12.2.so => /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-12.2.so So the solution is to simply remove libpulsecommon-11.1.so from the list. BUG=None R=miu,marinaciocea Change-Id: Idefca3b7f25b1875188ffd4f300f0f9ff9ec6c7d Reviewed-on: https://chromium-review.googlesource.com/c/1352815Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cde48580e93d..d2ede8935345 git log cde48580e93d..d2ede8935345 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@d2ede8935345 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iff4a7b7c085a3fa1f4d0e8e80d92d0007395f800 Reviewed-on: https://chromium-review.googlesource.com/c/1351299Reviewed-by:
-
Ned Nguyen authored
They are: * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsing * contrib.oilpan.oilpan_gc_times_unittest.OilpanGCTimesTest.testForParsingOldFormat NOTRY=true # Disabling CL only TBR=haraken@chromium.org, peria@chromium.org Bug: 909752 Change-Id: I87176fab5851ccc910fb5cc5dfede31880626423 Reviewed-on: https://chromium-review.googlesource.com/c/1354127 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611733}
-
Lan Wei authored
In order to match with WebDriver Action API, we need to modify the command of ExecutePerformActions in ChromeDriver. I also add this new action API in chromederiver.py and some tests to test this new API. Because we have not added this Action API to CDP, I am using Input.dispatchMouseEvent right now for mouse events only. Bug: chromedriver:1897 Change-Id: I28cac07b58d570ab1a102ac7b13d3d06dac507d8 Reviewed-on: https://chromium-review.googlesource.com/c/1333831Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#611732}
-
Chris Mumford authored
1. Grouped together HSTS methods. 2. Moved WriteCacheMetadata with other HttpCache methods. 3. Moved ResetURLLoaderFactories beside CreateURLLoaderFactory. 4. Grouped Proxy methods. Bug: 897830 Change-Id: I457539627d7245e243441f73f3a19e37fa3ddcce Reviewed-on: https://chromium-review.googlesource.com/c/1352439Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#611731}
-
Eugene But authored
jzw@ wrote most of this code and ichikawa@ reviewed most of the changes. This CL effectively removes eugenebut@, michaeldo@ or rohitrao@ from ios/web_view/internal/autofill OWNERS, because these engineers are not very familiar with the code. Bug: None Change-Id: Ifcb617d2f513325839951735338f056d849dcefa Reviewed-on: https://chromium-review.googlesource.com/c/1351420Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#611730}
-
Shawn Gallea authored
Moved protocols under is_chromeos for selective compilation. These protocols have ChromeOS dependencies and would not compile on other platforms. This is needed for eventual compilation of exo on Chromecast. Bug: 896710 Test: Run exo_unittests Change-Id: Id30ebdc8bf8338cba9e21a87350ab206b6d6057c Reviewed-on: https://chromium-review.googlesource.com/c/1328566Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#611729}
-
Dan Elphick authored
Bug: v8:7281 Change-Id: I36c82597aa4168bf7772f72648167c83fb930f1e Reviewed-on: https://chromium-review.googlesource.com/c/1353999Reviewed-by:
-
Miguel Casas authored
This CL makes a CanvasColorParams() ctor private since it's not called from outside the method, and inlines three mutators. Also turns an if(A) return B; return C; into return ! ? B : C; Bug: 902585 Change-Id: I9582cce8cba5c546eef63096dab0ab476e84e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/1330347Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#611727}
-
Jonathan Metzman authored
Bug: 906214 Change-Id: Ic82a76d816aa7810c95dd3bd0ecc97b4a5f8bd03 Reviewed-on: https://chromium-review.googlesource.com/c/1352814Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611726}
-
Eugene But authored
Also added NavigationManagerImpl::IsRestoreSessionInProgress method, so WebStateImpl knows about in-progress restoration and can behave accordinly. Bug: 877671 Change-Id: Ic16391b8ba6a2a5742dee7c3fe91bc05c79d25fc Reviewed-on: https://chromium-review.googlesource.com/c/1352413Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#611725}
-
Dave Tapuska authored
BuitinCategories::Size() returned size_t but the ::At(..) method took an int. Make these consistent to avoid a 64 bit truncation. BUG=879657 Change-Id: I7e27f17b709f7070a5234ac53b96438efad0eaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1347570Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611724}
-
Vasilii Sukhanov authored
It doesn't work correctly for the password fields without name and id. In this case Chrome should not allow the manual password generation to start. Automatic password generation should not trigger on the problematic pages anyway. Bug: 908385 Change-Id: Ic6611e01f99ad9e4052a4198ba5f9f13217d6dd6 Reviewed-on: https://chromium-review.googlesource.com/c/1352317 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Ned Nguyen authored
This reverts commit 6dd06076. Reason for revert: suspect causing WebRtcDisableEncryptionFlagBrowserTest.VerifyEncryption to be flaky (FindIt's report) BUG:chromium:909704 Original change's description: > Align resource timing buffer full processing to spec PR 168 (reland) > > This change implements the processing model from PR 168[1], when > it comes to setResourceTimingBufferSize(), clearResourceTimings() > and the firing of the resourcetimingbufferfull event. > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1345269 > (but with nicer tests). > > [1] https://github.com/w3c/resource-timing/pull/168 > > Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339 > Bug: 908181, 908414 > Reviewed-on: https://chromium-review.googlesource.com/c/1350950 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611174} TBR=npm@chromium.org,yoavweiss@chromium.org Change-Id: Ia4bf26c6be1e7c4ae35b904bac25fe031f854604 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908181, 908414 Reviewed-on: https://chromium-review.googlesource.com/c/1354123Reviewed-by:
-
Marc Treib authored
It has been replaced by SyncUserSettings::SetChosenDataTypes. Note that *Profile*SyncService::OnUserChoseDatatypes still exists for now (it's used by SyncUserSettings). This will be changed in a later CL. This required a minor change in unified_consent_service_unittest.cc: This test's implementation of TestSyncService used to override OnUserChoseDatatypes. This logic is now moved (in slightly generalized form) into TestSyncUserSettings. Bug: 884159 Change-Id: I6723543f78a3f8c42f9bc29a9da84376ad92126b Reviewed-on: https://chromium-review.googlesource.com/c/1353878Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#611721}
-
Yuri Wiitala authored
Copies all the source ImageInfo to the SkBitmap result. Previously, the color space info was being dropped; probably because this code was written before Skia had a concept of color space. The new code uses a simpler API that should be more future-proof. Unit tests were modified to check that the color space is being plumbed-through. Bug: 810131 Change-Id: Ibf6dd685731c6fa1f98b1812a70110cf07405e2f Reviewed-on: https://chromium-review.googlesource.com/c/1352487Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611720}
-
