GitLab

Currently |StaticRange| is only used in |InputEvent|. Discussions about both IDLs are
covered in the intent below.

Intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/W-Q1yWW-zas/ezkF3lw9CAAJ

BUG=585875

Review-Url: https://codereview.chromium.org/2837293002
Cr-Commit-Position: refs/heads/master@{#467597}

Idle time spell checker fetches positions to check from undo stack, but
the positions can be invalid since undo stack can store stale information.

This patch corrects the position before calculating the checking range,
so that we don't pass an invalid position to TextIterator, and hence,
fixes the crash.

BUG=715107

Review-Url: https://codereview.chromium.org/2845863002
Cr-Commit-Position: refs/heads/master@{#467596}

This patch renames:
- ComputedStyle::style_inherited_data_ -> ComputedStyle::inherited_data_
  (to be consistent with the other data refs like box_data_)
- Members of StyleInheritedData to have trailing underscore.

so that StyleInheritedData can be generated without name changes showing
up in the diff.

BUG=628043

Review-Url: https://codereview.chromium.org/2845463003
Cr-Commit-Position: refs/heads/master@{#467595}

We are looking into changing gattserverdisconnected to
gattserverdisconnect.

Review-Url: https://codereview.chromium.org/2841293002
Cr-Commit-Position: refs/heads/master@{#467594}

Preparation for using FreeType on older mac OS versions for supporting
OpenType variable fonts.

Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in
order not to expose FreeType symbols on the main executable on Mac,
since there is a symbol visibility check build-step which breaks if it
finds FreeType symbols there.

BUG=714553

Review-Url: https://codereview.chromium.org/2842513004
Cr-Commit-Position: refs/heads/master@{#467593}

Add LayoutNG versions of the DrawText and DrawEmphasisMarks methods that
operate on TextFragmentPaintInfo instances (wrapping text fragment data)
instead of TextRunPaintInfo instances. Reuses impl when at all possible.

Also adds support for bloberizing emphasis marks for text fragments with
the addition of a FillTextEmphasisGlyphs StringView/ShapeResult version.

BUG=714962
R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/2845883002
Cr-Commit-Position: refs/heads/master@{#467592}

Test network annotation tags added to network requests of:
net/url_request/url_request_context_builder_unittest.cc
net/url_request/url_request_file_dir_job_unittest.cc
net/url_request/url_request_file_job_unittest.cc
net/url_request/url_request_filter_unittest.cc
net/url_request/url_request_ftp_fuzzer.cc
net/url_request/url_request_ftp_job_unittest.cc
net/url_request/url_request_fuzzer.cc
net/url_request/url_request_http_job_unittest.cc
net/url_request/url_request_job_factory_impl_unittest.cc
net/url_request/url_request_job_unittest.cc
net/url_request/url_request_quic_unittest.cc
net/url_request/url_request_simple_job_unittest.cc
net/url_request/url_request_throttler_simulation_unittest.cc
net/url_request/url_request_throttler_unittest.cc
net/url_request/url_request_unittest.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2837543002
Cr-Commit-Position: refs/heads/master@{#467591}

Add a bunch of basic tests for the PromoDialog/PromoDialogLayout
that confirm that elements appear when they should, and that
clicking on them triggers the right events.

BUG=712836,712833

Review-Url: https://codereview.chromium.org/2842943002
Cr-Commit-Position: refs/heads/master@{#467590}

This change adds animation when transitioning between bottom sheet
content. The existing view is faded out completely before the new
view is faded in. The animation is applied to both the sheet content
and the toolbar view.

Notably, the onContentChanged() event is now called when the
transition animation has finished instead of immediately when
showContent(...) is called.

BUG=702717

Review-Url: https://codereview.chromium.org/2839673002
Cr-Original-Commit-Position: refs/heads/master@{#466780}
Committed: https://chromium.googlesource.com/chromium/src/+/419509cbf0ac3a8a8595b3ce9e56daf75e5c2f0c
Review-Url: https://codereview.chromium.org/2839673002
Cr-Commit-Position: refs/heads/master@{#467589}

Bug: 709815
Change-Id: Ib4ceec1a6a369a055e24f60ca54e6c694b6a70d1
Reviewed-on: https://chromium-review.googlesource.com/488161Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467588}

And reset selection to original language.

BUG=703887

Review-Url: https://codereview.chromium.org/2842113002
Cr-Commit-Position: refs/heads/master@{#467587}

https://pdfium.googlesource.com/pdfium.git/+log/e47e0c96009b..827db14d7f3d

$ git log e47e0c960..827db14d7 --date=short --no-merges --format='%ad %ae %s'
2017-04-26 tsepez Remove a few more |new|s.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ic141641351bed83fd7c458eddf3f9b8107203e54
Reviewed-on: https://chromium-review.googlesource.com/488169
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467586}

A couple of places in our code-based were hand-written to check for
whether the code was running on Android O, before we added support
for this through BuildInfo#isAtLeastO().

This CL makes them both call the generic method, so if that
generic method is changed, they will both benefit from that.

BUG=704209

Change-Id: I44b583af0744a67c889ef786eef7e6a96ddf8eed
Reviewed-on: https://chromium-review.googlesource.com/488129Reviewed-by: Dan Alcantara <dfalcantara@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467585}

Note that this only changes the one overload that matches the semantics
of std::basic_string<T>::replace(): STL doesn't provide an overload to
find a pattern and replace that pattern.

Bug: 709815
Change-Id: If1ef5a6233fd39d02f76cadb1e5d18d9d6905831
Reviewed-on: https://chromium-review.googlesource.com/487902Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467584}

TBR=yzshen@chromium.org

Bug: 709815
Change-Id: Ic2967caa96c4a42782766541472494aa27bc6179
Reviewed-on: https://chromium-review.googlesource.com/488170
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467583}

This shows the same toolbar overlay as MD History, with 'Cancel'/'Delete'
options. In MD Bookmarks, the overlay is only shown when more than one
item is selected, to avoid flickering when double clicking items.

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2827573002
Cr-Commit-Position: refs/heads/master@{#467582}

There were two issues preventing focus from working correctly:
. In ash there is a single FocusClient used. FocusSynchronizer didn't
  work well with this, and as a result never told mus about focus
  changes.
. Mushrome mode was never configuring activation parents in mus. This
  meant even once the previous item was fixed mus would ignore the
  focus request. The fix is to move configuration of activation
  parents to the right place.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2843193002
Cr-Commit-Position: refs/heads/master@{#467581}

There's a race where we could receive a new click event before receving
notification of a remote frame becoming focused as a result of advancing
(using the tab key for example) to that frame.

If we already think we're focused we would never reply back to the
browser to refocus this frame.

BUG=713977
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2844563002
Cr-Commit-Position: refs/heads/master@{#467580}

Revert of [tools/perf] Disable browse:chrome:newtab (patchset #1 id:1 of https://codereview.chromium.org/2827623002/ )

Reason for revert:
The issue with InputText was fixed in crrev.com/2822573002

Original issue's description:
> [tools/perf] Disable browse:chrome:newtab
>
> Story is failing on android bots.
>
> TBR=nednguyen@google.com,ssid@chromium.org
> BUG=712590
>
> Review-Url: https://codereview.chromium.org/2827623002
> Cr-Commit-Position: refs/heads/master@{#465199}
> Committed: https://chromium.googlesource.com/chromium/src/+/6a10d876438a19c51bf3d73d7f4484255718a5a2

TBR=nednguyen@google.com,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=712590

Review-Url: https://codereview.chromium.org/2844883004
Cr-Commit-Position: refs/heads/master@{#467579}

Element rolls:
  paper-icon-button: 1.1.2 -> 1.1.6
  paper-menu: 1.2.2 -> 1.3.0
  paper-radio-button: 1.3.3 -> 1.4.0

Targeted PRs:
  https://github.com/PolymerElements/paper-icon-button/pull/111
  https://github.com/PolymerElements/paper-menu/pull/107
  https://github.com/PolymerElements/paper-radio-button/pull/119

R=sammiequon@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839293002
Cr-Commit-Position: refs/heads/master@{#467578}

BUG=684680
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2840333004
Cr-Commit-Position: refs/heads/master@{#467577}

This CL adds a temporary solution to make the active user's pref
service available in *ash.

BUG=713934

Review-Url: https://codereview.chromium.org/2827193004
Cr-Commit-Position: refs/heads/master@{#467576}

Review-Url: https://codereview.chromium.org/2818103002
Cr-Commit-Position: refs/heads/master@{#467575}

This CL tweaks the MB configs so that any builder that is using goma
also sets strip_absolute_paths_from_debug_symbols_by_default=true.
This helps ensure that we get the best goma cache hit rate possible.
We don't just make the default equal to use_goma=true because doing
so may make it harder for devs to debug binaries, and we want devs
to be able to both debug binaries and use goma by default; the
tradeoff is that their builds are slightly slower.

R=thakis@chromium.org, jochen@chromium.org
BUG=603286, 712790

Review-Url: https://codereview.chromium.org/2837863005
Cr-Commit-Position: refs/heads/master@{#467574}

For example, chrome/common/renderer_configuration.mojom defines:

interface RendererConfiguration {
  SetInitialConfiguration(etc);
  SetContentSettingRules(etc);
  SetFieldTrialGroup(etc);
};

The generated IDs in
gen/chrome/common/renderer_configuration.mojom-shared-internal.h, prior
to this CL, and also after this CL with an empty seed, are:

constexpr uint32_t kRendererConfiguration_SetInitialConfiguration_Name = 0;
constexpr uint32_t kRendererConfiguration_SetContentSettingRules_Name = 1;
constexpr uint32_t kRendererConfiguration_SetFieldTrialGroup_Name = 2;

After this CL, with a "foo" seed, the IDs are:

constexpr uint32_t kRendererConfiguration_SetInitialConfiguration_Name = 1257880741;
constexpr uint32_t kRendererConfiguration_SetContentSettingRules_Name = 631133653;
constexpr uint32_t kRendererConfiguration_SetFieldTrialGroup_Name = 549336076;

BUG=673417

Review-Url: https://codereview.chromium.org/2794743002
Cr-Commit-Position: refs/heads/master@{#467573}

Set kShowStateKey property from init params show_state so that
mus window is created properly.

BUG=714804
TEST=DesktopWindowTreeHostMusTest.CreateFullscreenWidget

Review-Url: https://codereview.chromium.org/2840903002
Cr-Commit-Position: refs/heads/master@{#467572}

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381

Review-Url: https://codereview.chromium.org/2842303002
Cr-Commit-Position: refs/heads/master@{#467571}

BUG=703403
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2846623002
Cr-Commit-Position: refs/heads/master@{#467570}

The test case fractional-scroll-offset-fixed-position-non-composited.html
is passing, so removing it from TestExpectations

BUG=417782

Review-Url: https://codereview.chromium.org/2839193002
Cr-Commit-Position: refs/heads/master@{#467569}

Revert of printing::Metafile:  Simplify OS_MACOSX-specific code path (patchset #3 id:40001 of https://codereview.chromium.org/2802093006/ )

Reason for revert:
Likely causing https://crbug.com/712309

Original issue's description:
> printing::Metafile:  Simplify OS_MACOSX-specific code path
>
>   - printing::Metafile
>       * move MacRenderPageParams to PdfMetafileCg
>       * remove virtual RenderPage()
>   - printing::PdfMetafileCg
>       * Add MacRenderPageParams
>       * RenderPage no longer an override
>   - printing::PdfMetafileSkia
>       * no longer implment RenderPage()
>       * code moved to printing::PrintedDocument::RenderPrintedPage()
>
> This will help isolate BUG=chromium:374359
>
> R=thestig@chromium.org
>
> Review-Url: https://codereview.chromium.org/2802093006
> Cr-Commit-Position: refs/heads/master@{#463828}
> Committed: https://chromium.googlesource.com/chromium/src/+/c843c89f3051e4b01cf032e52c478000f7ded0ee

TBR=halcanary@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2839323002
Cr-Commit-Position: refs/heads/master@{#467568}

This CL removes the bookmarks-sidebar element in and replaces it with
a root bookmarks-folder-node. This serves to specify the recursive nature
of the sidebar, and will allow for neater recursive behaviors such as
keyboard navigation.

BUG=692844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823053003
Cr-Commit-Position: refs/heads/master@{#467567}

This makes AshTestBase::CreateTestWindow() get the logic (when in
mash) that is in
WmTestHelper::CreateTestWindow(). I added
AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase
to AshTestBase.

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2840393002
Cr-Commit-Position: refs/heads/master@{#467566}

Remove media-remoting-encrypted flag since encrypted contents are not
supported by media remoting for now.

BUG=715853

Review-Url: https://codereview.chromium.org/2843263002
Cr-Commit-Position: refs/heads/master@{#467565}

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2838343003
Cr-Commit-Position: refs/heads/master@{#467564}

This CL:
* Removes the dependency on gdbus from NPBL and uses //src/dbus instead
* Handle notifications asynchronously on a dedicated task runner
* Modify NativeNotificationDisplayService to allow async initialization
  of the NotificationPlatformBridge (only on Linux)

BUG=676220
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2821533003
Cr-Commit-Position: refs/heads/master@{#467563}

The cast executables set RPATH. If shared_libraries set RUNPATH, this
can causes issues since the RUNPATH in the shard_lib suppresses the RPATH from
the parent executable, but libraries are placed such that the parent
binary RPATH will find them.

If RUNPATH/RPATH are not set on the shared_libraries, then the parent
RPATH gets used correctly.

BUG=internal b/37514052
TEST=build libcast_media_1.0.so
readelf -a libcast_media_1.0.so | grep PATH
RUNPATh and RPATH are not set

Change-Id: I3866ddd84ced393a3926b023160298054d9a4adb
Reviewed-on: https://chromium-review.googlesource.com/487827Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467562}

This patch generates the following fields as part of a group:
- background ('storage_only' of type FillLayer)
- background_color ('storage_only' of type Color)

Since both fields correspond to shorthands, we specify them in
ComputedStyleExtraFields.json5.

Diff of generated files:
https://gist.github.com/darrnshn/48a62d4ef7efe9f7a8c2b707eb57644f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2841433002
Cr-Commit-Position: refs/heads/master@{#467561}

CWVScrollView.

BUG=714543

Review-Url: https://codereview.chromium.org/2840013004
Cr-Commit-Position: refs/heads/master@{#467560}

Cr-Commit-Position: refs/heads/master@{#467559}

This is a preparation of collapsed border optimization
(https://codereview.chromium.org/2805103003/)
and bug fixing (later).

BUG=626748

Review-Url: https://codereview.chromium.org/2840903003
Cr-Commit-Position: refs/heads/master@{#467558}