GitLab

This patch adds a new method setSpellCheckResolvedCallback to test
runner, so that layout tests can run script when a spell check request
is resolved, which can be used to inspect spelling markers in a
better manner. It also adds removeSpellCheckResolvedCallback for clearing
a previously set callback.

Currently layout tests can only set a timeout to wait for markers to appear.
Follow-up patches will utilize this new method in layout tests.

BUG=674819

Review-Url: https://codereview.chromium.org/2587823003
Cr-Commit-Position: refs/heads/master@{#439725}

The font size was too small in DSF>1.0 because pointsToPixels() unnecessarily
multiplied the value by device scale factor.  Font sizes in this code should be
treated as DIP size.

BUG=674663

Review-Url: https://codereview.chromium.org/2587283002
Cr-Commit-Position: refs/heads/master@{#439724}

R=rjkroege@chromium.org
BUG=675055

Review-Url: https://codereview.chromium.org/2586393002
Cr-Commit-Position: refs/heads/master@{#439723}

Revert of Optimize KURL protocols (patchset #9 id:160001 of https://codereview.chromium.org/2463703002/ )

Reason for revert:
Causing DCHECK flakes. crbug.com/674388

Original issue's description:
> Optimize KURL protocols
>
> This patch optimizes KURL::protocol and KURL::protocolIs by keeping
> an AtomicString m_protocol on KURL. This reduces string allocations
> throughout the code using KURL::protocol().
>
> This also fixes an inconsistency with KURL::protocolIs that will return
> true for invalid URLs.
>
> BUG=348655
>
> Committed: https://crrev.com/775abc2d7c903f191f7b24f8b299ebabbea3f624
> Cr-Commit-Position: refs/heads/master@{#438197}

TBR=esprehn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=348655,674388

Review-Url: https://codereview.chromium.org/2586253004
Cr-Commit-Position: refs/heads/master@{#439722}

This patch adds RELEASE_CHECK of offset and length to
InlineTextBox::constructTextRun(). StringView constructor only does
SECURITY_DCHECK intentionally, see http://crrev.com/2587863002.

BUG=671328

Review-Url: https://codereview.chromium.org/2588193003
Cr-Commit-Position: refs/heads/master@{#439721}

BUG=672719, 675819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2590103002
Cr-Commit-Position: refs/heads/master@{#439720}

The lifetimes of RenderWidgetHostViewGuest and BrowserPluginGuest are not tied together and
it is possible for BrowserPluginGuest to be destroyed sooner than RenderWidgetHostViewGuest.

This CL will check for |guest_| null-ness before getting owner's RenderWidgetHostView from
it.

BUG=674417
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2588233002
Cr-Commit-Position: refs/heads/master@{#439719}

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Review-Url: https://codereview.chromium.org/2586323002
Cr-Commit-Position: refs/heads/master@{#439718}

to remove the term "sample" when no sampling is being done.

BUG=

Review-Url: https://codereview.chromium.org/2592493002
Cr-Commit-Position: refs/heads/master@{#439717}

* Introduce TypeResolver to manage conversion from WebIDL types
  to C++ types and paths
* Add is_void and is_date to IdlType
* Add tests

R=bashi,peria,yukishiino
BUG=654129

Review-Url: https://codereview.chromium.org/2581373004
Cr-Commit-Position: refs/heads/master@{#439716}

We don't need to parse compressed header with vaapi. The callback for
context update should always be null.

TEST=video_decode_accelerator_unittest with VP9 video on samus
BUG=b/33563231
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2586843002
Cr-Commit-Position: refs/heads/master@{#439715}

Plumb custom bounds through DstRangeRelationToSrcRange to remove
duplicate comparisons. Refactor RangeConstraint from an enum to a class
containing bools, which can be independently evaluated at compile-time.

Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/

TBR=tsepez

Review-Url: https://codereview.chromium.org/2583053003
Cr-Commit-Position: refs/heads/master@{#439714}

Dropping a bookmark folder on Toolbar or Tab strip will open all of the urls in
separate tabs.

The first URL of dragged/dropped bookmark on toolbar_controller should be opened
in the current opening tab.

BUG=661765

Review-Url: https://codereview.chromium.org/2587763002
Cr-Commit-Position: refs/heads/master@{#439713}

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2589003002
Cr-Commit-Position: refs/heads/master@{#439712}

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704

Review-Url: https://codereview.chromium.org/2561683003
Cr-Commit-Position: refs/heads/master@{#439711}

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562393003
Cr-Commit-Position: refs/heads/master@{#439710}

For a spellcheck test, sample should be removed after the test passes. This
patch ensures sample removal for the above mentioned layout test.

This patch is also a preparation for idle time spell checker because it
relies on visibility, while unremoved samples affect visibility of other
tests.

BUG=517298

Review-Url: https://codereview.chromium.org/2583413002
Cr-Commit-Position: refs/heads/master@{#439709}

Just calling SuspendRenderer() in OnMemoryStateChange() breaks
many things. We need a reliable and consistent way to suspend
renderers. Until we come up with a solution, disable renderer
suspending when memory coordinator is enabled. In follow-up
CLs I'll add some tests to prevent this kind of regressions.

BUG=675735,675811

Review-Url: https://codereview.chromium.org/2590073002
Cr-Commit-Position: refs/heads/master@{#439708}

After the move from IPC to Mojo, the IPC util function(s) are no longer
needed or used.  This is a cleanup CL to remove the files and references.

BUG=N/A

Review-Url: https://codereview.chromium.org/2581853002
Cr-Commit-Position: refs/heads/master@{#439707}

This CL is the follow up for CL 2522693002, part of color management implementation
for ImageBitmap as described in proposal:
(github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md)

BUG=665919

Review-Url: https://codereview.chromium.org/2575693005
Cr-Commit-Position: refs/heads/master@{#439706}

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563

Review-Url: https://codereview.chromium.org/2587883002
Cr-Commit-Position: refs/heads/master@{#439705}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/html/.
There are too many references to change them all at once, so this CL is
part 7 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2583233002
Cr-Commit-Position: refs/heads/master@{#439704}

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2584103002
Cr-Commit-Position: refs/heads/master@{#439703}

BUG=671517
TEST=manual test by the repro step noted in the bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2589823002
Cr-Commit-Position: refs/heads/master@{#439702}

Add support for the following copying techniques:

1) Using CopyTexImage2D when the source is color-renderable.

2) Drawing a quad when the destination is color-renderable.

3) Drawing to an intermediate texture, and copying from that
intermediate texture to the destination, when neither is
color-renderable.

Add support for nearly all of the new ES 3.0 texture formats.

Follow-on work remains, including some scenarios described in the bug,
such as copying to faces of currently-incomplete cube maps.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/bcf132827ebd0436fd3620bbda4cbcf3febdc161
Review-Url: https://codereview.chromium.org/2479513002
Cr-Original-Commit-Position: refs/heads/master@{#439312}
Cr-Commit-Position: refs/heads/master@{#439701}

Currently the permission kill switch check and secure origin checks happen in
PermissionContextBase::GetPermissionStatus. This function is virtual which
means that it's easy to accidentally override this logic unintentionally,
and hard to insert extra permission checks which take precedence over the user
setting but not over the kill switch.

This CL makes GetPermissionStatus non-virtual such that the kill switch and
origin checking logic is always called and adds a new virtual
GetPermissionStatusInternal function which subclasses can override as needed.

TBR=tommycli@chromium.org

BUG=674389

Review-Url: https://codereview.chromium.org/2586153002
Cr-Commit-Position: refs/heads/master@{#439700}

Cr-Commit-Position: refs/heads/master@{#439699}

BUG=643964

Review-Url: https://codereview.chromium.org/2587613002
Cr-Commit-Position: refs/heads/master@{#439698}

With this CL, MojoAsyncResourceHandler dispatches OnTransferSizeUpdated messages
when report_raw_headers is set in the request. This is for devtools which needs
transfer size update events.

BUG=603396
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2566943002
Cr-Commit-Position: refs/heads/master@{#439697}

This is a speculative fix for a leak reported by a leak bot.

BUG=672740

Review-Url: https://codereview.chromium.org/2587943002
Cr-Commit-Position: refs/heads/master@{#439696}

BUG=

Review-Url: https://codereview.chromium.org/2590003003
Cr-Commit-Position: refs/heads/master@{#439695}

By moving ContextProviderCommandBuffer into mus gpu client-lib, both
content and other mus clients can use this.

BUG=643746
TBR=jam@ for content/renderer and content/test (since simple rename)

Review-Url: https://codereview.chromium.org/2584363002
Cr-Commit-Position: refs/heads/master@{#439694}

Now that we use Mojo for our IPC and the ID of the remoted session is
passed around by the Daemon, we no longer need the code which allows
the desktop process to be queried for its session id.  Removing this
code to simplify the remoting_desktop creation process.

BUG=N/A

Review-Url: https://codereview.chromium.org/2567003003
Cr-Commit-Position: refs/heads/master@{#439693}

This makes ignoreInputEvents a static flag and moved it to WebFrameWidgetBase,
removing all the logic we used to propagate it to all instances of WebViewImpl
and WebFrameWidgetImpl within the process.
The only anticipated side effect is that newly created pages in the same
process would ignore input events while we're on inner message loop, which
seems like a good thing.

Review-Url: https://codereview.chromium.org/2585113005
Cr-Commit-Position: refs/heads/master@{#439692}

We are going to add content::MemoryCoordinator to expose some methods outside
content/. As a preparation, merge the current MemoryCoordinator class
and its impl class into MemoryCoordinatorImpl to simplify the relationship
of classes. In a follow-up CL we will add content::MemoryCoordinator
in content/public/browser and make MemoryCoordinatorImpl be a subclass of it.

BUG=673216

Review-Url: https://codereview.chromium.org/2579233002
Cr-Commit-Position: refs/heads/master@{#439691}

Revert of [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT (patchset #2 id:20001 of https://codereview.chromium.org/2579623002/ )

Reason for revert:
We have enough crash dumps for now, so reverting so this doesn't prevent the hang dumps from uploading due to rate limiting.

Original issue's description:
> [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT
>
> It's unclear what's causing this, but the current instrumentation seems
> to show this ExceptionCode is the last one received before a hang.
>
> BUG=636158, 613701
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/1104899ce2fcb512e2df2600b455fbe1f8ffc056
> Cr-Commit-Position: refs/heads/master@{#438887}

TBR=sandersd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636158, 613701

Review-Url: https://codereview.chromium.org/2591593002
Cr-Commit-Position: refs/heads/master@{#439690}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/02552140..580ee66c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2588813003
Cr-Commit-Position: refs/heads/master@{#439689}

They are not used.
This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2586163002
Cr-Commit-Position: refs/heads/master@{#439688}

Following metrics are no longer used hence obsoleted:
FileBrowser.Load.Construct
FileBrowser.Load.DOM
FileBrowser.Load.FileSystem
FileBrowser.Load.Parse
FileBrowser.Load.Roots

BUG=675507
TEST=None

Review-Url: https://codereview.chromium.org/2585173002
Cr-Commit-Position: refs/heads/master@{#439687}

This patch changes the nodes container in the rtree to use a vector.
In order to preserve the consistent access to elements, it reserves the
vector to the needed capacity. The wasted space is <= 6 elements.

Added a unittest to verify the reserve path is correct for up to 1000
rects. However, locally I've tested this for up to 520k rects (and
still testing for up to 1m rects).

The perf results from N7v2 are below.
Before the patch:
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 75723.8671875 runs/s
*RESULT rtree_construct: 1000= 11985 runs/s
*RESULT rtree_construct: 10000= 715.2415161132812 runs/s
*RESULT rtree_construct: 100000= 54.19050216674805 runs/s
[       OK ] RTreePerfTest.Construct (8243 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 352105 runs/s
*RESULT rtree_search: 1000= 97542.0234375 runs/s
*RESULT rtree_search: 10000= 10274.0595703125 runs/s
*RESULT rtree_search: 100000= 866.167236328125 runs/s
[       OK ] RTreePerfTest.Search (8122 ms)

After the patch:
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 112420 runs/s (+48%)
*RESULT rtree_construct: 1000= 13482.32421875 runs/s (+12%)
*RESULT rtree_construct: 10000= 666.6328125 runs/s (-7%)
*RESULT rtree_construct: 100000= 55.98017501831055 runs/s (+3%)
[       OK ] RTreePerfTest.Construct (8340 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 365225 runs/s
*RESULT rtree_search: 1000= 98002.0078125 runs/s
*RESULT rtree_search: 10000= 10344.048828125 runs/s
*RESULT rtree_search: 100000= 866.0883178710938 runs/s
[       OK ] RTreePerfTest.Search (8092 ms)

BUG=674169
R=danakj@chromium.org, dskiba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591533002
Cr-Commit-Position: refs/heads/master@{#439686}